Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9734

Refactoring of checksum failure report related codes

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      This was from discussion with Jing Zhao in HDFS-9646. There is some duplicate codes between client and datanode sides:

          private void addCorruptedBlock(ExtendedBlock blk, DatanodeInfo node,
              Map<ExtendedBlock, Set<DatanodeInfo>> corruptionMap) {
            Set<DatanodeInfo> dnSet = corruptionMap.get(blk);
            if (dnSet == null) {
              dnSet = new HashSet<>();
              corruptionMap.put(blk, dnSet);
            }
            if (!dnSet.contains(node)) {
              dnSet.add(node);
            }
          }
      

      This would resolve the duplication and also simplify the codes some bit.

      1. HADOOP-12744-v1.patch
        29 kB
        Kai Zheng
      2. HADOOP-12744-v2.patch
        33 kB
        Kai Zheng
      3. HDFS-9734-v3.patch
        33 kB
        Kai Zheng
      4. HDFS-9734-v4.patch
        33 kB
        Kai Zheng
      5. HDFS-9734-v5.patch
        29 kB
        Kai Zheng
      6. HDFS-9734-v6.patch
        29 kB
        Kai Zheng
      7. HDFS-9734-v7.patch
        30 kB
        Kai Zheng
      8. HDFS-9734-v8.patch
        30 kB
        Zhe Zhang

        Activity

        Hide
        drankye Kai Zheng added a comment -

        Oh, too bad. It should be a HDFS one. Will ask for help to convert it.

        Show
        drankye Kai Zheng added a comment - Oh, too bad. It should be a HDFS one. Will ask for help to convert it.
        Hide
        drankye Kai Zheng added a comment -

        Uploaded a patch doing the refactor. Kindly review, thanks.

        Show
        drankye Kai Zheng added a comment - Uploaded a patch doing the refactor. Kindly review, thanks.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 18s Maven dependency ordering for branch
        +1 mvninstall 8m 21s trunk passed
        +1 compile 1m 32s trunk passed with JDK v1.8.0_66
        +1 compile 1m 28s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 1m 33s trunk passed
        +1 mvneclipse 0m 27s trunk passed
        +1 findbugs 4m 9s trunk passed
        +1 javadoc 1m 33s trunk passed with JDK v1.8.0_66
        +1 javadoc 2m 19s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 17s Maven dependency ordering for patch
        +1 mvninstall 1m 22s the patch passed
        +1 compile 1m 23s the patch passed with JDK v1.8.0_66
        +1 javac 1m 23s the patch passed
        +1 compile 1m 28s the patch passed with JDK v1.7.0_91
        +1 javac 1m 28s the patch passed
        -1 checkstyle 0m 27s hadoop-hdfs-project: patch generated 1 new + 154 unchanged - 4 fixed = 155 total (was 158)
        +1 mvnsite 1m 30s the patch passed
        +1 mvneclipse 0m 23s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 4m 40s the patch passed
        +1 javadoc 1m 27s the patch passed with JDK v1.8.0_66
        +1 javadoc 2m 15s the patch passed with JDK v1.7.0_91
        +1 unit 0m 54s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66.
        -1 unit 56m 34s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        +1 unit 0m 59s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91.
        -1 unit 53m 33s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        152m 31s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.TestRecoverStripedFile
          hadoop.hdfs.server.namenode.TestCacheDirectives
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestRecoverStripedFile
          hadoop.hdfs.shortcircuit.TestShortCircuitCache



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784594/HADOOP-12744-v1.patch
        JIRA Issue HADOOP-12744
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 66b6c46d189e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / c01bee0
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8477/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8477/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8477/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8477/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8477/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8477/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Max memory used 77MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8477/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 8m 21s trunk passed +1 compile 1m 32s trunk passed with JDK v1.8.0_66 +1 compile 1m 28s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 30s trunk passed +1 mvnsite 1m 33s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 4m 9s trunk passed +1 javadoc 1m 33s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 19s trunk passed with JDK v1.7.0_91 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 22s the patch passed +1 compile 1m 23s the patch passed with JDK v1.8.0_66 +1 javac 1m 23s the patch passed +1 compile 1m 28s the patch passed with JDK v1.7.0_91 +1 javac 1m 28s the patch passed -1 checkstyle 0m 27s hadoop-hdfs-project: patch generated 1 new + 154 unchanged - 4 fixed = 155 total (was 158) +1 mvnsite 1m 30s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 40s the patch passed +1 javadoc 1m 27s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 15s the patch passed with JDK v1.7.0_91 +1 unit 0m 54s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66. -1 unit 56m 34s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 0m 59s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91. -1 unit 53m 33s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 152m 31s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.server.namenode.TestCacheDirectives JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.shortcircuit.TestShortCircuitCache Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784594/HADOOP-12744-v1.patch JIRA Issue HADOOP-12744 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 66b6c46d189e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c01bee0 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8477/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8477/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8477/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8477/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8477/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8477/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8477/console This message was automatically generated.
        Hide
        drankye Kai Zheng added a comment -

        The Jenkins report looks good!

        DFSStripedInputStream.java:571: final CorruptedBlocks corruptedBlocks;:27: Variable 'corruptedBlocks' must be private and have accessor methods.

        The added check style better not fix to be consistent with other variables.

        Show
        drankye Kai Zheng added a comment - The Jenkins report looks good! DFSStripedInputStream.java:571: final CorruptedBlocks corruptedBlocks;:27: Variable 'corruptedBlocks' must be private and have accessor methods. The added check style better not fix to be consistent with other variables.
        Hide
        drankye Kai Zheng added a comment -

        Refined the patch some bit.

        Show
        drankye Kai Zheng added a comment - Refined the patch some bit.
        Hide
        drankye Kai Zheng added a comment -

        Zhe Zhang, would you help convert this to a HDFS one and give it a review? Thanks!

        Show
        drankye Kai Zheng added a comment - Zhe Zhang , would you help convert this to a HDFS one and give it a review? Thanks!
        Hide
        drankye Kai Zheng added a comment -

        Thanks Jing Zhao for the help with the converting! Will rename and upload the patch.

        Show
        drankye Kai Zheng added a comment - Thanks Jing Zhao for the help with the converting! Will rename and upload the patch.
        Hide
        drankye Kai Zheng added a comment -

        Renamed the patch to reflect the issue ID change.

        Show
        drankye Kai Zheng added a comment - Renamed the patch to reflect the issue ID change.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 21s Maven dependency ordering for branch
        +1 mvninstall 6m 27s trunk passed
        +1 compile 1m 15s trunk passed with JDK v1.8.0_66
        +1 compile 1m 19s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 1m 23s trunk passed
        +1 mvneclipse 0m 25s trunk passed
        +1 findbugs 3m 40s trunk passed
        +1 javadoc 1m 25s trunk passed with JDK v1.8.0_66
        +1 javadoc 2m 7s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 18s Maven dependency ordering for patch
        -1 mvninstall 0m 30s hadoop-hdfs-client in the patch failed.
        -1 mvninstall 0m 20s hadoop-hdfs in the patch failed.
        +1 compile 1m 13s the patch passed with JDK v1.8.0_66
        +1 javac 1m 13s the patch passed
        +1 compile 1m 17s the patch passed with JDK v1.7.0_91
        +1 javac 1m 17s the patch passed
        -1 checkstyle 0m 27s hadoop-hdfs-project: patch generated 1 new + 274 unchanged - 4 fixed = 275 total (was 278)
        -1 mvnsite 0m 21s hadoop-hdfs in the patch failed.
        +1 mvneclipse 0m 21s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        -1 findbugs 0m 21s hadoop-hdfs in the patch failed.
        -1 javadoc 3m 39s hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66 with JDK v1.8.0_66 generated 5 new + 7 unchanged - 0 fixed = 12 total (was 7)
        +1 javadoc 1m 21s the patch passed with JDK v1.8.0_66
        -1 javadoc 5m 58s hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91 with JDK v1.7.0_91 generated 5 new + 7 unchanged - 0 fixed = 12 total (was 7)
        +1 javadoc 2m 4s the patch passed with JDK v1.7.0_91
        +1 unit 0m 49s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66.
        -1 unit 0m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        +1 unit 0m 51s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91.
        -1 unit 0m 22s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 17s Patch does not generate ASF License warnings.
        35m 3s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785617/HDFS-9734-v3.patch
        JIRA Issue HDFS-9734
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6a3ae286a04b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ed55950
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt
        mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
        javadoc hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        javadoc hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14329/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Max memory used 77MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14329/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 21s Maven dependency ordering for branch +1 mvninstall 6m 27s trunk passed +1 compile 1m 15s trunk passed with JDK v1.8.0_66 +1 compile 1m 19s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 23s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 3m 40s trunk passed +1 javadoc 1m 25s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 7s trunk passed with JDK v1.7.0_91 0 mvndep 0m 18s Maven dependency ordering for patch -1 mvninstall 0m 30s hadoop-hdfs-client in the patch failed. -1 mvninstall 0m 20s hadoop-hdfs in the patch failed. +1 compile 1m 13s the patch passed with JDK v1.8.0_66 +1 javac 1m 13s the patch passed +1 compile 1m 17s the patch passed with JDK v1.7.0_91 +1 javac 1m 17s the patch passed -1 checkstyle 0m 27s hadoop-hdfs-project: patch generated 1 new + 274 unchanged - 4 fixed = 275 total (was 278) -1 mvnsite 0m 21s hadoop-hdfs in the patch failed. +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 0m 21s hadoop-hdfs in the patch failed. -1 javadoc 3m 39s hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66 with JDK v1.8.0_66 generated 5 new + 7 unchanged - 0 fixed = 12 total (was 7) +1 javadoc 1m 21s the patch passed with JDK v1.8.0_66 -1 javadoc 5m 58s hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91 with JDK v1.7.0_91 generated 5 new + 7 unchanged - 0 fixed = 12 total (was 7) +1 javadoc 2m 4s the patch passed with JDK v1.7.0_91 +1 unit 0m 49s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66. -1 unit 0m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 0m 51s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91. -1 unit 0m 22s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 35m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785617/HDFS-9734-v3.patch JIRA Issue HDFS-9734 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6a3ae286a04b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ed55950 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt javadoc hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66: https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt javadoc hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91: https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14329/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14329/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14329/console This message was automatically generated.
        Hide
        drankye Kai Zheng added a comment -

        The Jenkins building looks messy as not clean as the one before. Changed minor to re-trigger the building.

        Show
        drankye Kai Zheng added a comment - The Jenkins building looks messy as not clean as the one before. Changed minor to re-trigger the building.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 19s Maven dependency ordering for branch
        +1 mvninstall 9m 56s trunk passed
        +1 compile 2m 53s trunk passed with JDK v1.8.0_66
        +1 compile 2m 20s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 38s trunk passed
        +1 mvnsite 2m 7s trunk passed
        +1 mvneclipse 0m 32s trunk passed
        +1 findbugs 5m 21s trunk passed
        +1 javadoc 2m 23s trunk passed with JDK v1.8.0_66
        +1 javadoc 3m 40s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 21s Maven dependency ordering for patch
        +1 mvninstall 1m 59s the patch passed
        +1 compile 2m 51s the patch passed with JDK v1.8.0_66
        +1 javac 2m 51s the patch passed
        +1 compile 2m 6s the patch passed with JDK v1.7.0_91
        +1 javac 2m 6s the patch passed
        -1 checkstyle 0m 36s hadoop-hdfs-project: patch generated 1 new + 274 unchanged - 4 fixed = 275 total (was 278)
        +1 mvnsite 2m 11s the patch passed
        +1 mvneclipse 0m 30s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 6m 31s the patch passed
        +1 javadoc 2m 38s the patch passed with JDK v1.8.0_66
        +1 javadoc 3m 57s the patch passed with JDK v1.7.0_91
        +1 unit 1m 43s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66.
        -1 unit 109m 59s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        +1 unit 1m 20s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91.
        -1 unit 79m 30s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 26s Patch does not generate ASF License warnings.
        250m 55s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
          hadoop.tracing.TestTracing
          hadoop.hdfs.server.namenode.TestDecommissioningStatus
          hadoop.hdfs.qjournal.TestSecureNNWithQJM
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport
          hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.TestFileAppend
          hadoop.hdfs.TestDFSUpgradeFromImage
          hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider
          hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
          hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
          hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785695/HDFS-9734-v4.patch
        JIRA Issue HDFS-9734
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 47c8a756b527 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9875325
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14334/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14334/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14334/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14334/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14334/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14334/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14334/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 19s Maven dependency ordering for branch +1 mvninstall 9m 56s trunk passed +1 compile 2m 53s trunk passed with JDK v1.8.0_66 +1 compile 2m 20s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 38s trunk passed +1 mvnsite 2m 7s trunk passed +1 mvneclipse 0m 32s trunk passed +1 findbugs 5m 21s trunk passed +1 javadoc 2m 23s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 40s trunk passed with JDK v1.7.0_91 0 mvndep 0m 21s Maven dependency ordering for patch +1 mvninstall 1m 59s the patch passed +1 compile 2m 51s the patch passed with JDK v1.8.0_66 +1 javac 2m 51s the patch passed +1 compile 2m 6s the patch passed with JDK v1.7.0_91 +1 javac 2m 6s the patch passed -1 checkstyle 0m 36s hadoop-hdfs-project: patch generated 1 new + 274 unchanged - 4 fixed = 275 total (was 278) +1 mvnsite 2m 11s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 6m 31s the patch passed +1 javadoc 2m 38s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 57s the patch passed with JDK v1.7.0_91 +1 unit 1m 43s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66. -1 unit 109m 59s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 1m 20s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91. -1 unit 79m 30s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 250m 55s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.tracing.TestTracing   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestFileAppend   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785695/HDFS-9734-v4.patch JIRA Issue HDFS-9734 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 47c8a756b527 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9875325 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14334/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14334/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14334/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14334/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14334/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14334/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14334/console This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Kai Zheng for the refactoring work, and sorry for chiming in late. Could you rebase the patch? Also I think we should avoid wildcard import (import java.util.*).

        Show
        zhz Zhe Zhang added a comment - Thanks Kai Zheng for the refactoring work, and sorry for chiming in late. Could you rebase the patch? Also I think we should avoid wildcard import ( import java.util.* ).
        Hide
        drankye Kai Zheng added a comment -

        Thanks Zhe for the review. Updated the patch accordingly.

        Show
        drankye Kai Zheng added a comment - Thanks Zhe for the review. Updated the patch accordingly.
        Hide
        drankye Kai Zheng added a comment -

        Uploaded HDFS-9734-v5.patch using the correct issue ID.

        Show
        drankye Kai Zheng added a comment - Uploaded HDFS-9734 -v5.patch using the correct issue ID.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 9s Maven dependency ordering for branch
        +1 mvninstall 7m 23s trunk passed
        +1 compile 1m 49s trunk passed with JDK v1.8.0_72
        +1 compile 1m 31s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 1m 36s trunk passed
        +1 mvneclipse 0m 26s trunk passed
        +1 findbugs 3m 45s trunk passed
        +1 javadoc 1m 44s trunk passed with JDK v1.8.0_72
        +1 javadoc 2m 25s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 1m 23s the patch passed
        +1 compile 1m 44s the patch passed with JDK v1.8.0_72
        +1 javac 1m 44s the patch passed
        +1 compile 1m 29s the patch passed with JDK v1.7.0_95
        +1 javac 1m 29s the patch passed
        -1 checkstyle 0m 29s hadoop-hdfs-project: patch generated 2 new + 330 unchanged - 4 fixed = 332 total (was 334)
        +1 mvnsite 1m 25s the patch passed
        +1 mvneclipse 0m 22s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 4m 1s the patch passed
        +1 javadoc 1m 40s the patch passed with JDK v1.8.0_72
        +1 javadoc 2m 25s the patch passed with JDK v1.7.0_95
        +1 unit 1m 4s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72.
        -1 unit 82m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
        +1 unit 1m 2s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
        -1 unit 74m 57s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        199m 28s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.hdfs.tools.TestDFSZKFailoverController
          hadoop.hdfs.server.datanode.TestDataNodeMetrics
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.TestFileAppend
          hadoop.hdfs.server.datanode.TestDirectoryScanner
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache
          hadoop.hdfs.TestFileAppend
          hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787917/HDFS-9734-v5.patch
        JIRA Issue HDFS-9734
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7b67af6dc673 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8ed07bd
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14496/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14496/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14496/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14496/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14496/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14496/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14496/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 7m 23s trunk passed +1 compile 1m 49s trunk passed with JDK v1.8.0_72 +1 compile 1m 31s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 30s trunk passed +1 mvnsite 1m 36s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 45s trunk passed +1 javadoc 1m 44s trunk passed with JDK v1.8.0_72 +1 javadoc 2m 25s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 23s the patch passed +1 compile 1m 44s the patch passed with JDK v1.8.0_72 +1 javac 1m 44s the patch passed +1 compile 1m 29s the patch passed with JDK v1.7.0_95 +1 javac 1m 29s the patch passed -1 checkstyle 0m 29s hadoop-hdfs-project: patch generated 2 new + 330 unchanged - 4 fixed = 332 total (was 334) +1 mvnsite 1m 25s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 1s the patch passed +1 javadoc 1m 40s the patch passed with JDK v1.8.0_72 +1 javadoc 2m 25s the patch passed with JDK v1.7.0_95 +1 unit 1m 4s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72. -1 unit 82m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 1m 2s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 74m 57s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 199m 28s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.TestFileAppend   hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787917/HDFS-9734-v5.patch JIRA Issue HDFS-9734 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7b67af6dc673 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8ed07bd Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14496/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14496/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14496/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14496/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14496/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14496/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14496/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        drankye Kai Zheng added a comment -

        Fixed one minor check style.

        Show
        drankye Kai Zheng added a comment - Fixed one minor check style.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 10s Maven dependency ordering for branch
        +1 mvninstall 6m 41s trunk passed
        +1 compile 1m 30s trunk passed with JDK v1.8.0_72
        +1 compile 1m 21s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 1m 35s trunk passed
        +1 mvneclipse 0m 26s trunk passed
        +1 findbugs 4m 2s trunk passed
        +1 javadoc 1m 56s trunk passed with JDK v1.8.0_72
        +1 javadoc 2m 51s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 1m 45s the patch passed
        +1 compile 2m 19s the patch passed with JDK v1.8.0_72
        +1 javac 2m 19s the patch passed
        +1 compile 1m 52s the patch passed with JDK v1.7.0_95
        +1 javac 1m 52s the patch passed
        -1 checkstyle 0m 34s hadoop-hdfs-project: patch generated 1 new + 330 unchanged - 4 fixed = 331 total (was 334)
        +1 mvnsite 1m 38s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 4m 34s the patch passed
        +1 javadoc 1m 56s the patch passed with JDK v1.8.0_72
        +1 javadoc 2m 30s the patch passed with JDK v1.7.0_95
        +1 unit 1m 11s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72.
        -1 unit 73m 27s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
        +1 unit 1m 8s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
        -1 unit 74m 33s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 22s Patch does not generate ASF License warnings.
        192m 36s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.namenode.TestDecommissioningStatus
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.TestFileAppend
          hadoop.hdfs.TestDataTransferKeepalive
        JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
          org.apache.hadoop.hdfs.TestHDFSFileSystemContract
          org.apache.hadoop.hdfs.TestDFSInotifyEventInputStream
          org.apache.hadoop.hdfs.TestDFSClientSocketSize
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockManager
          hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
          hadoop.tracing.TestTracing
          hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788010/HDFS-9734-v6.patch
        JIRA Issue HDFS-9734
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b8efca5532c9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8ed07bd
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14502/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14502/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14502/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14502/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14502/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14502/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14502/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 6m 41s trunk passed +1 compile 1m 30s trunk passed with JDK v1.8.0_72 +1 compile 1m 21s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 35s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 4m 2s trunk passed +1 javadoc 1m 56s trunk passed with JDK v1.8.0_72 +1 javadoc 2m 51s trunk passed with JDK v1.7.0_95 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 45s the patch passed +1 compile 2m 19s the patch passed with JDK v1.8.0_72 +1 javac 2m 19s the patch passed +1 compile 1m 52s the patch passed with JDK v1.7.0_95 +1 javac 1m 52s the patch passed -1 checkstyle 0m 34s hadoop-hdfs-project: patch generated 1 new + 330 unchanged - 4 fixed = 331 total (was 334) +1 mvnsite 1m 38s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 34s the patch passed +1 javadoc 1m 56s the patch passed with JDK v1.8.0_72 +1 javadoc 2m 30s the patch passed with JDK v1.7.0_95 +1 unit 1m 11s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72. -1 unit 73m 27s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 1m 8s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 74m 33s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 192m 36s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestFileAppend   hadoop.hdfs.TestDataTransferKeepalive JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure   org.apache.hadoop.hdfs.TestHDFSFileSystemContract   org.apache.hadoop.hdfs.TestDFSInotifyEventInputStream   org.apache.hadoop.hdfs.TestDFSClientSocketSize JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.tracing.TestTracing   hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788010/HDFS-9734-v6.patch JIRA Issue HDFS-9734 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b8efca5532c9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8ed07bd Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14502/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14502/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14502/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14502/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14502/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14502/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14502/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Kai for the work! The refactor looks clean overall. A few minors:

        1. CorruptBlocks#getCorruptedBlocks is a little awkward. I think we should either rename it as getCorruptionMap, or add some methods to the CorruptBlocks: getBlocks(), getDatanodes(ExtendedBlock). We should also add a simple Javadoc to the corruptionMap variable.
        2. There should be a line between CorruptedBlocks class and the code above it.
        Show
        zhz Zhe Zhang added a comment - Thanks Kai for the work! The refactor looks clean overall. A few minors: CorruptBlocks#getCorruptedBlocks is a little awkward. I think we should either rename it as getCorruptionMap , or add some methods to the CorruptBlocks : getBlocks() , getDatanodes(ExtendedBlock) . We should also add a simple Javadoc to the corruptionMap variable. There should be a line between CorruptedBlocks class and the code above it.
        Hide
        drankye Kai Zheng added a comment -

        Thanks Zhe for the nice comments! Using getCorruptionMap sounds better for now, and I do feel adding some methods to the new class is also a good idea because the checksum failure reporting logic can be improved further in future.

        Show
        drankye Kai Zheng added a comment - Thanks Zhe for the nice comments! Using getCorruptionMap sounds better for now, and I do feel adding some methods to the new class is also a good idea because the checksum failure reporting logic can be improved further in future.
        Hide
        drankye Kai Zheng added a comment -

        Updated the patch according to review comments.

        Show
        drankye Kai Zheng added a comment - Updated the patch according to review comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 15m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 16s Maven dependency ordering for branch
        +1 mvninstall 6m 40s trunk passed
        +1 compile 1m 16s trunk passed with JDK v1.8.0_72
        +1 compile 1m 21s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 1m 25s trunk passed
        +1 mvneclipse 0m 26s trunk passed
        +1 findbugs 3m 32s trunk passed
        +1 javadoc 1m 25s trunk passed with JDK v1.8.0_72
        +1 javadoc 2m 8s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 1m 15s the patch passed
        +1 compile 1m 9s the patch passed with JDK v1.8.0_72
        +1 javac 1m 9s the patch passed
        +1 compile 1m 18s the patch passed with JDK v1.7.0_95
        +1 javac 1m 18s the patch passed
        -1 checkstyle 0m 28s hadoop-hdfs-project: patch generated 2 new + 330 unchanged - 4 fixed = 332 total (was 334)
        +1 mvnsite 1m 22s the patch passed
        +1 mvneclipse 0m 21s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 3m 58s the patch passed
        +1 javadoc 1m 20s the patch passed with JDK v1.8.0_72
        +1 javadoc 2m 5s the patch passed with JDK v1.7.0_95
        +1 unit 0m 50s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72.
        -1 unit 53m 11s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
        +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
        +1 unit 50m 2s hadoop-hdfs in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        155m 13s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788353/HDFS-9734-v7.patch
        JIRA Issue HDFS-9734
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b83985953be5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1c248ea
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14522/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14522/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14522/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14522/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14522/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 15m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 6m 40s trunk passed +1 compile 1m 16s trunk passed with JDK v1.8.0_72 +1 compile 1m 21s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 30s trunk passed +1 mvnsite 1m 25s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 32s trunk passed +1 javadoc 1m 25s trunk passed with JDK v1.8.0_72 +1 javadoc 2m 8s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 15s the patch passed +1 compile 1m 9s the patch passed with JDK v1.8.0_72 +1 javac 1m 9s the patch passed +1 compile 1m 18s the patch passed with JDK v1.7.0_95 +1 javac 1m 18s the patch passed -1 checkstyle 0m 28s hadoop-hdfs-project: patch generated 2 new + 330 unchanged - 4 fixed = 332 total (was 334) +1 mvnsite 1m 22s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 58s the patch passed +1 javadoc 1m 20s the patch passed with JDK v1.8.0_72 +1 javadoc 2m 5s the patch passed with JDK v1.7.0_95 +1 unit 0m 50s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72. -1 unit 53m 11s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. +1 unit 50m 2s hadoop-hdfs in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 155m 13s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788353/HDFS-9734-v7.patch JIRA Issue HDFS-9734 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b83985953be5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1c248ea Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14522/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14522/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14522/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14522/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14522/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        drankye Kai Zheng added a comment -

        Zhe, would you take another look at the patch? Thanks.

        Show
        drankye Kai Zheng added a comment - Zhe, would you take another look at the patch? Thanks.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Kai for the update. The v7 patch LGTM. One nit is that getCorruptedMap should be getCorruptionMap to match the variable name? I'm attaching a v8 patch wit this fix. Please LMK if you agree. Waiting for a fresh Jenkins run in the meantime.

        Show
        zhz Zhe Zhang added a comment - Thanks Kai for the update. The v7 patch LGTM. One nit is that getCorruptedMap should be getCorruptionMap to match the variable name? I'm attaching a v8 patch wit this fix. Please LMK if you agree. Waiting for a fresh Jenkins run in the meantime.
        Hide
        drankye Kai Zheng added a comment -

        One nit is that getCorruptedMap should be getCorruptionMap

        Right exactly. Thanks for the update, Zhe!

        Show
        drankye Kai Zheng added a comment - One nit is that getCorruptedMap should be getCorruptionMap Right exactly. Thanks for the update, Zhe!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 13s Maven dependency ordering for branch
        +1 mvninstall 6m 38s trunk passed
        +1 compile 1m 16s trunk passed with JDK v1.8.0_72
        +1 compile 1m 18s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 1m 24s trunk passed
        +1 mvneclipse 0m 24s trunk passed
        +1 findbugs 3m 37s trunk passed
        +1 javadoc 1m 24s trunk passed with JDK v1.8.0_72
        +1 javadoc 2m 10s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 1m 17s the patch passed
        +1 compile 1m 13s the patch passed with JDK v1.8.0_72
        +1 javac 1m 13s the patch passed
        +1 compile 1m 16s the patch passed with JDK v1.7.0_95
        +1 javac 1m 16s the patch passed
        -1 checkstyle 0m 27s hadoop-hdfs-project: patch generated 2 new + 330 unchanged - 4 fixed = 332 total (was 334)
        +1 mvnsite 1m 20s the patch passed
        +1 mvneclipse 0m 21s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 3m 57s the patch passed
        +1 javadoc 1m 22s the patch passed with JDK v1.8.0_72
        +1 javadoc 2m 5s the patch passed with JDK v1.7.0_95
        +1 unit 0m 52s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72.
        -1 unit 53m 20s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
        +1 unit 0m 56s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
        -1 unit 51m 37s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        141m 59s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
          hadoop.hdfs.server.namenode.TestStartup
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
          hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789666/HDFS-9734-v8.patch
        JIRA Issue HDFS-9734
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 193c9b4c7224 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 954dd57
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14603/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14603/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14603/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14603/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14603/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14603/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14603/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 13s Maven dependency ordering for branch +1 mvninstall 6m 38s trunk passed +1 compile 1m 16s trunk passed with JDK v1.8.0_72 +1 compile 1m 18s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 30s trunk passed +1 mvnsite 1m 24s trunk passed +1 mvneclipse 0m 24s trunk passed +1 findbugs 3m 37s trunk passed +1 javadoc 1m 24s trunk passed with JDK v1.8.0_72 +1 javadoc 2m 10s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 17s the patch passed +1 compile 1m 13s the patch passed with JDK v1.8.0_72 +1 javac 1m 13s the patch passed +1 compile 1m 16s the patch passed with JDK v1.7.0_95 +1 javac 1m 16s the patch passed -1 checkstyle 0m 27s hadoop-hdfs-project: patch generated 2 new + 330 unchanged - 4 fixed = 332 total (was 334) +1 mvnsite 1m 20s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 57s the patch passed +1 javadoc 1m 22s the patch passed with JDK v1.8.0_72 +1 javadoc 2m 5s the patch passed with JDK v1.7.0_95 +1 unit 0m 52s hadoop-hdfs-client in the patch passed with JDK v1.8.0_72. -1 unit 53m 20s hadoop-hdfs in the patch failed with JDK v1.8.0_72. +1 unit 0m 56s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 51m 37s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 141m 59s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.server.namenode.TestStartup JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12789666/HDFS-9734-v8.patch JIRA Issue HDFS-9734 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 193c9b4c7224 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 954dd57 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14603/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14603/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14603/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14603/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14603/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14603/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14603/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Kai. +1 on the v8 patch. The reported test failures all pass locally.

        Show
        zhz Zhe Zhang added a comment - Thanks Kai. +1 on the v8 patch. The reported test failures all pass locally.
        Hide
        zhz Zhe Zhang added a comment -

        Committed to trunk. Thanks Kai for the work!

        Show
        zhz Zhe Zhang added a comment - Committed to trunk. Thanks Kai for the work!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9369 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9369/)
        HDFS-9734. Refactoring of checksum failure report related codes. (zhz: rev 8808779db351fe444388d4acb3094766b5980718)

        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSStripedInputStream.java
        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/erasurecode/ErasureCodingWorker.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestReconstructStripedFile.java
        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9369 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9369/ ) HDFS-9734 . Refactoring of checksum failure report related codes. (zhz: rev 8808779db351fe444388d4acb3094766b5980718) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSStripedInputStream.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/erasurecode/ErasureCodingWorker.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestReconstructStripedFile.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java
        Hide
        drankye Kai Zheng added a comment -

        Thanks Zhe Zhang for the reviewing and getting this in!

        Show
        drankye Kai Zheng added a comment - Thanks Zhe Zhang for the reviewing and getting this in!

          People

          • Assignee:
            drankye Kai Zheng
            Reporter:
            drankye Kai Zheng
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development