Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9730

Storage ID update does not happen when there is a layout change

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
    • Component/s: datanode
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      HDFS-9654 will cause test failures when we increment the datanode layout version next time.

      TestDatanodeStartupFixesLegacyStorageIDs#testUpgradeFrom22via26FixesStorageIDs
      TestDatanodeStartupFixesLegacyStorageIDs#testUpgradeFrom22FixesStorageIDs
      

      This is because createStorageID() is no longer called when it goes through the layout upgrade path.

      1. h9730_20160202.patch
        3 kB
        Tsz Wo Nicholas Sze
      2. h9730_20160203.patch
        4 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Hide
          ctrezzo Chris Trezzo added a comment -

          Thanks Kihwal Lee for the catch. I am not quite sure I understand why the current unit tests are actually passing. It seems as though both testUpgradeFrom22via26FixesStorageIDs and testUpgradeFrom22FixesStorageIDs should be failing with the current trunk. Investigating this.

          Show
          ctrezzo Chris Trezzo added a comment - Thanks Kihwal Lee for the catch. I am not quite sure I understand why the current unit tests are actually passing. It seems as though both testUpgradeFrom22via26FixesStorageIDs and testUpgradeFrom22FixesStorageIDs should be failing with the current trunk. Investigating this.
          Hide
          ctrezzo Chris Trezzo added a comment -

          (As well as 2.7.3)

          Show
          ctrezzo Chris Trezzo added a comment - (As well as 2.7.3)
          Hide
          kihwal Kihwal Lee added a comment -

          I am not quite sure I understand why the current unit tests are actually passing

          The datanode layout version(-56) hasn't changed in trunk or branch-2.7. So the test won't go through the layout update path. If the test case used an older layout version, it would have failed. HDFS-7575 was created with the test resource containing datanode layout version -56.

          Show
          kihwal Kihwal Lee added a comment - I am not quite sure I understand why the current unit tests are actually passing The datanode layout version(-56) hasn't changed in trunk or branch-2.7. So the test won't go through the layout update path. If the test case used an older layout version, it would have failed. HDFS-7575 was created with the test resource containing datanode layout version -56.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Hi Kihwal Lee, thanks for reporting this.

          > This is because createStorageID() is no longer called when it goes through the layout upgrade path.

          We still call createStorageID(..) the upgrade path. The call is moved to doUgrade(..) as shown below (line 802 in DataStorage).

          @@ -784,7 +798,8 @@ void doUpgrade(DataNode datanode, StorageDirectory sd, NamespaceInfo nsInfo)
               // 5. Rename <SD>/previous.tmp to <SD>/previous
               rename(tmpDir, prevDir);
               LOG.info("Upgrade of " + sd.getRoot()+ " is complete");
          -    addBlockPoolStorage(nsInfo.getBlockPoolID(), bpStorage);
          +
          +    createStorageID(sd, layoutVersion);
             }
          
          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Hi Kihwal Lee , thanks for reporting this. > This is because createStorageID() is no longer called when it goes through the layout upgrade path. We still call createStorageID(..) the upgrade path. The call is moved to doUgrade(..) as shown below (line 802 in DataStorage). @@ -784,7 +798,8 @@ void doUpgrade(DataNode datanode, StorageDirectory sd, NamespaceInfo nsInfo) // 5. Rename <SD>/previous.tmp to <SD>/previous rename(tmpDir, prevDir); LOG.info( "Upgrade of " + sd.getRoot()+ " is complete" ); - addBlockPoolStorage(nsInfo.getBlockPoolID(), bpStorage); + + createStorageID(sd, layoutVersion); }
          Hide
          vinayrpet Vinayakumar B added a comment -

          Thanks Kihwal Lee for reporting this. Yes, indeed createStorageId(..) is not called during layout upgrade.

          We still call createStorageID(..) the upgrade path. The call is moved to doUgrade(..) as shown below (line 802 in DataStorage).

          Yes Tsz Wo Nicholas Sze, its called. But it will hit only during layout upgrade from pre-federation layouts. Otherwise it will just write latest layoutVersion to VERSION file and return. does nothing else.

              if (DataNodeLayoutVersion.supports(
                  LayoutVersion.Feature.FEDERATION, layoutVersion)) {
                // The VERSION file is already read in. Override the layoutVersion 
                // field and overwrite the file. The upgrade work is handled by
                // {@link BlockPoolSliceStorage#doUpgrade}
                LOG.info("Updating layout version from " + layoutVersion + " to "
                    + HdfsServerConstants.DATANODE_LAYOUT_VERSION + " for storage "
                    + sd.getRoot());
                layoutVersion = HdfsServerConstants.DATANODE_LAYOUT_VERSION;
                writeProperties(sd);
                return;
              }

          Change created this is

               // do upgrade
               if (this.layoutVersion > HdfsServerConstants.DATANODE_LAYOUT_VERSION) {
          -      doUpgrade(datanode, sd, nsInfo);  // upgrade
          -      createStorageID(sd, !haveValidStorageId);
          -      return;
          +      doUpgrade(sd, nsInfo, conf);  // upgrade
          +      return true; // doUgrade already has written properties
               }

          My Apologies for missing this during review

          The fix would be as below.

          --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java
          +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java
          @@ -743,6 +743,8 @@ void doUpgrade(final StorageDirectory sd, final NamespaceInfo nsInfo,
                 LOG.info("Updating layout version from " + layoutVersion + " to "
                     + HdfsServerConstants.DATANODE_LAYOUT_VERSION + " for storage "
                     + sd.getRoot());
          +      // check and regenerate storageId if required.
          +      createStorageID(sd, layoutVersion);
                 layoutVersion = HdfsServerConstants.DATANODE_LAYOUT_VERSION;
                 writeProperties(sd);
                 return;
          

          But, I have tried to run tests by changing layout version in my eclipse, didnt hit failures though

          Show
          vinayrpet Vinayakumar B added a comment - Thanks Kihwal Lee for reporting this. Yes, indeed createStorageId(..) is not called during layout upgrade. We still call createStorageID(..) the upgrade path. The call is moved to doUgrade(..) as shown below (line 802 in DataStorage). Yes Tsz Wo Nicholas Sze , its called. But it will hit only during layout upgrade from pre-federation layouts. Otherwise it will just write latest layoutVersion to VERSION file and return. does nothing else. if (DataNodeLayoutVersion.supports( LayoutVersion.Feature.FEDERATION, layoutVersion)) { // The VERSION file is already read in. Override the layoutVersion // field and overwrite the file. The upgrade work is handled by // {@link BlockPoolSliceStorage#doUpgrade} LOG.info( "Updating layout version from " + layoutVersion + " to " + HdfsServerConstants.DATANODE_LAYOUT_VERSION + " for storage " + sd.getRoot()); layoutVersion = HdfsServerConstants.DATANODE_LAYOUT_VERSION; writeProperties(sd); return ; } Change created this is // do upgrade if ( this .layoutVersion > HdfsServerConstants.DATANODE_LAYOUT_VERSION) { - doUpgrade(datanode, sd, nsInfo); // upgrade - createStorageID(sd, !haveValidStorageId); - return ; + doUpgrade(sd, nsInfo, conf); // upgrade + return true ; // doUgrade already has written properties } My Apologies for missing this during review The fix would be as below. --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java @@ -743,6 +743,8 @@ void doUpgrade( final StorageDirectory sd, final NamespaceInfo nsInfo, LOG.info( "Updating layout version from " + layoutVersion + " to " + HdfsServerConstants.DATANODE_LAYOUT_VERSION + " for storage " + sd.getRoot()); + // check and regenerate storageId if required. + createStorageID(sd, layoutVersion); layoutVersion = HdfsServerConstants.DATANODE_LAYOUT_VERSION; writeProperties(sd); return ; But, I have tried to run tests by changing layout version in my eclipse, didnt hit failures though
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Vinayakumar B, thanks for hints. I understand the bug now. The bug is that layout version is updated before createStorageID(..).

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Vinayakumar B , thanks for hints. I understand the bug now. The bug is that layout version is updated before createStorageID(..).
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          h9730_20160202.patch: createStorageID before set layoutVersion.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - h9730_20160202.patch: createStorageID before set layoutVersion.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Kihwal Lee, could you see if the patch passes your test?

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Kihwal Lee , could you see if the patch passes your test?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 8s Maven dependency ordering for branch
          +1 mvninstall 6m 58s trunk passed
          +1 compile 0m 41s trunk passed with JDK v1.8.0_66
          +1 compile 0m 41s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 0m 53s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 54s trunk passed
          +1 javadoc 1m 8s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 49s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 0m 48s the patch passed
          +1 compile 0m 39s the patch passed with JDK v1.8.0_66
          +1 javac 0m 39s the patch passed
          +1 compile 0m 39s the patch passed with JDK v1.7.0_91
          +1 javac 0m 39s the patch passed
          -1 checkstyle 0m 19s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 43 unchanged - 0 fixed = 44 total (was 43)
          +1 mvnsite 0m 52s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 10s the patch passed
          +1 javadoc 1m 3s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 45s the patch passed with JDK v1.7.0_91
          +1 unit 65m 32s hadoop-hdfs in the patch passed with JDK v1.8.0_66.
          +1 unit 64m 26s hadoop-hdfs in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          156m 14s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785735/h9730_20160202.patch
          JIRA Issue HDFS-9730
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 261a6e457a03 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4d7055e
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14338/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14338/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14338/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 6m 58s trunk passed +1 compile 0m 41s trunk passed with JDK v1.8.0_66 +1 compile 0m 41s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 54s trunk passed +1 javadoc 1m 8s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 49s trunk passed with JDK v1.7.0_91 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 48s the patch passed +1 compile 0m 39s the patch passed with JDK v1.8.0_66 +1 javac 0m 39s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_91 +1 javac 0m 39s the patch passed -1 checkstyle 0m 19s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 43 unchanged - 0 fixed = 44 total (was 43) +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 10s the patch passed +1 javadoc 1m 3s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 45s the patch passed with JDK v1.7.0_91 +1 unit 65m 32s hadoop-hdfs in the patch passed with JDK v1.8.0_66. +1 unit 64m 26s hadoop-hdfs in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 156m 14s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785735/h9730_20160202.patch JIRA Issue HDFS-9730 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 261a6e457a03 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4d7055e Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14338/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14338/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14338/console This message was automatically generated.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Its been a while since all unit tests passed in hdfs precommit run. Nice to see

          Show
          vinayrpet Vinayakumar B added a comment - Its been a while since all unit tests passed in hdfs precommit run. Nice to see
          Hide
          kihwal Kihwal Lee added a comment -

          It is reproduced in 2.7 by making following temporary change.

          --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeLayoutVersion.java
          +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeLayoutVersion.java
          @@ -65,8 +65,9 @@ public static boolean supports(final LayoutFeature f, final int lv) {
               FIRST_LAYOUT(-55, -53, "First datanode layout", false),
               BLOCKID_BASED_LAYOUT(-56,
                   "The block ID of a finalized block uniquely determines its position " +
          -            "in the directory structure");
          -   
          +            "in the directory structure"),
          +    TEST_NEW_LAYOUT(-57, "testing");
          +  
               private final FeatureInfo info;
           
               /**
          

          With Tsz Wo Nicholas Sze's patch ported to 2.7, the failing tests pass.

          It looks like trunk has another problem. DatanodeStorage.isValidStorageId() in trunk returns true for the old ID format. This was broken by HDFS-8979.

          Show
          kihwal Kihwal Lee added a comment - It is reproduced in 2.7 by making following temporary change. --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeLayoutVersion.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeLayoutVersion.java @@ -65,8 +65,9 @@ public static boolean supports( final LayoutFeature f, final int lv) { FIRST_LAYOUT(-55, -53, "First datanode layout" , false ), BLOCKID_BASED_LAYOUT(-56, "The block ID of a finalized block uniquely determines its position " + - "in the directory structure" ); - + "in the directory structure" ), + TEST_NEW_LAYOUT(-57, "testing" ); + private final FeatureInfo info; /** With Tsz Wo Nicholas Sze 's patch ported to 2.7, the failing tests pass. It looks like trunk has another problem. DatanodeStorage.isValidStorageId() in trunk returns true for the old ID format. This was broken by HDFS-8979 .
          Hide
          kihwal Kihwal Lee added a comment -

          Filed HDFS-9739 for the broken isValidStorageId().

          Show
          kihwal Kihwal Lee added a comment - Filed HDFS-9739 for the broken isValidStorageId() .
          Hide
          kihwal Kihwal Lee added a comment -

          Its been a while since all unit tests passed in hdfs precommit run.

          Apparently that was a bug.

          Show
          kihwal Kihwal Lee added a comment - Its been a while since all unit tests passed in hdfs precommit run. Apparently that was a bug.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          h9730_20160203.patch: some minor changes.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - h9730_20160203.patch: some minor changes.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 17s Maven dependency ordering for branch
          +1 mvninstall 9m 5s trunk passed
          +1 compile 1m 17s trunk passed with JDK v1.8.0_66
          +1 compile 0m 59s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 1m 12s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          +1 findbugs 2m 41s trunk passed
          +1 javadoc 1m 46s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 34s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 1m 8s the patch passed
          +1 compile 1m 22s the patch passed with JDK v1.8.0_66
          +1 javac 1m 22s the patch passed
          +1 compile 1m 12s the patch passed with JDK v1.7.0_91
          +1 javac 1m 12s the patch passed
          +1 checkstyle 0m 25s the patch passed
          +1 mvnsite 1m 14s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 54s the patch passed
          +1 javadoc 1m 48s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 51s the patch passed with JDK v1.7.0_91
          -1 unit 150m 55s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 127m 34s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 41s Patch does not generate ASF License warnings.
          317m 51s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.tracing.TestTracing
            hadoop.fs.TestSymlinkHdfsFileContext
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
            hadoop.fs.TestSymlinkHdfsFileSystem
            hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.hdfs.TestEncryptionZonesWithKMS
            hadoop.hdfs.TestSafeModeWithStripedFile
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.TestDatanodeRegistration
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785967/h9730_20160203.patch
          JIRA Issue HDFS-9730
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c690afbfda42 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / eb2fb94
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14359/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14359/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14359/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14359/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14359/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14359/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 17s Maven dependency ordering for branch +1 mvninstall 9m 5s trunk passed +1 compile 1m 17s trunk passed with JDK v1.8.0_66 +1 compile 0m 59s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 25s trunk passed +1 mvnsite 1m 12s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 2m 41s trunk passed +1 javadoc 1m 46s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 34s trunk passed with JDK v1.7.0_91 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 8s the patch passed +1 compile 1m 22s the patch passed with JDK v1.8.0_66 +1 javac 1m 22s the patch passed +1 compile 1m 12s the patch passed with JDK v1.7.0_91 +1 javac 1m 12s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 1m 14s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 54s the patch passed +1 javadoc 1m 48s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 51s the patch passed with JDK v1.7.0_91 -1 unit 150m 55s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 127m 34s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 41s Patch does not generate ASF License warnings. 317m 51s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.tracing.TestTracing   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.fs.TestSymlinkHdfsFileSystem   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.TestEncryptionZonesWithKMS   hadoop.hdfs.TestSafeModeWithStripedFile   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.TestDatanodeRegistration   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785967/h9730_20160203.patch JIRA Issue HDFS-9730 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c690afbfda42 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / eb2fb94 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14359/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14359/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14359/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14359/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14359/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14359/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 25s Maven dependency ordering for branch
          +1 mvninstall 12m 28s trunk passed
          +1 compile 1m 52s trunk passed with JDK v1.8.0_66
          +1 compile 1m 25s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 35s trunk passed
          +1 mvnsite 1m 42s trunk passed
          +1 mvneclipse 0m 23s trunk passed
          +1 findbugs 3m 22s trunk passed
          +1 javadoc 2m 28s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 26s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 39s the patch passed
          +1 compile 1m 48s the patch passed with JDK v1.8.0_66
          +1 javac 1m 48s the patch passed
          +1 compile 1m 18s the patch passed with JDK v1.7.0_91
          +1 javac 1m 18s the patch passed
          +1 checkstyle 0m 32s the patch passed
          +1 mvnsite 1m 41s the patch passed
          +1 mvneclipse 0m 20s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 38s the patch passed
          +1 javadoc 2m 10s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 21s the patch passed with JDK v1.7.0_91
          -1 unit 108m 38s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 95m 2s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 30s Patch does not generate ASF License warnings.
          253m 33s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.mover.TestStorageMover
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
            hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.namenode.TestNameNodeResourceChecker
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.server.datanode.TestDirectoryScanner



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785967/h9730_20160203.patch
          JIRA Issue HDFS-9730
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 656cb8a6dc78 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1adb64e
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14365/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14365/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14365/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14365/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14365/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14365/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 25s Maven dependency ordering for branch +1 mvninstall 12m 28s trunk passed +1 compile 1m 52s trunk passed with JDK v1.8.0_66 +1 compile 1m 25s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 35s trunk passed +1 mvnsite 1m 42s trunk passed +1 mvneclipse 0m 23s trunk passed +1 findbugs 3m 22s trunk passed +1 javadoc 2m 28s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 26s trunk passed with JDK v1.7.0_91 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 39s the patch passed +1 compile 1m 48s the patch passed with JDK v1.8.0_66 +1 javac 1m 48s the patch passed +1 compile 1m 18s the patch passed with JDK v1.7.0_91 +1 javac 1m 18s the patch passed +1 checkstyle 0m 32s the patch passed +1 mvnsite 1m 41s the patch passed +1 mvneclipse 0m 20s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 38s the patch passed +1 javadoc 2m 10s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 21s the patch passed with JDK v1.7.0_91 -1 unit 108m 38s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 95m 2s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 30s Patch does not generate ASF License warnings. 253m 33s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.mover.TestStorageMover   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.TestNameNodeResourceChecker   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785967/h9730_20160203.patch JIRA Issue HDFS-9730 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 656cb8a6dc78 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1adb64e Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14365/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14365/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14365/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14365/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14365/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14365/console This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          All failed tests passed in my machine. Let me start another build.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - All failed tests passed in my machine. Let me start another build.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 11s Maven dependency ordering for branch
          +1 mvninstall 6m 38s trunk passed
          +1 compile 0m 40s trunk passed with JDK v1.8.0_66
          +1 compile 0m 40s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 52s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 53s trunk passed
          +1 javadoc 1m 7s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 46s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 37s the patch passed with JDK v1.8.0_66
          +1 javac 0m 37s the patch passed
          +1 compile 0m 39s the patch passed with JDK v1.7.0_91
          +1 javac 0m 39s the patch passed
          +1 checkstyle 0m 18s the patch passed
          +1 mvnsite 0m 49s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 7s the patch passed
          +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 42s the patch passed with JDK v1.7.0_91
          +1 unit 51m 29s hadoop-hdfs in the patch passed with JDK v1.8.0_66.
          +1 unit 48m 48s hadoop-hdfs in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          125m 34s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785967/h9730_20160203.patch
          JIRA Issue HDFS-9730
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 568c1e29dd17 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 22a2b22
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14383/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14383/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 6m 38s trunk passed +1 compile 0m 40s trunk passed with JDK v1.8.0_66 +1 compile 0m 40s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 53s trunk passed +1 javadoc 1m 7s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 46s trunk passed with JDK v1.7.0_91 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 45s the patch passed +1 compile 0m 37s the patch passed with JDK v1.8.0_66 +1 javac 0m 37s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_91 +1 javac 0m 39s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 7s the patch passed +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 42s the patch passed with JDK v1.7.0_91 +1 unit 51m 29s hadoop-hdfs in the patch passed with JDK v1.8.0_66. +1 unit 48m 48s hadoop-hdfs in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 125m 34s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785967/h9730_20160203.patch JIRA Issue HDFS-9730 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 568c1e29dd17 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 22a2b22 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14383/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14383/console This message was automatically generated.
          Hide
          kihwal Kihwal Lee added a comment -

          No need to do manual testing anymore. HDFS-9739 fixed the bug of making TestDatanodeStartupFixesLegacyStorageIDs pass.

          The precommit says not this test case is fixed by your patch.

          testUpgradeFrom22FixesStorageIDs	0.76 sec	Fixed
          testUpgradeFrom22via26FixesStorageIDs	3.8 sec		Passed
          testUpgradeFrom26PreservesStorageIDs	0.76 sec	Passed
          

          +1 The patch looks good.

          Show
          kihwal Kihwal Lee added a comment - No need to do manual testing anymore. HDFS-9739 fixed the bug of making TestDatanodeStartupFixesLegacyStorageIDs pass. The precommit says not this test case is fixed by your patch. testUpgradeFrom22FixesStorageIDs 0.76 sec Fixed testUpgradeFrom22via26FixesStorageIDs 3.8 sec Passed testUpgradeFrom26PreservesStorageIDs 0.76 sec Passed +1 The patch looks good.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9246 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9246/)
          HDFS-9730. Storage ID update does not happen when there is a layout (kihwal: rev 496f33de0ce80dc455cfd51f19612da6f9b914f9)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9246 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9246/ ) HDFS-9730 . Storage ID update does not happen when there is a layout (kihwal: rev 496f33de0ce80dc455cfd51f19612da6f9b914f9) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java
          Hide
          kihwal Kihwal Lee added a comment -

          Committed to trunk, branch-2, branch-2.8 and branch-2.7.
          The branch-2.7 conflicts were due to the move of a variable from HdfsConstants to HdfsServerConstants in trunk/branch-2.

          Show
          kihwal Kihwal Lee added a comment - Committed to trunk, branch-2, branch-2.8 and branch-2.7. The branch-2.7 conflicts were due to the move of a variable from HdfsConstants to HdfsServerConstants in trunk/branch-2.
          Hide
          kihwal Kihwal Lee added a comment -

          Thanks Vinay for analysis and Nicholas for the patch.

          Show
          kihwal Kihwal Lee added a comment - Thanks Vinay for analysis and Nicholas for the patch.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Kihwal Lee, thanks for reviewing, testing and committing the patch!

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Kihwal Lee , thanks for reviewing, testing and committing the patch!
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Closing the JIRA as part of 2.7.3 release.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

            People

            • Assignee:
              szetszwo Tsz Wo Nicholas Sze
              Reporter:
              kihwal Kihwal Lee
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development