Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9705

Refine the behaviour of getFileChecksum when length = 0

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4, 2.8.2
    • Component/s: None
    • Labels:
      None

      Description

      FileSystem#getFileChecksum may accept length parameter and 0 is a valid value. Currently it will return null when length is 0, in the following code block:

          //compute file MD5
          final MD5Hash fileMD5 = MD5Hash.digest(md5out.getData());
          switch (crcType) {
          case CRC32:
            return new MD5MD5CRC32GzipFileChecksum(bytesPerCRC,
                crcPerBlock, fileMD5);
          case CRC32C:
            return new MD5MD5CRC32CastagnoliFileChecksum(bytesPerCRC,
                crcPerBlock, fileMD5);
          default:
            // If there is no block allocated for the file,
            // return one with the magic entry that matches what previous
            // hdfs versions return.
            if (locatedblocks.size() == 0) {
              return new MD5MD5CRC32GzipFileChecksum(0, 0, fileMD5);
            }
      
            // we should never get here since the validity was checked
            // when getCrcType() was called above.
            return null;
          }
      

      The comment says "we should never get here since the validity was checked" but it does. As we're using the MD5-MD5-X approach, and EMPTY--CONTENT actually is a valid case in which the MD5 value is d41d8cd98f00b204e9800998ecf8427e, so suggest we return a reasonable value other than null. At least some useful information in the returned value can be seen, like values from block checksum header.

      1. HDFS-9705-branch-2.001.patch
        5 kB
        SammiChen
      2. HDFS-9705-branch-2.002.patch
        5 kB
        SammiChen
      3. HDFS-9705-v1.patch
        4 kB
        Kai Zheng
      4. HDFS-9705-v2.patch
        5 kB
        Kai Zheng
      5. HDFS-9705-v3.patch
        7 kB
        Kai Zheng
      6. HDFS-9705-v4.patch
        7 kB
        Kai Zheng
      7. HDFS-9705-v5.patch
        7 kB
        Kai Zheng
      8. HDFS-9705-v6.patch
        7 kB
        SammiChen
      9. HDFS-9705-v7.patch
        7 kB
        SammiChen

        Issue Links

          Activity

          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.
          Hide
          Sammi SammiChen added a comment -

          Thanks Andrew and Kai for reviewing the patch!

          Show
          Sammi SammiChen added a comment - Thanks Andrew and Kai for reviewing the patch!
          Hide
          andrew.wang Andrew Wang added a comment -

          Thanks Sammi and Kai, committed to branch-2 and branch-2.8

          Show
          andrew.wang Andrew Wang added a comment - Thanks Sammi and Kai, committed to branch-2 and branch-2.8
          Hide
          drankye Kai Zheng added a comment -

          LGTM too and +1. Thanks Andrew and Sammi.

          Show
          drankye Kai Zheng added a comment - LGTM too and +1. Thanks Andrew and Sammi.
          Hide
          andrew.wang Andrew Wang added a comment -

          LGTM, Kai do you want to review too?

          Show
          andrew.wang Andrew Wang added a comment - LGTM, Kai do you want to review too?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 30s Maven dependency ordering for branch
          +1 mvninstall 8m 4s branch-2 passed
          +1 compile 1m 39s branch-2 passed with JDK v1.8.0_121
          +1 compile 1m 38s branch-2 passed with JDK v1.7.0_121
          +1 checkstyle 0m 40s branch-2 passed
          +1 mvnsite 1m 38s branch-2 passed
          +1 mvneclipse 0m 31s branch-2 passed
          +1 findbugs 4m 6s branch-2 passed
          +1 javadoc 1m 34s branch-2 passed with JDK v1.8.0_121
          +1 javadoc 2m 23s branch-2 passed with JDK v1.7.0_121
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 29s the patch passed
          +1 compile 1m 42s the patch passed with JDK v1.8.0_121
          +1 javac 1m 42s the patch passed
          +1 compile 1m 43s the patch passed with JDK v1.7.0_121
          +1 javac 1m 43s the patch passed
          -0 checkstyle 0m 39s hadoop-hdfs-project: The patch generated 2 new + 116 unchanged - 3 fixed = 118 total (was 119)
          +1 mvnsite 1m 42s the patch passed
          +1 mvneclipse 0m 30s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 52s the patch passed
          +1 javadoc 1m 31s the patch passed with JDK v1.8.0_121
          +1 javadoc 2m 19s the patch passed with JDK v1.7.0_121
          +1 unit 1m 3s hadoop-hdfs-client in the patch passed with JDK v1.7.0_121.
          -1 unit 56m 41s hadoop-hdfs in the patch failed with JDK v1.7.0_121.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          167m 17s



          Reason Tests
          JDK v1.8.0_121 Timed out junit tests org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean
          JDK v1.7.0_121 Failed junit tests hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain
            hadoop.fs.viewfs.TestViewFileSystemHdfs
          JDK v1.7.0_121 Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue HDFS-9705
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860814/HDFS-9705-branch-2.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 30b233a79de1 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / ef43a62
          Default Java 1.7.0_121
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18869/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/18869/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_121.txt
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18869/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18869/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 30s Maven dependency ordering for branch +1 mvninstall 8m 4s branch-2 passed +1 compile 1m 39s branch-2 passed with JDK v1.8.0_121 +1 compile 1m 38s branch-2 passed with JDK v1.7.0_121 +1 checkstyle 0m 40s branch-2 passed +1 mvnsite 1m 38s branch-2 passed +1 mvneclipse 0m 31s branch-2 passed +1 findbugs 4m 6s branch-2 passed +1 javadoc 1m 34s branch-2 passed with JDK v1.8.0_121 +1 javadoc 2m 23s branch-2 passed with JDK v1.7.0_121 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 29s the patch passed +1 compile 1m 42s the patch passed with JDK v1.8.0_121 +1 javac 1m 42s the patch passed +1 compile 1m 43s the patch passed with JDK v1.7.0_121 +1 javac 1m 43s the patch passed -0 checkstyle 0m 39s hadoop-hdfs-project: The patch generated 2 new + 116 unchanged - 3 fixed = 118 total (was 119) +1 mvnsite 1m 42s the patch passed +1 mvneclipse 0m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 52s the patch passed +1 javadoc 1m 31s the patch passed with JDK v1.8.0_121 +1 javadoc 2m 19s the patch passed with JDK v1.7.0_121 +1 unit 1m 3s hadoop-hdfs-client in the patch passed with JDK v1.7.0_121. -1 unit 56m 41s hadoop-hdfs in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 167m 17s Reason Tests JDK v1.8.0_121 Timed out junit tests org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean JDK v1.7.0_121 Failed junit tests hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain   hadoop.fs.viewfs.TestViewFileSystemHdfs JDK v1.7.0_121 Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-9705 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860814/HDFS-9705-branch-2.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 30b233a79de1 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / ef43a62 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18869/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/18869/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18869/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18869/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Sammi SammiChen added a comment -

          fix one style issue

          Show
          Sammi SammiChen added a comment - fix one style issue
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 49s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 28s Maven dependency ordering for branch
          +1 mvninstall 7m 6s branch-2 passed
          +1 compile 1m 18s branch-2 passed with JDK v1.8.0_121
          +1 compile 1m 25s branch-2 passed with JDK v1.7.0_121
          +1 checkstyle 0m 35s branch-2 passed
          +1 mvnsite 1m 26s branch-2 passed
          +1 mvneclipse 0m 29s branch-2 passed
          +1 findbugs 3m 36s branch-2 passed
          +1 javadoc 1m 14s branch-2 passed with JDK v1.8.0_121
          +1 javadoc 1m 57s branch-2 passed with JDK v1.7.0_121
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 11s the patch passed
          +1 compile 1m 11s the patch passed with JDK v1.8.0_121
          +1 javac 1m 11s the patch passed
          +1 compile 1m 21s the patch passed with JDK v1.7.0_121
          +1 javac 1m 21s the patch passed
          -0 checkstyle 0m 32s hadoop-hdfs-project: The patch generated 4 new + 116 unchanged - 4 fixed = 120 total (was 120)
          +1 mvnsite 1m 20s the patch passed
          +1 mvneclipse 0m 24s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 56s the patch passed
          +1 javadoc 1m 10s the patch passed with JDK v1.8.0_121
          +1 javadoc 1m 55s the patch passed with JDK v1.7.0_121
          +1 unit 1m 2s hadoop-hdfs-client in the patch passed with JDK v1.7.0_121.
          -1 unit 51m 37s hadoop-hdfs in the patch failed with JDK v1.7.0_121.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          154m 48s



          Reason Tests
          JDK v1.7.0_121 Failed junit tests hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs
            hadoop.tracing.TestTraceAdmin
            hadoop.hdfs.server.datanode.metrics.TestDataNodeOutlierDetectionViaMetrics
            hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue HDFS-9705
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860638/HDFS-9705-branch-2.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c031ee3bd8d6 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / c97da48
          Default Java 1.7.0_121
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18852/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/18852/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_121.txt
          JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18852/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18852/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 49s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 28s Maven dependency ordering for branch +1 mvninstall 7m 6s branch-2 passed +1 compile 1m 18s branch-2 passed with JDK v1.8.0_121 +1 compile 1m 25s branch-2 passed with JDK v1.7.0_121 +1 checkstyle 0m 35s branch-2 passed +1 mvnsite 1m 26s branch-2 passed +1 mvneclipse 0m 29s branch-2 passed +1 findbugs 3m 36s branch-2 passed +1 javadoc 1m 14s branch-2 passed with JDK v1.8.0_121 +1 javadoc 1m 57s branch-2 passed with JDK v1.7.0_121 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 11s the patch passed +1 compile 1m 11s the patch passed with JDK v1.8.0_121 +1 javac 1m 11s the patch passed +1 compile 1m 21s the patch passed with JDK v1.7.0_121 +1 javac 1m 21s the patch passed -0 checkstyle 0m 32s hadoop-hdfs-project: The patch generated 4 new + 116 unchanged - 4 fixed = 120 total (was 120) +1 mvnsite 1m 20s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 56s the patch passed +1 javadoc 1m 10s the patch passed with JDK v1.8.0_121 +1 javadoc 1m 55s the patch passed with JDK v1.7.0_121 +1 unit 1m 2s hadoop-hdfs-client in the patch passed with JDK v1.7.0_121. -1 unit 51m 37s hadoop-hdfs in the patch failed with JDK v1.7.0_121. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 154m 48s Reason Tests JDK v1.7.0_121 Failed junit tests hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs   hadoop.tracing.TestTraceAdmin   hadoop.hdfs.server.datanode.metrics.TestDataNodeOutlierDetectionViaMetrics   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-9705 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860638/HDFS-9705-branch-2.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c031ee3bd8d6 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / c97da48 Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_121 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/18852/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/18852/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_121.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18852/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18852/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Sammi SammiChen added a comment -

          Patch for back port to branch-2

          Show
          Sammi SammiChen added a comment - Patch for back port to branch-2
          Hide
          Sammi SammiChen added a comment -

          Reopen issue for back port to branch-2

          Show
          Sammi SammiChen added a comment - Reopen issue for back port to branch-2
          Hide
          drankye Kai Zheng added a comment -

          Hi SammiChen, it's a good idea to get this ported to 2.x to ensure the behavior is consistent, though I understand this would need to re-do the change. Thanks.

          Show
          drankye Kai Zheng added a comment - Hi SammiChen , it's a good idea to get this ported to 2.x to ensure the behavior is consistent, though I understand this would need to re-do the change. Thanks.
          Hide
          Sammi SammiChen added a comment - - edited

          Thanks Andrew for review and commit the patch!

          Show
          Sammi SammiChen added a comment - - edited Thanks Andrew for review and commit the patch!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11405 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11405/)
          HDFS-9705. Refine the behaviour of getFileChecksum when length = 0. (wang: rev cc1292e73acd39c1f1023ad4841ffe30176f7daf)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockChecksumHelper.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FileChecksumHelper.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11405 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11405/ ) HDFS-9705 . Refine the behaviour of getFileChecksum when length = 0. (wang: rev cc1292e73acd39c1f1023ad4841ffe30176f7daf) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockChecksumHelper.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/FileChecksumHelper.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java
          Hide
          andrew.wang Andrew Wang added a comment -

          Great, thanks Sammi! Credited both Kai and yourself in the commit message. Thanks also to Nicholas for doing earlier reviews.

          This doesn't apply to branch-2, so only committed to trunk. Do we care about getting this in for 2.x?

          Show
          andrew.wang Andrew Wang added a comment - Great, thanks Sammi! Credited both Kai and yourself in the commit message. Thanks also to Nicholas for doing earlier reviews. This doesn't apply to branch-2, so only committed to trunk. Do we care about getting this in for 2.x?
          Hide
          Sammi SammiChen added a comment -

          Thanks Andrew Wang for trigger the build. I have double checked the failed unit test. It's not relevant.

          Show
          Sammi SammiChen added a comment - Thanks Andrew Wang for trigger the build. I have double checked the failed unit test. It's not relevant.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 7s Maven dependency ordering for branch
          +1 mvninstall 13m 28s trunk passed
          +1 compile 1m 45s trunk passed
          +1 checkstyle 0m 45s trunk passed
          +1 mvnsite 1m 37s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          +1 findbugs 3m 37s trunk passed
          +1 javadoc 1m 15s trunk passed
          0 mvndep 0m 8s Maven dependency ordering for patch
          +1 mvninstall 1m 52s the patch passed
          +1 compile 1m 56s the patch passed
          +1 javac 1m 56s the patch passed
          +1 checkstyle 0m 47s hadoop-hdfs-project: The patch generated 0 new + 89 unchanged - 1 fixed = 89 total (was 90)
          +1 mvnsite 1m 53s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 10s the patch passed
          +1 javadoc 1m 4s the patch passed
          +1 unit 1m 11s hadoop-hdfs-client in the patch passed.
          -1 unit 74m 0s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          113m 3s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-9705
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12856913/HDFS-9705-v7.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 959fc0c90179 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 229c7c9
          Default Java 1.8.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/18685/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18685/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18685/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 7s Maven dependency ordering for branch +1 mvninstall 13m 28s trunk passed +1 compile 1m 45s trunk passed +1 checkstyle 0m 45s trunk passed +1 mvnsite 1m 37s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 37s trunk passed +1 javadoc 1m 15s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 52s the patch passed +1 compile 1m 56s the patch passed +1 javac 1m 56s the patch passed +1 checkstyle 0m 47s hadoop-hdfs-project: The patch generated 0 new + 89 unchanged - 1 fixed = 89 total (was 90) +1 mvnsite 1m 53s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 10s the patch passed +1 javadoc 1m 4s the patch passed +1 unit 1m 11s hadoop-hdfs-client in the patch passed. -1 unit 74m 0s hadoop-hdfs in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 113m 3s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-9705 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12856913/HDFS-9705-v7.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 959fc0c90179 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 229c7c9 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18685/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18685/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18685/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          Yea, sorry about the lack of precommit...I've been trying to retrigger the build for this JIRA when I notice, but our build slaves keep getting messed up.

          I retriggered one more time and it looks like it took, thanks for the patience: https://builds.apache.org/job/PreCommit-HDFS-Build/18685/

          Show
          andrew.wang Andrew Wang added a comment - Yea, sorry about the lack of precommit...I've been trying to retrigger the build for this JIRA when I notice, but our build slaves keep getting messed up. I retriggered one more time and it looks like it took, thanks for the patience: https://builds.apache.org/job/PreCommit-HDFS-Build/18685/
          Hide
          Sammi SammiChen added a comment -

          Hi Andrew Wang, would you please help to trigger a Jenkin build? It seems the build system doesn't work well.

          Show
          Sammi SammiChen added a comment - Hi Andrew Wang , would you please help to trigger a Jenkin build? It seems the build system doesn't work well.
          Hide
          Sammi SammiChen added a comment -

          re-upload the patch to trigger the Jenkins build

          Show
          Sammi SammiChen added a comment - re-upload the patch to trigger the Jenkins build
          Hide
          Sammi SammiChen added a comment - - edited

          The previous comment is kind of misleading. When the crcType is "NULL" which means no checksum for files, the execution will go through the "default" branch of makeFinalResult function.

          Show
          Sammi SammiChen added a comment - - edited The previous comment is kind of misleading. When the crcType is "NULL" which means no checksum for files, the execution will go through the "default" branch of makeFinalResult function.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 24s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 37s Maven dependency ordering for branch
          +1 mvninstall 15m 3s trunk passed
          +1 compile 1m 46s trunk passed
          +1 checkstyle 0m 45s trunk passed
          +1 mvnsite 1m 37s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 3m 26s trunk passed
          +1 javadoc 1m 1s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 16s the patch passed
          +1 compile 1m 19s the patch passed
          +1 javac 1m 19s the patch passed
          +1 checkstyle 0m 38s hadoop-hdfs-project: The patch generated 0 new + 89 unchanged - 1 fixed = 89 total (was 90)
          +1 mvnsite 1m 21s the patch passed
          +1 mvneclipse 0m 20s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 23s the patch passed
          +1 javadoc 0m 54s the patch passed
          +1 unit 0m 55s hadoop-hdfs-client in the patch passed.
          -1 unit 70m 55s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          108m 16s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestFSOutputSummer



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-9705
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12856226/HDFS-9705-v6.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0d53ef231060 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5e74196
          Default Java 1.8.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/18601/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18601/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18601/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 37s Maven dependency ordering for branch +1 mvninstall 15m 3s trunk passed +1 compile 1m 46s trunk passed +1 checkstyle 0m 45s trunk passed +1 mvnsite 1m 37s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 3m 26s trunk passed +1 javadoc 1m 1s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 16s the patch passed +1 compile 1m 19s the patch passed +1 javac 1m 19s the patch passed +1 checkstyle 0m 38s hadoop-hdfs-project: The patch generated 0 new + 89 unchanged - 1 fixed = 89 total (was 90) +1 mvnsite 1m 21s the patch passed +1 mvneclipse 0m 20s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 23s the patch passed +1 javadoc 0m 54s the patch passed +1 unit 0m 55s hadoop-hdfs-client in the patch passed. -1 unit 70m 55s hadoop-hdfs in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 108m 16s Reason Tests Failed junit tests hadoop.hdfs.TestFSOutputSummer Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-9705 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12856226/HDFS-9705-v6.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0d53ef231060 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5e74196 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18601/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18601/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18601/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          LGTM thanks Sammi, though it seems like precommit didn't run. I filed INFRA-13618 and am waiting on them to help resolve it.

          Show
          andrew.wang Andrew Wang added a comment - LGTM thanks Sammi, though it seems like precommit didn't run. I filed INFRA-13618 and am waiting on them to help resolve it.
          Hide
          Sammi SammiChen added a comment -

          Hi Andrew Wang, I uploaded a new patch to add the check. Would you mind take a look at and give your comments? Thanks!

          Show
          Sammi SammiChen added a comment - Hi Andrew Wang , I uploaded a new patch to add the check. Would you mind take a look at and give your comments? Thanks!
          Hide
          andrew.wang Andrew Wang added a comment -

          Looks like the patch still applies, and Nicholas' review comments were addressed.

          One little nit, do you want to add a Precondition check here as an extra guard, since now we really think this shouldn't happen?

                  // we should never get here since the validity was checked
          
          Show
          andrew.wang Andrew Wang added a comment - Looks like the patch still applies, and Nicholas' review comments were addressed. One little nit, do you want to add a Precondition check here as an extra guard, since now we really think this shouldn't happen? // we should never get here since the validity was checked
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 24s Maven dependency ordering for branch
          +1 mvninstall 13m 4s trunk passed
          +1 compile 1m 23s trunk passed
          +1 checkstyle 0m 40s trunk passed
          +1 mvnsite 1m 22s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 3m 17s trunk passed
          +1 javadoc 1m 0s trunk passed
          0 mvndep 0m 7s Maven dependency ordering for patch
          +1 mvninstall 1m 21s the patch passed
          +1 compile 1m 39s the patch passed
          +1 javac 1m 39s the patch passed
          +1 checkstyle 0m 45s the patch passed
          +1 mvnsite 1m 38s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 1s The patch has no whitespace issues.
          +1 findbugs 3m 50s the patch passed
          +1 javadoc 1m 2s the patch passed
          +1 unit 1m 8s hadoop-hdfs-client in the patch passed.
          -1 unit 77m 13s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          112m 52s



          Reason Tests
          Failed junit tests hadoop.hdfs.web.TestWebHDFS
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.datanode.TestDataNodeUUID
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HDFS-9705
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796250/HDFS-9705-v5.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 6462f7d752dc 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 658702e
          Default Java 1.8.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/18389/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18389/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18389/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 24s Maven dependency ordering for branch +1 mvninstall 13m 4s trunk passed +1 compile 1m 23s trunk passed +1 checkstyle 0m 40s trunk passed +1 mvnsite 1m 22s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 17s trunk passed +1 javadoc 1m 0s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 21s the patch passed +1 compile 1m 39s the patch passed +1 javac 1m 39s the patch passed +1 checkstyle 0m 45s the patch passed +1 mvnsite 1m 38s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 3m 50s the patch passed +1 javadoc 1m 2s the patch passed +1 unit 1m 8s hadoop-hdfs-client in the patch passed. -1 unit 77m 13s hadoop-hdfs in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 112m 52s Reason Tests Failed junit tests hadoop.hdfs.web.TestWebHDFS   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-9705 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796250/HDFS-9705-v5.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6462f7d752dc 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 658702e Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/18389/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/18389/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/18389/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Andrew Wang, could we pick this up? Would be good to have for the 3.0 release. Thanks.

          Show
          drankye Kai Zheng added a comment - Andrew Wang , could we pick this up? Would be good to have for the 3.0 release. Thanks.
          Hide
          drankye Kai Zheng added a comment -

          Note the failed tests are not related.

          Show
          drankye Kai Zheng added a comment - Note the failed tests are not related.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 33s trunk passed
          +1 compile 1m 17s trunk passed with JDK v1.8.0_74
          +1 compile 1m 22s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 1m 24s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 3m 33s trunk passed
          +1 javadoc 1m 24s trunk passed with JDK v1.8.0_74
          +1 javadoc 2m 12s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 15s the patch passed
          +1 compile 1m 14s the patch passed with JDK v1.8.0_74
          +1 javac 1m 14s the patch passed
          +1 compile 1m 18s the patch passed with JDK v1.7.0_95
          +1 javac 1m 18s the patch passed
          +1 checkstyle 0m 25s the patch passed
          +1 mvnsite 1m 20s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 2s the patch passed
          +1 javadoc 1m 30s the patch passed with JDK v1.8.0_74
          +1 javadoc 2m 9s the patch passed with JDK v1.7.0_95
          +1 unit 0m 51s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74.
          -1 unit 56m 6s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
          +1 unit 0m 55s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
          -1 unit 53m 12s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          146m 26s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestHFlush
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.TestEditLog
            hadoop.hdfs.TestHFlush



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796250/HDFS-9705-v5.patch
          JIRA Issue HDFS-9705
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 7c352e438635 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 32c0c3e
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15021/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15021/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15021/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15021/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15021/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15021/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 33s trunk passed +1 compile 1m 17s trunk passed with JDK v1.8.0_74 +1 compile 1m 22s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 26s trunk passed +1 mvnsite 1m 24s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 33s trunk passed +1 javadoc 1m 24s trunk passed with JDK v1.8.0_74 +1 javadoc 2m 12s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 15s the patch passed +1 compile 1m 14s the patch passed with JDK v1.8.0_74 +1 javac 1m 14s the patch passed +1 compile 1m 18s the patch passed with JDK v1.7.0_95 +1 javac 1m 18s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 1m 20s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 2s the patch passed +1 javadoc 1m 30s the patch passed with JDK v1.8.0_74 +1 javadoc 2m 9s the patch passed with JDK v1.7.0_95 +1 unit 0m 51s hadoop-hdfs-client in the patch passed with JDK v1.8.0_74. -1 unit 56m 6s hadoop-hdfs in the patch failed with JDK v1.8.0_74. +1 unit 0m 55s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 53m 12s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 146m 26s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestHFlush JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.TestHFlush Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796250/HDFS-9705-v5.patch JIRA Issue HDFS-9705 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7c352e438635 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 32c0c3e Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15021/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15021/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15021/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15021/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15021/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15021/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch:

          • Rebased with latest changes;
          • Fixed some Javadoc comments inherited from HDFS-9694.

          Tsz Wo Nicholas Sze, Uma Maheswara Rao G, would you help take a look? Thanks.

          Show
          drankye Kai Zheng added a comment - Updated the patch: Rebased with latest changes; Fixed some Javadoc comments inherited from HDFS-9694 . Tsz Wo Nicholas Sze , Uma Maheswara Rao G , would you help take a look? Thanks.
          Hide
          drankye Kai Zheng added a comment -

          Trigger another building.

          Show
          drankye Kai Zheng added a comment - Trigger another building.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 6m 25s trunk passed
          +1 compile 1m 11s trunk passed with JDK v1.8.0_66
          +1 compile 1m 19s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 1m 24s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 3m 43s trunk passed
          +1 javadoc 1m 21s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 9s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 14s the patch passed
          +1 compile 1m 10s the patch passed with JDK v1.8.0_66
          +1 javac 1m 10s the patch passed
          +1 compile 1m 17s the patch passed with JDK v1.7.0_91
          +1 javac 1m 17s the patch passed
          -1 checkstyle 0m 23s hadoop-hdfs-project: patch generated 1 new + 52 unchanged - 1 fixed = 53 total (was 53)
          +1 mvnsite 1m 18s the patch passed
          +1 mvneclipse 0m 21s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 6s the patch passed
          +1 javadoc 1m 20s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 3s the patch passed with JDK v1.7.0_91
          +1 unit 0m 47s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66.
          -1 unit 50m 29s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 54s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91.
          +1 unit 50m 22s hadoop-hdfs in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          137m 30s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics
            hadoop.hdfs.TestRecoverStripedFile



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785492/HDFS-9705-v4.patch
          JIRA Issue HDFS-9705
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d3f8e5d688db 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8f2622b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14317/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14317/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14317/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14317/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14317/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 6m 25s trunk passed +1 compile 1m 11s trunk passed with JDK v1.8.0_66 +1 compile 1m 19s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 26s trunk passed +1 mvnsite 1m 24s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 3m 43s trunk passed +1 javadoc 1m 21s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 9s trunk passed with JDK v1.7.0_91 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 14s the patch passed +1 compile 1m 10s the patch passed with JDK v1.8.0_66 +1 javac 1m 10s the patch passed +1 compile 1m 17s the patch passed with JDK v1.7.0_91 +1 javac 1m 17s the patch passed -1 checkstyle 0m 23s hadoop-hdfs-project: patch generated 1 new + 52 unchanged - 1 fixed = 53 total (was 53) +1 mvnsite 1m 18s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 6s the patch passed +1 javadoc 1m 20s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 3s the patch passed with JDK v1.7.0_91 +1 unit 0m 47s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66. -1 unit 50m 29s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 0m 54s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91. +1 unit 50m 22s hadoop-hdfs in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 137m 30s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.TestRecoverStripedFile Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785492/HDFS-9705-v4.patch JIRA Issue HDFS-9705 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d3f8e5d688db 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8f2622b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14317/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14317/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14317/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14317/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14317/console This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Sorry, Nichalos should be Nicholas. Note the failed tests are not related.

          Show
          drankye Kai Zheng added a comment - Sorry, Nichalos should be Nicholas. Note the failed tests are not related.
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch, addressing a check style.

          public MD5MD5CRC32FileChecksum getFileChecksum(String src, long length):3: Method length is 193 lines (max allowed is 150).

          This is an old issue, and will be resolved in HDFS-8430 related in the way that the large method will be refactored.

          Nichalos, how do you like the latest patch? Thanks.

          Show
          drankye Kai Zheng added a comment - Updated the patch, addressing a check style. public MD5MD5CRC32FileChecksum getFileChecksum(String src, long length):3: Method length is 193 lines (max allowed is 150). This is an old issue, and will be resolved in HDFS-8430 related in the way that the large method will be refactored. Nichalos, how do you like the latest patch? Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 29s Maven dependency ordering for branch
          +1 mvninstall 9m 53s trunk passed
          +1 compile 2m 19s trunk passed with JDK v1.8.0_66
          +1 compile 1m 50s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 1m 50s trunk passed
          +1 mvneclipse 0m 29s trunk passed
          +1 findbugs 4m 46s trunk passed
          +1 javadoc 2m 2s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 55s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 41s the patch passed
          +1 compile 2m 13s the patch passed with JDK v1.8.0_66
          +1 javac 2m 13s the patch passed
          +1 compile 1m 48s the patch passed with JDK v1.7.0_91
          +1 javac 1m 48s the patch passed
          -1 checkstyle 0m 30s hadoop-hdfs-project: patch generated 2 new + 52 unchanged - 1 fixed = 54 total (was 53)
          +1 mvnsite 1m 46s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 5m 14s the patch passed
          +1 javadoc 2m 1s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 41s the patch passed with JDK v1.7.0_91
          +1 unit 1m 17s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66.
          -1 unit 91m 35s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 1m 14s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91.
          -1 unit 108m 54s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 32s Patch does not generate ASF License warnings.
          252m 45s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.TestErasureCodeBenchmarkThroughput
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.TestEncryptionZonesWithKMS
            hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
            hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.TestSafeModeWithStripedFile
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.hdfs.qjournal.TestMiniJournalCluster



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784623/HDFS-9705-v3.patch
          JIRA Issue HDFS-9705
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9375bb756fbd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c01bee0
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14259/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14259/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14259/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 29s Maven dependency ordering for branch +1 mvninstall 9m 53s trunk passed +1 compile 2m 19s trunk passed with JDK v1.8.0_66 +1 compile 1m 50s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 50s trunk passed +1 mvneclipse 0m 29s trunk passed +1 findbugs 4m 46s trunk passed +1 javadoc 2m 2s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 55s trunk passed with JDK v1.7.0_91 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 41s the patch passed +1 compile 2m 13s the patch passed with JDK v1.8.0_66 +1 javac 2m 13s the patch passed +1 compile 1m 48s the patch passed with JDK v1.7.0_91 +1 javac 1m 48s the patch passed -1 checkstyle 0m 30s hadoop-hdfs-project: patch generated 2 new + 52 unchanged - 1 fixed = 54 total (was 53) +1 mvnsite 1m 46s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 5m 14s the patch passed +1 javadoc 2m 1s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 41s the patch passed with JDK v1.7.0_91 +1 unit 1m 17s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66. -1 unit 91m 35s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 1m 14s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91. -1 unit 108m 54s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 32s Patch does not generate ASF License warnings. 252m 45s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestErasureCodeBenchmarkThroughput   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.TestEncryptionZonesWithKMS   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestSafeModeWithStripedFile   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.hdfs.qjournal.TestMiniJournalCluster Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784623/HDFS-9705-v3.patch JIRA Issue HDFS-9705 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9375bb756fbd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c01bee0 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14259/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14259/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14259/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14259/console This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Updated the patch according to above discussion.
          Note the magic value MD5-of-0MD5-of-0CRC32:70bc8f4b72a86921468bf8e8441dce51 is used in the case (request length is 0) as the case of empty file. The two cases are consolidated into a single place at the beginning. Also cleaned up a Javadoc by the way.

          Show
          drankye Kai Zheng added a comment - Updated the patch according to above discussion. Note the magic value MD5-of-0MD5-of-0CRC32:70bc8f4b72a86921468bf8e8441dce51 is used in the case (request length is 0) as the case of empty file. The two cases are consolidated into a single place at the beginning. Also cleaned up a Javadoc by the way.
          Hide
          drankye Kai Zheng added a comment -

          Got it. I'll use the preferred option. Thanks!

          Show
          drankye Kai Zheng added a comment - Got it. I'll use the preferred option. Thanks!
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          FileChecksum#EMPTY is attractive, however, it is more correct to use MD5-of-0MD5-of-0CRC32C:d41d8cd98f00b204e9800998ecf8427e since non-Hadoop could use the same algorithm to compute the same value.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - FileChecksum#EMPTY is attractive, however, it is more correct to use MD5-of-0MD5-of-0CRC32C:d41d8cd98f00b204e9800998ecf8427e since non-Hadoop could use the same algorithm to compute the same value.
          Hide
          drankye Kai Zheng added a comment -

          Thanks Nicholas for the comment!

          Let's check if length == 0 in the very beginning of DFSClient.getFileChecksum and return.

          At the very beginning, what would you prefer to return? Still null or a FileChecksum type object that represents empty content? If the latter case, do you want to go to datanodes to retrieve the checksum meta data in replicas? Otherwise we could use a value like MD5-of-0MD5-of-0CRC32C:d41d8cd98f00b204e9800998ecf8427e, here d41d8cd98f00b204e9800998ecf8427e represents empty value for MD5. Kinds of a bit complicated, maybe define a constant value FileChecksum#EMPTY for the purpose? Thanks for your confirm.

          Show
          drankye Kai Zheng added a comment - Thanks Nicholas for the comment! Let's check if length == 0 in the very beginning of DFSClient.getFileChecksum and return. At the very beginning, what would you prefer to return? Still null or a FileChecksum type object that represents empty content? If the latter case, do you want to go to datanodes to retrieve the checksum meta data in replicas? Otherwise we could use a value like MD5-of-0MD5-of-0CRC32C:d41d8cd98f00b204e9800998ecf8427e , here d41d8cd98f00b204e9800998ecf8427e represents empty value for MD5. Kinds of a bit complicated, maybe define a constant value FileChecksum#EMPTY for the purpose? Thanks for your confirm.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Thanks Kai for working on this. Some comment on the patch:

          • Let's check if length == 0 in the very beginning of DFSClient.getFileChecksum and return.
          • For the new test, let's add it to TestDistributedFileSystem.testFileChecksum(). It is expensive to start a cluster.
          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Thanks Kai for working on this. Some comment on the patch: Let's check if length == 0 in the very beginning of DFSClient.getFileChecksum and return. For the new test, let's add it to TestDistributedFileSystem.testFileChecksum(). It is expensive to start a cluster.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 26s Maven dependency ordering for branch
          +1 mvninstall 10m 17s trunk passed
          +1 compile 2m 39s trunk passed with JDK v1.8.0_66
          +1 compile 1m 51s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 1m 51s trunk passed
          +1 mvneclipse 0m 29s trunk passed
          +1 findbugs 4m 44s trunk passed
          +1 javadoc 2m 9s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 4s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 20s Maven dependency ordering for patch
          +1 mvninstall 1m 52s the patch passed
          +1 compile 2m 42s the patch passed with JDK v1.8.0_66
          +1 javac 2m 42s the patch passed
          +1 compile 2m 26s the patch passed with JDK v1.7.0_91
          +1 javac 2m 26s the patch passed
          +1 checkstyle 0m 40s the patch passed
          +1 mvnsite 2m 22s the patch passed
          +1 mvneclipse 0m 37s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 6m 3s the patch passed
          +1 javadoc 2m 45s the patch passed with JDK v1.8.0_66
          +1 javadoc 4m 4s the patch passed with JDK v1.7.0_91
          +1 unit 1m 20s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66.
          -1 unit 98m 4s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 1m 8s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91.
          -1 unit 97m 53s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 32s Patch does not generate ASF License warnings.
          255m 2s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.cli.TestHDFSCLI
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.TestPersistBlocks
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.TestGetFileChecksum
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
            hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.7.0_91 Failed junit tests hadoop.cli.TestHDFSCLI
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.TestLocalDFS
            hadoop.hdfs.TestGetFileChecksum
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.server.datanode.TestDirectoryScanner



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784390/HDFS-9705-v1.patch
          JIRA Issue HDFS-9705
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1fae44896464 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d0d7c22
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14245/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14245/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14245/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14245/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14245/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14245/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 26s Maven dependency ordering for branch +1 mvninstall 10m 17s trunk passed +1 compile 2m 39s trunk passed with JDK v1.8.0_66 +1 compile 1m 51s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 32s trunk passed +1 mvnsite 1m 51s trunk passed +1 mvneclipse 0m 29s trunk passed +1 findbugs 4m 44s trunk passed +1 javadoc 2m 9s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 4s trunk passed with JDK v1.7.0_91 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvninstall 1m 52s the patch passed +1 compile 2m 42s the patch passed with JDK v1.8.0_66 +1 javac 2m 42s the patch passed +1 compile 2m 26s the patch passed with JDK v1.7.0_91 +1 javac 2m 26s the patch passed +1 checkstyle 0m 40s the patch passed +1 mvnsite 2m 22s the patch passed +1 mvneclipse 0m 37s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 6m 3s the patch passed +1 javadoc 2m 45s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 4s the patch passed with JDK v1.7.0_91 +1 unit 1m 20s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66. -1 unit 98m 4s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 1m 8s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91. -1 unit 97m 53s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 32s Patch does not generate ASF License warnings. 255m 2s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.cli.TestHDFSCLI   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestGetFileChecksum   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Failed junit tests hadoop.cli.TestHDFSCLI   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.TestGetFileChecksum   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784390/HDFS-9705-v1.patch JIRA Issue HDFS-9705 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1fae44896464 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d0d7c22 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14245/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14245/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14245/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14245/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14245/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14245/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 7m 27s trunk passed
          +1 compile 1m 31s trunk passed with JDK v1.8.0_66
          +1 compile 1m 23s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 1m 25s trunk passed
          +1 mvneclipse 0m 23s trunk passed
          +1 findbugs 3m 39s trunk passed
          +1 javadoc 1m 29s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 11s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 16s the patch passed
          +1 compile 1m 29s the patch passed with JDK v1.8.0_66
          +1 javac 1m 29s the patch passed
          +1 compile 1m 20s the patch passed with JDK v1.7.0_91
          +1 javac 1m 20s the patch passed
          -1 checkstyle 0m 23s hadoop-hdfs-project: patch generated 1 new + 52 unchanged - 1 fixed = 53 total (was 53)
          +1 mvnsite 1m 20s the patch passed
          +1 mvneclipse 0m 20s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 4m 5s the patch passed
          +1 javadoc 1m 24s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 5s the patch passed with JDK v1.7.0_91
          +1 unit 0m 55s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66.
          -1 unit 60m 44s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 55s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91.
          +1 unit 54m 29s hadoop-hdfs in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          154m 0s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestHFlush
            hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.TestDFSClientRetries
            hadoop.hdfs.server.datanode.TestBlockScanner



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784400/HDFS-9705-v2.patch
          JIRA Issue HDFS-9705
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 405e59e87fdf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d0d7c22
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14246/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14246/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14246/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14246/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14246/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 7m 27s trunk passed +1 compile 1m 31s trunk passed with JDK v1.8.0_66 +1 compile 1m 23s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 25s trunk passed +1 mvnsite 1m 25s trunk passed +1 mvneclipse 0m 23s trunk passed +1 findbugs 3m 39s trunk passed +1 javadoc 1m 29s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 11s trunk passed with JDK v1.7.0_91 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 16s the patch passed +1 compile 1m 29s the patch passed with JDK v1.8.0_66 +1 javac 1m 29s the patch passed +1 compile 1m 20s the patch passed with JDK v1.7.0_91 +1 javac 1m 20s the patch passed -1 checkstyle 0m 23s hadoop-hdfs-project: patch generated 1 new + 52 unchanged - 1 fixed = 53 total (was 53) +1 mvnsite 1m 20s the patch passed +1 mvneclipse 0m 20s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 5s the patch passed +1 javadoc 1m 24s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 5s the patch passed with JDK v1.7.0_91 +1 unit 0m 55s hadoop-hdfs-client in the patch passed with JDK v1.8.0_66. -1 unit 60m 44s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 0m 55s hadoop-hdfs-client in the patch passed with JDK v1.7.0_91. +1 unit 54m 29s hadoop-hdfs in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 154m 0s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport   hadoop.hdfs.TestFileAppend   hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.server.datanode.TestBlockScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784400/HDFS-9705-v2.patch JIRA Issue HDFS-9705 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 405e59e87fdf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d0d7c22 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14246/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14246/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14246/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14246/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14246/console This message was automatically generated.
          Hide
          drankye Kai Zheng added a comment -

          Change safer and add comment for a confusing place.

          Show
          drankye Kai Zheng added a comment - Change safer and add comment for a confusing place.
          Hide
          drankye Kai Zheng added a comment -

          Uploaded a patch, ready for review. Note the new test file will be updated in some work like HDFS-9694.
          Tsz Wo Nicholas Sze, would you mind taking a look and give your comment? Thanks.

          Show
          drankye Kai Zheng added a comment - Uploaded a patch, ready for review. Note the new test file will be updated in some work like HDFS-9694 . Tsz Wo Nicholas Sze , would you mind taking a look and give your comment? Thanks.

            People

            • Assignee:
              Sammi SammiChen
              Reporter:
              drankye Kai Zheng
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development