[HDFS-970] FSImage writing should always fsync before close

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.20.1, 0.21.0, 0.22.0
• Fix Version/s: 0.22.0
• Component/s: namenode
• Hadoop Flags: Reviewed
• Assignee: Todd Lipcon
• Reporter: Todd Lipcon
• Created: 11/Feb/10 23:37
• Updated: 12/Dec/11 06:19
• Resolved: 15/May/10 05:05

Description

Without an fsync, it's common that filesystems will delay the writing of metadata to the journal until all of the data blocks have been flushed. If the system crashes while the dirty pages haven't been flushed, the file is left in an indeterminate state. In some FSs (eg ext4) this will result in a 0-length file. In others (eg XFS) it will result in the correct length but any number of data blocks getting zeroed. Calling FileChannel.force before closing the FSImage prevents this issue.

Issue Links

• is related to: HDFS-955 FSImage.saveFSImage can lose edits
• is related to: HDFS-957 FSImage layout version should be only once file is complete