Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9659

EditLogTailerThread to Active Namenode RPC should timeout

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: ha, namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      EditLogTailerThread to Active Namenode RPC doesn't have timeout and it’s removed in HDFS-6440.

      When inject the disk slow and consume system IO to the active name node, the nameservice can't switch and this is because SNN not able to stop EditLogTailerThread.

      Thread dump from SNN

      "IPC Server handler 33 on 25000" #118 daemon prio=5 os_prio=0 tid=0x00007f2384409800 nid=0x26c89 in Object.wait() [0x00007f2376ac7000]
         java.lang.Thread.State: WAITING (on object monitor)
      	at java.lang.Object.wait(Native Method)
      	at java.lang.Thread.join(Thread.java:1245)
      	- locked <0x00000006d517f538> (a org.apache.hadoop.hdfs.server.namenode.ha.EditLogTailer$EditLogTailerThread)
      	at java.lang.Thread.join(Thread.java:1319)
      	at org.apache.hadoop.hdfs.server.namenode.ha.EditLogTailer.stop(EditLogTailer.java:183)
      	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.stopStandbyServices(FSNamesystem.java:1284)
      	at org.apache.hadoop.hdfs.server.namenode.NameNode$NameNodeHAContext.stopStandbyServices(NameNode.java:1852)
      	at org.apache.hadoop.hdfs.server.namenode.ha.StandbyState.exitState(StandbyState.java:72)
      	at org.apache.hadoop.hdfs.server.namenode.ha.HAState.setStateInternal(HAState.java:62)
      	at org.apache.hadoop.hdfs.server.namenode.ha.StandbyState.setState(StandbyState.java:49)
      	at org.apache.hadoop.hdfs.server.namenode.NameNode.transitionToActive(NameNode.java:1684)
      

      Thread dump for EditLogTailerThread, it is stuck in NamenodeProtocolTranslatorPB.rollEditLog() rpc call.

      "Edit log tailer" #150 prio=5 os_prio=0 tid=0x00007f2395569800 nid=0x26cac in Object.wait() [0x00007f2374aa7000]
         java.lang.Thread.State: WAITING (on object monitor)
      	at java.lang.Object.wait(Native Method)
      	at java.lang.Object.wait(Object.java:502)
      	at org.apache.hadoop.ipc.Client.call(Client.java:1503)
      	- locked <0x00000006d581bb90> (a org.apache.hadoop.ipc.Client$Call)
      	at org.apache.hadoop.ipc.Client.call(Client.java:1448)
      	at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:229)
      	at com.sun.proxy.$Proxy16.rollEditLog(Unknown Source)
      	at org.apache.hadoop.hdfs.protocolPB.NamenodeProtocolTranslatorPB.rollEditLog(NamenodeProtocolTranslatorPB.java:148)
      	at org.apache.hadoop.hdfs.server.namenode.ha.EditLogTailer$2.doWork(EditLogTailer.java:301)
      	at org.apache.hadoop.hdfs.server.namenode.ha.EditLogTailer$2.doWork(EditLogTailer.java:298)
      	at org.apache.hadoop.hdfs.server.namenode.ha.EditLogTailer$MultipleNameNodeProxy.call(EditLogTailer.java:420)
      
      1. HDFS-9659.01.patch
        2 kB
        Surendra Singh Lilhore
      2. HDFS-9659.02.patch
        1 kB
        Surendra Singh Lilhore
      3. HDFS-9659.patch
        1 kB
        Surendra Singh Lilhore

        Issue Links

          Activity

          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Attached initial patch
          Please review..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Attached initial patch Please review..
          Hide
          drankye Kai Zheng added a comment -

          By the way, suggest use RPC#getProxy instead. The waitForProxy call with the Long.MAX_VALUE ineffective parameter doesn't look clean.

          Show
          drankye Kai Zheng added a comment - By the way, suggest use RPC#getProxy instead. The waitForProxy call with the Long.MAX_VALUE ineffective parameter doesn't look clean.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Kai Zheng for suggestion..
          Attached updated patch. Please review ...

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Kai Zheng for suggestion.. Attached updated patch. Please review ...
          Hide
          vinayrpet Vinayakumar B added a comment -
          -      int rpcTimeout = conf.getInt(
          -          DFSConfigKeys.DFS_HA_LOGROLL_RPC_TIMEOUT_KEY,
          -          DFSConfigKeys.DFS_HA_LOGROLL_RPC_TIMEOUT_DEFAULT);
          -      NamenodeProtocolPB proxy = RPC.waitForProxy(NamenodeProtocolPB.class,
          -          RPC.getProtocolVersion(NamenodeProtocolPB.class), activeAddr, conf,
          -          rpcTimeout, Long.MAX_VALUE)
          

          This was the code before HDFS-6440, which retries on connect exceptions.
          I think its better to restore current code back to pre-HDFS-6440 code by using RPC.waitForProxy(..).

          Show
          vinayrpet Vinayakumar B added a comment - - int rpcTimeout = conf.getInt( - DFSConfigKeys.DFS_HA_LOGROLL_RPC_TIMEOUT_KEY, - DFSConfigKeys.DFS_HA_LOGROLL_RPC_TIMEOUT_DEFAULT); - NamenodeProtocolPB proxy = RPC.waitForProxy(NamenodeProtocolPB.class, - RPC.getProtocolVersion(NamenodeProtocolPB.class), activeAddr, conf, - rpcTimeout, Long .MAX_VALUE) This was the code before HDFS-6440 , which retries on connect exceptions. I think its better to restore current code back to pre- HDFS-6440 code by using RPC.waitForProxy(..) .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 10m 54s trunk passed
          +1 compile 1m 12s trunk passed with JDK v1.8.0_66
          +1 compile 1m 0s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 1m 11s trunk passed
          +1 mvneclipse 0m 20s trunk passed
          +1 findbugs 2m 40s trunk passed
          +1 javadoc 1m 47s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 35s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 8s the patch passed
          +1 compile 1m 10s the patch passed with JDK v1.8.0_66
          +1 javac 1m 10s the patch passed
          +1 compile 0m 58s the patch passed with JDK v1.7.0_91
          +1 javac 0m 58s the patch passed
          +1 checkstyle 0m 22s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 25 unchanged - 2 fixed = 25 total (was 27)
          +1 mvnsite 1m 14s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 57s the patch passed
          +1 javadoc 1m 33s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 39s the patch passed with JDK v1.7.0_91
          -1 unit 86m 27s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 94m 24s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 34s Patch does not generate ASF License warnings.
          219m 55s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.TestListFilesInDFS
            org.apache.hadoop.hdfs.TestFileAppend2
            org.apache.hadoop.hdfs.TestHDFSFileSystemContract
            org.apache.hadoop.hdfs.TestDFSShell
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.security.TestDelegationTokenForProxyUser



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783092/HDFS-9659.01.patch
          JIRA Issue HDFS-9659
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0f7ca693c52f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 57d0a94
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14169/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14169/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14169/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14169/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14169/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14169/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 10m 54s trunk passed +1 compile 1m 12s trunk passed with JDK v1.8.0_66 +1 compile 1m 0s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 22s trunk passed +1 mvnsite 1m 11s trunk passed +1 mvneclipse 0m 20s trunk passed +1 findbugs 2m 40s trunk passed +1 javadoc 1m 47s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 35s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 8s the patch passed +1 compile 1m 10s the patch passed with JDK v1.8.0_66 +1 javac 1m 10s the patch passed +1 compile 0m 58s the patch passed with JDK v1.7.0_91 +1 javac 0m 58s the patch passed +1 checkstyle 0m 22s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 25 unchanged - 2 fixed = 25 total (was 27) +1 mvnsite 1m 14s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 57s the patch passed +1 javadoc 1m 33s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 39s the patch passed with JDK v1.7.0_91 -1 unit 86m 27s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 94m 24s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 34s Patch does not generate ASF License warnings. 219m 55s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.security.TestDelegationTokenForProxyUser JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.TestListFilesInDFS   org.apache.hadoop.hdfs.TestFileAppend2   org.apache.hadoop.hdfs.TestHDFSFileSystemContract   org.apache.hadoop.hdfs.TestDFSShell JDK v1.7.0_91 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.security.TestDelegationTokenForProxyUser Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783092/HDFS-9659.01.patch JIRA Issue HDFS-9659 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0f7ca693c52f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 57d0a94 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14169/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14169/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14169/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14169/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14169/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14169/console This message was automatically generated.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Vinayakumar B for comments!

          Kai Zheng what's your opinion on the Vinay's comment ?

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Vinayakumar B for comments! Kai Zheng what's your opinion on the Vinay's comment ?
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Attached updated patch. Addressed Vinayakumar B comments..

          Please review ...

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Attached updated patch. Addressed Vinayakumar B comments.. Please review ...
          Hide
          drankye Kai Zheng added a comment -

          Sorry just saw this. I thought Vinay's comment makes sense to me for easy tracking. waitForProxy is rarely used now and can be obsolete, but it can be addressed later in other issue as commented here

          Show
          drankye Kai Zheng added a comment - Sorry just saw this. I thought Vinay's comment makes sense to me for easy tracking. waitForProxy is rarely used now and can be obsolete, but it can be addressed later in other issue as commented here
          Hide
          vinayrpet Vinayakumar B added a comment -

          Oh!. Now I seen the first patch, which is same as latest.

          Retries on initial connect exceptions are required, when Active NN machine is down, and only StandbyNN is started.

          Since SNN is a daemon, EditLogTailer needs to be running regardless of Connect exceptions until explicit shutdown or failover.
          Kai Zheng, You agree with this.?

          +1 on latest patch

          I will commit tomorrow, if there is no objection.

          Show
          vinayrpet Vinayakumar B added a comment - Oh!. Now I seen the first patch, which is same as latest. Retries on initial connect exceptions are required, when Active NN machine is down, and only StandbyNN is started. Since SNN is a daemon, EditLogTailer needs to be running regardless of Connect exceptions until explicit shutdown or failover. Kai Zheng , You agree with this.? +1 on latest patch I will commit tomorrow, if there is no objection.
          Hide
          vinayrpet Vinayakumar B added a comment - - edited

          waitForProxy is rarely used now and can be obsolete, but it can be addressed later in other issue as commented here

          Oh. yes. Other comment explains me why you asked to use just RPC.getProxy().
          Anyway, I will now stick to using waitForProxy() in this.
          Which can be removed later along with other uses.

          So committing this shortly.

          Show
          vinayrpet Vinayakumar B added a comment - - edited waitForProxy is rarely used now and can be obsolete, but it can be addressed later in other issue as commented here Oh. yes. Other comment explains me why you asked to use just RPC.getProxy(). Anyway, I will now stick to using waitForProxy() in this. Which can be removed later along with other uses. So committing this shortly.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Committed to trunk
          Thanks Surendra Singh Lilhore for the contribution
          Thanks Kai Zheng for review.

          Show
          vinayrpet Vinayakumar B added a comment - Committed to trunk Thanks Surendra Singh Lilhore for the contribution Thanks Kai Zheng for review.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9214 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9214/)
          HDFS-9659. EditLogTailerThread to Active Namenode RPC should timeout (vinayakumarb: rev 8f2622b6a0603f92e8b5784879da28d3d5797fc1)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9214 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9214/ ) HDFS-9659 . EditLogTailerThread to Active Namenode RPC should timeout (vinayakumarb: rev 8f2622b6a0603f92e8b5784879da28d3d5797fc1) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/EditLogTailer.java
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 23s Maven dependency ordering for branch
          +1 mvninstall 14m 28s trunk passed
          +1 compile 2m 13s trunk passed with JDK v1.8.0_66
          +1 compile 1m 37s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 40s trunk passed
          +1 mvnsite 1m 52s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 3m 34s trunk passed
          +1 javadoc 2m 36s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 46s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 46s the patch passed
          +1 compile 2m 5s the patch passed with JDK v1.8.0_66
          +1 javac 2m 5s the patch passed
          +1 compile 1m 28s the patch passed with JDK v1.7.0_91
          +1 javac 1m 28s the patch passed
          -1 checkstyle 0m 34s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 26 unchanged - 1 fixed = 27 total (was 27)
          +1 mvnsite 1m 50s the patch passed
          +1 mvneclipse 0m 21s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 59s the patch passed
          +1 javadoc 2m 33s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 40s the patch passed with JDK v1.7.0_91
          -1 unit 113m 29s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 95m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 32s Patch does not generate ASF License warnings.
          264m 49s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts
            hadoop.hdfs.TestMissingBlocksAlert
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.TestRecoverStripedFile
            hadoop.hdfs.server.datanode.TestDataNodeMetrics
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.TestSafeModeWithStripedFile
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.fs.viewfs.TestViewFsAtHdfsRoot
            hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestPersistBlocks
            hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.TestLocalDFS
            hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.server.datanode.TestDirectoryScanner



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785467/HDFS-9659.02.patch
          JIRA Issue HDFS-9659
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0f7ec8aa0b04 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2673cba
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14311/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14311/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14311/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14311/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14311/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14311/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14311/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 23s Maven dependency ordering for branch +1 mvninstall 14m 28s trunk passed +1 compile 2m 13s trunk passed with JDK v1.8.0_66 +1 compile 1m 37s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 40s trunk passed +1 mvnsite 1m 52s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 3m 34s trunk passed +1 javadoc 2m 36s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 46s trunk passed with JDK v1.7.0_91 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 46s the patch passed +1 compile 2m 5s the patch passed with JDK v1.8.0_66 +1 javac 2m 5s the patch passed +1 compile 1m 28s the patch passed with JDK v1.7.0_91 +1 javac 1m 28s the patch passed -1 checkstyle 0m 34s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 26 unchanged - 1 fixed = 27 total (was 27) +1 mvnsite 1m 50s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 59s the patch passed +1 javadoc 2m 33s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 40s the patch passed with JDK v1.7.0_91 -1 unit 113m 29s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 95m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 32s Patch does not generate ASF License warnings. 264m 49s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.hdfs.TestMissingBlocksAlert   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestSafeModeWithStripedFile   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.fs.viewfs.TestViewFsAtHdfsRoot   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785467/HDFS-9659.02.patch JIRA Issue HDFS-9659 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0f7ec8aa0b04 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2673cba Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14311/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14311/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14311/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14311/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14311/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14311/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14311/console This message was automatically generated.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Vinayakumar B for review and commit.
          Thanks Kai Zheng review.

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Vinayakumar B for review and commit. Thanks Kai Zheng review.

            People

            • Assignee:
              surendrasingh Surendra Singh Lilhore
              Reporter:
              surendrasingh Surendra Singh Lilhore
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development