Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10677 Über-jira: Enhancements to NNThroughputBenchmark tool
  3. HDFS-9601

NNThroughputBenchmark.BlockReportStats should handle NotReplicatedYetException on adding block

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9.0
    • Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Target Version/s:

      Description

      TestNNThroughputBenchmark intermittently fails due to NotReplicatedYetException. Because NNThroughputBenchmark.BlockReportStats#generateInputs directly uses ClientProtocol#addBlock, it must handles NotReplicatedYetException by itself as {{DFSOutputStream#addBlock} do.

      1. HDFS-9601.001.patch
        3 kB
        Masatake Iwasaki
      2. HDFS-9601.002.patch
        3 kB
        Masatake Iwasaki
      3. HDFS-9601-branch-2.7.002.patch
        3 kB
        Masatake Iwasaki

        Issue Links

          Activity

          Hide
          iwasakims Masatake Iwasaki added a comment -
          testNNThroughput(org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark)  Time elapsed: 2.836 sec  <<< ERROR!
          org.apache.hadoop.hdfs.server.namenode.NotReplicatedYetException: Not replicated yet: /nnThroughputBenchmark/blockReport/ThroughputBenchDir0/ThroughputBench4
          	at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.validateAddBlock(FSDirWriteFileOp.java:190)
          	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getAdditionalBlock(FSNamesystem.java:2378)
          	at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.addBlock(NameNodeRpcServer.java:797)
          	at org.apache.hadoop.hdfs.server.namenode.NNThroughputBenchmark$BlockReportStats.addBlocks(NNThroughputBenchmark.java:1184)
          	at org.apache.hadoop.hdfs.server.namenode.NNThroughputBenchmark$BlockReportStats.generateInputs(NNThroughputBenchmark.java:1171)
          	at org.apache.hadoop.hdfs.server.namenode.NNThroughputBenchmark$OperationStatsBase.benchmark(NNThroughputBenchmark.java:281)
          	at org.apache.hadoop.hdfs.server.namenode.NNThroughputBenchmark.run(NNThroughputBenchmark.java:1519)
          	at org.apache.hadoop.hdfs.server.namenode.NNThroughputBenchmark.runBenchmark(NNThroughputBenchmark.java:1422)
          	at org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark.testNNThroughput(TestNNThroughputBenchmark.java:53)
          
          Show
          iwasakims Masatake Iwasaki added a comment - testNNThroughput(org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark) Time elapsed: 2.836 sec <<< ERROR! org.apache.hadoop.hdfs.server.namenode.NotReplicatedYetException: Not replicated yet: /nnThroughputBenchmark/blockReport/ThroughputBenchDir0/ThroughputBench4 at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.validateAddBlock(FSDirWriteFileOp.java:190) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getAdditionalBlock(FSNamesystem.java:2378) at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.addBlock(NameNodeRpcServer.java:797) at org.apache.hadoop.hdfs.server.namenode.NNThroughputBenchmark$BlockReportStats.addBlocks(NNThroughputBenchmark.java:1184) at org.apache.hadoop.hdfs.server.namenode.NNThroughputBenchmark$BlockReportStats.generateInputs(NNThroughputBenchmark.java:1171) at org.apache.hadoop.hdfs.server.namenode.NNThroughputBenchmark$OperationStatsBase.benchmark(NNThroughputBenchmark.java:281) at org.apache.hadoop.hdfs.server.namenode.NNThroughputBenchmark.run(NNThroughputBenchmark.java:1519) at org.apache.hadoop.hdfs.server.namenode.NNThroughputBenchmark.runBenchmark(NNThroughputBenchmark.java:1422) at org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark.testNNThroughput(TestNNThroughputBenchmark.java:53)
          Hide
          iwasakims Masatake Iwasaki added a comment -

          I attached 001.

          For the case of TestNNThroughputBenchmark, NotReplicatedYetException is not wrapped by RemoteException.

          Show
          iwasakims Masatake Iwasaki added a comment - I attached 001. For the case of TestNNThroughputBenchmark , NotReplicatedYetException is not wrapped by RemoteException .
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks for working on this, Masatake Iwasaki. I think the patch makes sense. While the retry logic is very similar to addBlock in DFSOutputStream, I don't know how we can reuse the existing code though.

          Show
          liuml07 Mingliang Liu added a comment - Thanks for working on this, Masatake Iwasaki . I think the patch makes sense. While the retry logic is very similar to addBlock in DFSOutputStream, I don't know how we can reuse the existing code though.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 39s trunk passed
          +1 compile 0m 38s trunk passed with JDK v1.8.0_66
          +1 compile 0m 42s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 14s trunk passed
          +1 mvnsite 0m 51s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 54s trunk passed
          +1 javadoc 1m 4s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 45s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 35s the patch passed with JDK v1.8.0_66
          +1 javac 0m 35s the patch passed
          +1 compile 0m 39s the patch passed with JDK v1.7.0_91
          +1 javac 0m 39s the patch passed
          +1 checkstyle 0m 15s the patch passed
          +1 mvnsite 0m 48s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 0s the patch passed
          +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 46s the patch passed with JDK v1.7.0_91
          -1 unit 64m 53s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 64m 4s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          155m 0s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestRollingUpgrade
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
            hadoop.hdfs.server.datanode.TestBlockReplacement



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779855/HDFS-9601.001.patch
          JIRA Issue HDFS-9601
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 2f0b95968e5a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 99cf2ec
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14006/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14006/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14006/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14006/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14006/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 75MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14006/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 39s trunk passed +1 compile 0m 38s trunk passed with JDK v1.8.0_66 +1 compile 0m 42s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 54s trunk passed +1 javadoc 1m 4s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 45s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 45s the patch passed +1 compile 0m 35s the patch passed with JDK v1.8.0_66 +1 javac 0m 35s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_91 +1 javac 0m 39s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 0s the patch passed +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 46s the patch passed with JDK v1.7.0_91 -1 unit 64m 53s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 64m 4s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 155m 0s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestRollingUpgrade JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.server.datanode.TestBlockReplacement Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779855/HDFS-9601.001.patch JIRA Issue HDFS-9601 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2f0b95968e5a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 99cf2ec Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14006/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14006/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14006/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14006/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14006/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14006/console This message was automatically generated.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Thanks for the comment, Mingliang Liu.

          As you say, we can not reuse DFSOutputStream#addBlock depending on real dfs client as is. I think it is not problem to retry addBlock by itself because generateInputs is called in preparetion phase of the benchmark. It does not need to have same behavior with DFSOutputStream. It should not need even exponential backoff.

          Show
          iwasakims Masatake Iwasaki added a comment - Thanks for the comment, Mingliang Liu . As you say, we can not reuse DFSOutputStream#addBlock depending on real dfs client as is. I think it is not problem to retry addBlock by itself because generateInputs is called in preparetion phase of the benchmark. It does not need to have same behavior with DFSOutputStream . It should not need even exponential backoff.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          I attached 002.

          • simplified retrying
          • added comment
          • got rid of logging on every retries because NNThroughputBenchmark could be used from command line
          Show
          iwasakims Masatake Iwasaki added a comment - I attached 002. simplified retrying added comment got rid of logging on every retries because NNThroughputBenchmark could be used from command line
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 14s trunk passed
          +1 compile 0m 47s trunk passed with JDK v1.8.0_66
          +1 compile 0m 44s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 17s trunk passed
          +1 mvnsite 0m 53s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 1m 56s trunk passed
          +1 javadoc 1m 7s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 49s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 47s the patch passed
          +1 compile 0m 38s the patch passed with JDK v1.8.0_66
          +1 javac 0m 38s the patch passed
          +1 compile 0m 41s the patch passed with JDK v1.7.0_91
          +1 javac 0m 41s the patch passed
          +1 checkstyle 0m 15s the patch passed
          +1 mvnsite 0m 52s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 4s the patch passed
          +1 javadoc 1m 6s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 48s the patch passed with JDK v1.7.0_91
          -1 unit 66m 24s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          +1 unit 64m 45s hadoop-hdfs in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          159m 2s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean
            hadoop.hdfs.TestEncryptionZones



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780271/HDFS-9601.002.patch
          JIRA Issue HDFS-9601
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 897e235cb55f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7dafee1
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14017/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14017/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14017/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 75MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14017/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 14s trunk passed +1 compile 0m 47s trunk passed with JDK v1.8.0_66 +1 compile 0m 44s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 17s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 56s trunk passed +1 javadoc 1m 7s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 49s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 47s the patch passed +1 compile 0m 38s the patch passed with JDK v1.8.0_66 +1 javac 0m 38s the patch passed +1 compile 0m 41s the patch passed with JDK v1.7.0_91 +1 javac 0m 41s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 4s the patch passed +1 javadoc 1m 6s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 48s the patch passed with JDK v1.7.0_91 -1 unit 66m 24s hadoop-hdfs in the patch failed with JDK v1.8.0_66. +1 unit 64m 45s hadoop-hdfs in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 159m 2s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean   hadoop.hdfs.TestEncryptionZones Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780271/HDFS-9601.002.patch JIRA Issue HDFS-9601 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 897e235cb55f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7dafee1 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14017/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14017/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14017/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14017/console This message was automatically generated.
          Hide
          kihwal Kihwal Lee added a comment -

          +1 the patch looks good. Thanks Masatake Iwasaki.

          Show
          kihwal Kihwal Lee added a comment - +1 the patch looks good. Thanks Masatake Iwasaki .
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Committed to trunk and branch-2. Thanks, Mingliang Liu and Kihwal Lee.

          Show
          iwasakims Masatake Iwasaki added a comment - Committed to trunk and branch-2. Thanks, Mingliang Liu and Kihwal Lee .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9158 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9158/)
          HDFS-9601. NNThroughputBenchmark.BlockReportStats should handle (iwasakims: rev b2ffcc2915838cf2e35544cfbb0286984a435205)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9158 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9158/ ) HDFS-9601 . NNThroughputBenchmark.BlockReportStats should handle (iwasakims: rev b2ffcc2915838cf2e35544cfbb0286984a435205) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          shv Konstantin Shvachko added a comment -

          This should be pushed to branch-2.8.0 as it breaks TestNNThroughputBenchmark.
          If people are OK with this I'll cherry pick it to 2.8.0

          Show
          shv Konstantin Shvachko added a comment - This should be pushed to branch-2.8.0 as it breaks TestNNThroughputBenchmark. If people are OK with this I'll cherry pick it to 2.8.0
          Hide
          shv Konstantin Shvachko added a comment -

          Committed to branch-2.8, updated Fix Version.

          Show
          shv Konstantin Shvachko added a comment - Committed to branch-2.8, updated Fix Version.
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks Konstantin Shvachko, I also think we should commit this to branch-2.8.

          Show
          liuml07 Mingliang Liu added a comment - Thanks Konstantin Shvachko , I also think we should commit this to branch-2.8 .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9241 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9241/)
          Move HDFS-9601 to branch-2.8.0 in CHANGES.txt. (shv) (shv: rev 48b76c8301b7234856274b66037919ab640bf188)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9241 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9241/ ) Move HDFS-9601 to branch-2.8.0 in CHANGES.txt. (shv) (shv: rev 48b76c8301b7234856274b66037919ab640bf188) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Thanks, Konstantin Shvachko. I'm +1 on cherry-picking.

          Show
          iwasakims Masatake Iwasaki added a comment - Thanks, Konstantin Shvachko . I'm +1 on cherry-picking.
          Hide
          ebadger Eric Badger added a comment -

          Konstantin Shvachko, Mingliang Liu, Masatake Iwasaki, I'm seeing TestNNThroughputBenchmark failures in 2.7 as well. Can we cherry-pick to branch-2.7?

          Show
          ebadger Eric Badger added a comment - Konstantin Shvachko , Mingliang Liu , Masatake Iwasaki , I'm seeing TestNNThroughputBenchmark failures in 2.7 as well. Can we cherry-pick to branch-2.7?
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Can we cherry-pick to branch-2.7?

          I think we need trivial update for the patch since HDFS-7847 is not committed to branch-2.7. I will try to backport.

          Show
          iwasakims Masatake Iwasaki added a comment - Can we cherry-pick to branch-2.7? I think we need trivial update for the patch since HDFS-7847 is not committed to branch-2.7. I will try to backport.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          attaching the patch for branch-2.7.

          Show
          iwasakims Masatake Iwasaki added a comment - attaching the patch for branch-2.7.
          Hide
          shv Konstantin Shvachko added a comment -

          2.7 patch looks good.

          Show
          shv Konstantin Shvachko added a comment - 2.7 patch looks good.
          Hide
          liuml07 Mingliang Liu added a comment -

          +1 (non-binding) for HDFS-9601-branch-2.7.002.patch

          Show
          liuml07 Mingliang Liu added a comment - +1 (non-binding) for HDFS-9601-branch-2.7.002.patch
          Hide
          ebadger Eric Badger added a comment -

          +1 (non-binding) on the 2.7 patch. Built with the patch and ran NNThroughputBenchmark successfully on branch-2.7 head.

          Show
          ebadger Eric Badger added a comment - +1 (non-binding) on the 2.7 patch. Built with the patch and ran NNThroughputBenchmark successfully on branch-2.7 head.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, thanks Masatake.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, thanks Masatake.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Committed to branch-2.7. Thanks for the review comments, Konstantin Shvachko, Mingliang Liu, Eric Badger and Akira Ajisaka.

          Show
          iwasakims Masatake Iwasaki added a comment - Committed to branch-2.7. Thanks for the review comments, Konstantin Shvachko , Mingliang Liu , Eric Badger and Akira Ajisaka .

            People

            • Assignee:
              iwasakims Masatake Iwasaki
              Reporter:
              iwasakims Masatake Iwasaki
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development