[HDFS-9600] do not check replication if the block is under construction

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.8.0, 2.7.3, 2.6.4, 3.0.0-alpha1
• Target Version/s: 2.8.0, 2.7.3, 2.6.4
• Hadoop Flags: Reviewed
• Assignee: Phil Yang
• Reporter: Phil Yang
• Created: 25/Dec/15 06:58
• Updated: 13/Sep/16 21:08
• Resolved: 07/Jan/16 06:30

Description

When appending a file, we will update pipeline to bump a new GS and the old GS will be considered as out of date. When changing GS, in BlockInfo.setGenerationStampAndVerifyReplicas we will remove replicas having old GS which means we will remove all replicas because no DN has new GS until the block with new GS is added to blockMaps again by DatanodeProtocol.blockReceivedAndDeleted.

If we check replication of this block before it is added back, it will be regarded as missing. The probability is low but if there are decommissioning nodes the DecommissionManager.Monitor will scan all blocks belongs to decommissioning nodes with a very fast speed so the probability of finding missing block is very high but actually they are not missing.

Furthermore, after closing the appended file, in FSNamesystem.finalizeINodeFileUnderConstruction, it will checkReplication. If some of nodes are decommissioning, this block with new GS will be added to UnderReplicatedBlocks map so there are two blocks with same ID in this map, one is in QUEUE_WITH_CORRUPT_BLOCKS and the other is in QUEUE_HIGHEST_PRIORITY or QUEUE_UNDER_REPLICATED. And there will be many missing blocks warning in NameNode website but there is no corrupt files...

Therefore, I think the solution is we should not check replication if the block is under construction. We only check complete blocks.

Issue Links

• is related to: HDFS-10810 Setreplication removing block from underconstrcution temporarily when batch IBR is enabled.
• is related to: HDFS-9586 listCorruptFileBlocks should not output files that all replications are decommissioning