Looks like HDFS-9034 broke TestReplicationPolicyConsiderLoad#testChooseTargetWithDecomNodes.
This test has been failing since yesterday.
"StorageTypeStats" Metric should not count failed storage.
TestReplicationPolicyConsiderLoad.testChooseTargetWithDecomNodes failed on trunk
The test case failed, because after HDFS-9034, the data node storage are considered failed, thus not included in the stats.
Rev01: call HeartbeatManager.updateDnStat() to add stats after adding a datanode.
I suspect other tests may also be affected by HDFS-9034 though.
This message was automatically generated.
Failed test are unrelated.
The ASF license warning appears to be a false positive.
Sorry for duplicating, this patch looks good to me
Thanks Wei-Chiu Chuang for fixing this issue..
+1. The fix looks good to me. Thanks for taking care of it.
Will commit the patch after the tests.
Committed in trunk and branch-2. Thanks Wei-Chiu Chuang for the fix and Phil Yang for the review.
SUCCESS: Integrated in Hadoop-trunk-Commit #9025 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9025/)
HDFS-9597. BaseReplicationPolicyTest should update data node stats after (benoy: rev 8cfd672397efd91c471c417afef3aff85f64b506)
Thanks! Phil Yang and Surendra Singh Lilhore for reviews and Benoy Antony for committing this patch.
Benoy Antony, there is a branch-2.8 where you need to land this patch for it to be in 2.8.0.
committed to branch-2.8 also.