Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9582

TestLeaseRecoveryStriped file missing Apache License header and not well formatted

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    1. HDFS-9582-Trunk.00.patch
      8 kB
      Uma Maheswara Rao G

      Issue Links

        Activity

        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        I also took chance to format the code as per Apache Hadoop coding rules. Seems like lot of code in this file was not formatted well as per our formatting.

        Added Apache header.

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - I also took chance to format the code as per Apache Hadoop coding rules. Seems like lot of code in this file was not formatted well as per our formatting. Added Apache header.
        Hide
        hitliuyi Yi Liu added a comment -

        +1 pending Jenkins.
        Thanks Uma.

        Show
        hitliuyi Yi Liu added a comment - +1 pending Jenkins. Thanks Uma.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 19m 43s trunk passed
        +1 compile 2m 40s trunk passed with JDK v1.8.0_66
        +1 compile 2m 2s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 40s trunk passed
        +1 mvnsite 2m 19s trunk passed
        +1 mvneclipse 0m 34s trunk passed
        +1 findbugs 4m 31s trunk passed
        +1 javadoc 2m 55s trunk passed with JDK v1.8.0_66
        +1 javadoc 4m 7s trunk passed with JDK v1.7.0_91
        +1 mvninstall 2m 14s the patch passed
        +1 compile 2m 40s the patch passed with JDK v1.8.0_66
        +1 javac 2m 40s the patch passed
        +1 compile 2m 0s the patch passed with JDK v1.7.0_91
        +1 javac 2m 0s the patch passed
        +1 checkstyle 0m 39s the patch passed
        +1 mvnsite 2m 19s the patch passed
        +1 mvneclipse 0m 31s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 4m 51s the patch passed
        +1 javadoc 2m 47s the patch passed with JDK v1.8.0_66
        +1 javadoc 4m 22s the patch passed with JDK v1.7.0_91
        -1 unit 186m 12s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 168m 47s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 1m 19s Patch does not generate ASF License warnings.
        426m 15s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage
          hadoop.hdfs.TestBlockReaderLocal
          hadoop.hdfs.server.mover.TestMover
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
          hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.TestLocalDFS
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.TestSafeModeWithStripedFile
          hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
          hadoop.hdfs.TestWriteReadStripedFile
          hadoop.hdfs.tools.TestDFSAdminWithHA
          hadoop.hdfs.web.TestWebHdfsTokens
          hadoop.hdfs.server.namenode.TestSecurityTokenEditLog
          hadoop.hdfs.server.datanode.fsdataset.impl.TestSpaceReservation
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.server.namenode.ha.TestHAAppend
          hadoop.fs.TestSymlinkHdfsFileContext
          hadoop.fs.TestSymlinkHdfsFileSystem
          hadoop.hdfs.server.namenode.TestDecommissioningStatus
          hadoop.hdfs.qjournal.TestSecureNNWithQJM
          hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
          hadoop.hdfs.TestEncryptionZones
          hadoop.hdfs.TestDFSClientRetries
          hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
          hadoop.hdfs.server.datanode.TestDirectoryScanner
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestBlockStoragePolicy
          hadoop.hdfs.TestDFSUpgradeFromImage
          hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
          hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure100
          hadoop.hdfs.server.namenode.TestFsck
          hadoop.hdfs.TestLocalDFS
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure170
          hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage
          hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
          hadoop.hdfs.TestDistributedFileSystem
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
          hadoop.fs.contract.hdfs.TestHDFSContractConcat
          hadoop.hdfs.server.namenode.ha.TestHAAppend
          hadoop.fs.TestSymlinkHdfsFileContext
          hadoop.hdfs.qjournal.TestSecureNNWithQJM
          hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.TestEncryptionZones
          hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork
          hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
          hadoop.hdfs.server.datanode.TestDirectoryScanner



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778723/HDFS-9582-Trunk.00.patch
        JIRA Issue HDFS-9582
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c834379c43d6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0f82b5d
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13946/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13946/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13946/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13946/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13946/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13946/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 19m 43s trunk passed +1 compile 2m 40s trunk passed with JDK v1.8.0_66 +1 compile 2m 2s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 40s trunk passed +1 mvnsite 2m 19s trunk passed +1 mvneclipse 0m 34s trunk passed +1 findbugs 4m 31s trunk passed +1 javadoc 2m 55s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 7s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 14s the patch passed +1 compile 2m 40s the patch passed with JDK v1.8.0_66 +1 javac 2m 40s the patch passed +1 compile 2m 0s the patch passed with JDK v1.7.0_91 +1 javac 2m 0s the patch passed +1 checkstyle 0m 39s the patch passed +1 mvnsite 2m 19s the patch passed +1 mvneclipse 0m 31s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 51s the patch passed +1 javadoc 2m 47s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 22s the patch passed with JDK v1.7.0_91 -1 unit 186m 12s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 168m 47s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 1m 19s Patch does not generate ASF License warnings. 426m 15s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.TestBlockReaderLocal   hadoop.hdfs.server.mover.TestMover   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestSafeModeWithStripedFile   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.TestWriteReadStripedFile   hadoop.hdfs.tools.TestDFSAdminWithHA   hadoop.hdfs.web.TestWebHdfsTokens   hadoop.hdfs.server.namenode.TestSecurityTokenEditLog   hadoop.hdfs.server.datanode.fsdataset.impl.TestSpaceReservation   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.fs.TestSymlinkHdfsFileSystem   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestBlockStoragePolicy   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.namenode.ha.TestBootstrapStandby   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure100   hadoop.hdfs.server.namenode.TestFsck   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure170   hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation   hadoop.fs.contract.hdfs.TestHDFSContractConcat   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12778723/HDFS-9582-Trunk.00.patch JIRA Issue HDFS-9582 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c834379c43d6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0f82b5d findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13946/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13946/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13946/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13946/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13946/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13946/console This message was automatically generated.
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        Committed to trunk. Test failures unrelated to this change.

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - Committed to trunk. Test failures unrelated to this change.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9006 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9006/)
        HDFS-9582. TestLeaseRecoveryStriped file missing Apache License header (umamahesh: rev 52ad9125b8fbf1b4a92ef30969f0ec4c5f9d9852)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecoveryStriped.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9006 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9006/ ) HDFS-9582 . TestLeaseRecoveryStriped file missing Apache License header (umamahesh: rev 52ad9125b8fbf1b4a92ef30969f0ec4c5f9d9852) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestLeaseRecoveryStriped.java
        Hide
        zhz Zhe Zhang added a comment -

        Thanks for the catch Uma. I committed an oder version of the patch.

        Show
        zhz Zhe Zhang added a comment - Thanks for the catch Uma. I committed an oder version of the patch.

          People

          • Assignee:
            umamaheswararao Uma Maheswara Rao G
            Reporter:
            umamaheswararao Uma Maheswara Rao G
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development