Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9532

Detailed exception info is lost in reportTo method of ErrorReportAction and ReportBadBlockAction

    Details

    • Hadoop Flags:
      Reviewed

      Description

      See code below

          try {
            bpNamenode.reportBadBlocks(locatedBlock);
          } catch (RemoteException re) {
            DataNode.LOG.info("reportBadBlock encountered RemoteException for "
                + "block:  " + block , re);
          } catch (IOException e) {
            throw new BPServiceActorActionException("Failed to report bad block "
                + block + " to namenode: ");
          }
        }
      

      When IOException e is thrown, the information of e is not reported back to caller.

        Activity

        Hide
        yzhangal Yongjun Zhang added a comment -

        Submitted patch 001. Thanks for reviewing.

        Show
        yzhangal Yongjun Zhang added a comment - Submitted patch 001. Thanks for reviewing.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 11m 35s trunk passed
        +1 compile 1m 17s trunk passed with JDK v1.8.0_66
        +1 compile 1m 7s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 1m 21s trunk passed
        +1 mvneclipse 0m 19s trunk passed
        +1 findbugs 2m 45s trunk passed
        +1 javadoc 1m 55s trunk passed with JDK v1.8.0_66
        +1 javadoc 2m 49s trunk passed with JDK v1.7.0_91
        +1 mvninstall 1m 15s the patch passed
        +1 compile 1m 28s the patch passed with JDK v1.8.0_66
        +1 javac 1m 28s the patch passed
        +1 compile 1m 7s the patch passed with JDK v1.7.0_91
        +1 javac 1m 7s the patch passed
        +1 checkstyle 0m 22s the patch passed
        +1 mvnsite 1m 21s the patch passed
        +1 mvneclipse 0m 18s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 3m 9s the patch passed
        +1 javadoc 1m 54s the patch passed with JDK v1.8.0_66
        +1 javadoc 2m 52s the patch passed with JDK v1.7.0_91
        -1 unit 103m 17s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 90m 16s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        -1 asflicense 0m 25s Patch generated 56 ASF License warnings.
        235m 24s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.net.TestNetworkTopology
          hadoop.hdfs.TestQuota
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.TestReadStripedFileWithDecoding
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.server.namenode.ha.TestHAAppend
          hadoop.hdfs.TestFileCreationClient
          hadoop.hdfs.server.datanode.TestDirectoryScanner
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.fs.TestHDFSFileContextMainOperations
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
          hadoop.hdfs.server.datanode.TestDirectoryScanner



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776618/HDFS-9532.001.patch
        JIRA Issue HDFS-9532
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c7739cae81cd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 50edcb9
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13817/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13817/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13817/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13817/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13817/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13817/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13817/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 11m 35s trunk passed +1 compile 1m 17s trunk passed with JDK v1.8.0_66 +1 compile 1m 7s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 22s trunk passed +1 mvnsite 1m 21s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 2m 45s trunk passed +1 javadoc 1m 55s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 49s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 15s the patch passed +1 compile 1m 28s the patch passed with JDK v1.8.0_66 +1 javac 1m 28s the patch passed +1 compile 1m 7s the patch passed with JDK v1.7.0_91 +1 javac 1m 7s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 1m 21s the patch passed +1 mvneclipse 0m 18s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 9s the patch passed +1 javadoc 1m 54s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 52s the patch passed with JDK v1.7.0_91 -1 unit 103m 17s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 90m 16s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 25s Patch generated 56 ASF License warnings. 235m 24s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.net.TestNetworkTopology   hadoop.hdfs.TestQuota   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestReadStripedFileWithDecoding   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.TestFileCreationClient   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.fs.TestHDFSFileContextMainOperations   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776618/HDFS-9532.001.patch JIRA Issue HDFS-9532 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c7739cae81cd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 50edcb9 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13817/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13817/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13817/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13817/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13817/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13817/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13817/console This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        +1 thanks Yongjun!

        Show
        andrew.wang Andrew Wang added a comment - +1 thanks Yongjun!
        Hide
        yzhangal Yongjun Zhang added a comment -

        Many thanks to Andrew Wang for the review. I committed to trunk, branch-2 and branch-2.8.

        Show
        yzhangal Yongjun Zhang added a comment - Many thanks to Andrew Wang for the review. I committed to trunk, branch-2 and branch-2.8.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8959 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8959/)
        HDFS-9532. Detailed exception info is lost in reportTo methods of (yzhang: rev f5a911452f8f6bc8a37617d1fc155e5ec23f3a78)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActorActionException.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ReportBadBlockAction.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ErrorReportAction.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8959 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8959/ ) HDFS-9532 . Detailed exception info is lost in reportTo methods of (yzhang: rev f5a911452f8f6bc8a37617d1fc155e5ec23f3a78) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActorActionException.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ReportBadBlockAction.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ErrorReportAction.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #689 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/689/)
        HDFS-9532. Detailed exception info is lost in reportTo methods of (yzhang: rev f5a911452f8f6bc8a37617d1fc155e5ec23f3a78)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ReportBadBlockAction.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ErrorReportAction.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActorActionException.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #689 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/689/ ) HDFS-9532 . Detailed exception info is lost in reportTo methods of (yzhang: rev f5a911452f8f6bc8a37617d1fc155e5ec23f3a78) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ReportBadBlockAction.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ErrorReportAction.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActorActionException.java

          People

          • Assignee:
            yzhangal Yongjun Zhang
            Reporter:
            yzhangal Yongjun Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development