Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9521

TransferFsImage.receiveFile should account and log separate times for image download and fsync to disk

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently, TransferFsImage.receiveFile is logging total transfer time as below:

      double xferSec = Math.max(
             ((float)(Time.monotonicNow() - startTime)) / 1000.0, 0.001);    
      long xferKb = received / 1024;
      LOG.info(String.format("Transfer took %.2fs at %.2f KB/s",xferSec, xferKb / xferSec))
      

      This is really useful, but it just measures the total method execution time, which includes time taken to download the image and do an fsync to all the namenode metadata directories.

      Sometime when troubleshooting these imager transfer problems, it's interesting to know which part of the process is being the bottleneck (whether network or disk write).

      This patch accounts time for image download and fsync to each disk separately, logging how much time did it take on each operation.

      1. HDFS-9521.004.patch
        4 kB
        Harsh J
      2. HDFS-9521.patch
        3 kB
        Wellington Chevreuil
      3. HDFS-9521.patch.1
        5 kB
        Wellington Chevreuil
      4. HDFS-9521-2.patch
        4 kB
        Wellington Chevreuil
      5. HDFS-9521-3.patch
        4 kB
        Wellington Chevreuil

        Activity

        Hide
        liuml07 Mingliang Liu added a comment -

        Thanks for reporting this, I also think the detailed time will be helpful for troubleshooting purpose.

        As the overall time is removed, though can be calculated manually, it may make an operator uneasy if she only needs this information. I suggest we keep logging the overall execution time in INFO level, and dump individual download/fsync time in DEBUG level.

        Show
        liuml07 Mingliang Liu added a comment - Thanks for reporting this, I also think the detailed time will be helpful for troubleshooting purpose. As the overall time is removed, though can be calculated manually, it may make an operator uneasy if she only needs this information. I suggest we keep logging the overall execution time in INFO level, and dump individual download/fsync time in DEBUG level.
        Hide
        wchevreuil Wellington Chevreuil added a comment -

        Thanks Mingliang Liu. The original idea on measuring download time and individual disk fsync time separately and log it as INFO is to help troubleshooting issues once it occurs. Leaving it as DEBUG would require a restart of Namenodes and hope for the incident to re occur. Would you think leave this as INFO would add too much overhead on this feature?

        Show
        wchevreuil Wellington Chevreuil added a comment - Thanks Mingliang Liu . The original idea on measuring download time and individual disk fsync time separately and log it as INFO is to help troubleshooting issues once it occurs. Leaving it as DEBUG would require a restart of Namenodes and hope for the incident to re occur. Would you think leave this as INFO would add too much overhead on this feature?
        Hide
        wchevreuil Wellington Chevreuil added a comment -

        Initial patch version has been submitted.

        Show
        wchevreuil Wellington Chevreuil added a comment - Initial patch version has been submitted.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 23s trunk passed
        +1 compile 0m 46s trunk passed with JDK v1.8.0_66
        +1 compile 0m 43s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 18s trunk passed
        +1 mvnsite 0m 56s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 59s trunk passed
        +1 javadoc 1m 11s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 50s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 51s the patch passed
        +1 compile 0m 42s the patch passed with JDK v1.8.0_66
        +1 javac 0m 42s the patch passed
        +1 compile 0m 47s the patch passed with JDK v1.7.0_91
        +1 javac 0m 47s the patch passed
        -1 checkstyle 0m 17s Patch generated 3 new checkstyle issues in hadoop-hdfs-project/hadoop-hdfs (total was 26, now 29).
        +1 mvnsite 0m 58s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 36s the patch passed
        +1 javadoc 1m 12s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 54s the patch passed with JDK v1.7.0_91
        -1 unit 55m 28s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 54m 32s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        -1 asflicense 0m 20s Patch generated 58 ASF License warnings.
        139m 23s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestSnapshot
          hadoop.hdfs.server.datanode.TestDataNodeMetrics
          hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
          hadoop.hdfs.server.datanode.TestIncrementalBrVariations
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure130
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion
          hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776353/HDFS-9521.patch
        JIRA Issue HDFS-9521
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux dcd53ec2b38a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7fb212e
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13858/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13858/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13858/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13858/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13858/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13858/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13858/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus 0.1.0 http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13858/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 23s trunk passed +1 compile 0m 46s trunk passed with JDK v1.8.0_66 +1 compile 0m 43s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 59s trunk passed +1 javadoc 1m 11s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 50s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 51s the patch passed +1 compile 0m 42s the patch passed with JDK v1.8.0_66 +1 javac 0m 42s the patch passed +1 compile 0m 47s the patch passed with JDK v1.7.0_91 +1 javac 0m 47s the patch passed -1 checkstyle 0m 17s Patch generated 3 new checkstyle issues in hadoop-hdfs-project/hadoop-hdfs (total was 26, now 29). +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 36s the patch passed +1 javadoc 1m 12s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 54s the patch passed with JDK v1.7.0_91 -1 unit 55m 28s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 54m 32s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 20s Patch generated 58 ASF License warnings. 139m 23s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestSnapshot   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.server.datanode.TestIncrementalBrVariations JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure130   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776353/HDFS-9521.patch JIRA Issue HDFS-9521 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dcd53ec2b38a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7fb212e findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13858/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13858/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13858/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13858/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13858/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13858/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13858/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13858/console This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        The overhead should be fine. Overall information may be useful so that the operator does not have to calculate from verbose information.

        Show
        liuml07 Mingliang Liu added a comment - The overhead should be fine. Overall information may be useful so that the operator does not have to calculate from verbose information.
        Hide
        qwertymaniac Harsh J added a comment -

        Patch's approach looks good to me. Agreed with Mingliang Liu, that we can keep the total time also (but indicate in the message that it includes both times). Alternatively, a single combined log at the end that prints the total and divided times (along with path info as we have it in the current patch) would be better too.

        I do not agree on DEBUG level though. The change is a refinement of an existing, vital INFO message.

        Please also address the checkstyle issues, if they are relevant (sorry, am too late here and the build data's been wiped already). You can run checkstyle goal with maven to get the same results locally.

        The failing tests don't appear related.

        Show
        qwertymaniac Harsh J added a comment - Patch's approach looks good to me. Agreed with Mingliang Liu , that we can keep the total time also (but indicate in the message that it includes both times). Alternatively, a single combined log at the end that prints the total and divided times (along with path info as we have it in the current patch) would be better too. I do not agree on DEBUG level though. The change is a refinement of an existing, vital INFO message. Please also address the checkstyle issues, if they are relevant (sorry, am too late here and the build data's been wiped already). You can run checkstyle goal with maven to get the same results locally. The failing tests don't appear related.
        Hide
        wchevreuil Wellington Chevreuil added a comment -

        New patch version including logging for combined time for download + fsyncs to all disks.

        Also fixed minor checkstyles issues.

        Show
        wchevreuil Wellington Chevreuil added a comment - New patch version including logging for combined time for download + fsyncs to all disks. Also fixed minor checkstyles issues.
        Hide
        wchevreuil Wellington Chevreuil added a comment -

        New patch version available

        Show
        wchevreuil Wellington Chevreuil added a comment - New patch version available
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        0 patch 0m 10s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 46s trunk passed
        +1 compile 0m 40s trunk passed with JDK v1.8.0_66
        +1 compile 0m 45s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 15s trunk passed
        +1 mvnsite 0m 56s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 1m 56s trunk passed
        +1 javadoc 1m 11s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 54s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 48s the patch passed
        +1 compile 0m 38s the patch passed with JDK v1.8.0_66
        +1 javac 0m 38s the patch passed
        +1 compile 0m 43s the patch passed with JDK v1.7.0_91
        +1 javac 0m 43s the patch passed
        +1 checkstyle 0m 15s the patch passed
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 0s the patch passed
        +1 javadoc 1m 2s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 45s the patch passed with JDK v1.7.0_91
        -1 unit 70m 12s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 68m 3s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 22s Patch does not generate ASF License warnings.
        165m 16s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestPersistBlocks
          hadoop.hdfs.server.namenode.ha.TestHAAppend
          hadoop.hdfs.TestDFSClientRetries
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestEncryptionZones
          hadoop.hdfs.web.TestWebHDFS



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781218/HDFS-9521.patch.1
        JIRA Issue HDFS-9521
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6d8a1263170a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ed18527
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14070/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14070/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14070/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14070/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14070/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14070/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. 0 patch 0m 10s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 46s trunk passed +1 compile 0m 40s trunk passed with JDK v1.8.0_66 +1 compile 0m 45s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 56s trunk passed +1 javadoc 1m 11s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 54s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 48s the patch passed +1 compile 0m 38s the patch passed with JDK v1.8.0_66 +1 javac 0m 38s the patch passed +1 compile 0m 43s the patch passed with JDK v1.7.0_91 +1 javac 0m 43s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 0s the patch passed +1 javadoc 1m 2s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 45s the patch passed with JDK v1.7.0_91 -1 unit 70m 12s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 68m 3s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 165m 16s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.TestDFSClientRetries JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.web.TestWebHDFS Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781218/HDFS-9521.patch.1 JIRA Issue HDFS-9521 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6d8a1263170a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ed18527 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14070/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14070/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14070/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14070/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14070/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14070/console This message was automatically generated.
        Hide
        wchevreuil Wellington Chevreuil added a comment -

        New patch version. Combined all logs in a single log version.

        Show
        wchevreuil Wellington Chevreuil added a comment - New patch version. Combined all logs in a single log version.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 9s trunk passed
        +1 compile 0m 50s trunk passed with JDK v1.8.0_72
        +1 compile 0m 42s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 57s trunk passed
        +1 javadoc 1m 13s trunk passed with JDK v1.8.0_72
        +1 javadoc 1m 59s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 47s the patch passed
        +1 compile 0m 50s the patch passed with JDK v1.8.0_72
        +1 javac 0m 50s the patch passed
        +1 compile 0m 41s the patch passed with JDK v1.7.0_95
        +1 javac 0m 41s the patch passed
        +1 checkstyle 0m 18s the patch passed
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 9s the patch passed
        +1 javadoc 1m 14s the patch passed with JDK v1.8.0_72
        +1 javadoc 1m 50s the patch passed with JDK v1.7.0_95
        -1 unit 77m 33s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
        -1 unit 87m 16s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        192m 3s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
          hadoop.hdfs.TestErasureCodeBenchmarkThroughput
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.server.mover.TestStorageMover
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage
          hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.server.namenode.TestReconstructStripedBlocks
          hadoop.hdfs.server.balancer.TestBalancer
          hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
          hadoop.hdfs.server.datanode.TestDirectoryScanner



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787809/HDFS-9521-2.patch
        JIRA Issue HDFS-9521
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c43fc92fa48d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ec12ce8
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14492/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14492/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14492/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14492/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14492/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14492/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 9s trunk passed +1 compile 0m 50s trunk passed with JDK v1.8.0_72 +1 compile 0m 42s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 57s trunk passed +1 javadoc 1m 13s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 59s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 47s the patch passed +1 compile 0m 50s the patch passed with JDK v1.8.0_72 +1 javac 0m 50s the patch passed +1 compile 0m 41s the patch passed with JDK v1.7.0_95 +1 javac 0m 41s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 9s the patch passed +1 javadoc 1m 14s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 50s the patch passed with JDK v1.7.0_95 -1 unit 77m 33s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 87m 16s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 192m 3s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.TestErasureCodeBenchmarkThroughput   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.mover.TestStorageMover   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.namenode.TestReconstructStripedBlocks   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12787809/HDFS-9521-2.patch JIRA Issue HDFS-9521 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c43fc92fa48d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ec12ce8 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14492/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14492/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14492/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14492/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14492/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14492/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        wchevreuil Wellington Chevreuil added a comment -

        Removed the new line on the log message. Inserting the combined time before the separate fsync for each disk.

        Show
        wchevreuil Wellington Chevreuil added a comment - Removed the new line on the log message. Inserting the combined time before the separate fsync for each disk.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 46s trunk passed
        +1 compile 0m 46s trunk passed with JDK v1.8.0_72
        +1 compile 0m 40s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 18s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 53s trunk passed
        +1 javadoc 1m 11s trunk passed with JDK v1.8.0_72
        +1 javadoc 1m 50s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 46s the patch passed with JDK v1.8.0_72
        +1 javac 0m 46s the patch passed
        +1 compile 0m 39s the patch passed with JDK v1.7.0_95
        +1 javac 0m 39s the patch passed
        -1 checkstyle 0m 18s hadoop-hdfs-project/hadoop-hdfs: patch generated 2 new + 20 unchanged - 0 fixed = 22 total (was 20)
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 7s the patch passed
        +1 javadoc 1m 20s the patch passed with JDK v1.8.0_72
        +1 javadoc 1m 58s the patch passed with JDK v1.7.0_95
        -1 unit 81m 15s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
        -1 unit 73m 16s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        180m 49s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.server.blockmanagement.TestBlockManager
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.TestFileAppend
          hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestEncryptionZones
          hadoop.hdfs.server.blockmanagement.TestBlockManager
          hadoop.hdfs.TestFileAppend
          hadoop.hdfs.TestErasureCodeBenchmarkThroughput
          hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
          hadoop.hdfs.TestDFSUpgradeFromImage
          hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs
        JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.snapshot.TestFileContextSnapshot



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788083/HDFS-9521-3.patch
        JIRA Issue HDFS-9521
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d76fc9e56392 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4b0e59f
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14505/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14505/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14505/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14505/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14505/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14505/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14505/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 46s trunk passed +1 compile 0m 46s trunk passed with JDK v1.8.0_72 +1 compile 0m 40s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 53s trunk passed +1 javadoc 1m 11s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 50s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 45s the patch passed +1 compile 0m 46s the patch passed with JDK v1.8.0_72 +1 javac 0m 46s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_95 +1 javac 0m 39s the patch passed -1 checkstyle 0m 18s hadoop-hdfs-project/hadoop-hdfs: patch generated 2 new + 20 unchanged - 0 fixed = 22 total (was 20) +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 7s the patch passed +1 javadoc 1m 20s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 58s the patch passed with JDK v1.7.0_95 -1 unit 81m 15s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 73m 16s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 180m 49s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.TestFileAppend   hadoop.hdfs.TestErasureCodeBenchmarkThroughput   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.server.namenode.snapshot.TestFileContextSnapshot Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788083/HDFS-9521-3.patch JIRA Issue HDFS-9521 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d76fc9e56392 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4b0e59f Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14505/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14505/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14505/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14505/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14505/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14505/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14505/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        qwertymaniac Harsh J added a comment -

        LGTM. Just had two checkstyle nits I've corrected in this variant, aside of some spacing logic. Will commit once jenkins returns +1.

        The previously failed tests don't appear related.

        Show
        qwertymaniac Harsh J added a comment - LGTM. Just had two checkstyle nits I've corrected in this variant, aside of some spacing logic. Will commit once jenkins returns +1. The previously failed tests don't appear related.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 49s trunk passed
        +1 compile 0m 40s trunk passed with JDK v1.8.0_74
        +1 compile 0m 42s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 21s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 2m 2s trunk passed
        +1 javadoc 1m 8s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 50s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 48s the patch passed
        +1 compile 0m 39s the patch passed with JDK v1.8.0_74
        +1 javac 0m 39s the patch passed
        +1 compile 0m 39s the patch passed with JDK v1.7.0_95
        +1 javac 0m 39s the patch passed
        +1 checkstyle 0m 19s the patch passed
        +1 mvnsite 0m 48s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 13s the patch passed
        +1 javadoc 1m 6s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 45s the patch passed with JDK v1.7.0_95
        -1 unit 67m 9s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
        +1 unit 67m 39s hadoop-hdfs in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 26s Patch does not generate ASF License warnings.
        160m 45s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeLifeline
          hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.server.namenode.TestEditLog



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791736/HDFS-9521.004.patch
        JIRA Issue HDFS-9521
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux bba9e223c48c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4f9fe3a
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14732/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14732/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14732/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14732/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 49s trunk passed +1 compile 0m 40s trunk passed with JDK v1.8.0_74 +1 compile 0m 42s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 2m 2s trunk passed +1 javadoc 1m 8s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 50s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 48s the patch passed +1 compile 0m 39s the patch passed with JDK v1.8.0_74 +1 javac 0m 39s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_95 +1 javac 0m 39s the patch passed +1 checkstyle 0m 19s the patch passed +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 13s the patch passed +1 javadoc 1m 6s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 45s the patch passed with JDK v1.7.0_95 -1 unit 67m 9s hadoop-hdfs in the patch failed with JDK v1.8.0_74. +1 unit 67m 39s hadoop-hdfs in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 160m 45s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeLifeline   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.namenode.TestEditLog Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791736/HDFS-9521.004.patch JIRA Issue HDFS-9521 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bba9e223c48c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4f9fe3a Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14732/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14732/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14732/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14732/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        qwertymaniac Harsh J added a comment -

        +1.

        The check-point related tests in one of the tests seemed relevant but they pass locally on both JDK7 and JDK8.

        Running org.apache.hadoop.hdfs.TestRollingUpgrade
        Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 99.737 sec - in org.apache.hadoop.hdfs.TestRollingUpgrade
        

        Therefore they appear to be flaky than at fault here. Other tests appear similarly unrelated to the log change here (no tests appear to rely on the original message either).

        Committing to branch-2 and trunk shortly.

        Show
        qwertymaniac Harsh J added a comment - +1. The check-point related tests in one of the tests seemed relevant but they pass locally on both JDK7 and JDK8. Running org.apache.hadoop.hdfs.TestRollingUpgrade Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 99.737 sec - in org.apache.hadoop.hdfs.TestRollingUpgrade Therefore they appear to be flaky than at fault here. Other tests appear similarly unrelated to the log change here (no tests appear to rely on the original message either). Committing to branch-2 and trunk shortly.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9433 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9433/)
        HDFS-9521. TransferFsImage.receiveFile should account and log separate (harsh: rev fd1c09be3e7c67c188a1dd7e4fccb3d92dcc5b5b)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9433 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9433/ ) HDFS-9521 . TransferFsImage.receiveFile should account and log separate (harsh: rev fd1c09be3e7c67c188a1dd7e4fccb3d92dcc5b5b) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/TransferFsImage.java

          People

          • Assignee:
            wchevreuil Wellington Chevreuil
            Reporter:
            wchevreuil Wellington Chevreuil
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development