Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9517

Fix missing @Test annotation on TestDistCpUtils.testUnpackAttributes

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: distcp
    • Labels:
      None
    • Target Version/s:

      Description

      testUnpackAttributes() test method in TestDistCpUtils does not have @Test annotation and is not testable.

      I searched around and saw no discussion it was omitted, so I assume it was just unintentional.

      1. HDFS-9517.001.patch
        0.7 kB
        Wei-Chiu Chuang

        Activity

        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Rev01. added @Test annotation. Test passed locally.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Rev01. added @Test annotation. Test passed locally.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 1s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 10m 7s trunk passed
        +1 compile 0m 24s trunk passed with JDK v1.8.0_66
        +1 compile 0m 22s trunk passed with JDK v1.7.0_85
        +1 checkstyle 0m 11s trunk passed
        +1 mvnsite 0m 29s trunk passed
        +1 mvneclipse 0m 19s trunk passed
        +1 findbugs 0m 37s trunk passed
        +1 javadoc 0m 20s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 18s trunk passed with JDK v1.7.0_85
        +1 mvninstall 0m 25s the patch passed
        +1 compile 0m 22s the patch passed with JDK v1.8.0_66
        +1 javac 0m 22s the patch passed
        +1 compile 0m 21s the patch passed with JDK v1.7.0_85
        +1 javac 0m 21s the patch passed
        +1 checkstyle 0m 11s the patch passed
        +1 mvnsite 0m 28s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 44s the patch passed
        +1 javadoc 0m 18s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 19s the patch passed with JDK v1.7.0_85
        +1 unit 8m 23s hadoop-distcp in the patch passed with JDK v1.8.0_66.
        +1 unit 8m 4s hadoop-distcp in the patch passed with JDK v1.7.0_85.
        +1 asflicense 0m 31s Patch does not generate ASF License warnings.
        35m 3s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776155/HDFS-9517.001.patch
        JIRA Issue HDFS-9517
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 808987efafd2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 01a641b
        findbugs v3.0.0
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13794/testReport/
        modules C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp
        Max memory used 76MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13794/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 1s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 10m 7s trunk passed +1 compile 0m 24s trunk passed with JDK v1.8.0_66 +1 compile 0m 22s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 11s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 0m 37s trunk passed +1 javadoc 0m 20s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 18s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 25s the patch passed +1 compile 0m 22s the patch passed with JDK v1.8.0_66 +1 javac 0m 22s the patch passed +1 compile 0m 21s the patch passed with JDK v1.7.0_85 +1 javac 0m 21s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 28s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 44s the patch passed +1 javadoc 0m 18s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 19s the patch passed with JDK v1.7.0_85 +1 unit 8m 23s hadoop-distcp in the patch passed with JDK v1.8.0_66. +1 unit 8m 4s hadoop-distcp in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 31s Patch does not generate ASF License warnings. 35m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776155/HDFS-9517.001.patch JIRA Issue HDFS-9517 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 808987efafd2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 01a641b findbugs v3.0.0 JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13794/testReport/ modules C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13794/console This message was automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        +1. Thanks, Wei-Chiu Chuang.

        Show
        cmccabe Colin P. McCabe added a comment - +1. Thanks, Wei-Chiu Chuang .
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9104 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9104/)
        HDFS-9517. Fix missing @Test annotation on (cmccabe: rev 8315582c4ff2951144b096c23a64e753f397572d)

        • hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/util/TestDistCpUtils.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9104 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9104/ ) HDFS-9517 . Fix missing @Test annotation on (cmccabe: rev 8315582c4ff2951144b096c23a64e753f397572d) hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/util/TestDistCpUtils.java hadoop-common-project/hadoop-common/CHANGES.txt

          People

          • Assignee:
            jojochuang Wei-Chiu Chuang
            Reporter:
            jojochuang Wei-Chiu Chuang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development