[HDFS-9491] Tests should get the number of pending async delets via FsDatasetTestUtils

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.7.1
• Fix Version/s: 2.9.0, 3.0.0-alpha1
• Component/s: test
• Target Version/s: 2.8.0
• Assignee: Tony Wu
• Reporter: Tony Wu
• Created: 01/Dec/15 19:51
• Updated: 12/May/16 18:13
• Resolved: 05/Dec/15 02:07

Description

A few unit tests use DataNodeTestUtils#getPendingAsyncDeletions to retrieve the number of pending async deletions. It internally calls FsDatasetTestUtil#getPendingAsyncDeletions:

public static long getPendingAsyncDeletions(FsDatasetSpi<?> fsd) {
    return ((FsDatasetImpl)fsd).asyncDiskService.countPendingDeletions();
}

This assumes FsDatasetImpl is (the only implementation of) FsDataset. However FsDataset is pluggable and can have other implementations.

We can abstract getting the number of async deletions in FsDatasetTestUtils.