Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9482

Replace DatanodeInfo constructors with a builder pattern

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      As per Arpit Agarwal comment here,Replace DatanodeInfo constructors with a builder pattern,

      1. HDFS-9482.patch
        36 kB
        Brahma Reddy Battula
      2. HDFS-9482-002.patch
        35 kB
        Brahma Reddy Battula
      3. HDFS-9482-003.patch
        39 kB
        Brahma Reddy Battula
      4. HDFS-9482-branch-2.8.patch
        36 kB
        Brahma Reddy Battula
      5. HDFS-9482-branch-2.patch
        36 kB
        Brahma Reddy Battula

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Pushed to branch-2.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Pushed to branch-2.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Arpit Agarwal thanks a lot committing to trunk and review..

        This was not an easy patch to review and I am sure not very fun to write either.

        hmm.. Yes, it is not easy..thanks a bunch again for your time on review this.

        if the only difference in the branch-2 patch is the EC changes then I am +1 for that too. Feel free to commit the branch-2 patch Brahma Reddy Battula.

        Yes,diff only that ..will commit to branch-2

        I posted a comment on HDFS-9371. If we can merge that to branch-2.8 then we don't need a separate branch-2.8 patch here.

        ok. will hold commit till HDFS-9371 get in branch-2.8.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Arpit Agarwal thanks a lot committing to trunk and review.. This was not an easy patch to review and I am sure not very fun to write either. hmm.. Yes, it is not easy..thanks a bunch again for your time on review this. if the only difference in the branch-2 patch is the EC changes then I am +1 for that too. Feel free to commit the branch-2 patch Brahma Reddy Battula. Yes,diff only that ..will commit to branch-2 I posted a comment on HDFS-9371 . If we can merge that to branch-2.8 then we don't need a separate branch-2.8 patch here. ok. will hold commit till HDFS-9371 get in branch-2.8.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10796 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10796/)
        HDFS-9482. Replace DatanodeInfo constructors with a builder pattern. (arp: rev ed0bebabaaf27cd730f7f8eb002d92c9c7db327d)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/erasurecode/StripedBlockWriter.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/protocolPB/TestPBHelper.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/JsonUtilClient.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/NamenodeProtocolServerSideTranslatorPB.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestInterDatanodeProtocol.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCorruption.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ReportBadBlockAction.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockRecovery.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSStripedOutputStream.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/client/impl/TestBlockReaderFactory.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientSocketSize.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10796 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10796/ ) HDFS-9482 . Replace DatanodeInfo constructors with a builder pattern. (arp: rev ed0bebabaaf27cd730f7f8eb002d92c9c7db327d) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitCache.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeInfo.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/erasurecode/StripedBlockWriter.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/protocolPB/TestPBHelper.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/JsonUtilClient.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelperClient.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/NamenodeProtocolServerSideTranslatorPB.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestInterDatanodeProtocol.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCorruption.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/ReportBadBlockAction.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockRecovery.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSStripedOutputStream.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/client/impl/TestBlockReaderFactory.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientSocketSize.java
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        if the only difference in the branch-2 patch is the EC changes then I am +1 for that too. Feel free to commit the branch-2 patch Brahma Reddy Battula.

        I posted a comment on HDFS-9371. If we can merge that to branch-2.8 then we don't need a separate branch-2.8 patch here.

        Show
        arpitagarwal Arpit Agarwal added a comment - if the only difference in the branch-2 patch is the EC changes then I am +1 for that too. Feel free to commit the branch-2 patch Brahma Reddy Battula . I posted a comment on HDFS-9371 . If we can merge that to branch-2.8 then we don't need a separate branch-2.8 patch here.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Committed to trunk. This was not an easy patch to review and I am sure not very fun to write either.

        Thanks for contributing this refactoring change Brahma. I will take a look at the branch-2 patch later this week.

        Show
        arpitagarwal Arpit Agarwal added a comment - Committed to trunk. This was not an easy patch to review and I am sure not very fun to write either. Thanks for contributing this refactoring change Brahma. I will take a look at the branch-2 patch later this week.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Hi Brahma Reddy Battula, this is on my to-do list. I'll try to review it this week.

        Show
        arpitagarwal Arpit Agarwal added a comment - Hi Brahma Reddy Battula , this is on my to-do list. I'll try to review it this week.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Arpit Agarwal can you please take look once..I think, branch-2.8 might not require.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Arpit Agarwal can you please take look once..I think, branch-2.8 might not require.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
        0 mvndep 0m 23s Maven dependency ordering for branch
        +1 mvninstall 7m 47s branch-2.8 passed
        +1 compile 1m 58s branch-2.8 passed with JDK v1.8.0_111
        +1 compile 1m 46s branch-2.8 passed with JDK v1.7.0_111
        +1 checkstyle 0m 37s branch-2.8 passed
        +1 mvnsite 1m 37s branch-2.8 passed
        +1 mvneclipse 0m 32s branch-2.8 passed
        +1 findbugs 4m 6s branch-2.8 passed
        +1 javadoc 1m 29s branch-2.8 passed with JDK v1.8.0_111
        +1 javadoc 2m 22s branch-2.8 passed with JDK v1.7.0_111
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 23s the patch passed
        +1 compile 1m 36s the patch passed with JDK v1.8.0_111
        +1 javac 1m 36s the patch passed
        +1 compile 1m 39s the patch passed with JDK v1.7.0_111
        +1 javac 1m 39s the patch passed
        -0 checkstyle 0m 32s hadoop-hdfs-project: The patch generated 23 new + 517 unchanged - 18 fixed = 540 total (was 535)
        +1 mvnsite 1m 30s the patch passed
        +1 mvneclipse 0m 25s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 3s the patch passed
        +1 javadoc 1m 8s the patch passed with JDK v1.8.0_111
        +1 javadoc 1m 56s the patch passed with JDK v1.7.0_111
        +1 unit 1m 7s hadoop-hdfs-client in the patch passed with JDK v1.7.0_111.
        -1 unit 59m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_111.
        +1 asflicense 0m 26s The patch does not generate ASF License warnings.
        162m 19s



        Reason Tests
        JDK v1.8.0_111 Failed junit tests hadoop.hdfs.server.namenode.TestDecommissioningStatus
          hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
        JDK v1.8.0_111 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2
        JDK v1.7.0_111 Failed junit tests hadoop.hdfs.TestEncryptionZones



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:5af2af1
        JIRA Issue HDFS-9482
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837115/HDFS-9482-branch-2.8.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6666b7d93ebf 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.8 / b082d4b
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17428/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17428/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17428/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17428/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. 0 mvndep 0m 23s Maven dependency ordering for branch +1 mvninstall 7m 47s branch-2.8 passed +1 compile 1m 58s branch-2.8 passed with JDK v1.8.0_111 +1 compile 1m 46s branch-2.8 passed with JDK v1.7.0_111 +1 checkstyle 0m 37s branch-2.8 passed +1 mvnsite 1m 37s branch-2.8 passed +1 mvneclipse 0m 32s branch-2.8 passed +1 findbugs 4m 6s branch-2.8 passed +1 javadoc 1m 29s branch-2.8 passed with JDK v1.8.0_111 +1 javadoc 2m 22s branch-2.8 passed with JDK v1.7.0_111 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 23s the patch passed +1 compile 1m 36s the patch passed with JDK v1.8.0_111 +1 javac 1m 36s the patch passed +1 compile 1m 39s the patch passed with JDK v1.7.0_111 +1 javac 1m 39s the patch passed -0 checkstyle 0m 32s hadoop-hdfs-project: The patch generated 23 new + 517 unchanged - 18 fixed = 540 total (was 535) +1 mvnsite 1m 30s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 3s the patch passed +1 javadoc 1m 8s the patch passed with JDK v1.8.0_111 +1 javadoc 1m 56s the patch passed with JDK v1.7.0_111 +1 unit 1m 7s hadoop-hdfs-client in the patch passed with JDK v1.7.0_111. -1 unit 59m 45s hadoop-hdfs in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 162m 19s Reason Tests JDK v1.8.0_111 Failed junit tests hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA JDK v1.8.0_111 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 JDK v1.7.0_111 Failed junit tests hadoop.hdfs.TestEncryptionZones Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Issue HDFS-9482 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837115/HDFS-9482-branch-2.8.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6666b7d93ebf 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / b082d4b Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17428/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17428/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17428/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17428/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 29s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
        0 mvndep 0m 38s Maven dependency ordering for branch
        +1 mvninstall 6m 46s branch-2 passed
        +1 compile 1m 19s branch-2 passed with JDK v1.8.0_101
        +1 compile 1m 23s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 44s branch-2 passed
        +1 mvnsite 1m 26s branch-2 passed
        +1 mvneclipse 0m 29s branch-2 passed
        +1 findbugs 3m 35s branch-2 passed
        +1 javadoc 1m 14s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 2m 3s branch-2 passed with JDK v1.7.0_111
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 1m 13s the patch passed
        +1 compile 1m 11s the patch passed with JDK v1.8.0_101
        +1 javac 1m 11s the patch passed
        +1 compile 1m 20s the patch passed with JDK v1.7.0_111
        +1 javac 1m 20s the patch passed
        -0 checkstyle 0m 41s hadoop-hdfs-project: The patch generated 20 new + 827 unchanged - 22 fixed = 847 total (was 849)
        +1 mvnsite 1m 22s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 56s the patch passed
        +1 javadoc 1m 10s the patch passed with JDK v1.8.0_101
        +1 javadoc 1m 56s the patch passed with JDK v1.7.0_111
        +1 unit 0m 59s hadoop-hdfs-client in the patch passed with JDK v1.7.0_111.
        +1 unit 64m 58s hadoop-hdfs in the patch passed with JDK v1.7.0_111.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        166m 37s



        Reason Tests
        JDK v1.8.0_101 Failed junit tests hadoop.hdfs.server.blockmanagement.TestReplicationPolicy



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HDFS-9482
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837113/HDFS-9482-branch-2.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3aeb65c7eeed 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 3eed75a
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17426/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17426/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17426/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 29s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. 0 mvndep 0m 38s Maven dependency ordering for branch +1 mvninstall 6m 46s branch-2 passed +1 compile 1m 19s branch-2 passed with JDK v1.8.0_101 +1 compile 1m 23s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 44s branch-2 passed +1 mvnsite 1m 26s branch-2 passed +1 mvneclipse 0m 29s branch-2 passed +1 findbugs 3m 35s branch-2 passed +1 javadoc 1m 14s branch-2 passed with JDK v1.8.0_101 +1 javadoc 2m 3s branch-2 passed with JDK v1.7.0_111 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 13s the patch passed +1 compile 1m 11s the patch passed with JDK v1.8.0_101 +1 javac 1m 11s the patch passed +1 compile 1m 20s the patch passed with JDK v1.7.0_111 +1 javac 1m 20s the patch passed -0 checkstyle 0m 41s hadoop-hdfs-project: The patch generated 20 new + 827 unchanged - 22 fixed = 847 total (was 849) +1 mvnsite 1m 22s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 56s the patch passed +1 javadoc 1m 10s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 56s the patch passed with JDK v1.7.0_111 +1 unit 0m 59s hadoop-hdfs-client in the patch passed with JDK v1.7.0_111. +1 unit 64m 58s hadoop-hdfs in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 166m 37s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.hdfs.server.blockmanagement.TestReplicationPolicy Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-9482 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837113/HDFS-9482-branch-2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3aeb65c7eeed 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 3eed75a Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17426/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17426/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17426/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
        0 mvndep 0m 32s Maven dependency ordering for branch
        +1 mvninstall 6m 33s branch-2 passed
        +1 compile 1m 19s branch-2 passed with JDK v1.8.0_101
        +1 compile 1m 28s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 45s branch-2 passed
        +1 mvnsite 1m 34s branch-2 passed
        +1 mvneclipse 0m 31s branch-2 passed
        +1 findbugs 3m 53s branch-2 passed
        +1 javadoc 1m 21s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 2m 5s branch-2 passed with JDK v1.7.0_111
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 1m 22s the patch passed
        +1 compile 1m 33s the patch passed with JDK v1.8.0_101
        +1 javac 1m 33s the patch passed
        +1 compile 1m 29s the patch passed with JDK v1.7.0_111
        +1 javac 1m 29s the patch passed
        -0 checkstyle 0m 41s hadoop-hdfs-project: The patch generated 20 new + 827 unchanged - 22 fixed = 847 total (was 849)
        +1 mvnsite 1m 21s the patch passed
        +1 mvneclipse 0m 23s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 1s the patch passed
        +1 javadoc 1m 20s the patch passed with JDK v1.8.0_101
        +1 javadoc 2m 1s the patch passed with JDK v1.7.0_111
        +1 unit 1m 11s hadoop-hdfs-client in the patch passed with JDK v1.7.0_111.
        -1 unit 58m 27s hadoop-hdfs in the patch failed with JDK v1.7.0_111.
        +1 asflicense 0m 24s The patch does not generate ASF License warnings.
        153m 28s



        Reason Tests
        JDK v1.8.0_101 Failed junit tests hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs
          hadoop.hdfs.server.datanode.TestDataNodeUUID
        JDK v1.7.0_111 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeUUID
          hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HDFS-9482
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837113/HDFS-9482-branch-2.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux fb3152690c2e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 3eed75a
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17427/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17427/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17427/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17427/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. 0 mvndep 0m 32s Maven dependency ordering for branch +1 mvninstall 6m 33s branch-2 passed +1 compile 1m 19s branch-2 passed with JDK v1.8.0_101 +1 compile 1m 28s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 45s branch-2 passed +1 mvnsite 1m 34s branch-2 passed +1 mvneclipse 0m 31s branch-2 passed +1 findbugs 3m 53s branch-2 passed +1 javadoc 1m 21s branch-2 passed with JDK v1.8.0_101 +1 javadoc 2m 5s branch-2 passed with JDK v1.7.0_111 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 22s the patch passed +1 compile 1m 33s the patch passed with JDK v1.8.0_101 +1 javac 1m 33s the patch passed +1 compile 1m 29s the patch passed with JDK v1.7.0_111 +1 javac 1m 29s the patch passed -0 checkstyle 0m 41s hadoop-hdfs-project: The patch generated 20 new + 827 unchanged - 22 fixed = 847 total (was 849) +1 mvnsite 1m 21s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 1s the patch passed +1 javadoc 1m 20s the patch passed with JDK v1.8.0_101 +1 javadoc 2m 1s the patch passed with JDK v1.7.0_111 +1 unit 1m 11s hadoop-hdfs-client in the patch passed with JDK v1.7.0_111. -1 unit 58m 27s hadoop-hdfs in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 153m 28s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs   hadoop.hdfs.server.datanode.TestDataNodeUUID JDK v1.7.0_111 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-9482 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837113/HDFS-9482-branch-2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fb3152690c2e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 3eed75a Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17427/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17427/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17427/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17427/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Testfailure unrelated and checkstyle can be ignored.. and uploaded patch for branch-2(just removed EC related classes) and branch-2.8(as HDFS-9371 not merged, need to keep one constructor as public).
        Arpit Agarwal can you please review.?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Testfailure unrelated and checkstyle can be ignored.. and uploaded patch for branch-2(just removed EC related classes) and branch-2.8(as HDFS-9371 not merged, need to keep one constructor as public). Arpit Agarwal can you please review.?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
        0 mvndep 0m 6s Maven dependency ordering for branch
        +1 mvninstall 8m 11s trunk passed
        +1 compile 1m 39s trunk passed
        +1 checkstyle 0m 40s trunk passed
        +1 mvnsite 1m 40s trunk passed
        +1 mvneclipse 0m 25s trunk passed
        +1 findbugs 3m 32s trunk passed
        +1 javadoc 1m 0s trunk passed
        0 mvndep 0m 6s Maven dependency ordering for patch
        +1 mvninstall 1m 17s the patch passed
        +1 compile 1m 24s the patch passed
        +1 javac 1m 24s the patch passed
        -0 checkstyle 0m 38s hadoop-hdfs-project: The patch generated 20 new + 855 unchanged - 22 fixed = 875 total (was 877)
        +1 mvnsite 1m 23s the patch passed
        +1 mvneclipse 0m 20s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 22s the patch passed
        +1 javadoc 0m 54s the patch passed
        +1 unit 0m 52s hadoop-hdfs-client in the patch passed.
        -1 unit 54m 33s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        83m 57s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-9482
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837068/HDFS-9482-003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 93ff5c6074a0 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 69dd5fa
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17424/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17424/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17424/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17424/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. 0 mvndep 0m 6s Maven dependency ordering for branch +1 mvninstall 8m 11s trunk passed +1 compile 1m 39s trunk passed +1 checkstyle 0m 40s trunk passed +1 mvnsite 1m 40s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 3m 32s trunk passed +1 javadoc 1m 0s trunk passed 0 mvndep 0m 6s Maven dependency ordering for patch +1 mvninstall 1m 17s the patch passed +1 compile 1m 24s the patch passed +1 javac 1m 24s the patch passed -0 checkstyle 0m 38s hadoop-hdfs-project: The patch generated 20 new + 855 unchanged - 22 fixed = 875 total (was 877) +1 mvnsite 1m 23s the patch passed +1 mvneclipse 0m 20s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 22s the patch passed +1 javadoc 0m 54s the patch passed +1 unit 0m 52s hadoop-hdfs-client in the patch passed. -1 unit 54m 33s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 83m 57s Reason Tests Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-9482 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837068/HDFS-9482-003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 93ff5c6074a0 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 69dd5fa Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17424/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17424/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17424/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17424/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Thanks a lot Arpit Agarwal Uploaded the patch to address all the above comments.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Thanks a lot Arpit Agarwal Uploaded the patch to address all the above comments.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Thank you for contributing this improvement Brahma Reddy Battula. A few comments:

        1. Fields from and nodeID in DatanodeInfoBuilder should be removed. They seem to be unused.
        2. DataNodeInfo has a number of unused constructors now. We should probably remove them.
        3. DatanodeInfoBuilder can be a static nested class of DatanodeInfo.
        4. Generally when we use a builder pattern, the constructor is made private to enforce construction via the builder. Is it possible to do that here?

        Looks good otherwise.

        Show
        arpitagarwal Arpit Agarwal added a comment - Thank you for contributing this improvement Brahma Reddy Battula . A few comments: Fields from and nodeID in DatanodeInfoBuilder should be removed. They seem to be unused. DataNodeInfo has a number of unused constructors now. We should probably remove them. DatanodeInfoBuilder can be a static nested class of DatanodeInfo. Generally when we use a builder pattern, the constructor is made private to enforce construction via the builder. Is it possible to do that here? Looks good otherwise.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
        0 mvndep 0m 8s Maven dependency ordering for branch
        +1 mvninstall 7m 44s trunk passed
        +1 compile 1m 35s trunk passed
        +1 checkstyle 0m 41s trunk passed
        +1 mvnsite 1m 31s trunk passed
        +1 mvneclipse 0m 24s trunk passed
        +1 findbugs 3m 26s trunk passed
        +1 javadoc 1m 20s trunk passed
        0 mvndep 0m 7s Maven dependency ordering for patch
        +1 mvninstall 1m 22s the patch passed
        +1 compile 1m 26s the patch passed
        +1 javac 1m 26s the patch passed
        -0 checkstyle 0m 40s hadoop-hdfs-project: The patch generated 21 new + 817 unchanged - 16 fixed = 838 total (was 833)
        +1 mvnsite 1m 30s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 1m 40s hadoop-hdfs-project/hadoop-hdfs-client generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
        +1 javadoc 1m 20s the patch passed
        +1 unit 0m 54s hadoop-hdfs-client in the patch passed.
        -1 unit 61m 56s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        92m 20s



        Reason Tests
        FindBugs module:hadoop-hdfs-project/hadoop-hdfs-client
          Unused field:DatanodeInfoBuilder.java
          Unused field:DatanodeInfoBuilder.java
        Failed junit tests hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-9482
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830445/HDFS-9482-002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux cccec4757cab 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / edf0d0f
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16877/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16877/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16877/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16877/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16877/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 7m 44s trunk passed +1 compile 1m 35s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 1m 31s trunk passed +1 mvneclipse 0m 24s trunk passed +1 findbugs 3m 26s trunk passed +1 javadoc 1m 20s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 22s the patch passed +1 compile 1m 26s the patch passed +1 javac 1m 26s the patch passed -0 checkstyle 0m 40s hadoop-hdfs-project: The patch generated 21 new + 817 unchanged - 16 fixed = 838 total (was 833) +1 mvnsite 1m 30s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 40s hadoop-hdfs-project/hadoop-hdfs-client generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 javadoc 1m 20s the patch passed +1 unit 0m 54s hadoop-hdfs-client in the patch passed. -1 unit 61m 56s hadoop-hdfs in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 92m 20s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs-client   Unused field:DatanodeInfoBuilder.java   Unused field:DatanodeInfoBuilder.java Failed junit tests hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-9482 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830445/HDFS-9482-002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cccec4757cab 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / edf0d0f Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16877/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16877/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/16877/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16877/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16877/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded the patch to fix applicable checksystyle and findbugs

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch to fix applicable checksystyle and findbugs
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 27s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
        0 mvndep 0m 30s Maven dependency ordering for branch
        +1 mvninstall 8m 34s trunk passed
        +1 compile 1m 41s trunk passed
        +1 checkstyle 0m 44s trunk passed
        +1 mvnsite 1m 43s trunk passed
        +1 mvneclipse 0m 28s trunk passed
        +1 findbugs 3m 38s trunk passed
        +1 javadoc 1m 19s trunk passed
        0 mvndep 0m 7s Maven dependency ordering for patch
        +1 mvninstall 1m 30s the patch passed
        +1 compile 1m 34s the patch passed
        +1 javac 1m 34s the patch passed
        -0 checkstyle 0m 40s hadoop-hdfs-project: The patch generated 36 new + 817 unchanged - 16 fixed = 853 total (was 833)
        +1 mvnsite 1m 38s the patch passed
        +1 mvneclipse 0m 22s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 1m 52s hadoop-hdfs-project/hadoop-hdfs-client generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
        +1 javadoc 1m 18s the patch passed
        +1 unit 0m 59s hadoop-hdfs-client in the patch passed.
        +1 unit 59m 33s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        92m 39s



        Reason Tests
        FindBugs module:hadoop-hdfs-project/hadoop-hdfs-client
          Unread field:DatanodeInfoBuilder.java:[line 51]
          Unread field:DatanodeInfoBuilder.java:[line 77]



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-9482
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830366/HDFS-9482.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 757e27fe6ad2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4815d02
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16864/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16864/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16864/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16864/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 27s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. 0 mvndep 0m 30s Maven dependency ordering for branch +1 mvninstall 8m 34s trunk passed +1 compile 1m 41s trunk passed +1 checkstyle 0m 44s trunk passed +1 mvnsite 1m 43s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 38s trunk passed +1 javadoc 1m 19s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 30s the patch passed +1 compile 1m 34s the patch passed +1 javac 1m 34s the patch passed -0 checkstyle 0m 40s hadoop-hdfs-project: The patch generated 36 new + 817 unchanged - 16 fixed = 853 total (was 833) +1 mvnsite 1m 38s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 52s hadoop-hdfs-project/hadoop-hdfs-client generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 javadoc 1m 18s the patch passed +1 unit 0m 59s hadoop-hdfs-client in the patch passed. +1 unit 59m 33s hadoop-hdfs in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 92m 39s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs-client   Unread field:DatanodeInfoBuilder.java: [line 51]   Unread field:DatanodeInfoBuilder.java: [line 77] Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-9482 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830366/HDFS-9482.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 757e27fe6ad2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4815d02 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16864/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16864/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16864/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16864/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        uploaded the patch..Arpit Agarwal can you plrease review..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - uploaded the patch.. Arpit Agarwal can you plrease review..?

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            brahmareddy Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development