Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9472

concat() API does not give proper exception messages on ./reserved relative path

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      dfs#concat() API doesn't resolve the /.reserved/raw path. For example, if the input paths of the form /.reserved/raw/ezone/a then this API doesn't work properly. The idea of this jira to discuss this behavior and handle accordingly.

      1. HDFS-9472-00.patch
        4 kB
        Rakesh R
      2. HDFS-9472-01.patch
        4 kB
        Rakesh R
      3. HDFS-9472-02.patch
        4 kB
        Rakesh R
      4. HDFS-9472-03.patch
        4 kB
        Rakesh R
      5. HDFS-9472-04.patch
        4 kB
        Rakesh R

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #686 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/686/)
        HDFS-9472. concat() API does not give proper exception messages on (umamahesh: rev e363417e7b7abdd5d149f303f729ecf3e95ef8f3)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #686 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/686/ ) HDFS-9472 . concat() API does not give proper exception messages on (umamahesh: rev e363417e7b7abdd5d149f303f729ecf3e95ef8f3) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        rakeshr Rakesh R added a comment -

        Thanks a lot Uma Maheswara Rao G for the final review & committing the patch.

        Show
        rakeshr Rakesh R added a comment - Thanks a lot Uma Maheswara Rao G for the final review & committing the patch.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8954 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8954/)
        HDFS-9472. concat() API does not give proper exception messages on (umamahesh: rev e363417e7b7abdd5d149f303f729ecf3e95ef8f3)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8954 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8954/ ) HDFS-9472 . concat() API does not give proper exception messages on (umamahesh: rev e363417e7b7abdd5d149f303f729ecf3e95ef8f3) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        Committed to trunk and branch-2

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - Committed to trunk and branch-2
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 9m 47s trunk passed
        +1 compile 1m 3s trunk passed with JDK v1.8.0_66
        +1 compile 0m 55s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 20s trunk passed
        +1 mvnsite 1m 7s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 2m 24s trunk passed
        +1 javadoc 1m 28s trunk passed with JDK v1.8.0_66
        +1 javadoc 2m 13s trunk passed with JDK v1.7.0_91
        +1 mvninstall 1m 2s the patch passed
        +1 compile 1m 4s the patch passed with JDK v1.8.0_66
        +1 javac 1m 4s the patch passed
        +1 compile 0m 50s the patch passed with JDK v1.7.0_91
        +1 javac 0m 50s the patch passed
        +1 checkstyle 0m 19s the patch passed
        +1 mvnsite 1m 1s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 24s the patch passed
        +1 javadoc 1m 19s the patch passed with JDK v1.8.0_66
        +1 javadoc 2m 10s the patch passed with JDK v1.7.0_91
        -1 unit 70m 0s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 69m 28s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        -1 asflicense 0m 23s Patch generated 58 ASF License warnings.
        173m 1s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.server.balancer.TestBalancer
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040
          hadoop.hdfs.TestDFSUpgradeFromImage
          hadoop.hdfs.server.datanode.TestDataNodeMetrics
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure120
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeXAttr
          hadoop.hdfs.TestEncryptionZones
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776836/HDFS-9472-04.patch
        JIRA Issue HDFS-9472
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f621424ac374 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f910e4f
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13826/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13826/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13826/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13826/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13826/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13826/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13826/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 47s trunk passed +1 compile 1m 3s trunk passed with JDK v1.8.0_66 +1 compile 0m 55s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 20s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 2m 24s trunk passed +1 javadoc 1m 28s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 13s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 2s the patch passed +1 compile 1m 4s the patch passed with JDK v1.8.0_66 +1 javac 1m 4s the patch passed +1 compile 0m 50s the patch passed with JDK v1.7.0_91 +1 javac 0m 50s the patch passed +1 checkstyle 0m 19s the patch passed +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 24s the patch passed +1 javadoc 1m 19s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 10s the patch passed with JDK v1.7.0_91 -1 unit 70m 0s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 69m 28s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 23s Patch generated 58 ASF License warnings. 173m 1s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure120 JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeXAttr   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040 Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776836/HDFS-9472-04.patch JIRA Issue HDFS-9472 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f621424ac374 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f910e4f findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13826/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13826/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13826/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13826/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13826/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13826/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13826/console This message was automatically generated.
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        +1 on the latest patch. Pending Jenkins.

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - +1 on the latest patch. Pending Jenkins.
        Hide
        rakeshr Rakesh R added a comment -

        Thanks again Uma Maheswara Rao G, I've corrected the same and updated another patch.

        Show
        rakeshr Rakesh R added a comment - Thanks again Uma Maheswara Rao G , I've corrected the same and updated another patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 9m 17s trunk passed
        +1 compile 0m 54s trunk passed with JDK v1.8.0_66
        +1 compile 0m 48s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 19s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 2m 17s trunk passed
        +1 javadoc 1m 24s trunk passed with JDK v1.8.0_66
        +1 javadoc 2m 11s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 56s the patch passed
        +1 compile 0m 51s the patch passed with JDK v1.8.0_66
        +1 javac 0m 51s the patch passed
        +1 compile 0m 50s the patch passed with JDK v1.7.0_91
        +1 javac 0m 50s the patch passed
        +1 checkstyle 0m 18s the patch passed
        +1 mvnsite 1m 1s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 27s the patch passed
        +1 javadoc 1m 19s the patch passed with JDK v1.8.0_66
        +1 javadoc 2m 5s the patch passed with JDK v1.7.0_91
        -1 unit 64m 12s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 55m 12s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        -1 asflicense 0m 24s Patch generated 58 ASF License warnings.
        151m 16s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestErasureCodeBenchmarkThroughput
          hadoop.hdfs.server.namenode.TestHDFSConcat
          hadoop.hdfs.TestRecoverStripedFile
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.TestLeaseRecovery2
          hadoop.hdfs.server.namenode.TestAddStripedBlocks
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestHDFSConcat
          hadoop.hdfs.server.balancer.TestBalancer
          hadoop.hdfs.TestDFSStripedOutputStream
          hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
          hadoop.hdfs.server.datanode.TestBlockReplacement



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776748/HDFS-9472-03.patch
        JIRA Issue HDFS-9472
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 22110a897859 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 132478e
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13823/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13823/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13823/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13823/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13823/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13823/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13823/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 17s trunk passed +1 compile 0m 54s trunk passed with JDK v1.8.0_66 +1 compile 0m 48s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 19s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 17s trunk passed +1 javadoc 1m 24s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 11s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 56s the patch passed +1 compile 0m 51s the patch passed with JDK v1.8.0_66 +1 javac 0m 51s the patch passed +1 compile 0m 50s the patch passed with JDK v1.7.0_91 +1 javac 0m 50s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 27s the patch passed +1 javadoc 1m 19s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 5s the patch passed with JDK v1.7.0_91 -1 unit 64m 12s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 55m 12s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 24s Patch generated 58 ASF License warnings. 151m 16s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestErasureCodeBenchmarkThroughput   hadoop.hdfs.server.namenode.TestHDFSConcat   hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.TestLeaseRecovery2   hadoop.hdfs.server.namenode.TestAddStripedBlocks JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestHDFSConcat   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.TestDFSStripedOutputStream   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.server.datanode.TestBlockReplacement Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776748/HDFS-9472-03.patch JIRA Issue HDFS-9472 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 22110a897859 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 132478e findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13823/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13823/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13823/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13823/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13823/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13823/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13823/console This message was automatically generated.
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        Thanks Rakesh. I think you missed to change for srcs(same comment as above) and in test too. Could you please update?

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - Thanks Rakesh. I think you missed to change for srcs(same comment as above) and in test too. Could you please update?
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Uma Maheswara Rao G. Attached another patch addressing the comments. Also, updated the jira subject line reflecting this behavior.

        Show
        rakeshr Rakesh R added a comment - Thanks Uma Maheswara Rao G . Attached another patch addressing the comments. Also, updated the jira subject line reflecting this behavior.
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        nit:

        throw new IOException("Concat operation doesn't supports "
        +          + FSDirectory.DOT_RESERVED_STRING + " relative path : " + target);
        

        supports -->support
        Otherwise +1

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - nit: throw new IOException( "Concat operation doesn't supports " + + FSDirectory.DOT_RESERVED_STRING + " relative path : " + target); supports -->support Otherwise +1
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 41s trunk passed
        +1 compile 0m 40s trunk passed with JDK v1.8.0_66
        +1 compile 0m 44s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 16s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 56s trunk passed
        +1 javadoc 1m 13s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 51s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 48s the patch passed
        +1 compile 0m 38s the patch passed with JDK v1.8.0_66
        +1 javac 0m 38s the patch passed
        +1 compile 0m 41s the patch passed with JDK v1.7.0_91
        +1 javac 0m 41s the patch passed
        +1 checkstyle 0m 15s the patch passed
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 6s the patch passed
        +1 javadoc 1m 7s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 50s the patch passed with JDK v1.7.0_91
        -1 unit 67m 3s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 70m 54s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        -1 asflicense 0m 32s Patch generated 58 ASF License warnings.
        181m 51s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.TestLargeBlock



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776506/HDFS-9472-02.patch
        JIRA Issue HDFS-9472
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8bcfeef7e6cc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 50edcb9
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13812/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13812/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13812/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13812/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13812/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13812/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 75MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13812/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 41s trunk passed +1 compile 0m 40s trunk passed with JDK v1.8.0_66 +1 compile 0m 44s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 56s trunk passed +1 javadoc 1m 13s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 51s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 48s the patch passed +1 compile 0m 38s the patch passed with JDK v1.8.0_66 +1 javac 0m 38s the patch passed +1 compile 0m 41s the patch passed with JDK v1.7.0_91 +1 javac 0m 41s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 6s the patch passed +1 javadoc 1m 7s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 50s the patch passed with JDK v1.7.0_91 -1 unit 67m 3s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 70m 54s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 32s Patch generated 58 ASF License warnings. 181m 51s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.TestLargeBlock Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776506/HDFS-9472-02.patch JIRA Issue HDFS-9472 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8bcfeef7e6cc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 50edcb9 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13812/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13812/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13812/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13812/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13812/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13812/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13812/console This message was automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Uma Maheswara Rao G. Agreed, attached another patch addressing the comments.

        Show
        rakeshr Rakesh R added a comment - Thanks Uma Maheswara Rao G . Agreed, attached another patch addressing the comments.
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        InvalidPathException

        Hi Rakesh, I think generally path is still valid path but this API does not support. So, do we need to return IOException and say the message that we don't support this path?

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - InvalidPathException Hi Rakesh, I think generally path is still valid path but this API does not support. So, do we need to return IOException and say the message that we don't support this path?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 11m 2s trunk passed
        +1 compile 1m 19s trunk passed with JDK v1.8.0_66
        +1 compile 1m 0s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 1m 15s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 findbugs 2m 38s trunk passed
        +1 javadoc 1m 56s trunk passed with JDK v1.8.0_66
        +1 javadoc 2m 41s trunk passed with JDK v1.7.0_91
        +1 mvninstall 1m 12s the patch passed
        +1 compile 1m 17s the patch passed with JDK v1.8.0_66
        +1 javac 1m 17s the patch passed
        +1 compile 1m 12s the patch passed with JDK v1.7.0_91
        +1 javac 1m 12s the patch passed
        +1 checkstyle 0m 25s the patch passed
        +1 mvnsite 1m 29s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 3m 14s the patch passed
        +1 javadoc 1m 50s the patch passed with JDK v1.8.0_66
        +1 javadoc 2m 50s the patch passed with JDK v1.7.0_91
        -1 unit 110m 0s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 91m 34s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        -1 asflicense 0m 24s Patch generated 57 ASF License warnings.
        243m 3s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots
          hadoop.hdfs.TestPread
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.server.namenode.TestFsck
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
          hadoop.hdfs.server.datanode.TestDirectoryScanner
        JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.TestReplication
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.TestRecoverStripedFile
          hadoop.hdfs.TestCrcCorruption
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.datanode.TestDirectoryScanner



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776080/HDFS-9472-01.patch
        JIRA Issue HDFS-9472
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0ffc9d15229a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / fc47084
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13799/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13799/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13799/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13799/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13799/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13799/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 75MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13799/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 11m 2s trunk passed +1 compile 1m 19s trunk passed with JDK v1.8.0_66 +1 compile 1m 0s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 23s trunk passed +1 mvnsite 1m 15s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 2m 38s trunk passed +1 javadoc 1m 56s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 41s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 12s the patch passed +1 compile 1m 17s the patch passed with JDK v1.8.0_66 +1 javac 1m 17s the patch passed +1 compile 1m 12s the patch passed with JDK v1.7.0_91 +1 javac 1m 12s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 1m 29s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 14s the patch passed +1 javadoc 1m 50s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 50s the patch passed with JDK v1.7.0_91 -1 unit 110m 0s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 91m 34s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 24s Patch generated 57 ASF License warnings. 243m 3s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestUpdatePipelineWithSnapshots   hadoop.hdfs.TestPread   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.namenode.TestFsck   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.snapshot.TestSnapshotRename   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.TestReplication JDK v1.7.0_91 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776080/HDFS-9472-01.patch JIRA Issue HDFS-9472 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0ffc9d15229a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fc47084 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13799/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13799/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13799/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13799/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13799/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13799/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13799/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 14m 45s trunk passed
        +1 compile 1m 54s trunk passed with JDK v1.8.0_66
        +1 compile 1m 25s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 1m 40s trunk passed
        +1 mvneclipse 0m 25s trunk passed
        +1 findbugs 3m 25s trunk passed
        +1 javadoc 2m 21s trunk passed with JDK v1.8.0_66
        +1 javadoc 3m 29s trunk passed with JDK v1.7.0_91
        +1 mvninstall 1m 38s the patch passed
        +1 compile 1m 57s the patch passed with JDK v1.8.0_66
        +1 javac 1m 57s the patch passed
        +1 compile 1m 26s the patch passed with JDK v1.7.0_91
        +1 javac 1m 26s the patch passed
        +1 checkstyle 0m 28s the patch passed
        +1 mvnsite 1m 40s the patch passed
        +1 mvneclipse 0m 26s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 3m 48s the patch passed
        +1 javadoc 2m 25s the patch passed with JDK v1.8.0_66
        +1 javadoc 3m 24s the patch passed with JDK v1.7.0_91
        -1 unit 160m 55s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 102m 20s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        -1 asflicense 0m 25s Patch generated 56 ASF License warnings.
        316m 47s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestBlockReaderLocal
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.TestRecoverStripedFile
          hadoop.hdfs.server.datanode.TestDataNodeMetrics
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.TestLocalDFS
          hadoop.hdfs.TestCrcCorruption
          hadoop.hdfs.TestDecommission
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
          hadoop.hdfs.tools.TestDFSAdminWithHA
          hadoop.hdfs.server.namenode.TestAddStripedBlocks
          hadoop.hdfs.TestDistributedFileSystem
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.server.namenode.ha.TestHAAppend
          hadoop.fs.TestSymlinkHdfsFileContext
          hadoop.hdfs.TestAclsEndToEnd
          hadoop.hdfs.server.namenode.TestDecommissioningStatus
          hadoop.hdfs.qjournal.TestSecureNNWithQJM
          hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
          hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter
          hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider
          hadoop.hdfs.server.namenode.TestCacheDirectives
          hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
          hadoop.hdfs.server.namenode.TestDeleteRace
          hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.web.TestWebHDFS
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDFSInotifyEventInputStream
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider
          hadoop.hdfs.server.datanode.TestDirectoryScanner



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776080/HDFS-9472-01.patch
        JIRA Issue HDFS-9472
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 685c25085942 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 01a641b
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13790/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13790/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13790/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13790/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13790/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13790/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13790/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 14m 45s trunk passed +1 compile 1m 54s trunk passed with JDK v1.8.0_66 +1 compile 1m 25s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 40s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 3m 25s trunk passed +1 javadoc 2m 21s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 29s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 38s the patch passed +1 compile 1m 57s the patch passed with JDK v1.8.0_66 +1 javac 1m 57s the patch passed +1 compile 1m 26s the patch passed with JDK v1.7.0_91 +1 javac 1m 26s the patch passed +1 checkstyle 0m 28s the patch passed +1 mvnsite 1m 40s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 48s the patch passed +1 javadoc 2m 25s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 24s the patch passed with JDK v1.7.0_91 -1 unit 160m 55s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 102m 20s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 25s Patch generated 56 ASF License warnings. 316m 47s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestBlockReaderLocal   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestLocalDFS   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.TestDecommission   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.tools.TestDFSAdminWithHA   hadoop.hdfs.server.namenode.TestAddStripedBlocks   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.TestAclsEndToEnd   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter   hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.namenode.TestDeleteRace   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.web.TestWebHDFS JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDFSInotifyEventInputStream   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776080/HDFS-9472-01.patch JIRA Issue HDFS-9472 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 685c25085942 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 01a641b findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13790/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13790/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13790/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13790/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13790/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13790/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13790/console This message was automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        Attached a new patch throwing InvalidPathException. Please review, thanks!. Will change the jira subjectline/description once we agreed on this.

        Show
        rakeshr Rakesh R added a comment - Attached a new patch throwing InvalidPathException . Please review, thanks!. Will change the jira subjectline/description once we agreed on this.
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Uma Maheswara Rao G for the suggestions. If this is designed intentionally, then IMHO would be good to throw InvalidPathException to the callers instead of FNFException. How about something like,

            if (FSDirectory.isReservedRawName(target) && FSDirectory.isReservedInodesName(target)) {
               throw new InvalidPathException(target);
            }
         // Also, will validate srcs...
        
        Show
        rakeshr Rakesh R added a comment - Thanks Uma Maheswara Rao G for the suggestions. If this is designed intentionally, then IMHO would be good to throw InvalidPathException to the callers instead of FNFException. How about something like, if (FSDirectory.isReservedRawName(target) && FSDirectory.isReservedInodesName(target)) { throw new InvalidPathException(target); } // Also, will validate srcs...
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        ok. then Just making log more meaningful should be enough. Yi Liu what do you say? any comments from you ?

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - ok. then Just making log more meaningful should be enough. Yi Liu what do you say? any comments from you ?
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Uma Maheswara Rao G for the comments.

        if so, what error you are getting when you try with .reservedPaths

        It is throwing FileNotFoundException. But I think it is not conveying proper message to the caller about the " This does not support ".inodes" relative path".

        org.apache.hadoop.ipc.RemoteException(java.io.FileNotFoundException): File does not exist: /ezone/trg
        	at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:73)
        	at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:63)
        	at org.apache.hadoop.hdfs.server.namenode.FSDirConcatOp.verifyTargetFile(FSDirConcatOp.java:112)
        	at org.apache.hadoop.hdfs.server.namenode.FSDirConcatOp.concat(FSDirConcatOp.java:83)
        	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.concat(FSNamesystem.java:1831)
        	at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.concat(NameNodeRpcServer.java:951)
        	at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.concat(ClientNamenodeProtocolServerSideTranslatorPB.java:572)
        	at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java:22107)
        	at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:637)
        	at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:976)
        	at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2305)
        	at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:1)
        	at java.security.AccessController.doPrivileged(Native Method)
        	at javax.security.auth.Subject.doAs(Subject.java:422)
        	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1669)
        	at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2300)
        
        	at org.apache.hadoop.ipc.Client.call(Client.java:1448)
        	at org.apache.hadoop.ipc.Client.call(Client.java:1385)
        	at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:230)
        	at com.sun.proxy.$Proxy20.concat(Unknown Source)
        	at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.concat(ClientNamenodeProtocolTranslatorPB.java:506)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:497)
        	at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:255)
        	at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:103)
        	at com.sun.proxy.$Proxy25.concat(Unknown Source)
        	at org.apache.hadoop.hdfs.DFSClient.concat(DFSClient.java:1468)
        	at org.apache.hadoop.hdfs.DistributedFileSystem.concat(DistributedFileSystem.java:584)
        
        Show
        rakeshr Rakesh R added a comment - Thanks Uma Maheswara Rao G for the comments. if so, what error you are getting when you try with .reservedPaths It is throwing FileNotFoundException . But I think it is not conveying proper message to the caller about the " This does not support ".inodes" relative path". org.apache.hadoop.ipc.RemoteException(java.io.FileNotFoundException): File does not exist: /ezone/trg at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:73) at org.apache.hadoop.hdfs.server.namenode.INodeFile.valueOf(INodeFile.java:63) at org.apache.hadoop.hdfs.server.namenode.FSDirConcatOp.verifyTargetFile(FSDirConcatOp.java:112) at org.apache.hadoop.hdfs.server.namenode.FSDirConcatOp.concat(FSDirConcatOp.java:83) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.concat(FSNamesystem.java:1831) at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.concat(NameNodeRpcServer.java:951) at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.concat(ClientNamenodeProtocolServerSideTranslatorPB.java:572) at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java:22107) at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:637) at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:976) at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2305) at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:1) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:422) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1669) at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2300) at org.apache.hadoop.ipc.Client.call(Client.java:1448) at org.apache.hadoop.ipc.Client.call(Client.java:1385) at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:230) at com.sun.proxy.$Proxy20.concat(Unknown Source) at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.concat(ClientNamenodeProtocolTranslatorPB.java:506) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:255) at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:103) at com.sun.proxy.$Proxy25.concat(Unknown Source) at org.apache.hadoop.hdfs.DFSClient.concat(DFSClient.java:1468) at org.apache.hadoop.hdfs.DistributedFileSystem.concat(DistributedFileSystem.java:584)
        Hide
        umamaheswararao Uma Maheswara Rao G added a comment -

        Hi Rakesh, Thanks for reporting. I am not sure user will have real need of concatenating .reservedPaths.
        In the concat javadoc of Fsnamesystem says " * This does not support ".inodes" relative path"
        Yi Liu do you know this comment means, we don't support .reserved paths?

        if so, what error you are getting when you try with .reservedPaths, Rakesh R ?

        Show
        umamaheswararao Uma Maheswara Rao G added a comment - Hi Rakesh, Thanks for reporting. I am not sure user will have real need of concatenating .reservedPaths. In the concat javadoc of Fsnamesystem says " * This does not support ".inodes" relative path" Yi Liu do you know this comment means, we don't support .reserved paths? if so, what error you are getting when you try with .reservedPaths, Rakesh R ?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 12m 58s trunk passed
        +1 compile 1m 29s trunk passed with JDK v1.8.0_66
        +1 compile 1m 8s trunk passed with JDK v1.7.0_85
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 1m 30s trunk passed
        +1 mvneclipse 0m 19s trunk passed
        +1 findbugs 3m 1s trunk passed
        +1 javadoc 2m 2s trunk passed with JDK v1.8.0_66
        +1 javadoc 3m 8s trunk passed with JDK v1.7.0_85
        +1 mvninstall 1m 22s the patch passed
        +1 compile 1m 30s the patch passed with JDK v1.8.0_66
        +1 javac 1m 30s the patch passed
        +1 compile 1m 7s the patch passed with JDK v1.7.0_85
        +1 javac 1m 7s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 1m 26s the patch passed
        +1 mvneclipse 0m 20s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 3m 18s the patch passed
        +1 javadoc 2m 5s the patch passed with JDK v1.8.0_66
        +1 javadoc 3m 6s the patch passed with JDK v1.7.0_85
        -1 unit 107m 55s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 87m 58s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
        -1 asflicense 0m 23s Patch generated 56 ASF License warnings.
        241m 8s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.TestPersistBlocks
          hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.TestDFSStripedOutputStream
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.TestReplication
          hadoop.hdfs.server.namenode.ha.TestHAAppend
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure110
          hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.TestEncryptionZones
          hadoop.hdfs.TestDFSClientRetries
          hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
          hadoop.hdfs.server.datanode.TestDirectoryScanner
        JDK v1.7.0_85 Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts
          hadoop.hdfs.TestDFSUpgradeFromImage
          hadoop.hdfs.server.blockmanagement.TestHeartbeatHandling
          hadoop.hdfs.server.namenode.TestQuotaByStorageType
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.server.namenode.TestMetaSave
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
          hadoop.hdfs.server.namenode.TestCacheDirectives
          hadoop.hdfs.server.datanode.TestDirectoryScanner



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774578/HDFS-9472-00.patch
        JIRA Issue HDFS-9472
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e049ca58c855 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9f256d1
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13681/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13681/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13681/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13681/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13681/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13681/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 75MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13681/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 12m 58s trunk passed +1 compile 1m 29s trunk passed with JDK v1.8.0_66 +1 compile 1m 8s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 26s trunk passed +1 mvnsite 1m 30s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 3m 1s trunk passed +1 javadoc 2m 2s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 8s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 22s the patch passed +1 compile 1m 30s the patch passed with JDK v1.8.0_66 +1 javac 1m 30s the patch passed +1 compile 1m 7s the patch passed with JDK v1.7.0_85 +1 javac 1m 7s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 1m 26s the patch passed +1 mvneclipse 0m 20s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 18s the patch passed +1 javadoc 2m 5s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 6s the patch passed with JDK v1.7.0_85 -1 unit 107m 55s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 87m 58s hadoop-hdfs in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 23s Patch generated 56 ASF License warnings. 241m 8s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestDFSStripedOutputStream   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.TestReplication   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure110   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_85 Failed junit tests hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.blockmanagement.TestHeartbeatHandling   hadoop.hdfs.server.namenode.TestQuotaByStorageType   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.namenode.TestMetaSave   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774578/HDFS-9472-00.patch JIRA Issue HDFS-9472 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e049ca58c855 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9f256d1 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13681/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13681/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13681/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13681/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13681/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13681/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13681/console This message was automatically generated.

          People

          • Assignee:
            rakeshr Rakesh R
            Reporter:
            rakeshr Rakesh R
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development