Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-947

The namenode should redirect a hftp request to read a file to the datanode that has the maximum number of local replicas

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      A client that uses the Hftp protocol to read a file is redirected by the namenode to a random datanode. It would be nice if the client gets redirected to a datanode that has the maximum number of local replicas of the blocks of the file.

      1. hftpRedirection.patch
        5 kB
        dhruba borthakur
      2. HDFS-947.patch
        9 kB
        Dmytro Molkov
      3. HDFS-947.2.patch
        11 kB
        Dmytro Molkov

        Activity

        Hide
        dhruba borthakur added a comment -

        This is a patch fro hadoop 0.20. The namenode redirects a hftp read request to the datanode that has the max number of local replicas of the file.

        Show
        dhruba borthakur added a comment - This is a patch fro hadoop 0.20. The namenode redirects a hftp read request to the datanode that has the max number of local replicas of the file.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12446046/HDFS-947.patch
        against trunk revision 949827.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The applied patch generated 24 javac compiler warnings (more than the trunk's current 23 warnings).

        -1 findbugs. The patch appears to introduce 1 new Findbugs warnings.

        -1 release audit. The applied patch generated 113 release audit warnings (more than the trunk's current 112 warnings).

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/388/testReport/
        Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/388/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/388/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/388/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/388/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12446046/HDFS-947.patch against trunk revision 949827. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 24 javac compiler warnings (more than the trunk's current 23 warnings). -1 findbugs. The patch appears to introduce 1 new Findbugs warnings. -1 release audit. The applied patch generated 113 release audit warnings (more than the trunk's current 112 warnings). -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/388/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/388/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/388/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/388/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/388/console This message is automatically generated.
        Hide
        Dmytro Molkov added a comment -

        Attaching a patch that is not broken in so many ways

        Show
        Dmytro Molkov added a comment - Attaching a patch that is not broken in so many ways
        Hide
        Dmytro Molkov added a comment -

        Resubmitting the patch because there were problems with Hudson this last days.

        Show
        Dmytro Molkov added a comment - Resubmitting the patch because there were problems with Hudson this last days.
        Hide
        dhruba borthakur added a comment -

        +1 code looks good to me.

        Show
        dhruba borthakur added a comment - +1 code looks good to me.
        Hide
        Dmytro Molkov added a comment -

        I ran hadoopQA locally since Hudson keeps ignoring this jira:

        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 4 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        The tests also ran fine.

        Show
        Dmytro Molkov added a comment - I ran hadoopQA locally since Hudson keeps ignoring this jira: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 4 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. The tests also ran fine.
        Hide
        dhruba borthakur added a comment -

        Thanks dmytro, i will commit it.

        Show
        dhruba borthakur added a comment - Thanks dmytro, i will commit it.
        Hide
        dhruba borthakur added a comment -

        I just committed this. Thanks Dmytro!

        Show
        dhruba borthakur added a comment - I just committed this. Thanks Dmytro!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #314 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/314/)
        HDFS-947. An Hftp read request is redirected to a datanode that has
        the most replicas of the blocks in the file. (Dmytro Molkov via dhruba)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #314 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/314/ ) HDFS-947 . An Hftp read request is redirected to a datanode that has the most replicas of the blocks in the file. (Dmytro Molkov via dhruba)

          People

          • Assignee:
            Dmytro Molkov
            Reporter:
            dhruba borthakur
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development