Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9445

Datanode may deadlock while handling a bad volume

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.7.2
    • Fix Version/s: 2.8.0, 2.7.2, 2.6.4, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Found one Java-level deadlock:
      =============================
      "DataXceiver for client DFSClient_attempt_xxx at /1.2.3.4:100 [Sending block BP-xxxxx:blk_123_456]":
        waiting to lock monitor 0x00007f77d0731768 (object 0x00000000d60d9930, a org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl),
        which is held by "Thread-565"
      "Thread-565":
        waiting for ownable synchronizer 0x00000000d55613c8, (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync),
        which is held by "DataNode: heartbeating to my-nn:8020"
      "DataNode: heartbeating to my-nn:8020":
        waiting to lock monitor 0x00007f77d0731768 (object 0x00000000d60d9930, a org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl),
        which is held by "Thread-565"
      
      1. HDFS-9445.00.patch
        5 kB
        Walter Su
      2. HDFS-9445.01.patch
        8 kB
        Walter Su
      3. HDFS-9445.02.patch
        7 kB
        Walter Su
      4. HDFS-9445-branch-2.6_02.patch
        7 kB
        Walter Su
      5. HDFS-9445-branch-2.6.02.patch
        7 kB
        Akira Ajisaka

        Activity

        Hide
        kihwal Kihwal Lee added a comment -

        And the stack trace:

        Java stack information for the threads listed above:
        ===================================================
        "DataXceiver for client DFSClient_attempt_xxx [Sending block BP-xxxxx:blk_123_456]":
                at org.apache.hadoop.hdfs.server.datanode.BlockSender.<init>(BlockSender.java:234)
                - waiting to lock <0x00000000d60d9930> (a org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl)
                at org.apache.hadoop.hdfs.server.datanode.DataXceiver.readBlock(DataXceiver.java:537)
                at org.apache.hadoop.hdfs.protocol.datatransfer.Receiver.opReadBlock(Receiver.java:116)
                at org.apache.hadoop.hdfs.protocol.datatransfer.Receiver.processOp(Receiver.java:71)
                at org.apache.hadoop.hdfs.server.datanode.DataXceiver.run(DataXceiver.java:251)
                at java.lang.Thread.run(Thread.java:745)
        "Thread-565":
                at sun.misc.Unsafe.park(Native Method)
                - parking to wait for  <0x00000000d55613c8> (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync)
                at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
                at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
                at java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireShared(AbstractQueuedSynchronizer.java:967)
                at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireShared(AbstractQueuedSynchronizer.java:1283)
                at java.util.concurrent.locks.ReentrantReadWriteLock$ReadLock.lock(ReentrantReadWriteLock.java:727)
                at org.apache.hadoop.hdfs.server.datanode.BPOfferService.readLock(BPOfferService.java:105)
                at org.apache.hadoop.hdfs.server.datanode.BPOfferService.getBlockPoolId(BPOfferService.java:166)
                at org.apache.hadoop.hdfs.server.datanode.BPOfferService.checkBlock(BPOfferService.java:249)
                at org.apache.hadoop.hdfs.server.datanode.BPOfferService.notifyNamenodeDeletedBlock(BPOfferService.java:255)
                at org.apache.hadoop.hdfs.server.datanode.DataNode.notifyNamenodeDeletedBlock(DataNode.java:976)
                at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.invalidate(FsDatasetImpl.java:1891)
                at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.removeVolumes(FsDatasetImpl.java:485)
                - locked <0x00000000d60d9930> (a org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl)
                at org.apache.hadoop.hdfs.server.datanode.DataNode.removeVolumes(DataNode.java:690)
                - locked <0x00000000d58b9e70> (a org.apache.hadoop.hdfs.server.datanode.DataNode)
                at org.apache.hadoop.hdfs.server.datanode.DataNode.checkDiskError(DataNode.java:3137)
                at org.apache.hadoop.hdfs.server.datanode.DataNode.access$800(DataNode.java:242)
                at org.apache.hadoop.hdfs.server.datanode.DataNode$7.run(DataNode.java:3166)
                at java.lang.Thread.run(Thread.java:745)
        "DataNode: heartbeating to my-nn:8020":
                at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.validateBlockFile(FsDatasetImpl.java:1741)
                - waiting to lock <0x00000000d60d9930> (a org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl)
                at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.getBlockFile(FsDatasetImpl.java:663)
                at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.getBlockFile(FsDatasetImpl.java:656)
                at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.getLength(FsDatasetImpl.java:649)
                at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.checkBlock(FsDatasetImpl.java:1701)
                at org.apache.hadoop.hdfs.server.datanode.DataNode.transferBlock(DataNode.java:1875)
                at org.apache.hadoop.hdfs.server.datanode.DataNode.transferBlocks(DataNode.java:1931)
                at org.apache.hadoop.hdfs.server.datanode.BPOfferService.processCommandFromActive(BPOfferService.java:657)
                at org.apache.hadoop.hdfs.server.datanode.BPOfferService.processCommandFromActor(BPOfferService.java:615)
                at org.apache.hadoop.hdfs.server.datanode.BPServiceActor.processCommand(BPServiceActor.java:858)
                at org.apache.hadoop.hdfs.server.datanode.BPServiceActor.offerService(BPServiceActor.java:672)
                at org.apache.hadoop.hdfs.server.datanode.BPServiceActor.run(BPServiceActor.java:824)
                at java.lang.Thread.run(Thread.java:745)
        
        Show
        kihwal Kihwal Lee added a comment - And the stack trace: Java stack information for the threads listed above: =================================================== "DataXceiver for client DFSClient_attempt_xxx [Sending block BP-xxxxx:blk_123_456]": at org.apache.hadoop.hdfs.server.datanode.BlockSender.<init>(BlockSender.java:234) - waiting to lock <0x00000000d60d9930> (a org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl) at org.apache.hadoop.hdfs.server.datanode.DataXceiver.readBlock(DataXceiver.java:537) at org.apache.hadoop.hdfs.protocol.datatransfer.Receiver.opReadBlock(Receiver.java:116) at org.apache.hadoop.hdfs.protocol.datatransfer.Receiver.processOp(Receiver.java:71) at org.apache.hadoop.hdfs.server.datanode.DataXceiver.run(DataXceiver.java:251) at java.lang.Thread.run(Thread.java:745) "Thread-565": at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x00000000d55613c8> (a java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836) at java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireShared(AbstractQueuedSynchronizer.java:967) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireShared(AbstractQueuedSynchronizer.java:1283) at java.util.concurrent.locks.ReentrantReadWriteLock$ReadLock.lock(ReentrantReadWriteLock.java:727) at org.apache.hadoop.hdfs.server.datanode.BPOfferService.readLock(BPOfferService.java:105) at org.apache.hadoop.hdfs.server.datanode.BPOfferService.getBlockPoolId(BPOfferService.java:166) at org.apache.hadoop.hdfs.server.datanode.BPOfferService.checkBlock(BPOfferService.java:249) at org.apache.hadoop.hdfs.server.datanode.BPOfferService.notifyNamenodeDeletedBlock(BPOfferService.java:255) at org.apache.hadoop.hdfs.server.datanode.DataNode.notifyNamenodeDeletedBlock(DataNode.java:976) at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.invalidate(FsDatasetImpl.java:1891) at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.removeVolumes(FsDatasetImpl.java:485) - locked <0x00000000d60d9930> (a org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl) at org.apache.hadoop.hdfs.server.datanode.DataNode.removeVolumes(DataNode.java:690) - locked <0x00000000d58b9e70> (a org.apache.hadoop.hdfs.server.datanode.DataNode) at org.apache.hadoop.hdfs.server.datanode.DataNode.checkDiskError(DataNode.java:3137) at org.apache.hadoop.hdfs.server.datanode.DataNode.access$800(DataNode.java:242) at org.apache.hadoop.hdfs.server.datanode.DataNode$7.run(DataNode.java:3166) at java.lang.Thread.run(Thread.java:745) "DataNode: heartbeating to my-nn:8020": at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.validateBlockFile(FsDatasetImpl.java:1741) - waiting to lock <0x00000000d60d9930> (a org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl) at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.getBlockFile(FsDatasetImpl.java:663) at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.getBlockFile(FsDatasetImpl.java:656) at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.getLength(FsDatasetImpl.java:649) at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl.checkBlock(FsDatasetImpl.java:1701) at org.apache.hadoop.hdfs.server.datanode.DataNode.transferBlock(DataNode.java:1875) at org.apache.hadoop.hdfs.server.datanode.DataNode.transferBlocks(DataNode.java:1931) at org.apache.hadoop.hdfs.server.datanode.BPOfferService.processCommandFromActive(BPOfferService.java:657) at org.apache.hadoop.hdfs.server.datanode.BPOfferService.processCommandFromActor(BPOfferService.java:615) at org.apache.hadoop.hdfs.server.datanode.BPServiceActor.processCommand(BPServiceActor.java:858) at org.apache.hadoop.hdfs.server.datanode.BPServiceActor.offerService(BPServiceActor.java:672) at org.apache.hadoop.hdfs.server.datanode.BPServiceActor.run(BPServiceActor.java:824) at java.lang.Thread.run(Thread.java:745)
        Hide
        walter.k.su Walter Su added a comment -

        I think the lock should be required in such order: bposLock --> FSDatasetLock. If FSDatasetLock is held, it shouldn't require bposLock any more.
        Upload initial patch. If anyone already working on this and have better patch, be free to upload yours.

        Show
        walter.k.su Walter Su added a comment - I think the lock should be required in such order: bposLock --> FSDatasetLock. If FSDatasetLock is held, it shouldn't require bposLock any more. Upload initial patch. If anyone already working on this and have better patch, be free to upload yours.
        Hide
        kihwal Kihwal Lee added a comment -

        The approach looks good. Since the private invalidate method is only used by removeVolumes(), why don't we make it accept the built-up collection of blocks? We could also rename the method so that it is clearly distinct from the public invalidate().

        Show
        kihwal Kihwal Lee added a comment - The approach looks good. Since the private invalidate method is only used by removeVolumes() , why don't we make it accept the built-up collection of blocks? We could also rename the method so that it is clearly distinct from the public invalidate() .
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Kihwal Lee / Walter Su, I am holding off 2.7.2 for this one, please let me know if this needs more time. Thanks.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Kihwal Lee / Walter Su , I am holding off 2.7.2 for this one, please let me know if this needs more time. Thanks.
        Hide
        walter.k.su Walter Su added a comment -

        Sorry for late update. Let's get it done.

        // If a DFSClient has the replica in its cache of short-circuit file
        // descriptors (and the client is using ShortCircuitShm), invalidate it.
        datanode.getShortCircuitRegistry().processBlockInvalidation(
                  new ExtendedBlockId(invalidBlks[i].getBlockId(), bpid));
        
        // If the block is cached, start uncaching it.
        cacheManager.uncacheBlock(bpid, invalidBlks[i].getBlockId());
        

        The 2 lines are copied from public void invalidate(..). It's a clean-up after remove blocks from volumeMap. Those 2 lines are the only part same as invalidate.
        These lines look unrelated. So it's hard to pick a proper func name for them.
        Those 2 lines don't require inside the FSDatasetLock.
        I just moved them to removeVolumes. Let me know if it's ok to you.

        Show
        walter.k.su Walter Su added a comment - Sorry for late update. Let's get it done. // If a DFSClient has the replica in its cache of short -circuit file // descriptors (and the client is using ShortCircuitShm), invalidate it. datanode.getShortCircuitRegistry().processBlockInvalidation( new ExtendedBlockId(invalidBlks[i].getBlockId(), bpid)); // If the block is cached, start uncaching it. cacheManager.uncacheBlock(bpid, invalidBlks[i].getBlockId()); The 2 lines are copied from public void invalidate(..) . It's a clean-up after remove blocks from volumeMap. Those 2 lines are the only part same as invalidate . These lines look unrelated. So it's hard to pick a proper func name for them. Those 2 lines don't require inside the FSDatasetLock. I just moved them to removeVolumes . Let me know if it's ok to you.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 9m 30s trunk passed
        +1 compile 0m 58s trunk passed with JDK v1.8.0_66
        +1 compile 0m 51s trunk passed with JDK v1.7.0_85
        +1 checkstyle 0m 18s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 2m 23s trunk passed
        +1 javadoc 1m 20s trunk passed with JDK v1.8.0_66
        +1 javadoc 2m 0s trunk passed with JDK v1.7.0_85
        +1 mvninstall 0m 56s the patch passed
        +1 compile 0m 53s the patch passed with JDK v1.8.0_66
        +1 javac 0m 53s the patch passed
        +1 compile 0m 51s the patch passed with JDK v1.7.0_85
        +1 javac 0m 51s the patch passed
        -1 checkstyle 0m 19s Patch generated 1 new checkstyle issues in hadoop-hdfs-project/hadoop-hdfs (total was 123, now 123).
        +1 mvnsite 0m 58s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 28s the patch passed
        +1 javadoc 1m 15s the patch passed with JDK v1.8.0_66
        +1 javadoc 2m 0s the patch passed with JDK v1.7.0_85
        -1 unit 62m 28s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 55m 15s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
        -1 asflicense 0m 19s Patch generated 56 ASF License warnings.
        149m 30s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
          hadoop.hdfs.TestWriteReadStripedFile
          hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion
          hadoop.hdfs.TestHFlush
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.web.TestWebHdfsTimeouts
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.shortcircuit.TestShortCircuitCache
        JDK v1.7.0_85 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
          hadoop.hdfs.TestCrcCorruption
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774458/HDFS-9445.01.patch
        JIRA Issue HDFS-9445
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8a31298c87e9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0348e76
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13674/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13674/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13674/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13674/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13674/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13674/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13674/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13674/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 30s trunk passed +1 compile 0m 58s trunk passed with JDK v1.8.0_66 +1 compile 0m 51s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 18s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 2m 23s trunk passed +1 javadoc 1m 20s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 0s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 56s the patch passed +1 compile 0m 53s the patch passed with JDK v1.8.0_66 +1 javac 0m 53s the patch passed +1 compile 0m 51s the patch passed with JDK v1.7.0_85 +1 javac 0m 51s the patch passed -1 checkstyle 0m 19s Patch generated 1 new checkstyle issues in hadoop-hdfs-project/hadoop-hdfs (total was 123, now 123). +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 28s the patch passed +1 javadoc 1m 15s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 0s the patch passed with JDK v1.7.0_85 -1 unit 62m 28s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 55m 15s hadoop-hdfs in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 19s Patch generated 56 ASF License warnings. 149m 30s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.TestWriteReadStripedFile   hadoop.hdfs.server.namenode.snapshot.TestSnapshotDeletion   hadoop.hdfs.TestHFlush   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.web.TestWebHdfsTimeouts   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.shortcircuit.TestShortCircuitCache JDK v1.7.0_85 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040 Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774458/HDFS-9445.01.patch JIRA Issue HDFS-9445 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8a31298c87e9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0348e76 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13674/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13674/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13674/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13674/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13674/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13674/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13674/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13674/console This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Patch looks almost good. Thanks Walter Su.

        I just moved them to removeVolumes. Let me know if it's ok to you.

        I would prefer to keep invalidate(..) as is and call it inside removeVolume(). Though public invalidate(..) is not used anywhere else, it would be better not to change it now.
        +1 once addressed.

        Show
        vinayrpet Vinayakumar B added a comment - Patch looks almost good. Thanks Walter Su . I just moved them to removeVolumes. Let me know if it's ok to you. I would prefer to keep invalidate(..) as is and call it inside removeVolume() . Though public invalidate(..) is not used anywhere else, it would be better not to change it now. +1 once addressed.
        Hide
        walter.k.su Walter Su added a comment -

        Uploaded 02 patch.
        1. keep public void invalidate(String bpid, ReplicaInfo block)
        2. address TestDataNodeHotSwapVolumes.testRemoveOneVolume

        Show
        walter.k.su Walter Su added a comment - Uploaded 02 patch. 1. keep public void invalidate(String bpid, ReplicaInfo block) 2. address TestDataNodeHotSwapVolumes.testRemoveOneVolume
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 13m 56s trunk passed
        +1 compile 1m 43s trunk passed with JDK v1.8.0_66
        +1 compile 1m 17s trunk passed with JDK v1.7.0_85
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 1m 42s trunk passed
        +1 mvneclipse 0m 23s trunk passed
        +1 findbugs 3m 14s trunk passed
        +1 javadoc 2m 20s trunk passed with JDK v1.8.0_66
        +1 javadoc 3m 5s trunk passed with JDK v1.7.0_85
        +1 mvninstall 1m 31s the patch passed
        +1 compile 1m 40s the patch passed with JDK v1.8.0_66
        +1 javac 1m 40s the patch passed
        +1 compile 1m 19s the patch passed with JDK v1.7.0_85
        +1 javac 1m 19s the patch passed
        -1 checkstyle 0m 27s Patch generated 1 new checkstyle issues in hadoop-hdfs-project/hadoop-hdfs (total was 123, now 123).
        +1 mvnsite 1m 32s the patch passed
        +1 mvneclipse 0m 22s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 3m 25s the patch passed
        +1 javadoc 2m 7s the patch passed with JDK v1.8.0_66
        +1 javadoc 3m 5s the patch passed with JDK v1.7.0_85
        -1 unit 111m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 106m 38s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
        -1 asflicense 0m 31s Patch generated 56 ASF License warnings.
        267m 9s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.TestFileAppend2
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.server.namenode.TestMetaSave
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.server.datanode.TestDirectoryScanner
        JDK v1.7.0_85 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.TestSafeMode
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.qjournal.TestSecureNNWithQJM
          hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
          hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
          hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
          hadoop.hdfs.server.datanode.TestDirectoryScanner



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774490/HDFS-9445.02.patch
        JIRA Issue HDFS-9445
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 102a16948005 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9f256d1
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13678/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13678/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13678/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13678/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13678/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
        JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13678/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13678/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 75MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13678/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 13m 56s trunk passed +1 compile 1m 43s trunk passed with JDK v1.8.0_66 +1 compile 1m 17s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 28s trunk passed +1 mvnsite 1m 42s trunk passed +1 mvneclipse 0m 23s trunk passed +1 findbugs 3m 14s trunk passed +1 javadoc 2m 20s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 5s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 31s the patch passed +1 compile 1m 40s the patch passed with JDK v1.8.0_66 +1 javac 1m 40s the patch passed +1 compile 1m 19s the patch passed with JDK v1.7.0_85 +1 javac 1m 19s the patch passed -1 checkstyle 0m 27s Patch generated 1 new checkstyle issues in hadoop-hdfs-project/hadoop-hdfs (total was 123, now 123). +1 mvnsite 1m 32s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 25s the patch passed +1 javadoc 2m 7s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 5s the patch passed with JDK v1.7.0_85 -1 unit 111m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 106m 38s hadoop-hdfs in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 31s Patch generated 56 ASF License warnings. 267m 9s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.TestFileAppend2   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.namenode.TestMetaSave   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_85 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestSafeMode   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774490/HDFS-9445.02.patch JIRA Issue HDFS-9445 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 102a16948005 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9f256d1 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13678/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13678/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13678/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13678/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13678/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13678/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13678/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13678/console This message was automatically generated.
        Hide
        kihwal Kihwal Lee added a comment -

        Re-ran the failed test cases multiple times and only TestEditLogTailer#testNN1TriggersLogRolls failed once. I don't think it is related to this patch.
        The latest patch looks good to me. What do you think, Vinayakumar B?

        Show
        kihwal Kihwal Lee added a comment - Re-ran the failed test cases multiple times and only TestEditLogTailer#testNN1TriggersLogRolls failed once. I don't think it is related to this patch. The latest patch looks good to me. What do you think, Vinayakumar B ?
        Hide
        liuml07 Mingliang Liu added a comment -

        The bposLock --> FSDatasetLock locking order looks good to me.

        The TestDirectoryScanner#testThrottle() is flaky and is tracked by HDFS-9300. The org.apache.hadoop.hdfs.server.namenode.TestMetaSave fails consistently on trunk branch and is considered a bug (newly filed HDFS-9493 to track this). All other failing tests can not reproduce locally (both Gentoo Linux and Mac).

        Kihwal Lee, the TestEditLogTailer#testNN1TriggersLogRolls is known to fail with bind exception and is tracked by HDFS-9444. I don't think it is related to this patch anyway.

        +1 (non-binding)

        Show
        liuml07 Mingliang Liu added a comment - The bposLock --> FSDatasetLock locking order looks good to me. The TestDirectoryScanner#testThrottle() is flaky and is tracked by HDFS-9300 . The org.apache.hadoop.hdfs.server.namenode.TestMetaSave fails consistently on trunk branch and is considered a bug (newly filed HDFS-9493 to track this). All other failing tests can not reproduce locally (both Gentoo Linux and Mac). Kihwal Lee , the TestEditLogTailer#testNN1TriggersLogRolls is known to fail with bind exception and is tracked by HDFS-9444 . I don't think it is related to this patch anyway. +1 (non-binding)
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Bump! Any progress on this? Blocked on this for the 2.7.2 release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Bump! Any progress on this? Blocked on this for the 2.7.2 release.
        Hide
        kihwal Kihwal Lee added a comment -

        +1. I will commit it this afternoon, if no one objects until then.

        Show
        kihwal Kihwal Lee added a comment - +1. I will commit it this afternoon, if no one objects until then.
        Hide
        cnauroth Chris Nauroth added a comment -

        Kihwal Lee and Walter Su, if I understand correctly, this deadlock was introduced by the HDFS-6788 patch (introduction of the read-write lock in BPOfferService, and the deadlock can occur if there is concurrent heartbeat processing while the disk checker thread is also taking a volume out of service. Does that sound accurate?

        Show
        cnauroth Chris Nauroth added a comment - Kihwal Lee and Walter Su , if I understand correctly, this deadlock was introduced by the HDFS-6788 patch (introduction of the read-write lock in BPOfferService , and the deadlock can occur if there is concurrent heartbeat processing while the disk checker thread is also taking a volume out of service. Does that sound accurate?
        Hide
        vinayrpet Vinayakumar B added a comment -

        You are right Chris Nauroth.

        Kihwal Lee, Latest patch looks good to me. +1.

        Show
        vinayrpet Vinayakumar B added a comment - You are right Chris Nauroth . Kihwal Lee , Latest patch looks good to me. +1.
        Hide
        kihwal Kihwal Lee added a comment - - edited

        I've committed this to trunk, branch-2, branch-2.8, branch-2.7 and branch-2.7.2. Thank you for working on the patch, Walter, and also hhank you Vinay for fantastic reviews.

        Show
        kihwal Kihwal Lee added a comment - - edited I've committed this to trunk, branch-2, branch-2.8, branch-2.7 and branch-2.7.2. Thank you for working on the patch, Walter, and also hhank you Vinay for fantastic reviews.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8955 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8955/)
        HDFS-9445. Datanode may deadlock while handling a bad volume. (kihwal: rev a48301791e9564363bc2abad4e89e344b0d7a5ff)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8955 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8955/ ) HDFS-9445 . Datanode may deadlock while handling a bad volume. (kihwal: rev a48301791e9564363bc2abad4e89e344b0d7a5ff) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #687 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/687/)
        HDFS-9445. Datanode may deadlock while handling a bad volume. (kihwal: rev a48301791e9564363bc2abad4e89e344b0d7a5ff)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #687 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/687/ ) HDFS-9445 . Datanode may deadlock while handling a bad volume. (kihwal: rev a48301791e9564363bc2abad4e89e344b0d7a5ff) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
        Hide
        djp Junping Du added a comment -

        Hi Walter Su, Vinayakumar B and Kihwal Lee, does the same issue exist in branch-2.6 also? If so, we may consider to cherry-pick the fix to branch-2.6?

        Show
        djp Junping Du added a comment - Hi Walter Su , Vinayakumar B and Kihwal Lee , does the same issue exist in branch-2.6 also? If so, we may consider to cherry-pick the fix to branch-2.6?
        Hide
        walter.k.su Walter Su added a comment -

        yes. Uploaded HDFS-9445-branch-2.6_02.patch

        Show
        walter.k.su Walter Su added a comment - yes. Uploaded HDFS-9445 -branch-2.6_02.patch
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 6s HDFS-9445 does not apply to branch-2. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780259/HDFS-9445-branch-2.6_02.patch
        JIRA Issue HDFS-9445
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14015/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 6s HDFS-9445 does not apply to branch-2. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780259/HDFS-9445-branch-2.6_02.patch JIRA Issue HDFS-9445 Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14015/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 4s HDFS-9445 does not apply to branch-2. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780259/HDFS-9445-branch-2.6_02.patch
        JIRA Issue HDFS-9445
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14016/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 4s HDFS-9445 does not apply to branch-2. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780259/HDFS-9445-branch-2.6_02.patch JIRA Issue HDFS-9445 Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14016/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        -1 patch

        Looks like the name of the patch is not in the expected format. Attaching the same patch as branch-2.6_02.patch.

        Show
        ajisakaa Akira Ajisaka added a comment - -1 patch Looks like the name of the patch is not in the expected format. Attaching the same patch as branch-2.6_02.patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 10m 53s branch-2.6 passed
        -1 compile 0m 45s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_66.
        -1 compile 0m 45s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_91.
        +1 checkstyle 0m 20s branch-2.6 passed
        +1 mvnsite 1m 0s branch-2.6 passed
        +1 mvneclipse 0m 20s branch-2.6 passed
        -1 findbugs 2m 55s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 273 extant Findbugs warnings.
        +1 javadoc 1m 8s branch-2.6 passed with JDK v1.8.0_66
        +1 javadoc 1m 51s branch-2.6 passed with JDK v1.7.0_91
        +1 mvninstall 0m 54s the patch passed
        -1 compile 0m 41s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 javac 0m 41s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 compile 0m 43s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        -1 javac 0m 43s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 checkstyle 0m 17s the patch passed
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        -1 whitespace 0m 2s The patch has 2289 line(s) that end in whitespace. Use git apply --whitespace=fix.
        -1 whitespace 0m 55s The patch has 110 line(s) with tabs.
        +1 findbugs 3m 0s the patch passed
        +1 javadoc 1m 8s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 50s the patch passed with JDK v1.7.0_91
        -1 unit 0m 44s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 0m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        -1 asflicense 0m 38s Patch generated 72 ASF License warnings.
        47m 12s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:date2016-01-04
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780274/HDFS-9445-branch-2.6.02.patch
        JIRA Issue HDFS-9445
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ff9a2650f29e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.6 / 0381556
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        findbugs v1.3.9
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/whitespace-tabs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14018/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 70MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14018/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 10m 53s branch-2.6 passed -1 compile 0m 45s hadoop-hdfs in branch-2.6 failed with JDK v1.8.0_66. -1 compile 0m 45s hadoop-hdfs in branch-2.6 failed with JDK v1.7.0_91. +1 checkstyle 0m 20s branch-2.6 passed +1 mvnsite 1m 0s branch-2.6 passed +1 mvneclipse 0m 20s branch-2.6 passed -1 findbugs 2m 55s hadoop-hdfs-project/hadoop-hdfs in branch-2.6 has 273 extant Findbugs warnings. +1 javadoc 1m 8s branch-2.6 passed with JDK v1.8.0_66 +1 javadoc 1m 51s branch-2.6 passed with JDK v1.7.0_91 +1 mvninstall 0m 54s the patch passed -1 compile 0m 41s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 javac 0m 41s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 compile 0m 43s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 javac 0m 43s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 checkstyle 0m 17s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 12s the patch passed -1 whitespace 0m 2s The patch has 2289 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 55s The patch has 110 line(s) with tabs. +1 findbugs 3m 0s the patch passed +1 javadoc 1m 8s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 50s the patch passed with JDK v1.7.0_91 -1 unit 0m 44s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 0m 48s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 38s Patch generated 72 ASF License warnings. 47m 12s Subsystem Report/Notes Docker Image:yetus/hadoop:date2016-01-04 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12780274/HDFS-9445-branch-2.6.02.patch JIRA Issue HDFS-9445 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ff9a2650f29e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6 / 0381556 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 compile https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt findbugs v1.3.9 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html compile https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14018/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14018/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 70MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14018/console This message was automatically generated.
        Hide
        djp Junping Du added a comment -

        I have merge the 2.6 patch to branch-2.6. Thanks Walter Su and Akira Ajisaka for help on this!

        Show
        djp Junping Du added a comment - I have merge the 2.6 patch to branch-2.6. Thanks Walter Su and Akira Ajisaka for help on this!
        Hide
        kihwal Kihwal Lee added a comment -

        The branch build failure might be related to HDFS-8346. We might want to pull that in to branch-2.6 and branch-2.7.

        Show
        kihwal Kihwal Lee added a comment - The branch build failure might be related to HDFS-8346 . We might want to pull that in to branch-2.6 and branch-2.7.
        Hide
        djp Junping Du added a comment -

        Thanks Kihwal Lee for reminding on this. I have ping Chris on HDFS-8346.

        Show
        djp Junping Du added a comment - Thanks Kihwal Lee for reminding on this. I have ping Chris on HDFS-8346 .

          People

          • Assignee:
            walter.k.su Walter Su
            Reporter:
            kihwal Kihwal Lee
          • Votes:
            0 Vote for this issue
            Watchers:
            26 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development