Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9439

Include status of closeAck into exception message in DataNode#run

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      When closeAck.getStatus is not SUCCESS and an IOException is thrown, the status is not included in the message, which makes it harder to investigate.

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9522 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9522/)
        HDFS-9439. Support reconfiguring fs.protected.directories without NN (arp: rev ddfe6774c21c8ccf5582a05bb0b58e961bbec309)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestProtectedDirectories.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9522 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9522/ ) HDFS-9439 . Support reconfiguring fs.protected.directories without NN (arp: rev ddfe6774c21c8ccf5582a05bb0b58e961bbec309) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestProtectedDirectories.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2560 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2560/)
        HDFS-9439. Include status of closeAck into exception message in (yzhang: rev 31dc5c650e3fcfd5b581cbc1132b895d3eadaf49)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2560 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2560/ ) HDFS-9439 . Include status of closeAck into exception message in (yzhang: rev 31dc5c650e3fcfd5b581cbc1132b895d3eadaf49) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #699 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/699/)
        HDFS-9439. Include status of closeAck into exception message in (yzhang: rev 31dc5c650e3fcfd5b581cbc1132b895d3eadaf49)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #699 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/699/ ) HDFS-9439 . Include status of closeAck into exception message in (yzhang: rev 31dc5c650e3fcfd5b581cbc1132b895d3eadaf49) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1425 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1425/)
        HDFS-9439. Include status of closeAck into exception message in (yzhang: rev 31dc5c650e3fcfd5b581cbc1132b895d3eadaf49)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1425 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1425/ ) HDFS-9439 . Include status of closeAck into exception message in (yzhang: rev 31dc5c650e3fcfd5b581cbc1132b895d3eadaf49) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #687 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/687/)
        HDFS-9439. Include status of closeAck into exception message in (yzhang: rev 31dc5c650e3fcfd5b581cbc1132b895d3eadaf49)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #687 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/687/ ) HDFS-9439 . Include status of closeAck into exception message in (yzhang: rev 31dc5c650e3fcfd5b581cbc1132b895d3eadaf49) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #621 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/621/)
        HDFS-9439. Include status of closeAck into exception message in (yzhang: rev 31dc5c650e3fcfd5b581cbc1132b895d3eadaf49)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #621 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/621/ ) HDFS-9439 . Include status of closeAck into exception message in (yzhang: rev 31dc5c650e3fcfd5b581cbc1132b895d3eadaf49) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2628 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2628/)
        HDFS-9439. Include status of closeAck into exception message in (yzhang: rev 31dc5c650e3fcfd5b581cbc1132b895d3eadaf49)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2628 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2628/ ) HDFS-9439 . Include status of closeAck into exception message in (yzhang: rev 31dc5c650e3fcfd5b581cbc1132b895d3eadaf49) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8830 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8830/)
        HDFS-9439. Include status of closeAck into exception message in (yzhang: rev 31dc5c650e3fcfd5b581cbc1132b895d3eadaf49)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8830 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8830/ ) HDFS-9439 . Include status of closeAck into exception message in (yzhang: rev 31dc5c650e3fcfd5b581cbc1132b895d3eadaf49) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks very much Yongjun for the commit.

        Show
        xiaochen Xiao Chen added a comment - Thanks very much Yongjun for the commit.
        Hide
        yzhangal Yongjun Zhang added a comment -

        I committed to trunk and branch-2. Thanks Xiao for the contribution.

        Show
        yzhangal Yongjun Zhang added a comment - I committed to trunk and branch-2. Thanks Xiao for the contribution.
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks Xiao Chen for reporting the issue and the patch, +1. Will commit soon.

        Show
        yzhangal Yongjun Zhang added a comment - Thanks Xiao Chen for reporting the issue and the patch, +1. Will commit soon.
        Hide
        xiaochen Xiao Chen added a comment -

        This is a supportability JIRA so no tests added.
        The unit test failures and asflicense warnings are not introduced by this patch.

        Show
        xiaochen Xiao Chen added a comment - This is a supportability JIRA so no tests added. The unit test failures and asflicense warnings are not introduced by this patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 54s trunk passed
        +1 compile 0m 55s trunk passed with JDK v1.8.0_66
        +1 compile 0m 50s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 20s trunk passed
        +1 mvnsite 1m 3s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 2m 20s trunk passed
        +1 javadoc 1m 26s trunk passed with JDK v1.8.0_66
        +1 javadoc 2m 14s trunk passed with JDK v1.7.0_79
        +1 mvninstall 0m 58s the patch passed
        +1 compile 0m 56s the patch passed with JDK v1.8.0_66
        +1 javac 0m 56s the patch passed
        +1 compile 0m 51s the patch passed with JDK v1.7.0_79
        +1 javac 0m 51s the patch passed
        +1 checkstyle 0m 19s the patch passed
        +1 mvnsite 1m 1s the patch passed
        +1 mvneclipse 0m 17s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 28s the patch passed
        +1 javadoc 1m 26s the patch passed with JDK v1.8.0_66
        +1 javadoc 2m 8s the patch passed with JDK v1.7.0_79
        -1 unit 78m 29s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 77m 41s hadoop-hdfs in the patch failed with JDK v1.7.0_79.
        -1 asflicense 0m 23s Patch generated 56 ASF License warnings.
        188m 57s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestReplaceDatanodeOnFailure
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure100
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.TestAclsEndToEnd
        JDK v1.7.0_79 Failed junit tests hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.server.datanode.TestDirectoryScanner



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:date2015-11-18
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773075/HDFS-9439.001.patch
        JIRA Issue HDFS-9439
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 56a7f52339ab 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
        git revision trunk / bad2afe
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13550/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13550/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13550/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13550/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13550/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13550/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 77MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13550/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 54s trunk passed +1 compile 0m 55s trunk passed with JDK v1.8.0_66 +1 compile 0m 50s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 20s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 2m 20s trunk passed +1 javadoc 1m 26s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 14s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 58s the patch passed +1 compile 0m 56s the patch passed with JDK v1.8.0_66 +1 javac 0m 56s the patch passed +1 compile 0m 51s the patch passed with JDK v1.7.0_79 +1 javac 0m 51s the patch passed +1 checkstyle 0m 19s the patch passed +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 28s the patch passed +1 javadoc 1m 26s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 8s the patch passed with JDK v1.7.0_79 -1 unit 78m 29s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 77m 41s hadoop-hdfs in the patch failed with JDK v1.7.0_79. -1 asflicense 0m 23s Patch generated 56 ASF License warnings. 188m 57s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestReplaceDatanodeOnFailure   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure100   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.TestAclsEndToEnd JDK v1.7.0_79 Failed junit tests hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-18 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773075/HDFS-9439.001.patch JIRA Issue HDFS-9439 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 56a7f52339ab 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision trunk / bad2afe findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13550/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13550/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13550/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13550/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13550/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13550/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13550/console This message was automatically generated.

          People

          • Assignee:
            xiaochen Xiao Chen
            Reporter:
            xiaochen Xiao Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development