Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9415

Document dfs.cluster.administrators and dfs.permissions.superusergroup

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      dfs.cluster.administrators and dfs.permissions.superusergroup documentation is not clear enough.

      1. HDFS-9415.004.patch
        2 kB
        Xiaobing Zhou
      2. HDFS-9415.003.patch
        2 kB
        Xiaobing Zhou
      3. HDFS-9415.002.patch
        2 kB
        Xiaobing Zhou
      4. HDFS-9415.001.patch
        1 kB
        Xiaobing Zhou

        Activity

        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Closing the JIRA as part of 2.7.3 release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9115 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9115/)
        HDFS-9415. Document dfs.cluster.administrators and (arp: rev e97cd4ade5e87f23271c0a29c9f468789efb0202)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9115 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9115/ ) HDFS-9415 . Document dfs.cluster.administrators and (arp: rev e97cd4ade5e87f23271c0a29c9f468789efb0202) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Committed for 2.6.4, 2.7.3 and 2.8.0.

        Thanks for the contribution Xiaobing and the review Daniel.

        Show
        arpitagarwal Arpit Agarwal added a comment - Committed for 2.6.4, 2.7.3 and 2.8.0. Thanks for the contribution Xiaobing and the review Daniel.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 31s trunk passed
        +1 compile 0m 52s trunk passed with JDK v1.8.0_66
        +1 compile 0m 43s trunk passed with JDK v1.7.0_91
        +1 mvnsite 0m 57s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 javadoc 1m 10s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 47s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 47s the patch passed
        +1 compile 0m 49s the patch passed with JDK v1.8.0_66
        +1 javac 0m 49s the patch passed
        +1 compile 0m 42s the patch passed with JDK v1.7.0_91
        +1 javac 0m 42s the patch passed
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 0s The patch has no ill-formed XML file.
        +1 javadoc 1m 15s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 54s the patch passed with JDK v1.7.0_91
        -1 unit 68m 53s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 66m 14s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        158m 25s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          hadoop.hdfs.server.namenode.TestAuditLogs
          hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
          hadoop.hdfs.server.namenode.TestStartup
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.TestFileAppend4
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache
          hadoop.hdfs.TestEncryptionZones
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
          hadoop.hdfs.server.namenode.TestStartup
          hadoop.hdfs.server.namenode.TestNameEditsConfigs



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782333/HDFS-9415.004.patch
        JIRA Issue HDFS-9415
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux 65f4e576eb74 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / b1ed28f
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14126/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14126/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 31s trunk passed +1 compile 0m 52s trunk passed with JDK v1.8.0_66 +1 compile 0m 43s trunk passed with JDK v1.7.0_91 +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 13s trunk passed +1 javadoc 1m 10s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 47s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 47s the patch passed +1 compile 0m 49s the patch passed with JDK v1.8.0_66 +1 javac 0m 49s the patch passed +1 compile 0m 42s the patch passed with JDK v1.7.0_91 +1 javac 0m 42s the patch passed +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 javadoc 1m 15s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 54s the patch passed with JDK v1.7.0_91 -1 unit 68m 53s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 66m 14s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 158m 25s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.namenode.TestAuditLogs   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.server.namenode.TestStartup   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestFileAppend4 JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.server.namenode.TestStartup   hadoop.hdfs.server.namenode.TestNameEditsConfigs Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12782333/HDFS-9415.004.patch JIRA Issue HDFS-9415 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 65f4e576eb74 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b1ed28f Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14126/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14126/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14126/console This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 pending Jenkins.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 pending Jenkins.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Thanks all for review. We should follow the principle of clarity regardless of the confused test cases. I posted V004 with " * " removed.

        Show
        xiaobingo Xiaobing Zhou added a comment - Thanks all for review. We should follow the principle of clarity regardless of the confused test cases. I posted V004 with " * " removed.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        If what you want to say is that trailing spaces are allowed, then say that instead. (It's probably not a bad thing to add in any case.)

        I never talked about trailing spaces. But I see what you are saying now. The Jira font made it easy to miss the surrounding spaces in your comment. I agree it's fair to omit that one.
        Xiaobing Zhou, do you want to post an updated patch that removes the " * " wildcard option?

        Show
        arpitagarwal Arpit Agarwal added a comment - If what you want to say is that trailing spaces are allowed, then say that instead. (It's probably not a bad thing to add in any case.) I never talked about trailing spaces. But I see what you are saying now. The Jira font made it easy to miss the surrounding spaces in your comment. I agree it's fair to omit that one. Xiaobing Zhou , do you want to post an updated patch that removes the " * " wildcard option?
        Hide
        templedf Daniel Templeton added a comment -

        My concern is that we clearly state that the correct format is 'users groups', but then say that ' * ' is also valid, which doesn't follow that format. I don't see how that can improve clarity. If what you want to say is that trailing spaces are allowed, then say that instead. (It's probably not a bad thing to add in any case.)

        I will yield on this one. It's not worth arguing over 7 characters.

        Show
        templedf Daniel Templeton added a comment - My concern is that we clearly state that the correct format is 'users groups', but then say that ' * ' is also valid, which doesn't follow that format. I don't see how that can improve clarity. If what you want to say is that trailing spaces are allowed, then say that instead. (It's probably not a bad thing to add in any case.) I will yield on this one. It's not worth arguing over 7 characters.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Also IME customers routinely skip the trailing space.

            <property>
              <name>dfs.cluster.administrators</name>
              <value>hdfs</value>
            </property>
        

        I plan to commit this patch later today.

        Show
        arpitagarwal Arpit Agarwal added a comment - Also IME customers routinely skip the trailing space. <property> <name>dfs.cluster.administrators</name> <value>hdfs</value> </property> I plan to commit this patch later today.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        The test case does make it explicit that we accept "*" as a valid wildcard. I see no harm in documenting it if we are doing to document the wildcard behavior.

        Show
        arpitagarwal Arpit Agarwal added a comment - The test case does make it explicit that we accept "*" as a valid wildcard. I see no harm in documenting it if we are doing to document the wildcard behavior.
        Hide
        templedf Daniel Templeton added a comment -

        Just because there's a test case, it doesn't mean it's a valid configuration. In the case of ' * ', the string is split on the first space, giving a user of '' and a group of '* '. The group is then trimmed before splitting on comma, giving groups of ['*']. That's a long way to say that ' * ' is a poorly formatted version of ' *' and hence should not be mentioned in the docs.

        Show
        templedf Daniel Templeton added a comment - Just because there's a test case, it doesn't mean it's a valid configuration. In the case of ' * ', the string is split on the first space, giving a user of '' and a group of '* '. The group is then trimmed before splitting on comma, giving groups of ['*']. That's a long way to say that ' * ' is a poorly formatted version of ' *' and hence should not be mentioned in the docs.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Yes, that's valid. There is one test case in TestAccessControlList#testWildCardAccessControlList.

        Show
        xiaobingo Xiaobing Zhou added a comment - Yes, that's valid. There is one test case in TestAccessControlList#testWildCardAccessControlList.
        Hide
        templedf Daniel Templeton added a comment -

        ' * ' is valid? I thought only one space was allowed, or at least specified to be allowed.

        Show
        templedf Daniel Templeton added a comment - ' * ' is valid? I thought only one space was allowed, or at least specified to be allowed.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 22s trunk passed
        +1 compile 0m 39s trunk passed with JDK v1.8.0_66
        +1 compile 0m 41s trunk passed with JDK v1.7.0_91
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 javadoc 1m 5s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 45s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 36s the patch passed with JDK v1.8.0_66
        +1 javac 0m 36s the patch passed
        +1 compile 0m 40s the patch passed with JDK v1.7.0_91
        +1 javac 0m 40s the patch passed
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 42s the patch passed with JDK v1.7.0_91
        -1 unit 52m 3s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 50m 20s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        123m 25s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
          hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.server.namenode.TestStartup
          hadoop.hdfs.TestLeaseRecovery2
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
          hadoop.hdfs.server.namenode.TestStartup



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781952/HDFS-9415.003.patch
        JIRA Issue HDFS-9415
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux ebd994fa4cd6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / fbb5868
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14108/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14108/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14108/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14108/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14108/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14108/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 22s trunk passed +1 compile 0m 39s trunk passed with JDK v1.8.0_66 +1 compile 0m 41s trunk passed with JDK v1.7.0_91 +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 14s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 45s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 46s the patch passed +1 compile 0m 36s the patch passed with JDK v1.8.0_66 +1 javac 0m 36s the patch passed +1 compile 0m 40s the patch passed with JDK v1.7.0_91 +1 javac 0m 40s the patch passed +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 1m 4s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 42s the patch passed with JDK v1.7.0_91 -1 unit 52m 3s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 50m 20s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 123m 25s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.namenode.TestStartup   hadoop.hdfs.TestLeaseRecovery2 JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.server.namenode.TestStartup Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781952/HDFS-9415.003.patch JIRA Issue HDFS-9415 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux ebd994fa4cd6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fbb5868 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14108/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14108/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14108/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14108/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14108/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14108/console This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 pending Jenkins.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 pending Jenkins.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Thanks Arpit Agarwal Daniel Templeton and for review. V003 addressed the comments.

        Show
        xiaobingo Xiaobing Zhou added a comment - Thanks Arpit Agarwal Daniel Templeton and for review. V003 addressed the comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 1s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 9m 59s trunk passed
        +1 compile 1m 9s trunk passed with JDK v1.8.0_66
        +1 compile 0m 55s trunk passed with JDK v1.7.0_91
        +1 mvnsite 1m 9s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 javadoc 1m 38s trunk passed with JDK v1.8.0_66
        +1 javadoc 2m 15s trunk passed with JDK v1.7.0_91
        +1 mvninstall 1m 5s the patch passed
        +1 compile 1m 9s the patch passed with JDK v1.8.0_66
        +1 javac 1m 9s the patch passed
        +1 compile 0m 58s the patch passed with JDK v1.7.0_91
        +1 javac 0m 58s the patch passed
        +1 mvnsite 1m 11s the patch passed
        +1 mvneclipse 0m 17s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 0s The patch has no ill-formed XML file.
        +1 javadoc 1m 39s the patch passed with JDK v1.8.0_66
        +1 javadoc 2m 31s the patch passed with JDK v1.7.0_91
        -1 unit 80m 39s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 71m 16s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 30s Patch does not generate ASF License warnings.
        181m 44s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestDFSClientRetries
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
          hadoop.hdfs.server.datanode.TestBlockScanner
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
          hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad
          hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
          hadoop.hdfs.TestClientReportBadBlock
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestBlockReplacement
          hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
          hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad
          hadoop.hdfs.shortcircuit.TestShortCircuitCache



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779153/HDFS-9415.002.patch
        JIRA Issue HDFS-9415
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux e31676ba7f23 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / df83230
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13981/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13981/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13981/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13981/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13981/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13981/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 1s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 59s trunk passed +1 compile 1m 9s trunk passed with JDK v1.8.0_66 +1 compile 0m 55s trunk passed with JDK v1.7.0_91 +1 mvnsite 1m 9s trunk passed +1 mvneclipse 0m 17s trunk passed +1 javadoc 1m 38s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 15s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 5s the patch passed +1 compile 1m 9s the patch passed with JDK v1.8.0_66 +1 javac 1m 9s the patch passed +1 compile 0m 58s the patch passed with JDK v1.7.0_91 +1 javac 0m 58s the patch passed +1 mvnsite 1m 11s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 javadoc 1m 39s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 31s the patch passed with JDK v1.7.0_91 -1 unit 80m 39s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 71m 16s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 30s Patch does not generate ASF License warnings. 181m 44s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.TestClientReportBadBlock   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.server.blockmanagement.TestReplicationPolicyConsiderLoad   hadoop.hdfs.shortcircuit.TestShortCircuitCache Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779153/HDFS-9415.002.patch JIRA Issue HDFS-9415 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux e31676ba7f23 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / df83230 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13981/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13981/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13981/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13981/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13981/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13981/console This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Thanks for the updated patch Xiaobing Zhou.

        1. I think you can remove this sentence A comma separated list of groups is not allowed. e.g., "supergroup" is good, but "supergroup1,supergroup2" is incorrect. Just stating it should be a single group name is sufficient.
        2. The format are should be the The format is.
        3. You can just convert the numbered list in the dfs.cluster.administrators description to paragraphs. I am not sure the numbered lists will render well when the XML is convered to HTML.
        4. I did not mention the wildcard option for dfs.cluster.administrators as IMO it is best left undocumented. If you choose to include it as Daniel suggests, see AccessControlList#buildACL for the precise behavior of the wildcard.
        Show
        arpitagarwal Arpit Agarwal added a comment - Thanks for the updated patch Xiaobing Zhou . I think you can remove this sentence A comma separated list of groups is not allowed. e.g., "supergroup" is good, but "supergroup1,supergroup2" is incorrect. Just stating it should be a single group name is sufficient. The format are should be the The format is . You can just convert the numbered list in the dfs.cluster.administrators description to paragraphs. I am not sure the numbered lists will render well when the XML is convered to HTML. I did not mention the wildcard option for dfs.cluster.administrators as IMO it is best left undocumented. If you choose to include it as Daniel suggests, see AccessControlList#buildACL for the precise behavior of the wildcard.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        I'm not sure removing the value for dfs.cluster.administrators is the right thing. I think that value is there as intended.

        The setting was commented so I don't think the value was taking effect. Removing it should be a no-op.

        Show
        arpitagarwal Arpit Agarwal added a comment - I'm not sure removing the value for dfs.cluster.administrators is the right thing. I think that value is there as intended. The setting was commented so I don't think the value was taking effect. Removing it should be a no-op.
        Hide
        templedf Daniel Templeton added a comment -

        It should also explain the use of * for dfs.cluster.administrators.

        I'm not sure removing the value for dfs.cluster.administrators is the right thing. I think that value is there as intended.

        Show
        templedf Daniel Templeton added a comment - It should also explain the use of * for dfs.cluster.administrators . I'm not sure removing the value for dfs.cluster.administrators is the right thing. I think that value is there as intended.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Thanks Arpit Agarwal. Posted V002 for review.

        Show
        xiaobingo Xiaobing Zhou added a comment - Thanks Arpit Agarwal . Posted V002 for review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 41s trunk passed
        +1 compile 0m 40s trunk passed with JDK v1.8.0_66
        +1 compile 0m 41s trunk passed with JDK v1.7.0_91
        +1 mvnsite 0m 53s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 javadoc 1m 7s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 48s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 48s the patch passed
        +1 compile 0m 40s the patch passed with JDK v1.8.0_66
        +1 javac 0m 40s the patch passed
        +1 compile 0m 42s the patch passed with JDK v1.7.0_91
        +1 javac 0m 42s the patch passed
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) with tabs.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 1m 6s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 46s the patch passed with JDK v1.7.0_91
        -1 unit 51m 32s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 49m 54s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 28s Patch does not generate ASF License warnings.
        123m 36s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestLeaseRecovery2
          hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
          hadoop.hdfs.server.namenode.TestSaveNamespace



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779113/HDFS-9415.001.patch
        JIRA Issue HDFS-9415
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux b165722cf771 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5c0ff69
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13978/artifact/patchprocess/whitespace-tabs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13978/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13978/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13978/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13978/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13978/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13978/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 41s trunk passed +1 compile 0m 40s trunk passed with JDK v1.8.0_66 +1 compile 0m 41s trunk passed with JDK v1.7.0_91 +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 14s trunk passed +1 javadoc 1m 7s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 48s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 48s the patch passed +1 compile 0m 40s the patch passed with JDK v1.8.0_66 +1 javac 0m 40s the patch passed +1 compile 0m 42s the patch passed with JDK v1.7.0_91 +1 javac 0m 42s the patch passed +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) with tabs. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 1m 6s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 46s the patch passed with JDK v1.7.0_91 -1 unit 51m 32s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 49m 54s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 28s Patch does not generate ASF License warnings. 123m 36s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestLeaseRecovery2   hadoop.hdfs.server.namenode.TestNNThroughputBenchmark JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNNThroughputBenchmark   hadoop.hdfs.server.namenode.TestSaveNamespace Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779113/HDFS-9415.001.patch JIRA Issue HDFS-9415 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux b165722cf771 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5c0ff69 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13978/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13978/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13978/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13978/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13978/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13978/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13978/console This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Thanks Xiaobing Zhou. We should document the format of this setting with examples. AccessControlList.java has a good description that we can reuse.

           * The String is a a comma separated list of users and groups.
           * The user list comes first and is separated by a space followed 
           * by the group list. For e.g. "user1,user2 group1,group2"
        

        We can add that both users and groups are optional. So "user1", " group1", "", "user1 group1", "user1,user2 group1,group2" are all valid (note the leading space in " group1").

        Also for dfs.permissions.supergroup, we should document that it accepts a single group name as the value. I have seen some administrators try to incorrectly configure this as a comma separated list of groups.

        Show
        arpitagarwal Arpit Agarwal added a comment - Thanks Xiaobing Zhou . We should document the format of this setting with examples. AccessControlList.java has a good description that we can reuse. * The String is a a comma separated list of users and groups. * The user list comes first and is separated by a space followed * by the group list. For e.g. "user1,user2 group1,group2" We can add that both users and groups are optional. So "user1", " group1", "", "user1 group1", "user1,user2 group1,group2" are all valid (note the leading space in " group1"). Also for dfs.permissions.supergroup , we should document that it accepts a single group name as the value. I have seen some administrators try to incorrectly configure this as a comma separated list of groups.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Posted patch V001, kindly review!

        Show
        xiaobingo Xiaobing Zhou added a comment - Posted patch V001, kindly review!

          People

          • Assignee:
            xiaobingo Xiaobing Zhou
            Reporter:
            arpitagarwal Arpit Agarwal
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development