Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9406

FSImage may get corrupted after deleting snapshot

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
      None
    • Environment:

      CentOS 6 amd64, CDH 5.4.4-1
      2xCPU: Intel(R) Xeon(R) CPU E5-2640 v3
      Memory: 32GB
      Namenode blocks: ~700_000 blocks, no HA setup

    • Hadoop Flags:
      Reviewed

      Description

      FSImage corruption happened after HDFS snapshots were taken. Cluster was not used
      at that time.

      When namenode restarts it reported NULL pointer exception:

      15/11/07 10:01:15 INFO namenode.FileJournalManager: Recovering unfinalized segments in /tmp/fsimage_checker_5857/fsimage/current
      15/11/07 10:01:15 INFO namenode.FSImage: No edit log streams selected.
      15/11/07 10:01:18 INFO namenode.FSImageFormatPBINode: Loading 1370277 INodes.
      15/11/07 10:01:27 ERROR namenode.NameNode: Failed to start namenode.
      java.lang.NullPointerException
              at org.apache.hadoop.hdfs.server.namenode.INodeDirectory.addChild(INodeDirectory.java:531)
              at org.apache.hadoop.hdfs.server.namenode.FSImageFormatPBINode$Loader.addToParent(FSImageFormatPBINode.java:252)
              at org.apache.hadoop.hdfs.server.namenode.FSImageFormatPBINode$Loader.loadINodeDirectorySection(FSImageFormatPBINode.java:202)
              at org.apache.hadoop.hdfs.server.namenode.FSImageFormatProtobuf$Loader.loadInternal(FSImageFormatProtobuf.java:261)
              at org.apache.hadoop.hdfs.server.namenode.FSImageFormatProtobuf$Loader.load(FSImageFormatProtobuf.java:180)
              at org.apache.hadoop.hdfs.server.namenode.FSImageFormat$LoaderDelegator.load(FSImageFormat.java:226)
              at org.apache.hadoop.hdfs.server.namenode.FSImage.loadFSImage(FSImage.java:929)
              at org.apache.hadoop.hdfs.server.namenode.FSImage.loadFSImage(FSImage.java:913)
              at org.apache.hadoop.hdfs.server.namenode.FSImage.loadFSImageFile(FSImage.java:732)
              at org.apache.hadoop.hdfs.server.namenode.FSImage.loadFSImage(FSImage.java:668)
              at org.apache.hadoop.hdfs.server.namenode.FSImage.recoverTransitionRead(FSImage.java:281)
              at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.loadFSImage(FSNamesystem.java:1061)
              at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.loadFromDisk(FSNamesystem.java:765)
              at org.apache.hadoop.hdfs.server.namenode.NameNode.loadNamesystem(NameNode.java:584)
              at org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(NameNode.java:643)
              at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:810)
              at org.apache.hadoop.hdfs.server.namenode.NameNode.<init>(NameNode.java:794)
              at org.apache.hadoop.hdfs.server.namenode.NameNode.createNameNode(NameNode.java:1487)
              at org.apache.hadoop.hdfs.server.namenode.NameNode.main(NameNode.java:1553)
      15/11/07 10:01:27 INFO util.ExitUtil: Exiting with status 1
      

      Corruption happened after "07.11.2015 00:15", and after that time blocks ~9300 blocks were invalidated that shouldn't be.
      After recovering FSimage I discovered that around ~9300 blocks were missing.

      I also attached log of namenode before and after corruption happened.

      1. HDFS-9406.001.patch
        5 kB
        Yongjun Zhang
      2. HDFS-9406.002.patch
        5 kB
        Yongjun Zhang
      3. HDFS-9406.003.patch
        8 kB
        Yongjun Zhang
      4. HDFS-9406.branch-2.7.patch
        8 kB
        Yongjun Zhang

        Issue Links

          Activity

          Hide
          yzhangal Yongjun Zhang added a comment -

          HI Stanislav Antic,

          Thanks for reporting the issue. Do you have an older fsimage that can be loaded successfully and all the edit logs on top of that good fsimage that we can replay to reproduce the corrupted fsimage? It'd be great if you do. Thanks.

          .

          Show
          yzhangal Yongjun Zhang added a comment - HI Stanislav Antic , Thanks for reporting the issue. Do you have an older fsimage that can be loaded successfully and all the edit logs on top of that good fsimage that we can replay to reproduce the corrupted fsimage? It'd be great if you do. Thanks. .
          Hide
          stanislav.antic@gmail.com Stanislav Antic added a comment -

          Hi Yongjun Zhang,
          I see how this would be great for debugging, but I don't have it. For now I only have corrupted fsimage, I will make cron, if this happen again so we could have edits + OK image.

          Show
          stanislav.antic@gmail.com Stanislav Antic added a comment - Hi Yongjun Zhang , I see how this would be great for debugging, but I don't have it. For now I only have corrupted fsimage, I will make cron, if this happen again so we could have edits + OK image.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks much Stanislav Antic, I will pick it from there when you get OK fsimge + edit logs.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks much Stanislav Antic , I will pick it from there when you get OK fsimge + edit logs.
          Hide
          jingzhao Jing Zhao added a comment -

          Thanks for reporting the issue, Stanislav Antic. The corrupted fsimage should also be useful for debugging. Could you please share the image if possible?

          Show
          jingzhao Jing Zhao added a comment - Thanks for reporting the issue, Stanislav Antic . The corrupted fsimage should also be useful for debugging. Could you please share the image if possible?
          Hide
          kihwal Kihwal Lee added a comment -

          HDFS-9696 might be related.

          Show
          kihwal Kihwal Lee added a comment - HDFS-9696 might be related.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks Kihwal Lee and Jing Zhao.

          Hi Jing,

          I have got a set of data from Stanislav Antic at our private channel, the issue can be reproduced with this set of data (Thanks Stanislav a million for that!). I have been debugging and had good understanding. I will talk with you and Stanislav privately about the data.

          While I tried to create a small testcase to reproduce the symptom here, I was not quite successful. However, I was able to create HDFS-9697 and have a proposed solution (not published yet). My study showed that HDFS-9406 has similar cause as HDFS-9697 but not exactly the same. I'm digging it a bit further, I might need help from you guys at some point.

          Thanks much.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks Kihwal Lee and Jing Zhao . Hi Jing, I have got a set of data from Stanislav Antic at our private channel, the issue can be reproduced with this set of data (Thanks Stanislav a million for that!). I have been debugging and had good understanding. I will talk with you and Stanislav privately about the data. While I tried to create a small testcase to reproduce the symptom here, I was not quite successful. However, I was able to create HDFS-9697 and have a proposed solution (not published yet). My study showed that HDFS-9406 has similar cause as HDFS-9697 but not exactly the same. I'm digging it a bit further, I might need help from you guys at some point. Thanks much.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Hi Guys,

          I just uploaded a prototype patch to address this issue and the one reported in HDFS-9697. I will add test code soon.

          Thanks Stanislav again for the test data. The sequence of events I found the in the data that trigger the issue is roughly:

          1. snapshot s0 is taken
          2. file A is created at dir X
          3. file A is moved from dir X to dir Y
          4. snapshot s1 is taken
          5. Y is deleted with trash enabled, thus Y is moved to trash which is not snapshottable dir
          6. snapshot s2 is taken
          7. Y is deleted when cleaning trash
          8. delete snapshot s1 which is the last snapshot that has file A (and A is already deleted from current state)

          Unfortunately I did not manage to create a small testcase that reproduce the symptom. So I used Stanislav's data to see the problem and verify the fix.

          The issue I found was, when deleting a snapshot which is the last one that contains a given INode, the current implementation fails to clean up:

          1. the create list of the snapshot diff in the snapshot prior to the snapshot to be deleted
          2. the parent INodeDirectory's children list.

          The prototype I did does two condition checking and do the cleaning accordingly:

          1. check the reference count of a child to be removed, if it's a reference and has a reference count 1
          2. check if a child of current INodeDirectory is in the removedINodes, if so, remove it from the children list of current INodeDirectory. This part needs some optimization since removedINodes may be a long list of INodes that are not the children of the current INode.

          Though I'm trying to solve these two jiras together here, I will update a testcase scenario I found that can reproduce HDFS-9697 there.

          Hi Jing Zhao and Tsz Wo Nicholas Sze,

          Would you please help review this prototype patch and share your thoughts?

          Thanks a lot.

          Show
          yzhangal Yongjun Zhang added a comment - Hi Guys, I just uploaded a prototype patch to address this issue and the one reported in HDFS-9697 . I will add test code soon. Thanks Stanislav again for the test data. The sequence of events I found the in the data that trigger the issue is roughly: snapshot s0 is taken file A is created at dir X file A is moved from dir X to dir Y snapshot s1 is taken Y is deleted with trash enabled, thus Y is moved to trash which is not snapshottable dir snapshot s2 is taken Y is deleted when cleaning trash delete snapshot s1 which is the last snapshot that has file A (and A is already deleted from current state) Unfortunately I did not manage to create a small testcase that reproduce the symptom. So I used Stanislav's data to see the problem and verify the fix. The issue I found was, when deleting a snapshot which is the last one that contains a given INode, the current implementation fails to clean up: the create list of the snapshot diff in the snapshot prior to the snapshot to be deleted the parent INodeDirectory's children list. The prototype I did does two condition checking and do the cleaning accordingly: check the reference count of a child to be removed, if it's a reference and has a reference count 1 check if a child of current INodeDirectory is in the removedINodes , if so, remove it from the children list of current INodeDirectory. This part needs some optimization since removedINodes may be a long list of INodes that are not the children of the current INode. Though I'm trying to solve these two jiras together here, I will update a testcase scenario I found that can reproduce HDFS-9697 there. Hi Jing Zhao and Tsz Wo Nicholas Sze , Would you please help review this prototype patch and share your thoughts? Thanks a lot.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 10m 49s trunk passed
          +1 compile 1m 25s trunk passed with JDK v1.8.0_66
          +1 compile 1m 3s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 33s trunk passed
          +1 mvnsite 1m 23s trunk passed
          +1 mvneclipse 0m 20s trunk passed
          +1 findbugs 2m 52s trunk passed
          +1 javadoc 1m 50s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 51s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 13s the patch passed
          +1 compile 1m 28s the patch passed with JDK v1.8.0_66
          +1 javac 1m 28s the patch passed
          +1 compile 1m 5s the patch passed with JDK v1.7.0_91
          +1 javac 1m 5s the patch passed
          -1 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 79 unchanged - 0 fixed = 80 total (was 79)
          +1 mvnsite 1m 18s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 3m 6s the patch passed
          +1 javadoc 1m 48s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 57s the patch passed with JDK v1.7.0_91
          -1 unit 99m 52s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 89m 12s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 28s Patch does not generate ASF License warnings.
          230m 16s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.TestRecoverStripedFile
            hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.security.TestDelegationTokenForProxyUser



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784854/HDFS-9406.001.patch
          JIRA Issue HDFS-9406
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 09dcd4498c69 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 662e17b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14277/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14277/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14277/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14277/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14277/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14277/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14277/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14277/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 10m 49s trunk passed +1 compile 1m 25s trunk passed with JDK v1.8.0_66 +1 compile 1m 3s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 33s trunk passed +1 mvnsite 1m 23s trunk passed +1 mvneclipse 0m 20s trunk passed +1 findbugs 2m 52s trunk passed +1 javadoc 1m 50s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 51s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 13s the patch passed +1 compile 1m 28s the patch passed with JDK v1.8.0_66 +1 javac 1m 28s the patch passed +1 compile 1m 5s the patch passed with JDK v1.7.0_91 +1 javac 1m 5s the patch passed -1 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 79 unchanged - 0 fixed = 80 total (was 79) +1 mvnsite 1m 18s the patch passed +1 mvneclipse 0m 17s the patch passed -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 3m 6s the patch passed +1 javadoc 1m 48s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 57s the patch passed with JDK v1.7.0_91 -1 unit 99m 52s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 89m 12s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 28s Patch does not generate ASF License warnings. 230m 16s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.security.TestDelegationTokenForProxyUser JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.security.TestDelegationTokenForProxyUser Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784854/HDFS-9406.001.patch JIRA Issue HDFS-9406 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 09dcd4498c69 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 662e17b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14277/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14277/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14277/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14277/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14277/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14277/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14277/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14277/console This message was automatically generated.
          Hide
          jingzhao Jing Zhao added a comment -

          Thanks a lot for digging into the issue and providing fix, Yongjun Zhang!

          I used your test case and could confirm your analysis: the file A is still inside its parent's children list and created list of s0. Although this test case cannot reproduce fsimage corruption, we should definitely fix it. Currently I think the bug is here:

          DirectoryWithSnapshot#cleanDeletedINode
                if (topNode instanceof INodeReference.WithName) {
                  INodeReference.WithName wn = (INodeReference.WithName) topNode;
                  if (wn.getLastSnapshotId() >= post) {
                    wn.cleanSubtree(reclaimContext, post, prior);
                  }
          

          cleanDeletedINode aims to delete files that were created after the prior snapshot (e.g., s0 in the above example) and deleted after the post snapshot (e.g., s1). Thus the above file A should be cleaned here. But for a renamed file/directory, normally if the dstref node still exists, we should not treated it as a deleted one, thus in the above code we call the cleanSubtree function to go through its subtree and delete the post snapshot.

          However, if the WithName node is the last in the rename list and the DstRef node has already been deleted (i.e., the above failure case), we should fall back to the normal case and still clean the created list of the prior snapshot. The fix can be:

          diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/DirectoryWithSnapshotFeature.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/DirectoryWithSnapshotFeature.java
          index 5c5b259..45dd6ee 100644
          --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/DirectoryWithSnapshotFeature.java
          +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/DirectoryWithSnapshotFeature.java
          @@ -452,7 +452,15 @@ private static void cleanDeletedINode(INode.ReclaimContext reclaimContext,
                 if (topNode instanceof INodeReference.WithName) {
                   INodeReference.WithName wn = (INodeReference.WithName) topNode;
                   if (wn.getLastSnapshotId() >= post) {
          -          wn.cleanSubtree(reclaimContext, post, prior);
          +          INodeReference.WithCount wc = (INodeReference.WithCount) wn.getReferredINode();
          +          if (wc.getLastWithName() == wn && wc.getParentReference() == null) {
          +            // this wn is the last wn inside of the wc, also the dstRef node has
          +            // been deleted. In this case, we should treat the referred file/dir
          +            // as normal case
          +            queue.add(wc.getReferredINode());
          +          } else {
          +            wn.cleanSubtree(reclaimContext, post, prior);
          +          }
                   }
                   // For DstReference node, since the node is not in the created list of
                   // prior, we should treat it as regular file/dir
          

          In my local test this fix can clean the file A for the above example. Could you please see if the fix makes sense to you, Yongjun?

          Show
          jingzhao Jing Zhao added a comment - Thanks a lot for digging into the issue and providing fix, Yongjun Zhang ! I used your test case and could confirm your analysis: the file A is still inside its parent's children list and created list of s0. Although this test case cannot reproduce fsimage corruption, we should definitely fix it. Currently I think the bug is here: DirectoryWithSnapshot#cleanDeletedINode if (topNode instanceof INodeReference.WithName) { INodeReference.WithName wn = (INodeReference.WithName) topNode; if (wn.getLastSnapshotId() >= post) { wn.cleanSubtree(reclaimContext, post, prior); } cleanDeletedINode aims to delete files that were created after the prior snapshot (e.g., s0 in the above example) and deleted after the post snapshot (e.g., s1). Thus the above file A should be cleaned here. But for a renamed file/directory, normally if the dstref node still exists, we should not treated it as a deleted one, thus in the above code we call the cleanSubtree function to go through its subtree and delete the post snapshot. However, if the WithName node is the last in the rename list and the DstRef node has already been deleted (i.e., the above failure case), we should fall back to the normal case and still clean the created list of the prior snapshot. The fix can be: diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/DirectoryWithSnapshotFeature.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/DirectoryWithSnapshotFeature.java index 5c5b259..45dd6ee 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/DirectoryWithSnapshotFeature.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/DirectoryWithSnapshotFeature.java @@ -452,7 +452,15 @@ private static void cleanDeletedINode(INode.ReclaimContext reclaimContext, if (topNode instanceof INodeReference.WithName) { INodeReference.WithName wn = (INodeReference.WithName) topNode; if (wn.getLastSnapshotId() >= post) { - wn.cleanSubtree(reclaimContext, post, prior); + INodeReference.WithCount wc = (INodeReference.WithCount) wn.getReferredINode(); + if (wc.getLastWithName() == wn && wc.getParentReference() == null ) { + // this wn is the last wn inside of the wc, also the dstRef node has + // been deleted. In this case , we should treat the referred file/dir + // as normal case + queue.add(wc.getReferredINode()); + } else { + wn.cleanSubtree(reclaimContext, post, prior); + } } // For DstReference node, since the node is not in the created list of // prior, we should treat it as regular file/dir In my local test this fix can clean the file A for the above example. Could you please see if the fix makes sense to you, Yongjun?
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks a lot for looking into and your feedback Jing Zhao! I will try it out and get back.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks a lot for looking into and your feedback Jing Zhao ! I will try it out and get back.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Very nice Jing Zhao, I verified that the change you suggested works for both HDFS-9406 and HDFS-9697 cases, on top of the CDH release I have been using to investigate this problem.

          Wonder if have insight on why the sequence I have doesn't reproduce the fsimage corruption, I hope we can have a sequence that can reproduce so we can put into a unit test.

          BTW, I think it's possible that this fix also resolve HDFS-9696.

          Thank you so much!

          Show
          yzhangal Yongjun Zhang added a comment - Very nice Jing Zhao , I verified that the change you suggested works for both HDFS-9406 and HDFS-9697 cases, on top of the CDH release I have been using to investigate this problem. Wonder if have insight on why the sequence I have doesn't reproduce the fsimage corruption, I hope we can have a sequence that can reproduce so we can put into a unit test. BTW, I think it's possible that this fix also resolve HDFS-9696 . Thank you so much!
          Hide
          yzhangal Yongjun Zhang added a comment -

          Uploaded patch rev 002 to incorporate the change Jing Zhao suggested and the test code Vinayakumar B put together for HDFS-9697.

          Hi Jing and Vinayakumar,

          Would you please help taking a look at rev 002? Though we don't have a sequence that reproduce the exact symptom reported in HDFS-9406, but I did verify the change with the real case Stanislav Antic.

          Thanks much.

          Show
          yzhangal Yongjun Zhang added a comment - Uploaded patch rev 002 to incorporate the change Jing Zhao suggested and the test code Vinayakumar B put together for HDFS-9697 . Hi Jing and Vinayakumar, Would you please help taking a look at rev 002? Though we don't have a sequence that reproduce the exact symptom reported in HDFS-9406 , but I did verify the change with the real case Stanislav Antic . Thanks much.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 10m 50s trunk passed
          +1 compile 1m 29s trunk passed with JDK v1.8.0_66
          +1 compile 1m 7s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 31s trunk passed
          +1 mvnsite 1m 22s trunk passed
          +1 mvneclipse 0m 20s trunk passed
          +1 findbugs 2m 52s trunk passed
          +1 javadoc 1m 59s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 57s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 11s the patch passed
          +1 compile 1m 22s the patch passed with JDK v1.8.0_66
          +1 javac 1m 22s the patch passed
          +1 compile 1m 5s the patch passed with JDK v1.7.0_91
          +1 javac 1m 5s the patch passed
          +1 checkstyle 0m 29s the patch passed
          +1 mvnsite 1m 16s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 12s the patch passed
          +1 javadoc 1m 52s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 53s the patch passed with JDK v1.7.0_91
          -1 unit 107m 9s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 104m 5s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 45s Patch does not generate ASF License warnings.
          253m 36s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.qjournal.TestSecureNNWithQJM
            hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
            hadoop.hdfs.server.namenode.TestINodeFile
            hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDatanodeRegistration
            hadoop.hdfs.server.datanode.TestTriggerBlockReport
            hadoop.hdfs.server.namenode.TestINodeFile
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.server.namenode.TestNameNodeMXBean
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
          JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785119/HDFS-9406.002.patch
          JIRA Issue HDFS-9406
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e6c533a87698 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a277bdc
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14288/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14288/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14288/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14288/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14288/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14288/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 10m 50s trunk passed +1 compile 1m 29s trunk passed with JDK v1.8.0_66 +1 compile 1m 7s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 31s trunk passed +1 mvnsite 1m 22s trunk passed +1 mvneclipse 0m 20s trunk passed +1 findbugs 2m 52s trunk passed +1 javadoc 1m 59s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 57s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 11s the patch passed +1 compile 1m 22s the patch passed with JDK v1.8.0_66 +1 javac 1m 22s the patch passed +1 compile 1m 5s the patch passed with JDK v1.7.0_91 +1 javac 1m 5s the patch passed +1 checkstyle 0m 29s the patch passed +1 mvnsite 1m 16s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 12s the patch passed +1 javadoc 1m 52s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 53s the patch passed with JDK v1.7.0_91 -1 unit 107m 9s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 104m 5s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 45s Patch does not generate ASF License warnings. 253m 36s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.qjournal.TestSecureNNWithQJM   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.server.namenode.TestINodeFile   hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.security.TestDelegationTokenForProxyUser JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 JDK v1.7.0_91 Failed junit tests hadoop.hdfs.TestDatanodeRegistration   hadoop.hdfs.server.datanode.TestTriggerBlockReport   hadoop.hdfs.server.namenode.TestINodeFile   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.namenode.TestNameNodeMXBean   hadoop.hdfs.security.TestDelegationTokenForProxyUser JDK v1.7.0_91 Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785119/HDFS-9406.002.patch JIRA Issue HDFS-9406 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e6c533a87698 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a277bdc Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14288/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14288/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14288/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14288/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14288/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14288/console This message was automatically generated.
          Hide
          jingzhao Jing Zhao added a comment -

          Thanks for the patch, Yongjun! The patch looks good to me. But looks like we need to fix TestINodeFile#testClearBlocks because of the new clearBlocks logic.

          In the meanwhile, can we also add a test for the case you mentioned in this jira? Although this one may not cause fsimage corruption, but we can check if the file has finally been deleted from the inodeMap.

            @Test
            public void testRenameAndDelete() throws IOException {
              final Path foo = new Path("/foo");
              final Path x = new Path(foo, "x");
              final Path y = new Path(foo, "y");
              final Path trash = new Path("/trash");
              fs.mkdirs(x);
              fs.mkdirs(y);
              fs.mkdirs(trash);
              fs.allowSnapshot(foo);
              // 1. create snapshot s0
              fs.createSnapshot(foo, "s0");
              // 2. create file /foo/x/bar
              final Path file = new Path(x, "bar");
              DFSTestUtil.createFile(fs, file, BLOCKSIZE, (short) 1, 0L);
              final long fileId = fsdir.getINode4Write(file.toString()).getId();
              // 3. move file into /foo/y
              final Path newFile = new Path(y, "bar");
              fs.rename(file, newFile);
              // 4. create snapshot s1
              fs.createSnapshot(foo, "s1");
              // 5. move /foo/y to /trash
              final Path deletedY = new Path(trash, "y");
              fs.rename(y, deletedY);
              // 6. create snapshot s2
              fs.createSnapshot(foo, "s2");
              // 7. delete /trash/y
              fs.delete(deletedY, true);
              // 8. delete snapshot s1
              fs.deleteSnapshot(foo, "s1");
              // make sure bar has been cleaned
              Assert.assertNull(fsdir.getInode(fileId));
            }
          
          Show
          jingzhao Jing Zhao added a comment - Thanks for the patch, Yongjun! The patch looks good to me. But looks like we need to fix TestINodeFile#testClearBlocks because of the new clearBlocks logic. In the meanwhile, can we also add a test for the case you mentioned in this jira? Although this one may not cause fsimage corruption, but we can check if the file has finally been deleted from the inodeMap. @Test public void testRenameAndDelete() throws IOException { final Path foo = new Path( "/foo" ); final Path x = new Path(foo, "x" ); final Path y = new Path(foo, "y" ); final Path trash = new Path( "/trash" ); fs.mkdirs(x); fs.mkdirs(y); fs.mkdirs(trash); fs.allowSnapshot(foo); // 1. create snapshot s0 fs.createSnapshot(foo, "s0" ); // 2. create file /foo/x/bar final Path file = new Path(x, "bar" ); DFSTestUtil.createFile(fs, file, BLOCKSIZE, ( short ) 1, 0L); final long fileId = fsdir.getINode4Write(file.toString()).getId(); // 3. move file into /foo/y final Path newFile = new Path(y, "bar" ); fs.rename(file, newFile); // 4. create snapshot s1 fs.createSnapshot(foo, "s1" ); // 5. move /foo/y to /trash final Path deletedY = new Path(trash, "y" ); fs.rename(y, deletedY); // 6. create snapshot s2 fs.createSnapshot(foo, "s2" ); // 7. delete /trash/y fs.delete(deletedY, true ); // 8. delete snapshot s1 fs.deleteSnapshot(foo, "s1" ); // make sure bar has been cleaned Assert.assertNull(fsdir.getInode(fileId)); }
          Hide
          yzhangal Yongjun Zhang added a comment -

          Many thanks Jing Zhao.

          The testcase I saw is not that the INode is actually removed from the InodeMap, however, it's not removed from the children list of the parent INodeDirectory. I poked more today trying to see if I can create a testcase to reproduce the original symptom, still did not.succeed.

          I agree with you adding a testcase would help. On top of the test code you put, I added the part to ensure that a deleted child is not only removed from InodeMap but also from the children list of its parent, and uploaded rev 003. Would you please take a look to see if it makes sense to you?

          I ran all the failed tests locally and they are successful, except TestINodeFile as you pointed out. I fixed it in this patch.

          Thanks.

          Show
          yzhangal Yongjun Zhang added a comment - Many thanks Jing Zhao . The testcase I saw is not that the INode is actually removed from the InodeMap, however, it's not removed from the children list of the parent INodeDirectory. I poked more today trying to see if I can create a testcase to reproduce the original symptom, still did not.succeed. I agree with you adding a testcase would help. On top of the test code you put, I added the part to ensure that a deleted child is not only removed from InodeMap but also from the children list of its parent, and uploaded rev 003. Would you please take a look to see if it makes sense to you? I ran all the failed tests locally and they are successful, except TestINodeFile as you pointed out. I fixed it in this patch. Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 50s trunk passed
          +1 compile 1m 5s trunk passed with JDK v1.8.0_66
          +1 compile 0m 53s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 1m 7s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 2m 18s trunk passed
          +1 javadoc 1m 24s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 8s trunk passed with JDK v1.7.0_91
          +1 mvninstall 0m 59s the patch passed
          +1 compile 1m 6s the patch passed with JDK v1.8.0_66
          +1 javac 1m 6s the patch passed
          +1 compile 0m 52s the patch passed with JDK v1.7.0_91
          +1 javac 0m 52s the patch passed
          +1 checkstyle 0m 22s the patch passed
          +1 mvnsite 1m 4s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 38s the patch passed
          +1 javadoc 1m 26s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 11s the patch passed with JDK v1.7.0_91
          -1 unit 75m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 65m 53s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          174m 17s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.TestRollingUpgrade
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache
            hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
            hadoop.hdfs.server.namenode.TestRecoverStripedBlocks



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785332/HDFS-9406.003.patch
          JIRA Issue HDFS-9406
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e6a86b3e8a39 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 772ea7b
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14300/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14300/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 50s trunk passed +1 compile 1m 5s trunk passed with JDK v1.8.0_66 +1 compile 0m 53s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 18s trunk passed +1 javadoc 1m 24s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 8s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 59s the patch passed +1 compile 1m 6s the patch passed with JDK v1.8.0_66 +1 javac 1m 6s the patch passed +1 compile 0m 52s the patch passed with JDK v1.7.0_91 +1 javac 0m 52s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 38s the patch passed +1 javadoc 1m 26s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 11s the patch passed with JDK v1.7.0_91 -1 unit 75m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 65m 53s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 174m 17s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider JDK v1.7.0_91 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.namenode.TestRecoverStripedBlocks Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785332/HDFS-9406.003.patch JIRA Issue HDFS-9406 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e6a86b3e8a39 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 772ea7b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14300/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14300/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14300/console This message was automatically generated.
          Hide
          jingzhao Jing Zhao added a comment -

          Thanks for updating the patch, Yongjun Zhang! The latest patch looks good to me. +1

          Show
          jingzhao Jing Zhao added a comment - Thanks for updating the patch, Yongjun Zhang ! The latest patch looks good to me. +1
          Hide
          yzhangal Yongjun Zhang added a comment -

          Many thanks Jing Zhao!

          Will commit tomorrow. I was thinking about trunk, branch-2, branch-2.8, branch-2.7, branch-2.6. If you think differently, please let me know.

          Show
          yzhangal Yongjun Zhang added a comment - Many thanks Jing Zhao ! Will commit tomorrow. I was thinking about trunk, branch-2, branch-2.8, branch-2.7, branch-2.6. If you think differently, please let me know.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Hi Jing Zhao,

          I committed to trunk, branch-2, branch-2.8. Uploaded a patch for branch-2.7 for review just in case I missed anything. Would you please help taking a quick look? I will commit to branch-2.7 after your review.

          BTW, I saw some additional conflicts when trying to backport to branch-2.6. I decided to stop there in case backporting additional stuff there would disturb the stability.

          Thanks a lot.

          Show
          yzhangal Yongjun Zhang added a comment - Hi Jing Zhao , I committed to trunk, branch-2, branch-2.8. Uploaded a patch for branch-2.7 for review just in case I missed anything. Would you please help taking a quick look? I will commit to branch-2.7 after your review. BTW, I saw some additional conflicts when trying to backport to branch-2.6. I decided to stop there in case backporting additional stuff there would disturb the stability. Thanks a lot.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9218 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9218/)
          HDFS-9406. FSImage may get corrupted after deleting snapshot. (yzhang: rev 34ab50ea92370cc7440a8f7649286b148c2fde65)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotDeletion.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeReference.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestINodeFile.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/DirectoryWithSnapshotFeature.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9218 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9218/ ) HDFS-9406 . FSImage may get corrupted after deleting snapshot. (yzhang: rev 34ab50ea92370cc7440a8f7649286b148c2fde65) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotDeletion.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeReference.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestINodeFile.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/DirectoryWithSnapshotFeature.java
          Hide
          jingzhao Jing Zhao added a comment -

          Thanks a lot Yongjun! The 2.7 patch looks good to me. +1.

          Shall we also resolve HDFS-9697 and HDFS-9696 as duplicate?

          Show
          jingzhao Jing Zhao added a comment - Thanks a lot Yongjun! The 2.7 patch looks good to me. +1. Shall we also resolve HDFS-9697 and HDFS-9696 as duplicate?
          Hide
          yzhangal Yongjun Zhang added a comment -

          Thanks Jing! Yes, I planned to do so after committing. Am doing it shortly.

          Show
          yzhangal Yongjun Zhang added a comment - Thanks Jing! Yes, I planned to do so after committing. Am doing it shortly.
          Hide
          yzhangal Yongjun Zhang added a comment - - edited

          Committed to trunk, branch-2, branch-2.8, branch-2.7.

          commit 34ab50ea92370cc7440a8f7649286b148c2fde65
          Date: Mon Feb 1 11:23:44 2016 -0800

          HDFS-9406. FSImage may get corrupted after deleting snapshot. (Contributed by Jing Zhao, Stanislav Antic, Vinayakumar B, Yongjun Zhang)

          Many thanks to Stanislav Antic, Jing Zhao, and Vinayakumar B for the contribution, really nice community work!

          Show
          yzhangal Yongjun Zhang added a comment - - edited Committed to trunk, branch-2, branch-2.8, branch-2.7. commit 34ab50ea92370cc7440a8f7649286b148c2fde65 Date: Mon Feb 1 11:23:44 2016 -0800 HDFS-9406 . FSImage may get corrupted after deleting snapshot. (Contributed by Jing Zhao, Stanislav Antic, Vinayakumar B, Yongjun Zhang) Many thanks to Stanislav Antic , Jing Zhao , and Vinayakumar B for the contribution, really nice community work!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          -1 mvndep 0m 22s branch's hadoop-hdfs-project/hadoop-hdfs dependency:list failed
          0 mvndep 0m 22s Maven dependency ordering for branch
          -1 mvninstall 1m 18s root in branch-2.7 failed.
          -1 compile 0m 7s hadoop-hdfs in branch-2.7 failed with JDK v1.8.0_66.
          -1 compile 0m 7s hadoop-hdfs in branch-2.7 failed with JDK v1.7.0_91.
          +1 checkstyle 0m 7s branch-2.7 passed
          -1 mvnsite 0m 7s hadoop-hdfs in branch-2.7 failed.
          -1 mvneclipse 0m 12s hadoop-hdfs in branch-2.7 failed.
          -1 findbugs 0m 7s hadoop-hdfs in branch-2.7 failed.
          -1 javadoc 0m 6s hadoop-hdfs in branch-2.7 failed with JDK v1.8.0_66.
          -1 javadoc 0m 7s hadoop-hdfs in branch-2.7 failed with JDK v1.7.0_91.
          -1 mvndep 0m 7s patch's hadoop-hdfs-project/hadoop-hdfs dependency:list failed
          0 mvndep 0m 7s Maven dependency ordering for patch
          -1 mvninstall 0m 7s hadoop-hdfs in the patch failed.
          -1 compile 0m 6s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 javac 0m 6s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 compile 0m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          -1 javac 0m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          +1 checkstyle 0m 7s the patch passed
          -1 mvnsite 0m 6s hadoop-hdfs in the patch failed.
          -1 mvneclipse 0m 9s hadoop-hdfs in the patch failed.
          -1 whitespace 0m 1s The patch has 1740 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 whitespace 0m 37s The patch has 77 line(s) with tabs.
          -1 findbugs 0m 6s hadoop-hdfs in the patch failed.
          -1 javadoc 0m 6s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 javadoc 0m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          -1 unit 0m 5s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 0m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          -1 asflicense 44m 5s Patch generated 59 ASF License warnings.
          50m 15s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2016-02-01
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785614/HDFS-9406.branch-2.7.patch
          JIRA Issue HDFS-9406
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 8abee8a56976 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / 6b6167d
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          mvndep hadoop-hdfs-project_hadoop-hdfs: https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/maven-branch-dependencylist-hadoop-hdfs-project_hadoop-hdfs.txt
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/branch-mvninstall-root.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
          mvneclipse https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/branch-mvneclipse-hadoop-hdfs-project_hadoop-hdfs.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
          javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          mvndep hadoop-hdfs-project_hadoop-hdfs: https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/maven-patch-dependencylist-hadoop-hdfs-project_hadoop-hdfs.txt
          mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          compile https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
          mvneclipse https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-mvneclipse-hadoop-hdfs-project_hadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/whitespace-tabs.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
          javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14328/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 45MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14328/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. -1 mvndep 0m 22s branch's hadoop-hdfs-project/hadoop-hdfs dependency:list failed 0 mvndep 0m 22s Maven dependency ordering for branch -1 mvninstall 1m 18s root in branch-2.7 failed. -1 compile 0m 7s hadoop-hdfs in branch-2.7 failed with JDK v1.8.0_66. -1 compile 0m 7s hadoop-hdfs in branch-2.7 failed with JDK v1.7.0_91. +1 checkstyle 0m 7s branch-2.7 passed -1 mvnsite 0m 7s hadoop-hdfs in branch-2.7 failed. -1 mvneclipse 0m 12s hadoop-hdfs in branch-2.7 failed. -1 findbugs 0m 7s hadoop-hdfs in branch-2.7 failed. -1 javadoc 0m 6s hadoop-hdfs in branch-2.7 failed with JDK v1.8.0_66. -1 javadoc 0m 7s hadoop-hdfs in branch-2.7 failed with JDK v1.7.0_91. -1 mvndep 0m 7s patch's hadoop-hdfs-project/hadoop-hdfs dependency:list failed 0 mvndep 0m 7s Maven dependency ordering for patch -1 mvninstall 0m 7s hadoop-hdfs in the patch failed. -1 compile 0m 6s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 javac 0m 6s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 compile 0m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 javac 0m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 checkstyle 0m 7s the patch passed -1 mvnsite 0m 6s hadoop-hdfs in the patch failed. -1 mvneclipse 0m 9s hadoop-hdfs in the patch failed. -1 whitespace 0m 1s The patch has 1740 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 37s The patch has 77 line(s) with tabs. -1 findbugs 0m 6s hadoop-hdfs in the patch failed. -1 javadoc 0m 6s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 javadoc 0m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 unit 0m 5s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 0m 7s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 44m 5s Patch generated 59 ASF License warnings. 50m 15s Subsystem Report/Notes Docker Image:yetus/hadoop:date2016-02-01 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785614/HDFS-9406.branch-2.7.patch JIRA Issue HDFS-9406 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8abee8a56976 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 6b6167d Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 mvndep hadoop-hdfs-project_hadoop-hdfs: https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/maven-branch-dependencylist-hadoop-hdfs-project_hadoop-hdfs.txt mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/branch-mvninstall-root.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/branch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt mvneclipse https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/branch-mvneclipse-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt mvndep hadoop-hdfs-project_hadoop-hdfs: https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/maven-patch-dependencylist-hadoop-hdfs-project_hadoop-hdfs.txt mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt javac https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt mvneclipse https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-mvneclipse-hadoop-hdfs-project_hadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/whitespace-tabs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt javadoc https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14328/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14328/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 45MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14328/console This message was automatically generated.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Closing the JIRA as part of 2.7.3 release.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

            People

            • Assignee:
              yzhangal Yongjun Zhang
              Reporter:
              stanislav.antic@gmail.com Stanislav Antic
            • Votes:
              0 Vote for this issue
              Watchers:
              17 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development