[HDFS-9372] Remove dead code in DataStorage.recoverTransitionRead

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: datanode
• Hadoop Flags: Reviewed
• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 04/Nov/15 05:12
• Updated: 02/Feb/17 14:07
• Resolved: 05/Nov/15 18:16

Description

DataStorage.java

    if (this.initialized) {
      LOG.info("DataNode version: " + HdfsServerConstants.DATANODE_LAYOUT_VERSION
          + " and NameNode layout version: " + nsInfo.getLayoutVersion());
      this.storageDirs = new ArrayList<StorageDirectory>(dataDirs.size());
      // mark DN storage is initialized
      this.initialized = true;
    }

The first if should be !this.initialized I think?

Issue Links

• is broken by: HDFS-7035 Make adding a new data directory to the DataNode an atomic operation and improve error handling