Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      Steps to reconfigure:
      1. change value of the parameter in corresponding xml configuration file
      2. to reconfigure, run
          hdfs dfsadmin -reconfig namenode <nn_addr>:<ipc_port> start
      3. to check status of the most recent reconfigure operation, run
          hdfs dfsadmin -reconfig namenode <nn_addr>:<ipc_port> status
      4. to query a list reconfigurable properties on NN, run
          hdfs dfsadmin -reconfig namenode <nn_addr>:<ipc_port> properties
      Show
      Steps to reconfigure: 1. change value of the parameter in corresponding xml configuration file 2. to reconfigure, run     hdfs dfsadmin -reconfig namenode <nn_addr>:<ipc_port> start 3. to check status of the most recent reconfigure operation, run     hdfs dfsadmin -reconfig namenode <nn_addr>:<ipc_port> status 4. to query a list reconfigurable properties on NN, run     hdfs dfsadmin -reconfig namenode <nn_addr>:<ipc_port> properties

      Description

      This is to reconfigure

      fs.protected.directories
      

      without restarting NN.

      1. HDFS-9349-HDFS-9000.008.patch
        10 kB
        Xiaobing Zhou
      2. HDFS-9349-HDFS-9000.007.patch
        9 kB
        Xiaobing Zhou
      3. HDFS-9349-HDFS-9000.006.patch
        8 kB
        Xiaobing Zhou
      4. HDFS-9349-HDFS-9000.005.patch
        8 kB
        Xiaobing Zhou
      5. HDFS-9349-HDFS-9000.004.patch
        13 kB
        Xiaobing Zhou
      6. HDFS-9349-HDFS-9000.003.patch
        14 kB
        Xiaobing Zhou
      7. HDFS-9349.002.patch
        10 kB
        Xiaobing Zhou
      8. HDFS-9349.001.patch
        10 kB
        Xiaobing Zhou

        Activity

        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Patch v001. Kindly review.

        Show
        xiaobingo Xiaobing Zhou added a comment - Patch v001. Kindly review.
        Hide
        liuml07 Mingliang Liu added a comment -

        Thanks for working on this, Xiaobing Zhou.

        Is it possible to eliminate the new TreeSet() when re-configurate the protected directories? Plus, setProtectedDirectoriesToDefault() seems not needed as StringUtils.getTrimmedStringCollection() accepts null value.

        private final SortedSet<String> protectedDirectories;
          ....
        void setProtectedDirectories(String dirString) {
          protectedDirRWL.writeLock().lock();
          try {
            protectedDirectories.clear();
            protectedDirectories.addAll(normalizePaths(
                StringUtils.getTrimmedStringCollection(dirString),
                FS_PROTECTED_DIRECTORIES));
          } finally {
            protectedDirRWL.writeLock().unlock();
          }
        }
        
        Show
        liuml07 Mingliang Liu added a comment - Thanks for working on this, Xiaobing Zhou . Is it possible to eliminate the new TreeSet() when re-configurate the protected directories? Plus, setProtectedDirectoriesToDefault() seems not needed as StringUtils.getTrimmedStringCollection() accepts null value. private final SortedSet< String > protectedDirectories; .... void setProtectedDirectories( String dirString) { protectedDirRWL.writeLock().lock(); try { protectedDirectories.clear(); protectedDirectories.addAll(normalizePaths( StringUtils.getTrimmedStringCollection(dirString), FS_PROTECTED_DIRECTORIES)); } finally { protectedDirRWL.writeLock().unlock(); } }
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Good comments, thanks Mingliang Liu for review. Posted v002.

        Show
        xiaobingo Xiaobing Zhou added a comment - Good comments, thanks Mingliang Liu for review. Posted v002.
        Hide
        liuml07 Mingliang Liu added a comment -

        The v2 patch looks good overall to me.

        Further minor comments:

        -  private final SortedSet<String> protectedDirectories;
        +  private SortedSet<String> protectedDirectories;
        

        Seems we can keep the protectedDirectories final as we clear/addAll instead of constructing a new set when re-configurating it.

        +  void setProtectedDirectories(String dirString) {
        

        Some java doc may be helpful. And dirString parameter can be renamed protectedDirsString or...?

        Show
        liuml07 Mingliang Liu added a comment - The v2 patch looks good overall to me. Further minor comments: - private final SortedSet< String > protectedDirectories; + private SortedSet< String > protectedDirectories; Seems we can keep the protectedDirectories final as we clear/addAll instead of constructing a new set when re-configurating it. + void setProtectedDirectories( String dirString) { Some java doc may be helpful. And dirString parameter can be renamed protectedDirsString or...?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 6s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 3m 10s trunk passed
        +1 compile 0m 30s trunk passed with JDK v1.8.0_60
        +1 compile 0m 32s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 16s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 53s trunk passed
        +1 javadoc 1m 8s trunk passed with JDK v1.8.0_60
        +1 javadoc 1m 46s trunk passed with JDK v1.7.0_79
        +1 mvninstall 0m 38s the patch passed
        +1 compile 0m 30s the patch passed with JDK v1.8.0_60
        +1 javac 0m 30s the patch passed
        +1 compile 0m 32s the patch passed with JDK v1.7.0_79
        +1 javac 0m 32s the patch passed
        -1 checkstyle 0m 15s Patch generated 3 new checkstyle issues in hadoop-hdfs-project/hadoop-hdfs (total was 231, now 234).
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 2s the patch passed
        +1 javadoc 1m 8s the patch passed with JDK v1.8.0_60
        +1 javadoc 1m 48s the patch passed with JDK v1.7.0_79
        -1 unit 56m 18s hadoop-hdfs in the patch failed with JDK v1.8.0_60.
        -1 unit 49m 27s hadoop-hdfs in the patch failed with JDK v1.7.0_79.
        -1 asflicense 0m 22s Patch generated 58 ASF License warnings.
        125m 26s



        Reason Tests
        JDK v1.8.0_60 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.TestReplaceDatanodeOnFailure
          hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
        JDK v1.7.0_79 Failed junit tests hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-10
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771616/HDFS-9349.001.patch
        JIRA Issue HDFS-9349
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux 48f98d1e68ca 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh
        git revision trunk / c99925d
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13462/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13462/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13462/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13462/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13462/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13462/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13462/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 227MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13462/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 6s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 10s trunk passed +1 compile 0m 30s trunk passed with JDK v1.8.0_60 +1 compile 0m 32s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 16s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 53s trunk passed +1 javadoc 1m 8s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 46s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 38s the patch passed +1 compile 0m 30s the patch passed with JDK v1.8.0_60 +1 javac 0m 30s the patch passed +1 compile 0m 32s the patch passed with JDK v1.7.0_79 +1 javac 0m 32s the patch passed -1 checkstyle 0m 15s Patch generated 3 new checkstyle issues in hadoop-hdfs-project/hadoop-hdfs (total was 231, now 234). +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 2s the patch passed +1 javadoc 1m 8s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 48s the patch passed with JDK v1.7.0_79 -1 unit 56m 18s hadoop-hdfs in the patch failed with JDK v1.8.0_60. -1 unit 49m 27s hadoop-hdfs in the patch failed with JDK v1.7.0_79. -1 asflicense 0m 22s Patch generated 58 ASF License warnings. 125m 26s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.TestReplaceDatanodeOnFailure   hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation JDK v1.7.0_79 Failed junit tests hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-10 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771616/HDFS-9349.001.patch JIRA Issue HDFS-9349 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 48f98d1e68ca 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh git revision trunk / c99925d Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13462/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13462/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13462/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13462/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13462/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13462/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13462/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13462/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 8s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 3m 3s trunk passed
        +1 compile 0m 32s trunk passed with JDK v1.8.0_60
        +1 compile 0m 31s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 15s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 50s trunk passed
        +1 javadoc 1m 8s trunk passed with JDK v1.8.0_60
        +1 javadoc 1m 46s trunk passed with JDK v1.7.0_79
        +1 mvninstall 0m 37s the patch passed
        +1 compile 0m 32s the patch passed with JDK v1.8.0_60
        +1 javac 0m 32s the patch passed
        +1 compile 0m 31s the patch passed with JDK v1.7.0_79
        +1 javac 0m 31s the patch passed
        -1 checkstyle 0m 14s Patch generated 3 new checkstyle issues in hadoop-hdfs-project/hadoop-hdfs (total was 231, now 234).
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 2s the patch passed
        +1 javadoc 1m 6s the patch passed with JDK v1.8.0_60
        +1 javadoc 1m 47s the patch passed with JDK v1.7.0_79
        -1 unit 69m 57s hadoop-hdfs in the patch failed with JDK v1.8.0_60.
        -1 unit 71m 40s hadoop-hdfs in the patch failed with JDK v1.7.0_79.
        -1 asflicense 0m 19s Patch generated 58 ASF License warnings.
        161m 3s



        Reason Tests
        JDK v1.8.0_60 Failed junit tests hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
          hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
          hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
        JDK v1.7.0_79 Failed junit tests hadoop.hdfs.server.blockmanagement.TestNodeCount
          hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-11
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771653/HDFS-9349.002.patch
        JIRA Issue HDFS-9349
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux b4c1e0814f31 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh
        git revision trunk / 6e4562b
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13467/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13467/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13467/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13467/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13467/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13467/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13467/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 226MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13467/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 3s trunk passed +1 compile 0m 32s trunk passed with JDK v1.8.0_60 +1 compile 0m 31s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 15s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 50s trunk passed +1 javadoc 1m 8s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 46s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 37s the patch passed +1 compile 0m 32s the patch passed with JDK v1.8.0_60 +1 javac 0m 32s the patch passed +1 compile 0m 31s the patch passed with JDK v1.7.0_79 +1 javac 0m 31s the patch passed -1 checkstyle 0m 14s Patch generated 3 new checkstyle issues in hadoop-hdfs-project/hadoop-hdfs (total was 231, now 234). +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 2s the patch passed +1 javadoc 1m 6s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 47s the patch passed with JDK v1.7.0_79 -1 unit 69m 57s hadoop-hdfs in the patch failed with JDK v1.8.0_60. -1 unit 71m 40s hadoop-hdfs in the patch failed with JDK v1.7.0_79. -1 asflicense 0m 19s Patch generated 58 ASF License warnings. 161m 3s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes JDK v1.7.0_79 Failed junit tests hadoop.hdfs.server.blockmanagement.TestNodeCount   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-11 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771653/HDFS-9349.002.patch JIRA Issue HDFS-9349 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux b4c1e0814f31 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/patchprocess/apache-yetus-ee5baeb/precommit/personality/hadoop.sh git revision trunk / 6e4562b Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13467/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13467/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13467/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13467/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13467/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13467/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13467/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 226MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13467/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 7s trunk passed
        +1 compile 0m 51s trunk passed with JDK v1.8.0_66
        +1 compile 0m 43s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 0m 55s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 58s trunk passed
        +1 javadoc 1m 13s trunk passed with JDK v1.8.0_66
        +1 javadoc 1m 55s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 49s the patch passed
        +1 compile 0m 51s the patch passed with JDK v1.8.0_66
        +1 javac 0m 51s the patch passed
        +1 compile 0m 40s the patch passed with JDK v1.7.0_91
        +1 javac 0m 40s the patch passed
        -1 checkstyle 0m 21s hadoop-hdfs-project/hadoop-hdfs: patch generated 3 new + 223 unchanged - 0 fixed = 226 total (was 223)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 7s the patch passed
        +1 javadoc 1m 15s the patch passed with JDK v1.8.0_66
        +1 javadoc 1m 51s the patch passed with JDK v1.7.0_91
        -1 unit 68m 5s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
        -1 unit 64m 53s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        161m 2s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.TestDecommissioningStatus
          hadoop.hdfs.TestFileAppend
          hadoop.hdfs.server.datanode.TestBlockScanner
        JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
          hadoop.hdfs.TestRecoverStripedFile
          hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771653/HDFS-9349.002.patch
        JIRA Issue HDFS-9349
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux dfb51c261189 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4efdf3a
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14254/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14254/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14254/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14254/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14254/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14254/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14254/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 7s trunk passed +1 compile 0m 51s trunk passed with JDK v1.8.0_66 +1 compile 0m 43s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 58s trunk passed +1 javadoc 1m 13s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 55s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 49s the patch passed +1 compile 0m 51s the patch passed with JDK v1.8.0_66 +1 javac 0m 51s the patch passed +1 compile 0m 40s the patch passed with JDK v1.7.0_91 +1 javac 0m 40s the patch passed -1 checkstyle 0m 21s hadoop-hdfs-project/hadoop-hdfs: patch generated 3 new + 223 unchanged - 0 fixed = 226 total (was 223) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 7s the patch passed +1 javadoc 1m 15s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 51s the patch passed with JDK v1.7.0_91 -1 unit 68m 5s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 64m 53s hadoop-hdfs in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 161m 2s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.datanode.TestBlockScanner JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771653/HDFS-9349.002.patch JIRA Issue HDFS-9349 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dfb51c261189 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4efdf3a Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14254/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14254/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14254/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14254/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14254/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14254/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14254/console This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Posted patch V003. Thanks Mingliang Liu.

        Show
        xiaobingo Xiaobing Zhou added a comment - Posted patch V003. Thanks Mingliang Liu .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 42s trunk passed
        +1 compile 0m 42s trunk passed with JDK v1.8.0_72
        +1 compile 0m 40s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 25s trunk passed
        +1 mvnsite 0m 53s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 57s trunk passed
        +1 javadoc 1m 5s trunk passed with JDK v1.8.0_72
        +1 javadoc 1m 46s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 36s the patch passed with JDK v1.8.0_72
        +1 javac 0m 36s the patch passed
        +1 compile 0m 38s the patch passed with JDK v1.7.0_95
        +1 javac 0m 38s the patch passed
        -1 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: patch generated 4 new + 366 unchanged - 22 fixed = 370 total (was 388)
        +1 mvnsite 0m 48s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 10s the patch passed
        +1 javadoc 1m 2s the patch passed with JDK v1.8.0_72
        +1 javadoc 1m 44s the patch passed with JDK v1.7.0_95
        +1 unit 54m 11s hadoop-hdfs in the patch passed with JDK v1.8.0_72.
        -1 unit 51m 40s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        131m 11s



        Reason Tests
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestLeaseRecovery2



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788170/HDFS-9349-HDFS-9000.003.patch
        JIRA Issue HDFS-9349
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ca01b36084e8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 453e7e0
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14510/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14510/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14510/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14510/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14510/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 42s trunk passed +1 compile 0m 42s trunk passed with JDK v1.8.0_72 +1 compile 0m 40s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 57s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 46s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 45s the patch passed +1 compile 0m 36s the patch passed with JDK v1.8.0_72 +1 javac 0m 36s the patch passed +1 compile 0m 38s the patch passed with JDK v1.7.0_95 +1 javac 0m 38s the patch passed -1 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: patch generated 4 new + 366 unchanged - 22 fixed = 370 total (was 388) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 10s the patch passed +1 javadoc 1m 2s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 44s the patch passed with JDK v1.7.0_95 +1 unit 54m 11s hadoop-hdfs in the patch passed with JDK v1.8.0_72. -1 unit 51m 40s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 131m 11s Reason Tests JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788170/HDFS-9349-HDFS-9000.003.patch JIRA Issue HDFS-9349 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ca01b36084e8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 453e7e0 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14510/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14510/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14510/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14510/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14510/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        V004 fixed some check styple issues.

        Show
        xiaobingo Xiaobing Zhou added a comment - V004 fixed some check styple issues.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 docker 14m 30s Docker failed to build yetus/hadoop:0ca8df7.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788281/HDFS-9349-HDFS-9000.004.patch
        JIRA Issue HDFS-9349
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14513/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 14m 30s Docker failed to build yetus/hadoop:0ca8df7. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788281/HDFS-9349-HDFS-9000.004.patch JIRA Issue HDFS-9349 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14513/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 14m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 53s trunk passed
        +1 compile 0m 46s trunk passed with JDK v1.8.0_72
        +1 compile 0m 45s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 1m 1s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 2m 9s trunk passed
        +1 javadoc 1m 17s trunk passed with JDK v1.8.0_72
        +1 javadoc 2m 1s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 49s the patch passed
        +1 compile 0m 46s the patch passed with JDK v1.8.0_72
        +1 javac 0m 46s the patch passed
        +1 compile 0m 43s the patch passed with JDK v1.7.0_95
        +1 javac 0m 43s the patch passed
        +1 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 366 unchanged - 22 fixed = 366 total (was 388)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 21s the patch passed
        +1 javadoc 1m 13s the patch passed with JDK v1.8.0_72
        +1 javadoc 1m 56s the patch passed with JDK v1.7.0_95
        -1 unit 60m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
        -1 unit 55m 11s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        158m 41s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.hdfs.qjournal.client.TestQJMWithFaults
          hadoop.hdfs.TestFileAppend
          hadoop.hdfs.shortcircuit.TestShortCircuitCache
        JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.fs.TestGlobPaths
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestRenameWhileOpen
          hadoop.hdfs.shortcircuit.TestShortCircuitCache



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788281/HDFS-9349-HDFS-9000.004.patch
        JIRA Issue HDFS-9349
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0f3e37021d7a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0fb14aa
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14518/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14518/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14518/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14518/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14518/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14518/console
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 14m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 53s trunk passed +1 compile 0m 46s trunk passed with JDK v1.8.0_72 +1 compile 0m 45s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 9s trunk passed +1 javadoc 1m 17s trunk passed with JDK v1.8.0_72 +1 javadoc 2m 1s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 49s the patch passed +1 compile 0m 46s the patch passed with JDK v1.8.0_72 +1 javac 0m 46s the patch passed +1 compile 0m 43s the patch passed with JDK v1.7.0_95 +1 javac 0m 43s the patch passed +1 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 366 unchanged - 22 fixed = 366 total (was 388) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 21s the patch passed +1 javadoc 1m 13s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 56s the patch passed with JDK v1.7.0_95 -1 unit 60m 48s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 55m 11s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 158m 41s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.qjournal.client.TestQJMWithFaults   hadoop.hdfs.TestFileAppend   hadoop.hdfs.shortcircuit.TestShortCircuitCache JDK v1.8.0_72 Timed out junit tests org.apache.hadoop.fs.TestGlobPaths JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestRenameWhileOpen   hadoop.hdfs.shortcircuit.TestShortCircuitCache Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788281/HDFS-9349-HDFS-9000.004.patch JIRA Issue HDFS-9349 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0f3e37021d7a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0fb14aa Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14518/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14518/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14518/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14518/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14518/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14518/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Verified the test failure is not related to patch 004.

        Show
        xiaobingo Xiaobing Zhou added a comment - Verified the test failure is not related to patch 004.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 4s HDFS-9349 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788281/HDFS-9349-HDFS-9000.004.patch
        JIRA Issue HDFS-9349
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14816/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HDFS-9349 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788281/HDFS-9349-HDFS-9000.004.patch JIRA Issue HDFS-9349 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14816/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        V005 is rebased on trunk.

        Show
        xiaobingo Xiaobing Zhou added a comment - V005 is rebased on trunk.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Thank you for updating the patch Xiaobing Zhou. The synchronization needs more work as the caller of getProtectedDirectories assumes the set will not be modified. Modifications to protectedDirectories will be rare so let's just make it a volatile reference and setProtectedDirectories can replace the reference atomically with a newly constructed set. Also you can use parseProtectedDirectories to construct the new set.

        Show
        arpitagarwal Arpit Agarwal added a comment - Thank you for updating the patch Xiaobing Zhou . The synchronization needs more work as the caller of getProtectedDirectories assumes the set will not be modified. Modifications to protectedDirectories will be rare so let's just make it a volatile reference and setProtectedDirectories can replace the reference atomically with a newly constructed set. Also you can use parseProtectedDirectories to construct the new set.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 19m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 5s trunk passed
        +1 compile 0m 53s trunk passed with JDK v1.8.0_74
        +1 compile 0m 53s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 1m 3s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 2m 4s trunk passed
        +1 javadoc 1m 20s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 59s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 59s the patch passed
        +1 compile 0m 48s the patch passed with JDK v1.8.0_74
        +1 javac 0m 48s the patch passed
        +1 compile 0m 45s the patch passed with JDK v1.7.0_95
        +1 javac 0m 45s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 0m 58s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 21s the patch passed
        +1 javadoc 1m 9s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 50s the patch passed with JDK v1.7.0_95
        -1 unit 72m 38s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
        -1 unit 79m 41s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 36s Patch does not generate ASF License warnings.
        201m 4s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestHFlush
          hadoop.hdfs.tools.TestDFSAdmin
          hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
          hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush
          hadoop.hdfs.tools.TestDFSAdmin
          hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793658/HDFS-9349-HDFS-9000.005.patch
        JIRA Issue HDFS-9349
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c0528ecd1d5b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6529c875
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14827/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14827/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14827/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14827/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14827/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14827/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 19m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 5s trunk passed +1 compile 0m 53s trunk passed with JDK v1.8.0_74 +1 compile 0m 53s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 30s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 2m 4s trunk passed +1 javadoc 1m 20s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 59s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 59s the patch passed +1 compile 0m 48s the patch passed with JDK v1.8.0_74 +1 javac 0m 48s the patch passed +1 compile 0m 45s the patch passed with JDK v1.7.0_95 +1 javac 0m 45s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 21s the patch passed +1 javadoc 1m 9s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 50s the patch passed with JDK v1.7.0_95 -1 unit 72m 38s hadoop-hdfs in the patch failed with JDK v1.8.0_74. -1 unit 79m 41s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 36s Patch does not generate ASF License warnings. 201m 4s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.tools.TestDFSAdmin   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.tools.TestDFSAdmin   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793658/HDFS-9349-HDFS-9000.005.patch JIRA Issue HDFS-9349 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c0528ecd1d5b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6529c875 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14827/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14827/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14827/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14827/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14827/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14827/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Patch V006 should fix the problems you mentioned, thanks Arpit Agarwal.

        Show
        xiaobingo Xiaobing Zhou added a comment - Patch V006 should fix the problems you mentioned, thanks Arpit Agarwal .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 33s trunk passed
        +1 compile 0m 40s trunk passed with JDK v1.8.0_74
        +1 compile 0m 40s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 50s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 56s trunk passed
        +1 javadoc 1m 6s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 45s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 37s the patch passed with JDK v1.8.0_74
        +1 javac 0m 37s the patch passed
        +1 compile 0m 39s the patch passed with JDK v1.7.0_95
        +1 javac 0m 39s the patch passed
        -1 checkstyle 0m 21s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 201 unchanged - 0 fixed = 202 total (was 201)
        +1 mvnsite 0m 48s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 6s the patch passed
        +1 javadoc 1m 2s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 39s the patch passed with JDK v1.7.0_95
        -1 unit 57m 14s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
        -1 unit 53m 20s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 20s Patch does not generate ASF License warnings.
        135m 25s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache
          hadoop.hdfs.server.namenode.TestEditLog
          hadoop.hdfs.tools.TestDFSAdmin
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.tools.TestDFSAdmin
          hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795067/HDFS-9349-HDFS-9000.006.patch
        JIRA Issue HDFS-9349
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 5a97f49f5909 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 938222b
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14914/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14914/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14914/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14914/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14914/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14914/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14914/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 33s trunk passed +1 compile 0m 40s trunk passed with JDK v1.8.0_74 +1 compile 0m 40s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 56s trunk passed +1 javadoc 1m 6s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 45s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 45s the patch passed +1 compile 0m 37s the patch passed with JDK v1.8.0_74 +1 javac 0m 37s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_95 +1 javac 0m 39s the patch passed -1 checkstyle 0m 21s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 201 unchanged - 0 fixed = 202 total (was 201) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 6s the patch passed +1 javadoc 1m 2s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 39s the patch passed with JDK v1.7.0_95 -1 unit 57m 14s hadoop-hdfs in the patch failed with JDK v1.8.0_74. -1 unit 53m 20s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 135m 25s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.tools.TestDFSAdmin JDK v1.7.0_95 Failed junit tests hadoop.hdfs.tools.TestDFSAdmin   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795067/HDFS-9349-HDFS-9000.006.patch JIRA Issue HDFS-9349 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5a97f49f5909 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 938222b Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14914/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14914/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14914/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14914/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14914/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14914/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14914/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Hi Xiaobing Zhou, thanks for updating the patch. The protectedDirectories.clear() call on line 396 is not atomic wrt readers. We should just replace the volatile reference with a new empty set. Also let's change parseProtectedDirectories to take the string value instead of constructing a dummy Configuration object.

        Show
        arpitagarwal Arpit Agarwal added a comment - Hi Xiaobing Zhou , thanks for updating the patch. The protectedDirectories.clear() call on line 396 is not atomic wrt readers. We should just replace the volatile reference with a new empty set. Also let's change parseProtectedDirectories to take the string value instead of constructing a dummy Configuration object.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        I posted patch v007. It's hard to do that change directly on original parseProtectedDirectories, but the overload/refactoring is possible. Arpit Agarwal thanks.

        Show
        xiaobingo Xiaobing Zhou added a comment - I posted patch v007. It's hard to do that change directly on original parseProtectedDirectories, but the overload/refactoring is possible. Arpit Agarwal thanks.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        v008 fixed one unit test failure.

        Show
        xiaobingo Xiaobing Zhou added a comment - v008 fixed one unit test failure.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 32s trunk passed
        +1 compile 0m 38s trunk passed with JDK v1.8.0_74
        +1 compile 0m 40s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 56s trunk passed
        +1 javadoc 1m 5s trunk passed with JDK v1.8.0_74
        +1 javadoc 1m 46s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 38s the patch passed with JDK v1.8.0_74
        +1 javac 0m 38s the patch passed
        +1 compile 0m 39s the patch passed with JDK v1.7.0_95
        +1 javac 0m 39s the patch passed
        -1 checkstyle 0m 21s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 201 unchanged - 0 fixed = 202 total (was 201)
        +1 mvnsite 0m 48s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 9s the patch passed
        +1 javadoc 1m 4s the patch passed with JDK v1.8.0_74
        +1 javadoc 1m 45s the patch passed with JDK v1.7.0_95
        -1 unit 70m 2s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
        -1 unit 72m 12s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        -1 asflicense 0m 21s Patch generated 1 ASF License warnings.
        167m 24s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestHFlush
          hadoop.cli.TestHDFSCLI
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush
          hadoop.cli.TestHDFSCLI
          hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
          hadoop.hdfs.server.balancer.TestBalancer



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795737/HDFS-9349-HDFS-9000.008.patch
        JIRA Issue HDFS-9349
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux bf433e585676 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 948b758
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14967/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14967/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14967/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14967/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14967/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14967/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14967/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14967/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 32s trunk passed +1 compile 0m 38s trunk passed with JDK v1.8.0_74 +1 compile 0m 40s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 56s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 46s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 45s the patch passed +1 compile 0m 38s the patch passed with JDK v1.8.0_74 +1 javac 0m 38s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_95 +1 javac 0m 39s the patch passed -1 checkstyle 0m 21s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 201 unchanged - 0 fixed = 202 total (was 201) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 9s the patch passed +1 javadoc 1m 4s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 45s the patch passed with JDK v1.7.0_95 -1 unit 70m 2s hadoop-hdfs in the patch failed with JDK v1.8.0_74. -1 unit 72m 12s hadoop-hdfs in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 21s Patch generated 1 ASF License warnings. 167m 24s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.cli.TestHDFSCLI JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.cli.TestHDFSCLI   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.server.balancer.TestBalancer Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795737/HDFS-9349-HDFS-9000.008.patch JIRA Issue HDFS-9349 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bf433e585676 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 948b758 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14967/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14967/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14967/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14967/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14967/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14967/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14967/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14967/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1. Thanks Xiaobing Zhou. I committed this for 2.9.0.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1. Thanks Xiaobing Zhou . I committed this for 2.9.0.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        I fixed the checkstyle issue while committing. Delta for reference:

        @@ -37,7 +37,6 @@
         import org.apache.hadoop.fs.permission.FsPermission;
         import org.apache.hadoop.hdfs.DFSConfigKeys;
         import org.apache.hadoop.hdfs.DFSUtil;
        -import org.apache.hadoop.hdfs.HdfsConfiguration;
        
        Show
        arpitagarwal Arpit Agarwal added a comment - I fixed the checkstyle issue while committing. Delta for reference: @@ -37,7 +37,6 @@ import org.apache.hadoop.fs.permission.FsPermission; import org.apache.hadoop.hdfs.DFSConfigKeys; import org.apache.hadoop.hdfs.DFSUtil; - import org.apache.hadoop.hdfs.HdfsConfiguration;
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Thanks Arpit Agarwal for review. I also added release notes.

        Show
        xiaobingo Xiaobing Zhou added a comment - Thanks Arpit Agarwal for review. I also added release notes.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Arpit Agarwal is there any reason why this is not in trunk? Thanks.

        Show
        xiaobingo Xiaobing Zhou added a comment - Arpit Agarwal is there any reason why this is not in trunk? Thanks.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Look for commit ddfe677.

        Show
        arpitagarwal Arpit Agarwal added a comment - Look for commit ddfe677.

          People

          • Assignee:
            xiaobingo Xiaobing Zhou
            Reporter:
            xiaobingo Xiaobing Zhou
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development