Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-933

Add createIdentifier() implementation to DelegationTokenSecretManager

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      abstract method createIdentifier() is being added in Common (HADOOP-6419) and needs to be implemented by DelegationTokenSecretManager. This allows the RPC Server's authentication layer to deserialize received TokenIdentifiers.

      1. h6419-01.patch
        0.8 kB
        Kan Zhang
      2. h6419-07.patch
        16 kB
        Kan Zhang
      3. h6419-09.patch
        15 kB
        Kan Zhang

        Issue Links

          Activity

          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Tom White made changes -
          Fix Version/s 0.21.0 [ 12314046 ]
          Fix Version/s 0.22.0 [ 12314241 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #275 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/275/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #275 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/275/ )
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #146 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/146/)

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #146 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/146/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #186 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/186/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #186 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/186/ )
          Devaraj Das made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.22.0 [ 12314241 ]
          Resolution Fixed [ 1 ]
          Hide
          Devaraj Das added a comment -

          +1 (I also ran tests/findbugs/javadoc manually).
          I just committed this. Thanks, Kan!

          Show
          Devaraj Das added a comment - +1 (I also ran tests/findbugs/javadoc manually). I just committed this. Thanks, Kan!
          Hide
          Todd Lipcon added a comment -

          Is this going to be committed ASAP? Trunk build's currently broken.

          Show
          Todd Lipcon added a comment - Is this going to be committed ASAP? Trunk build's currently broken.
          Kan Zhang made changes -
          Attachment h6419-09.patch [ 12434457 ]
          Hide
          Kan Zhang added a comment -

          attaching a new patch that matches the latest Common changes.

          Show
          Kan Zhang added a comment - attaching a new patch that matches the latest Common changes.
          Hide
          Kan Zhang added a comment -

          Add a new patch that enables the NameNode to use DelegationToken to authenticate users over RPC (based on RPC changes done in HADOOP-6419).

          ran full test suit locally and found 2 test (TestBalancer and TestDFSRollback) failed. Re-ran those 2 tests individually multiple times and they all passed. Wasn't able to run test-patch.

          Show
          Kan Zhang added a comment - Add a new patch that enables the NameNode to use DelegationToken to authenticate users over RPC (based on RPC changes done in HADOOP-6419 ). ran full test suit locally and found 2 test (TestBalancer and TestDFSRollback) failed. Re-ran those 2 tests individually multiple times and they all passed. Wasn't able to run test-patch.
          Kan Zhang made changes -
          Attachment h6419-07.patch [ 12431901 ]
          Hide
          Kan Zhang added a comment -

          This is a small change required by HADOOP-6419.

          Show
          Kan Zhang added a comment - This is a small change required by HADOOP-6419 .
          Kan Zhang made changes -
          Link This issue is blocked by HADOOP-6419 [ HADOOP-6419 ]
          Kan Zhang made changes -
          Field Original Value New Value
          Attachment h6419-01.patch [ 12431852 ]
          Kan Zhang created issue -

            People

            • Assignee:
              Kan Zhang
              Reporter:
              Kan Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development