Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9307

fuseConnect should be private to fuse_connect.c

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: fuse-dfs
    • Labels:
      None
    • Target Version/s:

      Description

      fuseConnect should be private to fuse_connect.c, since it's not used outside that file

      1. HDFS-9307.000.patch
        0.6 kB
        Mingliang Liu
      2. HDFS-9307.001.patch
        2 kB
        Mingliang Liu

        Issue Links

          Activity

          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks for reporting this. I also think it should be private. The patch simply make it static.

          Show
          liuml07 Mingliang Liu added a comment - Thanks for reporting this. I also think it should be private. The patch simply make it static .
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks, Mingliang Liu. can you remove it from the header as well? +1 once that's done

          Show
          cmccabe Colin P. McCabe added a comment - Thanks, Mingliang Liu . can you remove it from the header as well? +1 once that's done
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks for your review, Colin P. McCabe. The v1 patch addresses this and also refines the comments for the functions.

          Show
          liuml07 Mingliang Liu added a comment - Thanks for your review, Colin P. McCabe . The v1 patch addresses this and also refines the comments for the functions.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 6m 44s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 9m 11s There were no new javac warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 49s mvn install still works.
          +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse.
          +1 native 1m 11s Pre-build of native portion
          +1 hdfs tests 0m 47s Tests passed in hadoop-hdfs-native-client.
              20m 47s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12768832/HDFS-9307.001.patch
          Optional Tests javac unit
          git revision trunk / 56e4f62
          hadoop-hdfs-native-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/13208/artifact/patchprocess/testrun_hadoop-hdfs-native-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13208/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13208/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 6m 44s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 9m 11s There were no new javac warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 49s mvn install still works. +1 eclipse:eclipse 0m 37s The patch built with eclipse:eclipse. +1 native 1m 11s Pre-build of native portion +1 hdfs tests 0m 47s Tests passed in hadoop-hdfs-native-client.     20m 47s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12768832/HDFS-9307.001.patch Optional Tests javac unit git revision trunk / 56e4f62 hadoop-hdfs-native-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/13208/artifact/patchprocess/testrun_hadoop-hdfs-native-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13208/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13208/console This message was automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          +1. Thanks, Mingliang Liu.

          Show
          cmccabe Colin P. McCabe added a comment - +1. Thanks, Mingliang Liu .
          Hide
          liuml07 Mingliang Liu added a comment -

          Thank you Colin P. McCabe for your reporting this jira, reviewing and committing the final patch.

          Show
          liuml07 Mingliang Liu added a comment - Thank you Colin P. McCabe for your reporting this jira, reviewing and committing the final patch.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #8716 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8716/)
          HDFS-9307. fuseConnect should be private to fuse_connect.c (Mingliang (cmccabe: rev faeb6a3f89f3580a5b1a40c6a1f6205269a5aa7a)

          • hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.h
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.c
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #8716 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8716/ ) HDFS-9307 . fuseConnect should be private to fuse_connect.c (Mingliang (cmccabe: rev faeb6a3f89f3580a5b1a40c6a1f6205269a5aa7a) hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.h hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.c
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2535 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2535/)
          HDFS-9307. fuseConnect should be private to fuse_connect.c (Mingliang (cmccabe: rev faeb6a3f89f3580a5b1a40c6a1f6205269a5aa7a)

          • hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.h
          • hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.c
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2535 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2535/ ) HDFS-9307 . fuseConnect should be private to fuse_connect.c (Mingliang (cmccabe: rev faeb6a3f89f3580a5b1a40c6a1f6205269a5aa7a) hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.h hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.c hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2481 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2481/)
          HDFS-9307. fuseConnect should be private to fuse_connect.c (Mingliang (cmccabe: rev faeb6a3f89f3580a5b1a40c6a1f6205269a5aa7a)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.c
          • hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.h
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2481 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2481/ ) HDFS-9307 . fuseConnect should be private to fuse_connect.c (Mingliang (cmccabe: rev faeb6a3f89f3580a5b1a40c6a1f6205269a5aa7a) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.c hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.h
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1328 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1328/)
          HDFS-9307. fuseConnect should be private to fuse_connect.c (Mingliang (cmccabe: rev faeb6a3f89f3580a5b1a40c6a1f6205269a5aa7a)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.c
          • hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.h
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1328 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1328/ ) HDFS-9307 . fuseConnect should be private to fuse_connect.c (Mingliang (cmccabe: rev faeb6a3f89f3580a5b1a40c6a1f6205269a5aa7a) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.c hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.h
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #544 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/544/)
          HDFS-9307. fuseConnect should be private to fuse_connect.c (Mingliang (cmccabe: rev faeb6a3f89f3580a5b1a40c6a1f6205269a5aa7a)

          • hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.c
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.h
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #544 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/544/ ) HDFS-9307 . fuseConnect should be private to fuse_connect.c (Mingliang (cmccabe: rev faeb6a3f89f3580a5b1a40c6a1f6205269a5aa7a) hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.c hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.h
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #605 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/605/)
          HDFS-9307. fuseConnect should be private to fuse_connect.c (Mingliang (cmccabe: rev faeb6a3f89f3580a5b1a40c6a1f6205269a5aa7a)

          • hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.h
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.c
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #605 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/605/ ) HDFS-9307 . fuseConnect should be private to fuse_connect.c (Mingliang (cmccabe: rev faeb6a3f89f3580a5b1a40c6a1f6205269a5aa7a) hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.h hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.c
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #592 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/592/)
          HDFS-9307. fuseConnect should be private to fuse_connect.c (Mingliang (cmccabe: rev faeb6a3f89f3580a5b1a40c6a1f6205269a5aa7a)

          • hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.c
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.h
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #592 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/592/ ) HDFS-9307 . fuseConnect should be private to fuse_connect.c (Mingliang (cmccabe: rev faeb6a3f89f3580a5b1a40c6a1f6205269a5aa7a) hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.c hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/fuse-dfs/fuse_connect.h

            People

            • Assignee:
              liuml07 Mingliang Liu
              Reporter:
              cmccabe Colin P. McCabe
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development