Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9297

Update TestBlockMissingException to use corruptBlockOnDataNodesByDeletingBlockFile()

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Target Version/s:

      Description

      TestBlockMissingException uses its own function to corrupt a block by deleting all its block files. HDFS-7235 introduced a helper function corruptBlockOnDataNodesByDeletingBlockFile() that does exactly the same thing. We can update this test to use the helper function.

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2468 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2468/)
        HDFS-9297. Update TestBlockMissingException to use (lei: rev 5679e46b7f867f8f7f8195c86c37e3db7b23d7d7)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockMissingException.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2468 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2468/ ) HDFS-9297 . Update TestBlockMissingException to use (lei: rev 5679e46b7f867f8f7f8195c86c37e3db7b23d7d7) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockMissingException.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #578 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/578/)
        HDFS-9297. Update TestBlockMissingException to use (lei: rev 5679e46b7f867f8f7f8195c86c37e3db7b23d7d7)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockMissingException.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #578 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/578/ ) HDFS-9297 . Update TestBlockMissingException to use (lei: rev 5679e46b7f867f8f7f8195c86c37e3db7b23d7d7) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockMissingException.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #591 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/591/)
        HDFS-9297. Update TestBlockMissingException to use (lei: rev 5679e46b7f867f8f7f8195c86c37e3db7b23d7d7)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockMissingException.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #591 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/591/ ) HDFS-9297 . Update TestBlockMissingException to use (lei: rev 5679e46b7f867f8f7f8195c86c37e3db7b23d7d7) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockMissingException.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2523 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2523/)
        HDFS-9297. Update TestBlockMissingException to use (lei: rev 5679e46b7f867f8f7f8195c86c37e3db7b23d7d7)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockMissingException.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2523 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2523/ ) HDFS-9297 . Update TestBlockMissingException to use (lei: rev 5679e46b7f867f8f7f8195c86c37e3db7b23d7d7) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockMissingException.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1313 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1313/)
        HDFS-9297. Update TestBlockMissingException to use (lei: rev 5679e46b7f867f8f7f8195c86c37e3db7b23d7d7)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockMissingException.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1313 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1313/ ) HDFS-9297 . Update TestBlockMissingException to use (lei: rev 5679e46b7f867f8f7f8195c86c37e3db7b23d7d7) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockMissingException.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #532 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/532/)
        HDFS-9297. Update TestBlockMissingException to use (lei: rev 5679e46b7f867f8f7f8195c86c37e3db7b23d7d7)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockMissingException.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #532 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/532/ ) HDFS-9297 . Update TestBlockMissingException to use (lei: rev 5679e46b7f867f8f7f8195c86c37e3db7b23d7d7) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockMissingException.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8699 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8699/)
        HDFS-9297. Update TestBlockMissingException to use (lei: rev 5679e46b7f867f8f7f8195c86c37e3db7b23d7d7)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockMissingException.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8699 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8699/ ) HDFS-9297 . Update TestBlockMissingException to use (lei: rev 5679e46b7f867f8f7f8195c86c37e3db7b23d7d7) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockMissingException.java
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        +1. Committed.

        Thanks, Tony Wu

        Show
        eddyxu Lei (Eddy) Xu added a comment - +1. Committed. Thanks, Tony Wu
        Hide
        twu Tony Wu added a comment -

        The failed tests are not related to this change.

        Show
        twu Tony Wu added a comment - The failed tests are not related to this change.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 8m 44s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 54s There were no new javac warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 37s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 52s mvn install still works.
        +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
        +1 findbugs 2m 45s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 1m 5s Pre-build of native portion
        -1 hdfs tests 67m 11s Tests failed in hadoop-hdfs.
            93m 12s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestRecoverStripedFile
          hadoop.hdfs.server.namenode.TestFileTruncate



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12768333/HDFS-9297.001.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 934d96a
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13157/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13157/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13157/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13157/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 8m 44s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 54s There were no new javac warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 37s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 52s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 2m 45s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 5s Pre-build of native portion -1 hdfs tests 67m 11s Tests failed in hadoop-hdfs.     93m 12s   Reason Tests Failed unit tests hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12768333/HDFS-9297.001.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 934d96a Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13157/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13157/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13157/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13157/console This message was automatically generated.
        Hide
        twu Tony Wu added a comment -

        In this patch:

        • Use corruptBlockOnDataNodesByDeletingBlockFile() to corrupt a block by removing all block files.
        • Removed the test's own implementation of the same function.
        Show
        twu Tony Wu added a comment - In this patch: Use corruptBlockOnDataNodesByDeletingBlockFile() to corrupt a block by removing all block files. Removed the test's own implementation of the same function.

          People

          • Assignee:
            twu Tony Wu
            Reporter:
            twu Tony Wu
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development