Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9281

Change TestDeleteBlockPool to not explicitly use File to check block pool existence.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Target Version/s:

      Description

      TestDeleteBlockPool checks the existence of a block pool by checking the directories in the file-based block pool exists. However, it does not apply to non file based fsdataset.

      We can fix it by abstracting the checking logic behind FsDatasetTestUtils.

      1. HDFS-9281.combo.00.patch
        12 kB
        Lei (Eddy) Xu
      2. HDFS-9281.03.patch
        10 kB
        Lei (Eddy) Xu
      3. HDFS-9281.02.patch
        10 kB
        Lei (Eddy) Xu
      4. HDFS-9281.00.patch
        10 kB
        Lei (Eddy) Xu

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #692 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/692/)
          HDFS-9281. Change TestDeleteBlockPool to not explicitly use File to (lei: rev f229772f99d1751e6b2152b6e3ac9c9f7844c15d)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDeleteBlockPool.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #692 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/692/ ) HDFS-9281 . Change TestDeleteBlockPool to not explicitly use File to (lei: rev f229772f99d1751e6b2152b6e3ac9c9f7844c15d) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDeleteBlockPool.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 11m 32s trunk passed
          +1 compile 1m 31s trunk passed with JDK v1.8.0_66
          +1 compile 1m 6s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 1m 20s trunk passed
          +1 mvneclipse 0m 19s trunk passed
          +1 findbugs 2m 45s trunk passed
          +1 javadoc 1m 48s trunk passed with JDK v1.8.0_66
          +1 javadoc 2m 57s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 17s the patch passed
          +1 compile 1m 24s the patch passed with JDK v1.8.0_66
          +1 javac 1m 24s the patch passed
          +1 compile 1m 3s the patch passed with JDK v1.7.0_91
          +1 javac 1m 3s the patch passed
          +1 checkstyle 0m 23s the patch passed
          +1 mvnsite 1m 16s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 4s the patch passed
          +1 javadoc 1m 54s the patch passed with JDK v1.8.0_66
          +1 javadoc 2m 31s the patch passed with JDK v1.7.0_91
          -1 unit 73m 15s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 76m 55s hadoop-hdfs in the patch failed with JDK v1.7.0_91.
          -1 asflicense 0m 26s Patch generated 58 ASF License warnings.
          191m 27s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.TestRecoverStripedBlocks
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
            hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider
            hadoop.hdfs.TestDistributedFileSystem
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.server.mover.TestStorageMover
            org.apache.hadoop.hdfs.server.balancer.TestBalancer
            org.apache.hadoop.hdfs.server.mover.TestMover
            org.apache.hadoop.hdfs.TestEncryptedTransfer
          JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestRecoverStripedBlocks
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776954/HDFS-9281.03.patch
          JIRA Issue HDFS-9281
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b79134d55899 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7fb212e
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13862/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13862/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13862/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13862/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13862/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13862/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 76MB
          Powered by Apache Yetus 0.1.0 http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13862/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 11m 32s trunk passed +1 compile 1m 31s trunk passed with JDK v1.8.0_66 +1 compile 1m 6s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 20s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 2m 45s trunk passed +1 javadoc 1m 48s trunk passed with JDK v1.8.0_66 +1 javadoc 2m 57s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 17s the patch passed +1 compile 1m 24s the patch passed with JDK v1.8.0_66 +1 javac 1m 24s the patch passed +1 compile 1m 3s the patch passed with JDK v1.7.0_91 +1 javac 1m 3s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 1m 16s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 4s the patch passed +1 javadoc 1m 54s the patch passed with JDK v1.8.0_66 +1 javadoc 2m 31s the patch passed with JDK v1.7.0_91 -1 unit 73m 15s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 76m 55s hadoop-hdfs in the patch failed with JDK v1.7.0_91. -1 asflicense 0m 26s Patch generated 58 ASF License warnings. 191m 27s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.namenode.TestRecoverStripedBlocks   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider   hadoop.hdfs.TestDistributedFileSystem JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.hdfs.server.mover.TestStorageMover   org.apache.hadoop.hdfs.server.balancer.TestBalancer   org.apache.hadoop.hdfs.server.mover.TestMover   org.apache.hadoop.hdfs.TestEncryptedTransfer JDK v1.7.0_91 Failed junit tests hadoop.hdfs.server.namenode.TestRecoverStripedBlocks   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.namenode.ha.TestRequestHedgingProxyProvider Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12776954/HDFS-9281.03.patch JIRA Issue HDFS-9281 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b79134d55899 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7fb212e findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13862/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13862/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13862/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13862/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13862/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13862/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 76MB Powered by Apache Yetus 0.1.0 http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13862/console This message was automatically generated.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8962 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8962/)
          HDFS-9281. Change TestDeleteBlockPool to not explicitly use File to (lei: rev f229772f99d1751e6b2152b6e3ac9c9f7844c15d)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDeleteBlockPool.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8962 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8962/ ) HDFS-9281 . Change TestDeleteBlockPool to not explicitly use File to (lei: rev f229772f99d1751e6b2152b6e3ac9c9f7844c15d) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDeleteBlockPool.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Thanks a lot for the reviews and suggestions, Colin P. McCabe!

          I committed this to trunk and branch-2.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Thanks a lot for the reviews and suggestions, Colin P. McCabe ! I committed this to trunk and branch-2 .
          Hide
          cmccabe Colin P. McCabe added a comment -

          +1. Thanks, Lei (Eddy) Xu.

          Show
          cmccabe Colin P. McCabe added a comment - +1. Thanks, Lei (Eddy) Xu .
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Thanks a lot for the great comments, Colin P. McCabe

          I updated the patch to split the checkBlockPool function into the two functions you suggested.

          Could you give another review?

          Thanks!

          Show
          eddyxu Lei (Eddy) Xu added a comment - Thanks a lot for the great comments, Colin P. McCabe I updated the patch to split the checkBlockPool function into the two functions you suggested. Could you give another review? Thanks!
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks, Lei (Eddy) Xu.

          checkBlockPool feels like an awkward name. It makes me think this function is doing something to validate the contents of the block pool-- when in fact, it's just checking for existence. And the fact that it can also check for non-existence if false is passed makes it even more confusing.

          How about splitting this into a verifyBlockPoolExists function for verifying that the block pool exists, and a verifyBlockPoolMissing function for verifying that the block pool is missing?

          Show
          cmccabe Colin P. McCabe added a comment - Thanks, Lei (Eddy) Xu . checkBlockPool feels like an awkward name. It makes me think this function is doing something to validate the contents of the block pool-- when in fact, it's just checking for existence. And the fact that it can also check for non-existence if false is passed makes it even more confusing. How about splitting this into a verifyBlockPoolExists function for verifying that the block pool exists, and a verifyBlockPoolMissing function for verifying that the block pool is missing?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 8m 13s trunk passed
          +1 compile 0m 43s trunk passed with JDK v1.8.0_66
          +1 compile 0m 44s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 0m 57s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 2m 2s trunk passed
          +1 javadoc 1m 14s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 55s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 52s the patch passed
          +1 compile 0m 44s the patch passed with JDK v1.8.0_66
          +1 javac 0m 44s the patch passed
          +1 compile 0m 44s the patch passed with JDK v1.7.0_85
          +1 javac 0m 44s the patch passed
          +1 checkstyle 0m 18s the patch passed
          +1 mvnsite 0m 54s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 14s the patch passed
          +1 javadoc 1m 9s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 55s the patch passed with JDK v1.7.0_85
          -1 unit 58m 22s hadoop-hdfs in the patch failed with JDK v1.8.0_66.
          -1 unit 56m 5s hadoop-hdfs in the patch failed with JDK v1.7.0_85.
          -1 asflicense 0m 19s Patch generated 56 ASF License warnings.
          143m 5s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner
            hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.TestRecoverStripedFile
          JDK v1.7.0_85 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure200
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure180
            hadoop.hdfs.TestLeaseRecovery2
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090
            hadoop.hdfs.server.datanode.TestBlockReplacement



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775887/HDFS-9281.02.patch
          JIRA Issue HDFS-9281
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 19af207543a3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / bc6d8d9
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13782/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/13782/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13782/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13782/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13782/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13782/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Max memory used 75MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13782/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 8m 13s trunk passed +1 compile 0m 43s trunk passed with JDK v1.8.0_66 +1 compile 0m 44s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 2m 2s trunk passed +1 javadoc 1m 14s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 55s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 52s the patch passed +1 compile 0m 44s the patch passed with JDK v1.8.0_66 +1 javac 0m 44s the patch passed +1 compile 0m 44s the patch passed with JDK v1.7.0_85 +1 javac 0m 44s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 14s the patch passed +1 javadoc 1m 9s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 55s the patch passed with JDK v1.7.0_85 -1 unit 58m 22s hadoop-hdfs in the patch failed with JDK v1.8.0_66. -1 unit 56m 5s hadoop-hdfs in the patch failed with JDK v1.7.0_85. -1 asflicense 0m 19s Patch generated 56 ASF License warnings. 143m 5s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.hdfs.server.datanode.TestBlockScanner   hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.TestRecoverStripedFile JDK v1.7.0_85 Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure200   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure180   hadoop.hdfs.TestLeaseRecovery2   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090   hadoop.hdfs.server.datanode.TestBlockReplacement Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12775887/HDFS-9281.02.patch JIRA Issue HDFS-9281 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 19af207543a3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bc6d8d9 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13782/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13782/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13782/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13782/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13782/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13782/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13782/console This message was automatically generated.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Update the patch after HDFS-9267 being checked in.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Update the patch after HDFS-9267 being checked in.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 8m 7s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 javac 7m 59s There were no new javac warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 23s There were no new checkstyle issues.
          -1 whitespace 0m 1s The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 2m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 1m 13s Pre-build of native portion
          -1 hdfs tests 51m 55s Tests failed in hadoop-hdfs.
              75m 37s  



          Reason Tests
          Failed unit tests hadoop.hdfs.qjournal.server.TestJournalNode
            hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
            hadoop.hdfs.TestDistributedFileSystem



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12767892/HDFS-9281.combo.00.patch
          Optional Tests javac unit findbugs checkstyle
          git revision trunk / 4c0bae2
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13126/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13126/artifact/patchprocess/whitespace.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13126/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13126/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13126/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 8m 7s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 7m 59s There were no new javac warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 23s There were no new checkstyle issues. -1 whitespace 0m 1s The patch has 6 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 13s Pre-build of native portion -1 hdfs tests 51m 55s Tests failed in hadoop-hdfs.     75m 37s   Reason Tests Failed unit tests hadoop.hdfs.qjournal.server.TestJournalNode   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.TestDistributedFileSystem Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767892/HDFS-9281.combo.00.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 4c0bae2 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13126/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13126/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13126/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13126/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13126/console This message was automatically generated.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          This combo patch includes the changes in HDFS-9267, so that it can be applied to trunk.

          Show
          eddyxu Lei (Eddy) Xu added a comment - This combo patch includes the changes in HDFS-9267 , so that it can be applied to trunk .
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          It depends some changes in HDFS-9267.

          Show
          eddyxu Lei (Eddy) Xu added a comment - It depends some changes in HDFS-9267 .

            People

            • Assignee:
              eddyxu Lei (Eddy) Xu
              Reporter:
              eddyxu Lei (Eddy) Xu
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development