Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9280

Document NFS gateway export point parameter

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      We should document the nfs.export.point configuration parameter.

      1. HDFS-9280.001.patch
        0.8 kB
        Xiao Chen
      2. HDFS-9280.002.patch
        0.9 kB
        Xiao Chen

        Activity

        Hide
        xiaochen Xiao Chen added a comment -

        Hi Zhe Zhang, thanks for creating this JIRA!
        I have read up the code and surrounding documents, but came up with this really short patch 001. Please see if it makes sense to you, and feel free to comment if you think we need to provide more information. Thank you.

        Show
        xiaochen Xiao Chen added a comment - Hi Zhe Zhang , thanks for creating this JIRA! I have read up the code and surrounding documents, but came up with this really short patch 001. Please see if it makes sense to you, and feel free to comment if you think we need to provide more information. Thank you.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks for the patch Xiao! It looks good to me overall. Some suggestions:

        1. In the context of NFS I believe it's usually called "export" instead of "mount" point.
        2. It's great that you documented the full path requirement and default value. Maybe also add that current we only support a single export point in NFS gateway? In single-node OSes NFS could have multiple export points.
        3. Maybe we should consider moving HdfsNfsGateway.md to the hadoop-hdfs-nfs module? Brandon Li Could you share some advice here? Thanks..
        Show
        zhz Zhe Zhang added a comment - Thanks for the patch Xiao! It looks good to me overall. Some suggestions: In the context of NFS I believe it's usually called "export" instead of "mount" point. It's great that you documented the full path requirement and default value. Maybe also add that current we only support a single export point in NFS gateway? In single-node OSes NFS could have multiple export points. Maybe we should consider moving HdfsNfsGateway.md to the hadoop-hdfs-nfs module? Brandon Li Could you share some advice here? Thanks..
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks Zhe for the review! Attached patch 002 addresses your comments.
        The patch is still based on the current file in hdfs module. I'll create a new patch if relocation is needed.

        Show
        xiaochen Xiao Chen added a comment - Thanks Zhe for the review! Attached patch 002 addresses your comments. The patch is still based on the current file in hdfs module. I'll create a new patch if relocation is needed.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Xiao! +1 on the latest patch. Triggering Jenkins.

        I think moving the file should be done in a separate JIRA anyway.

        Show
        zhz Zhe Zhang added a comment - Thanks Xiao! +1 on the latest patch. Triggering Jenkins. I think moving the file should be done in a separate JIRA anyway.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 3m 35s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 site 3m 34s Site still builds.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
            7m 36s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12768089/HDFS-9280.002.patch
        Optional Tests site
        git revision trunk / 4c0bae2
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13127/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 3m 35s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 3m 34s Site still builds. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     7m 36s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12768089/HDFS-9280.002.patch Optional Tests site git revision trunk / 4c0bae2 Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13127/console This message was automatically generated.
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks Zhe for submitting the patch. I thought Hadoop QA will -1 me since no tests included - apparently it's smart!

        Show
        xiaochen Xiao Chen added a comment - Thanks Zhe for submitting the patch. I thought Hadoop QA will -1 me since no tests included - apparently it's smart!
        Hide
        zhz Zhe Zhang added a comment -

        Yes Jenkins is smart enough to tell it's a document patch

        I just committed the patch to trunk and branch-2. Thanks Xiao for the work!

        Show
        zhz Zhe Zhang added a comment - Yes Jenkins is smart enough to tell it's a document patch I just committed the patch to trunk and branch-2. Thanks Xiao for the work!
        Hide
        xiaochen Xiao Chen added a comment -

        Thanks for committing Zhe!

        Show
        xiaochen Xiao Chen added a comment - Thanks for committing Zhe!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8690 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8690/)
        HDFS-9280. Document NFS gateway export point parameter. Contributed by (zhz: rev aea26bf4dd12316d1a7b15924607165b581a12ab)

        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsNfsGateway.md
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8690 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8690/ ) HDFS-9280 . Document NFS gateway export point parameter. Contributed by (zhz: rev aea26bf4dd12316d1a7b15924607165b581a12ab) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsNfsGateway.md hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #570 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/570/)
        HDFS-9280. Document NFS gateway export point parameter. Contributed by (zhz: rev aea26bf4dd12316d1a7b15924607165b581a12ab)

        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsNfsGateway.md
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #570 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/570/ ) HDFS-9280 . Document NFS gateway export point parameter. Contributed by (zhz: rev aea26bf4dd12316d1a7b15924607165b581a12ab) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsNfsGateway.md hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1306 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1306/)
        HDFS-9280. Document NFS gateway export point parameter. Contributed by (zhz: rev aea26bf4dd12316d1a7b15924607165b581a12ab)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsNfsGateway.md
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1306 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1306/ ) HDFS-9280 . Document NFS gateway export point parameter. Contributed by (zhz: rev aea26bf4dd12316d1a7b15924607165b581a12ab) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsNfsGateway.md
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #585 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/585/)
        HDFS-9280. Document NFS gateway export point parameter. Contributed by (zhz: rev aea26bf4dd12316d1a7b15924607165b581a12ab)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsNfsGateway.md
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #585 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/585/ ) HDFS-9280 . Document NFS gateway export point parameter. Contributed by (zhz: rev aea26bf4dd12316d1a7b15924607165b581a12ab) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsNfsGateway.md
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2517 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2517/)
        HDFS-9280. Document NFS gateway export point parameter. Contributed by (zhz: rev aea26bf4dd12316d1a7b15924607165b581a12ab)

        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsNfsGateway.md
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2517 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2517/ ) HDFS-9280 . Document NFS gateway export point parameter. Contributed by (zhz: rev aea26bf4dd12316d1a7b15924607165b581a12ab) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsNfsGateway.md hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2465 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2465/)
        HDFS-9280. Document NFS gateway export point parameter. Contributed by (zhz: rev aea26bf4dd12316d1a7b15924607165b581a12ab)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsNfsGateway.md
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2465 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2465/ ) HDFS-9280 . Document NFS gateway export point parameter. Contributed by (zhz: rev aea26bf4dd12316d1a7b15924607165b581a12ab) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsNfsGateway.md
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #528 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/528/)
        HDFS-9280. Document NFS gateway export point parameter. Contributed by (zhz: rev aea26bf4dd12316d1a7b15924607165b581a12ab)

        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsNfsGateway.md
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #528 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/528/ ) HDFS-9280 . Document NFS gateway export point parameter. Contributed by (zhz: rev aea26bf4dd12316d1a7b15924607165b581a12ab) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsNfsGateway.md hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            xiaochen Xiao Chen
            Reporter:
            zhz Zhe Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development