Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9278

Fix preferredBlockSize typo in OIV XML output

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: tools
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      The preferred block size XML element has been corrected from "\<perferredBlockSize>" to "\<preferredBlockSize>".

      Description

      I found a typo in the offline image viewer.

        Activity

        Hide
        templedf Daniel Templeton added a comment -

        Looks good to me. +1 (non-binding)

        Show
        templedf Daniel Templeton added a comment - Looks good to me. +1 (non-binding)
        Hide
        andrew.wang Andrew Wang added a comment -

        LGTM, targeting this for 3.0 since this is a user visible change. Will commit when Jenkins comes back clean, thanks for fixing this Nicole!

        Show
        andrew.wang Andrew Wang added a comment - LGTM, targeting this for 3.0 since this is a user visible change. Will commit when Jenkins comes back clean, thanks for fixing this Nicole!
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 18m 6s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 55s There were no new javac warning messages.
        +1 javadoc 10m 24s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 26s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 30s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 11s Pre-build of native portion
        -1 hdfs tests 52m 6s Tests failed in hadoop-hdfs.
            98m 9s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.blockmanagement.TestNodeCount
          hadoop.hdfs.server.blockmanagement.TestBlockManager
          hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
          hadoop.hdfs.TestDFSClientRetries



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12767812/HDFS-9278.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / e27c2ae
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13109/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13109/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13109/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13109/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 6s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 55s There were no new javac warning messages. +1 javadoc 10m 24s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 26s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 11s Pre-build of native portion -1 hdfs tests 52m 6s Tests failed in hadoop-hdfs.     98m 9s   Reason Tests Failed unit tests hadoop.hdfs.server.blockmanagement.TestNodeCount   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints   hadoop.hdfs.TestDFSClientRetries Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767812/HDFS-9278.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / e27c2ae Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13109/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13109/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13109/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13109/console This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Committed to trunk, thanks for the contribution Nicole and reviewing Daniel!

        Show
        andrew.wang Andrew Wang added a comment - Committed to trunk, thanks for the contribution Nicole and reviewing Daniel!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8683 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8683/)
        HDFS-9278. Fix preferredBlockSize typo in OIV XML output. Contributed by (wang: rev a24c6e84205c684ef864b0fc5301dc07b3578351)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8683 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8683/ ) HDFS-9278 . Fix preferredBlockSize typo in OIV XML output. Contributed by (wang: rev a24c6e84205c684ef864b0fc5301dc07b3578351) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #580 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/580/)
        HDFS-9278. Fix preferredBlockSize typo in OIV XML output. Contributed by (wang: rev a24c6e84205c684ef864b0fc5301dc07b3578351)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #580 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/580/ ) HDFS-9278 . Fix preferredBlockSize typo in OIV XML output. Contributed by (wang: rev a24c6e84205c684ef864b0fc5301dc07b3578351) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1301 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1301/)
        HDFS-9278. Fix preferredBlockSize typo in OIV XML output. Contributed by (wang: rev a24c6e84205c684ef864b0fc5301dc07b3578351)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1301 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1301/ ) HDFS-9278 . Fix preferredBlockSize typo in OIV XML output. Contributed by (wang: rev a24c6e84205c684ef864b0fc5301dc07b3578351) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #565 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/565/)
        HDFS-9278. Fix preferredBlockSize typo in OIV XML output. Contributed by (wang: rev a24c6e84205c684ef864b0fc5301dc07b3578351)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #565 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/565/ ) HDFS-9278 . Fix preferredBlockSize typo in OIV XML output. Contributed by (wang: rev a24c6e84205c684ef864b0fc5301dc07b3578351) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2513 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2513/)
        HDFS-9278. Fix preferredBlockSize typo in OIV XML output. Contributed by (wang: rev a24c6e84205c684ef864b0fc5301dc07b3578351)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2513 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2513/ ) HDFS-9278 . Fix preferredBlockSize typo in OIV XML output. Contributed by (wang: rev a24c6e84205c684ef864b0fc5301dc07b3578351) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #524 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/524/)
        HDFS-9278. Fix preferredBlockSize typo in OIV XML output. Contributed by (wang: rev a24c6e84205c684ef864b0fc5301dc07b3578351)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #524 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/524/ ) HDFS-9278 . Fix preferredBlockSize typo in OIV XML output. Contributed by (wang: rev a24c6e84205c684ef864b0fc5301dc07b3578351) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2461 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2461/)
        HDFS-9278. Fix preferredBlockSize typo in OIV XML output. Contributed by (wang: rev a24c6e84205c684ef864b0fc5301dc07b3578351)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2461 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2461/ ) HDFS-9278 . Fix preferredBlockSize typo in OIV XML output. Contributed by (wang: rev a24c6e84205c684ef864b0fc5301dc07b3578351) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageXmlWriter.java

          People

          • Assignee:
            npazmany Nicole Pazmany
            Reporter:
            npazmany Nicole Pazmany
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development