Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9251

Refactor TestWriteToReplica and TestFsDatasetImpl to avoid explicitly creating Files in tests code.

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 2.7.1
        • Fix Version/s: 2.8.0, 3.0.0-alpha1
        • Component/s: test
        • Labels:
          None
        • Target Version/s:
        • Hadoop Flags:
          Reviewed

          Description

          In TestWriteToReplica and TestFsDatasetImpl, tests directly creates block and metadata files:

          replicaInfo.getBlockFile().createNewFile();
replicaInfo.getMetaFile().createNewFile();

          It leaks the implementation details of FsDatasetImpl. This JIRA proposes to use FsDatasetImplTestUtils (HDFS-9188) to create replicas.

          1. Text File
            HDFS-9251.00.patch
            24 kB
            Lei (Eddy) Xu
          2. Text File
            HDFS-9251.01.patch
            24 kB
            Lei (Eddy) Xu
          3. Text File
            HDFS-9251.02.patch
            24 kB
            Lei (Eddy) Xu

            Activity

            Descending order - Click to sort in ascending order
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Hdfs-trunk #2455 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2455/)
            HDFS-9251. Refactor TestWriteToReplica and TestFsDatasetImpl to avoid (lei: rev 71e533a153cbe547c99d2bc18c4cd8b7da9b00b7)

            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
            • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2455 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2455/ ) HDFS-9251 . Refactor TestWriteToReplica and TestFsDatasetImpl to avoid (lei: rev 71e533a153cbe547c99d2bc18c4cd8b7da9b00b7) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #518 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/518/)
            HDFS-9251. Refactor TestWriteToReplica and TestFsDatasetImpl to avoid (lei: rev 71e533a153cbe547c99d2bc18c4cd8b7da9b00b7)

            • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #518 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/518/ ) HDFS-9251 . Refactor TestWriteToReplica and TestFsDatasetImpl to avoid (lei: rev 71e533a153cbe547c99d2bc18c4cd8b7da9b00b7) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Hadoop-Yarn-trunk #1293 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1293/)
            HDFS-9251. Refactor TestWriteToReplica and TestFsDatasetImpl to avoid (lei: rev 71e533a153cbe547c99d2bc18c4cd8b7da9b00b7)

            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java
            • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1293 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1293/ ) HDFS-9251 . Refactor TestWriteToReplica and TestFsDatasetImpl to avoid (lei: rev 71e533a153cbe547c99d2bc18c4cd8b7da9b00b7) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Mapreduce-trunk #2505 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2505/)
            HDFS-9251. Refactor TestWriteToReplica and TestFsDatasetImpl to avoid (lei: rev 71e533a153cbe547c99d2bc18c4cd8b7da9b00b7)

            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java
            • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2505 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2505/ ) HDFS-9251 . Refactor TestWriteToReplica and TestFsDatasetImpl to avoid (lei: rev 71e533a153cbe547c99d2bc18c4cd8b7da9b00b7) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #572 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/572/)
            HDFS-9251. Refactor TestWriteToReplica and TestFsDatasetImpl to avoid (lei: rev 71e533a153cbe547c99d2bc18c4cd8b7da9b00b7)

            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java
            • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #572 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/572/ ) HDFS-9251 . Refactor TestWriteToReplica and TestFsDatasetImpl to avoid (lei: rev 71e533a153cbe547c99d2bc18c4cd8b7da9b00b7) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #557 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/557/)
            HDFS-9251. Refactor TestWriteToReplica and TestFsDatasetImpl to avoid (lei: rev 71e533a153cbe547c99d2bc18c4cd8b7da9b00b7)

            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java
            • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #557 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/557/ ) HDFS-9251 . Refactor TestWriteToReplica and TestFsDatasetImpl to avoid (lei: rev 71e533a153cbe547c99d2bc18c4cd8b7da9b00b7) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-trunk-Commit #8670 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8670/)
            HDFS-9251. Refactor TestWriteToReplica and TestFsDatasetImpl to avoid (lei: rev 71e533a153cbe547c99d2bc18c4cd8b7da9b00b7)

            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java
            • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8670 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8670/ ) HDFS-9251 . Refactor TestWriteToReplica and TestFsDatasetImpl to avoid (lei: rev 71e533a153cbe547c99d2bc18c4cd8b7da9b00b7) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImplTestUtils.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/FsDatasetTestUtils.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestFsDatasetImpl.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
            Hide
            Permalink
            eddyxu Lei (Eddy) Xu added a comment -

            Thanks for the feedbacks and reviews, Colin P. McCabe.

            Committed to trunk and branch-2.

            Show
            eddyxu Lei (Eddy) Xu added a comment - Thanks for the feedbacks and reviews, Colin P. McCabe . Committed to trunk and branch-2.
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -



            -1 overall



            Vote Subsystem Runtime Comment
            -1 pre-patch 7m 59s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
            +1 javac 7m 54s There were no new javac warning messages.
            +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
            +1 checkstyle 1m 26s There were no new checkstyle issues.
            +1 whitespace 0m 1s The patch has no lines that end in whitespace.
            +1 install 1m 31s mvn install still works.
            +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
            +1 findbugs 2m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
            +1 native 1m 5s Pre-build of native portion
            +1 hdfs tests 49m 34s Tests passed in hadoop-hdfs.
                73m 2s  



            Subsystem Report/Notes
            Patch URL http://issues.apache.org/jira/secure/attachment/12767396/HDFS-9251.02.patch
            Optional Tests javac unit findbugs checkstyle
            git revision trunk / 7e2837f
            Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13072/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
            hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13072/artifact/patchprocess/testrun_hadoop-hdfs.txt
            Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13072/testReport/
            Java 1.7.0_55
            uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
            Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13072/console

            This message was automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 7m 59s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 7m 54s There were no new javac warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 26s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 33s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 5s Pre-build of native portion +1 hdfs tests 49m 34s Tests passed in hadoop-hdfs.     73m 2s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767396/HDFS-9251.02.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 7e2837f Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13072/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13072/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13072/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13072/console This message was automatically generated.
            Hide
            Permalink
            cmccabe Colin P. McCabe added a comment -

            +1 pending Jenkins. Thanks, Lei (Eddy) Xu.

            Show
            cmccabe Colin P. McCabe added a comment - +1 pending Jenkins. Thanks, Lei (Eddy) Xu .
            Hide
            Permalink
            eddyxu Lei (Eddy) Xu added a comment -

            Thanks for the inputs, Colin P. McCabe.

            I removed the precondition checks as you suggested in the patch.

            Show
            eddyxu Lei (Eddy) Xu added a comment - Thanks for the inputs, Colin P. McCabe . I removed the precondition checks as you suggested in the patch.
            Hide
            Permalink
            cmccabe Colin P. McCabe added a comment -

            Thanks, Lei (Eddy) Xu.

            222	    Preconditions.checkArgument(volume instanceof FsVolumeImpl);

            We should not have these lines. The test is FsDatasetImplTestUtils.java, so we know that the volume must be an instance of FsVolumeImpl. The only way it could not be is if there was a bug, which we don't want to hide.

            Looks good aside from that.

            Show
            cmccabe Colin P. McCabe added a comment - Thanks, Lei (Eddy) Xu . 222 Preconditions.checkArgument(volume instanceof FsVolumeImpl); We should not have these lines. The test is FsDatasetImplTestUtils.java , so we know that the volume must be an instance of FsVolumeImpl . The only way it could not be is if there was a bug, which we don't want to hide. Looks good aside from that.
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -



            -1 overall



            Vote Subsystem Runtime Comment
            -1 pre-patch 7m 53s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
            +1 javac 9m 2s There were no new javac warning messages.
            +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
            +1 checkstyle 1m 34s There were no new checkstyle issues.
            +1 whitespace 0m 1s The patch has no lines that end in whitespace.
            +1 install 1m 43s mvn install still works.
            +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse.
            +1 findbugs 2m 54s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
            +1 native 1m 13s Pre-build of native portion
            +1 hdfs tests 55m 13s Tests passed in hadoop-hdfs.
                80m 35s  



            Subsystem Report/Notes
            Patch URL http://issues.apache.org/jira/secure/attachment/12766916/HDFS-9251.01.patch
            Optional Tests javac unit findbugs checkstyle
            git revision trunk / cf23f2c
            Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13016/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
            hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13016/artifact/patchprocess/testrun_hadoop-hdfs.txt
            Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13016/testReport/
            Java 1.7.0_55
            uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
            Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13016/console

            This message was automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 7m 53s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 9m 2s There were no new javac warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 34s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 43s mvn install still works. +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse. +1 findbugs 2m 54s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 13s Pre-build of native portion +1 hdfs tests 55m 13s Tests passed in hadoop-hdfs.     80m 35s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766916/HDFS-9251.01.patch Optional Tests javac unit findbugs checkstyle git revision trunk / cf23f2c Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13016/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13016/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13016/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13016/console This message was automatically generated.
            Hide
            Permalink
            eddyxu Lei (Eddy) Xu added a comment -

            Address whitespace warnings.

            The findbugs warnings and test failures are not relevant.

            Show
            eddyxu Lei (Eddy) Xu added a comment - Address whitespace warnings. The findbugs warnings and test failures are not relevant.
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -



            -1 overall



            Vote Subsystem Runtime Comment
            -1 pre-patch 7m 58s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
            +1 javac 7m 54s There were no new javac warning messages.
            +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
            +1 checkstyle 1m 25s There were no new checkstyle issues.
            -1 whitespace 0m 1s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
            +1 install 1m 28s mvn install still works.
            +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
            +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
            +1 native 1m 2s Pre-build of native portion
            -1 hdfs tests 50m 16s Tests failed in hadoop-hdfs.
                73m 28s  



            Reason Tests
            Failed unit tests hadoop.hdfs.server.datanode.TestDirectoryScanner



            Subsystem Report/Notes
            Patch URL http://issues.apache.org/jira/secure/attachment/12766872/HDFS-9251.00.patch
            Optional Tests javac unit findbugs checkstyle
            git revision trunk / 8d2d3eb
            Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13011/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
            whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13011/artifact/patchprocess/whitespace.txt
            hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13011/artifact/patchprocess/testrun_hadoop-hdfs.txt
            Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13011/testReport/
            Java 1.7.0_55
            uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
            Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13011/console

            This message was automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 7m 58s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 javac 7m 54s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 25s There were no new checkstyle issues. -1 whitespace 0m 1s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 2s Pre-build of native portion -1 hdfs tests 50m 16s Tests failed in hadoop-hdfs.     73m 28s   Reason Tests Failed unit tests hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766872/HDFS-9251.00.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 8d2d3eb Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13011/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/13011/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13011/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13011/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13011/console This message was automatically generated.
            Hide
            Permalink
            eddyxu Lei (Eddy) Xu added a comment -

            This patch:

            • Add CreateFinalizedReplica, CreateRbw, CreateReplicaInPipeline, CreateRBW and CreateReplicaWaitingToBeRecovered to FsDatasetTestUtils.
            • Refactor TestFsDatasetImpl and TestWriteToReplica to use them.
            Show
            eddyxu Lei (Eddy) Xu added a comment - This patch: Add CreateFinalizedReplica , CreateRbw , CreateReplicaInPipeline , CreateRBW and CreateReplicaWaitingToBeRecovered to FsDatasetTestUtils . Refactor TestFsDatasetImpl and TestWriteToReplica to use them.

              People

              • Assignee:
                eddyxu Lei (Eddy) Xu
                Reporter:
                eddyxu Lei (Eddy) Xu
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development