Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9245

Fix findbugs warnings in hdfs-nfs/WriteCtx

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: nfs
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      There are findbugs warnings as follows, brought by HDFS-9092.

      It seems fine to ignore them by write a filter rule in the findbugsExcludeFile.xml file.

      <BugInstance rank="17" category="MT_CORRECTNESS" instanceHash="592511935f7cb9e5f97ef4c99a6c46c2" instanceOccurrenceNum="0" priority="2" abbrev="IS" type="IS2_INCONSISTENT_SYNC" cweid="366" instanceOccurrenceMax="0">
      <ShortMessage>Inconsistent synchronization</ShortMessage>
      <LongMessage>
      Inconsistent synchronization of org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx.offset; locked 75% of time
      </LongMessage>
      <Class classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx" primary="true">
      <SourceLine start="40" classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx" sourcepath="org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java" sourcefile="WriteCtx.java" end="314">
      <Message>At WriteCtx.java:[lines 40-314]</Message>
      </SourceLine>
      <Message>In class org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx</Message>
      </Class>
      

      and

      <BugInstance rank="17" category="MT_CORRECTNESS" instanceHash="4f3daa339eb819220f26c998369b02fe" instanceOccurrenceNum="0" priority="2" abbrev="IS" type="IS2_INCONSISTENT_SYNC" cweid="366" instanceOccurrenceMax="0">
      <ShortMessage>Inconsistent synchronization</ShortMessage>
      <LongMessage>
      Inconsistent synchronization of org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx.originalCount; locked 50% of time
      </LongMessage>
      <Class classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx" primary="true">
      <SourceLine start="40" classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx" sourcepath="org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java" sourcefile="WriteCtx.java" end="314">
      <Message>At WriteCtx.java:[lines 40-314]</Message>
      </SourceLine>
      <Message>In class org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx</Message>
      </Class>
      <Field isStatic="false" classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx" name="originalCount" primary="true" signature="I">
      <SourceLine classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx" sourcepath="org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java" sourcefile="WriteCtx.java">
      <Message>In WriteCtx.java</Message>
      </SourceLine>
      <Message>
      Field org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx.originalCount
      </Message>
      </Field>
      
      1. HDFS-9245.000.patch
        0.9 kB
        Mingliang Liu
      2. HDFS-9245.001.patch
        2 kB
        Mingliang Liu
      3. HDFS-9245.002.patch
        2 kB
        Mingliang Liu

        Activity

        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #594 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/594/)
        HDFS-9245. Fix findbugs warnings in hdfs-nfs/WriteCtx. Contributed by (xyao: rev 6e4562b844dfbbbdc0074323900eb69ee2a3e9c2)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #594 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/594/ ) HDFS-9245 . Fix findbugs warnings in hdfs-nfs/WriteCtx. Contributed by (xyao: rev 6e4562b844dfbbbdc0074323900eb69ee2a3e9c2) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2533 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2533/)
        HDFS-9245. Fix findbugs warnings in hdfs-nfs/WriteCtx. Contributed by (xyao: rev 6e4562b844dfbbbdc0074323900eb69ee2a3e9c2)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2533 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2533/ ) HDFS-9245 . Fix findbugs warnings in hdfs-nfs/WriteCtx. Contributed by (xyao: rev 6e4562b844dfbbbdc0074323900eb69ee2a3e9c2) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1390 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1390/)
        HDFS-9245. Fix findbugs warnings in hdfs-nfs/WriteCtx. Contributed by (xyao: rev 6e4562b844dfbbbdc0074323900eb69ee2a3e9c2)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1390 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1390/ ) HDFS-9245 . Fix findbugs warnings in hdfs-nfs/WriteCtx. Contributed by (xyao: rev 6e4562b844dfbbbdc0074323900eb69ee2a3e9c2) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2594 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2594/)
        HDFS-9245. Fix findbugs warnings in hdfs-nfs/WriteCtx. Contributed by (xyao: rev 6e4562b844dfbbbdc0074323900eb69ee2a3e9c2)

        • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2594 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2594/ ) HDFS-9245 . Fix findbugs warnings in hdfs-nfs/WriteCtx. Contributed by (xyao: rev 6e4562b844dfbbbdc0074323900eb69ee2a3e9c2) hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #666 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/666/)
        HDFS-9245. Fix findbugs warnings in hdfs-nfs/WriteCtx. Contributed by (xyao: rev 6e4562b844dfbbbdc0074323900eb69ee2a3e9c2)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #666 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/666/ ) HDFS-9245 . Fix findbugs warnings in hdfs-nfs/WriteCtx. Contributed by (xyao: rev 6e4562b844dfbbbdc0074323900eb69ee2a3e9c2) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #654 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/654/)
        HDFS-9245. Fix findbugs warnings in hdfs-nfs/WriteCtx. Contributed by (xyao: rev 6e4562b844dfbbbdc0074323900eb69ee2a3e9c2)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #654 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/654/ ) HDFS-9245 . Fix findbugs warnings in hdfs-nfs/WriteCtx. Contributed by (xyao: rev 6e4562b844dfbbbdc0074323900eb69ee2a3e9c2) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8789 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8789/)
        HDFS-9245. Fix findbugs warnings in hdfs-nfs/WriteCtx. Contributed by (xyao: rev 6e4562b844dfbbbdc0074323900eb69ee2a3e9c2)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8789 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8789/ ) HDFS-9245 . Fix findbugs warnings in hdfs-nfs/WriteCtx. Contributed by (xyao: rev 6e4562b844dfbbbdc0074323900eb69ee2a3e9c2) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java
        Hide
        liuml07 Mingliang Liu added a comment -

        Thanks Li Lu and Brandon Li for your review and offline discussion. Thanks Xiaoyu Yao for your review and commit.

        Show
        liuml07 Mingliang Liu added a comment - Thanks Li Lu and Brandon Li for your review and offline discussion. Thanks Xiaoyu Yao for your review and commit.
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Mingliang Liu for the contribution and all for the reviews. I've committed the patch to trunk and branch-2.

        Show
        xyao Xiaoyu Yao added a comment - Thanks Mingliang Liu for the contribution and all for the reviews. I've committed the patch to trunk and branch-2.
        Hide
        xyao Xiaoyu Yao added a comment -

        cc: Allen Wittenauer who may have an answer to this. It looks like a Infra issue unrelated to this change.
        I will commit it later today if I have not heard any additional comments by EOD today.

        Show
        xyao Xiaoyu Yao added a comment - cc: Allen Wittenauer who may have an answer to this. It looks like a Infra issue unrelated to this change. I will commit it later today if I have not heard any additional comments by EOD today.
        Hide
        liuml07 Mingliang Liu added a comment -

        Thanks for the review, Xiaoyu Yao. I validated locally too and found the findbugs issue was gone with this patch.

        Though there is findbugs warnings in the pre-patch findbugs warnings, the comment table says:

        The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 2 pre-existing warnings.

        It should be fine?

        Show
        liuml07 Mingliang Liu added a comment - Thanks for the review, Xiaoyu Yao . I validated locally too and found the findbugs issue was gone with this patch. Though there is findbugs warnings in the pre-patch findbugs warnings, the comment table says: The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 2 pre-existing warnings. It should be fine?
        Hide
        xyao Xiaoyu Yao added a comment -

        Patch v002 LGTM. +1. I validated locally that it fixed the two findbugs issue on IS2_INCONSISTENT_SYNC.

        Not sure why Jenkins still reported the same issue with the latest patch.
        https://builds.apache.org/job/PreCommit-HDFS-Build/13201/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs-nfs.html

        Show
        xyao Xiaoyu Yao added a comment - Patch v002 LGTM. +1. I validated locally that it fixed the two findbugs issue on IS2_INCONSISTENT_SYNC. Not sure why Jenkins still reported the same issue with the latest patch. https://builds.apache.org/job/PreCommit-HDFS-Build/13201/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs-nfs.html
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 16m 45s Pre-patch trunk has 2 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 8m 2s There were no new javac warning messages.
        +1 javadoc 10m 32s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 24s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        +1 findbugs 0m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 2 pre-existing warnings.
        +1 native 3m 12s Pre-build of native portion
        +1 hdfs tests 1m 48s Tests passed in hadoop-hdfs-nfs.
            44m 8s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12768785/HDFS-9245.002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 2f1eb2b
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13201/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs-nfs.html
        hadoop-hdfs-nfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13201/artifact/patchprocess/testrun_hadoop-hdfs-nfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13201/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13201/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 45s Pre-patch trunk has 2 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 2s There were no new javac warning messages. +1 javadoc 10m 32s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 24s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 0m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 2 pre-existing warnings. +1 native 3m 12s Pre-build of native portion +1 hdfs tests 1m 48s Tests passed in hadoop-hdfs-nfs.     44m 8s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12768785/HDFS-9245.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2f1eb2b Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13201/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs-nfs.html hadoop-hdfs-nfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13201/artifact/patchprocess/testrun_hadoop-hdfs-nfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13201/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13201/console This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        The v2 patch addresses the checkstyle warnings.

        Show
        liuml07 Mingliang Liu added a comment - The v2 patch addresses the checkstyle warnings.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 18m 1s Pre-patch trunk has 2 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 8m 45s There were no new javac warning messages.
        +1 javadoc 11m 6s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 25s The applied patch generated 2 new checkstyle issues (total was 6, now 8).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
        +1 findbugs 0m 54s The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 2 pre-existing warnings.
        +1 native 3m 32s Pre-build of native portion
        +1 hdfs tests 1m 52s Tests passed in hadoop-hdfs-nfs.
            47m 15s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12768574/HDFS-9245.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 446212a
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13185/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs-nfs.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13185/artifact/patchprocess/diffcheckstylehadoop-hdfs-nfs.txt
        hadoop-hdfs-nfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13185/artifact/patchprocess/testrun_hadoop-hdfs-nfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13185/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13185/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 1s Pre-patch trunk has 2 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 45s There were no new javac warning messages. +1 javadoc 11m 6s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 25s The applied patch generated 2 new checkstyle issues (total was 6, now 8). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 0m 54s The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 2 pre-existing warnings. +1 native 3m 32s Pre-build of native portion +1 hdfs tests 1m 52s Tests passed in hadoop-hdfs-nfs.     47m 15s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12768574/HDFS-9245.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 446212a Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13185/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs-nfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13185/artifact/patchprocess/diffcheckstylehadoop-hdfs-nfs.txt hadoop-hdfs-nfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13185/artifact/patchprocess/testrun_hadoop-hdfs-nfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13185/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13185/console This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        Per offline discussion withHaohui Mai and Li Lu, the volatile is considered premature optimization. The v1 patch simply use the synchronized block for accessors. The main observation is that synchronized read is not in critical path.

        Show
        liuml07 Mingliang Liu added a comment - Per offline discussion with Haohui Mai and Li Lu , the volatile is considered premature optimization. The v1 patch simply use the synchronized block for accessors. The main observation is that synchronized read is not in critical path.
        Hide
        liuml07 Mingliang Liu added a comment -

        Per offline discussion with Brandon Li, the volatile works just fine.

        Show
        liuml07 Mingliang Liu added a comment - Per offline discussion with Brandon Li , the volatile works just fine.
        Hide
        gtCarrera9 Li Lu added a comment -

        Yes I think using volatile here is appropriate. Findbugs also turned green for the fix.

        Show
        gtCarrera9 Li Lu added a comment - Yes I think using volatile here is appropriate. Findbugs also turned green for the fix.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 18m 6s Pre-patch trunk has 2 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 8m 49s There were no new javac warning messages.
        +1 javadoc 11m 22s There were no new javadoc warning messages.
        +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 25s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse.
        +1 findbugs 0m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 2 pre-existing warnings.
        +1 native 3m 40s Pre-build of native portion
        +1 hdfs tests 1m 53s Tests passed in hadoop-hdfs-nfs.
            47m 54s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12766930/HDFS-9245.000.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / cf23f2c
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13019/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs-nfs.html
        hadoop-hdfs-nfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13019/artifact/patchprocess/testrun_hadoop-hdfs-nfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13019/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13019/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 6s Pre-patch trunk has 2 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 8m 49s There were no new javac warning messages. +1 javadoc 11m 22s There were no new javadoc warning messages. +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 25s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse. +1 findbugs 0m 55s The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 2 pre-existing warnings. +1 native 3m 40s Pre-build of native portion +1 hdfs tests 1m 53s Tests passed in hadoop-hdfs-nfs.     47m 54s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766930/HDFS-9245.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / cf23f2c Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13019/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs-nfs.html hadoop-hdfs-nfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13019/artifact/patchprocess/testrun_hadoop-hdfs-nfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13019/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13019/console This message was automatically generated.
        Hide
        liuml07 Mingliang Liu added a comment -

        Hi Yongjun Zhang, please review the patch v0. Thanks.

        Show
        liuml07 Mingliang Liu added a comment - Hi Yongjun Zhang , please review the patch v0. Thanks.

          People

          • Assignee:
            liuml07 Mingliang Liu
            Reporter:
            liuml07 Mingliang Liu
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development