Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9245

Fix findbugs warnings in hdfs-nfs/WriteCtx

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: nfs
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      There are findbugs warnings as follows, brought by HDFS-9092.

      It seems fine to ignore them by write a filter rule in the findbugsExcludeFile.xml file.

      <BugInstance rank="17" category="MT_CORRECTNESS" instanceHash="592511935f7cb9e5f97ef4c99a6c46c2" instanceOccurrenceNum="0" priority="2" abbrev="IS" type="IS2_INCONSISTENT_SYNC" cweid="366" instanceOccurrenceMax="0">
      <ShortMessage>Inconsistent synchronization</ShortMessage>
      <LongMessage>
      Inconsistent synchronization of org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx.offset; locked 75% of time
      </LongMessage>
      <Class classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx" primary="true">
      <SourceLine start="40" classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx" sourcepath="org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java" sourcefile="WriteCtx.java" end="314">
      <Message>At WriteCtx.java:[lines 40-314]</Message>
      </SourceLine>
      <Message>In class org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx</Message>
      </Class>
      

      and

      <BugInstance rank="17" category="MT_CORRECTNESS" instanceHash="4f3daa339eb819220f26c998369b02fe" instanceOccurrenceNum="0" priority="2" abbrev="IS" type="IS2_INCONSISTENT_SYNC" cweid="366" instanceOccurrenceMax="0">
      <ShortMessage>Inconsistent synchronization</ShortMessage>
      <LongMessage>
      Inconsistent synchronization of org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx.originalCount; locked 50% of time
      </LongMessage>
      <Class classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx" primary="true">
      <SourceLine start="40" classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx" sourcepath="org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java" sourcefile="WriteCtx.java" end="314">
      <Message>At WriteCtx.java:[lines 40-314]</Message>
      </SourceLine>
      <Message>In class org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx</Message>
      </Class>
      <Field isStatic="false" classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx" name="originalCount" primary="true" signature="I">
      <SourceLine classname="org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx" sourcepath="org/apache/hadoop/hdfs/nfs/nfs3/WriteCtx.java" sourcefile="WriteCtx.java">
      <Message>In WriteCtx.java</Message>
      </SourceLine>
      <Message>
      Field org.apache.hadoop.hdfs.nfs.nfs3.WriteCtx.originalCount
      </Message>
      </Field>
      

        Attachments

        1. HDFS-9245.002.patch
          2 kB
          Mingliang Liu
        2. HDFS-9245.001.patch
          2 kB
          Mingliang Liu
        3. HDFS-9245.000.patch
          0.9 kB
          Mingliang Liu

          Activity

            People

            • Assignee:
              liuml07 Mingliang Liu
              Reporter:
              liuml07 Mingliang Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: