Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9237

NPE at TestDataNodeVolumeFailureToleration#tearDown

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Stack Trace:
      java.lang.NullPointerException: null
      at org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration.tearDown(TestDataNodeVolumeFailureToleration.java:79)
      
      1. HDFS-9237.patch
        0.9 kB
        Brahma Reddy Battula

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded the patch.. kindly review..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch.. kindly review..
        Hide
        liuml07 Mingliang Liu added a comment -

        In unit test methods we assume the cluster is not null as setup method is called before each test. This works just fine since the unit test methods won't run if setup throws an exception when constructing cluster and other resources.

        However, the @After annotated methods are guaranteed to run even if a @Before or @Test method throws an exception. Thus we'd better check the cluster before using it in tearDown.

        Another approach is to make the teadDown method throw an exception. This patch looks good to me.

        Show
        liuml07 Mingliang Liu added a comment - In unit test methods we assume the cluster is not null as setup method is called before each test. This works just fine since the unit test methods won't run if setup throws an exception when constructing cluster and other resources. However, the @After annotated methods are guaranteed to run even if a @Before or @Test method throws an exception. Thus we'd better check the cluster before using it in tearDown . Another approach is to make the teadDown method throw an exception. This patch looks good to me.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 8m 43s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 44s There were no new javac warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 33s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
        +1 findbugs 2m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 1m 6s Pre-build of native portion
        -1 hdfs tests 63m 40s Tests failed in hadoop-hdfs.
            89m 2s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestAppendSnapshotTruncate
          hadoop.hdfs.crypto.TestHdfsCryptoStreams
          hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.TestDFSStripedOutputStream
          hadoop.hdfs.TestDistributedFileSystem
          hadoop.hdfs.TestReplication
          hadoop.hdfs.server.namenode.ha.TestHAAppend
          hadoop.hdfs.TestParallelUnixDomainRead



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12766359/HDFS-9237.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 84cbd72
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12955/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12955/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12955/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12955/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 8m 43s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 44s There were no new javac warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 33s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 2m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 6s Pre-build of native portion -1 hdfs tests 63m 40s Tests failed in hadoop-hdfs.     89m 2s   Reason Tests Failed unit tests hadoop.hdfs.TestAppendSnapshotTruncate   hadoop.hdfs.crypto.TestHdfsCryptoStreams   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.TestDFSStripedOutputStream   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.TestReplication   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.TestParallelUnixDomainRead Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766359/HDFS-9237.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 84cbd72 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12955/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12955/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12955/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12955/console This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Test Case failures are unrelated.Mingliang Liu thanks for taking a look into this issue.you are correct.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Test Case failures are unrelated. Mingliang Liu thanks for taking a look into this issue.you are correct.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        +1, checking this in.

        Show
        ozawa Tsuyoshi Ozawa added a comment - +1, checking this in.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Committed this to trunk and branch-2. Thanks Brahma Reddy Battula for your review and thanks Mingliang Liu for your review.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Committed this to trunk and branch-2. Thanks Brahma Reddy Battula for your review and thanks Mingliang Liu for your review.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8660 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8660/)
        HDFS-9237. NPE at TestDataNodeVolumeFailureToleration#tearDown. (ozawa: rev 4c9c3955ae6cb5c3b67c8127eb7fa5449a0286d9)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureToleration.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8660 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8660/ ) HDFS-9237 . NPE at TestDataNodeVolumeFailureToleration#tearDown. (ozawa: rev 4c9c3955ae6cb5c3b67c8127eb7fa5449a0286d9) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureToleration.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #564 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/564/)
        HDFS-9237. NPE at TestDataNodeVolumeFailureToleration#tearDown. (ozawa: rev 4c9c3955ae6cb5c3b67c8127eb7fa5449a0286d9)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureToleration.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #564 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/564/ ) HDFS-9237 . NPE at TestDataNodeVolumeFailureToleration#tearDown. (ozawa: rev 4c9c3955ae6cb5c3b67c8127eb7fa5449a0286d9) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureToleration.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #549 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/549/)
        HDFS-9237. NPE at TestDataNodeVolumeFailureToleration#tearDown. (ozawa: rev 4c9c3955ae6cb5c3b67c8127eb7fa5449a0286d9)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureToleration.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #549 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/549/ ) HDFS-9237 . NPE at TestDataNodeVolumeFailureToleration#tearDown. (ozawa: rev 4c9c3955ae6cb5c3b67c8127eb7fa5449a0286d9) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureToleration.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1286 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1286/)
        HDFS-9237. NPE at TestDataNodeVolumeFailureToleration#tearDown. (ozawa: rev 4c9c3955ae6cb5c3b67c8127eb7fa5449a0286d9)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureToleration.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1286 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1286/ ) HDFS-9237 . NPE at TestDataNodeVolumeFailureToleration#tearDown. (ozawa: rev 4c9c3955ae6cb5c3b67c8127eb7fa5449a0286d9) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureToleration.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2498 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2498/)
        HDFS-9237. NPE at TestDataNodeVolumeFailureToleration#tearDown. (ozawa: rev 4c9c3955ae6cb5c3b67c8127eb7fa5449a0286d9)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureToleration.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2498 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2498/ ) HDFS-9237 . NPE at TestDataNodeVolumeFailureToleration#tearDown. (ozawa: rev 4c9c3955ae6cb5c3b67c8127eb7fa5449a0286d9) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureToleration.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2449 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2449/)
        HDFS-9237. NPE at TestDataNodeVolumeFailureToleration#tearDown. (ozawa: rev 4c9c3955ae6cb5c3b67c8127eb7fa5449a0286d9)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureToleration.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2449 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2449/ ) HDFS-9237 . NPE at TestDataNodeVolumeFailureToleration#tearDown. (ozawa: rev 4c9c3955ae6cb5c3b67c8127eb7fa5449a0286d9) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureToleration.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #512 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/512/)
        HDFS-9237. NPE at TestDataNodeVolumeFailureToleration#tearDown. (ozawa: rev 4c9c3955ae6cb5c3b67c8127eb7fa5449a0286d9)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureToleration.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #512 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/512/ ) HDFS-9237 . NPE at TestDataNodeVolumeFailureToleration#tearDown. (ozawa: rev 4c9c3955ae6cb5c3b67c8127eb7fa5449a0286d9) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureToleration.java
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Thanks Tsuyoshi Ozawa for review and commit!!

        Show
        brahmareddy Brahma Reddy Battula added a comment - Thanks Tsuyoshi Ozawa for review and commit!!

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            brahmareddy Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development