[HDFS-9231] fsck doesn't list correct file path when Bad Replicas/Blocks are in a snapshot

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: snapshots
• Labels: supportability
• Hadoop Flags: Reviewed
• Assignee: Xiao Chen
• Reporter: Xiao Chen
• Created: 13/Oct/15 00:33
• Updated: 30/Aug/16 01:25
• Resolved: 28/Oct/15 07:09

Description

Currently for snapshot files, fsck -list-corruptfileblocks shows corrupt blocks with the original file dir instead of the snapshot dir, and fsck -list-corruptfileblocks -includeSnapshots behave the same.
This can be confusing because even when the original file is deleted, fsck will still show that deleted file as corrupted, although what's actually corrupted is the snapshot.

As a side note, fsck -files -includeSnapshots shows the snapshot dirs.

Issue Links

• breaks: HDFS-9351 checkNNStartup() need to be called when fsck calls FSNamesystem.getSnapshottableDirs()
• breaks: HDFS-9377 Fix findbugs warnings in FSDirSnapshotOp
• relates to: HADOOP-12517 Findbugs reported 0 issues, but summary stated -1 for findbugs