Details
Test
Major
Description
Just adding some tests to validate the BlocksVerified metric.
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
+1 patch looks good, except a nit here:
- empty line mod:
@@ -86,7 +97,7 @@ public class TestDatanodeBlockScanner extends TestCase { return verificationTime; } - + public void testDatanodeBlockScanner() throws IOException {
This clearly has to be committed into 0.20 and above.
One more thing: it won't hurt to add some meaningful message to the following assert statement:
+ assertEquals(1, blocksValidated); + break;
this will facilitate the failures analysis.
I made Cos' changes. Thanks
+1 patch looks good. Please submit the patch for verification so it can be committed into the trunk and merged all the way back. Thanks.
Simply a rename to make it clear that this patch is for 20.
This patch is for trunk.
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12431382/HDFS-919.patch
against trunk revision 903381.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/104/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/104/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/104/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/104/console
This message is automatically generated.
These results look to be unrelated to my patch. The reference two other patches. I am going to resubmit to see if that clears up the issue.
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12431382/HDFS-919.patch
against trunk revision 903381.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/208/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/208/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/208/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/208/console
This message is automatically generated.
Exactly as before but with one empty line mod removed. I've done it myself in order to speed the commit.
I've just committed this to both 0.20.2, 0.21, and the trunk. Thank you Gary!
Integrated in Hadoop-Hdfs-trunk-Commit #182 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/182/)
. Create test to validate the BlocksVerified metric. Contributed by Gary Murry.
The attached patch adds the testing to TestDatanodeBlockScanner.java. Since there is a time interval that has to pass for the block scanner to run, I wanted to add my test in with one that already was waiting anyways.