Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9175

Change scope of 'AccessTokenProvider.getAccessToken()' and 'CredentialBasedAccessTokenProvider.getCredential()' abstract methods to public

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: webhdfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      org.apache.hadoop.hdfs.web.oauth2.AccessTokenProvider#getAccessToken() and org.apache.hadoop.hdfs.web.oauth2.CredentialBasedAccessTokenProvider#getCredential() abstract methods are having default scope.
      Unfortunately, it restricts the users from having the custom implementations of these classes in a different package.
      So, the proposal is to change scope of these abstract methods to public.

      1. HDFS-9175.1.patch
        1 kB
        Santhosh G Nayak

        Issue Links

          Activity

          Hide
          snayak Santhosh G Nayak added a comment -

          Attaching a patch containing the proposed changes.

          Show
          snayak Santhosh G Nayak added a comment - Attaching a patch containing the proposed changes.
          Hide
          cnauroth Chris Nauroth added a comment -

          +1 pending pre-commit run. This makes sense, given that the class itself is advertised as public. I'll submit this for pre-commit run now.

          Show
          cnauroth Chris Nauroth added a comment - +1 pending pre-commit run. This makes sense, given that the class itself is advertised as public. I'll submit this for pre-commit run now.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 17m 44s Pre-patch trunk has 7 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 59s There were no new javac warning messages.
          +1 javadoc 10m 4s There were no new javadoc warning messages.
          -1 release audit 0m 16s The applied patch generated 1 release audit warnings.
          +1 checkstyle 1m 34s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 29s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 2m 2s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 12s Pre-build of native portion
          +1 hdfs tests 0m 29s Tests passed in hadoop-hdfs-client.
              45m 27s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12764246/HDFS-9175.1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 6c17d31
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12754/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs-client.html
          Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12754/artifact/patchprocess/patchReleaseAuditProblems.txt
          hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12754/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12754/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12754/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 44s Pre-patch trunk has 7 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 59s There were no new javac warning messages. +1 javadoc 10m 4s There were no new javadoc warning messages. -1 release audit 0m 16s The applied patch generated 1 release audit warnings. +1 checkstyle 1m 34s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 2s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 12s Pre-build of native portion +1 hdfs tests 0m 29s Tests passed in hadoop-hdfs-client.     45m 27s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764246/HDFS-9175.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6c17d31 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12754/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs-client.html Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12754/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12754/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12754/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12754/console This message was automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          The release audit warning is unrelated. New tests are not relevant, because this is just changing visibility of a method that is already covered by existing unit tests. I'll commit this later today.

          Show
          cnauroth Chris Nauroth added a comment - The release audit warning is unrelated. New tests are not relevant, because this is just changing visibility of a method that is already covered by existing unit tests. I'll commit this later today.
          Hide
          cnauroth Chris Nauroth added a comment -

          I have committed this to trunk and branch-2. Santhosh G Nayak, thank you for the contribution.

          Show
          cnauroth Chris Nauroth added a comment - I have committed this to trunk and branch-2. Santhosh G Nayak , thank you for the contribution.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8549 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8549/)
          HDFS-9175. Change scope of 'AccessTokenProvider.getAccessToken()' and (cnauroth: rev c7e03c3a6cf8ccd73a1734a1d19bd8d753b2974c)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/CredentialBasedAccessTokenProvider.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/AccessTokenProvider.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8549 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8549/ ) HDFS-9175 . Change scope of 'AccessTokenProvider.getAccessToken()' and (cnauroth: rev c7e03c3a6cf8ccd73a1734a1d19bd8d753b2974c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/CredentialBasedAccessTokenProvider.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/AccessTokenProvider.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #474 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/474/)
          HDFS-9175. Change scope of 'AccessTokenProvider.getAccessToken()' and (cnauroth: rev c7e03c3a6cf8ccd73a1734a1d19bd8d753b2974c)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/AccessTokenProvider.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/CredentialBasedAccessTokenProvider.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #474 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/474/ ) HDFS-9175 . Change scope of 'AccessTokenProvider.getAccessToken()' and (cnauroth: rev c7e03c3a6cf8ccd73a1734a1d19bd8d753b2974c) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/AccessTokenProvider.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/CredentialBasedAccessTokenProvider.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #466 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/466/)
          HDFS-9175. Change scope of 'AccessTokenProvider.getAccessToken()' and (cnauroth: rev c7e03c3a6cf8ccd73a1734a1d19bd8d753b2974c)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/CredentialBasedAccessTokenProvider.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/AccessTokenProvider.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #466 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/466/ ) HDFS-9175 . Change scope of 'AccessTokenProvider.getAccessToken()' and (cnauroth: rev c7e03c3a6cf8ccd73a1734a1d19bd8d753b2974c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/CredentialBasedAccessTokenProvider.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/AccessTokenProvider.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1204 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1204/)
          HDFS-9175. Change scope of 'AccessTokenProvider.getAccessToken()' and (cnauroth: rev c7e03c3a6cf8ccd73a1734a1d19bd8d753b2974c)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/AccessTokenProvider.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/CredentialBasedAccessTokenProvider.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1204 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1204/ ) HDFS-9175 . Change scope of 'AccessTokenProvider.getAccessToken()' and (cnauroth: rev c7e03c3a6cf8ccd73a1734a1d19bd8d753b2974c) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/AccessTokenProvider.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/CredentialBasedAccessTokenProvider.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2409 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2409/)
          HDFS-9175. Change scope of 'AccessTokenProvider.getAccessToken()' and (cnauroth: rev c7e03c3a6cf8ccd73a1734a1d19bd8d753b2974c)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/AccessTokenProvider.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/CredentialBasedAccessTokenProvider.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2409 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2409/ ) HDFS-9175 . Change scope of 'AccessTokenProvider.getAccessToken()' and (cnauroth: rev c7e03c3a6cf8ccd73a1734a1d19bd8d753b2974c) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/AccessTokenProvider.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/CredentialBasedAccessTokenProvider.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2380 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2380/)
          HDFS-9175. Change scope of 'AccessTokenProvider.getAccessToken()' and (cnauroth: rev c7e03c3a6cf8ccd73a1734a1d19bd8d753b2974c)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/CredentialBasedAccessTokenProvider.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/AccessTokenProvider.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2380 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2380/ ) HDFS-9175 . Change scope of 'AccessTokenProvider.getAccessToken()' and (cnauroth: rev c7e03c3a6cf8ccd73a1734a1d19bd8d753b2974c) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/CredentialBasedAccessTokenProvider.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/AccessTokenProvider.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #440 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/440/)
          HDFS-9175. Change scope of 'AccessTokenProvider.getAccessToken()' and (cnauroth: rev c7e03c3a6cf8ccd73a1734a1d19bd8d753b2974c)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/CredentialBasedAccessTokenProvider.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/AccessTokenProvider.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #440 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/440/ ) HDFS-9175 . Change scope of 'AccessTokenProvider.getAccessToken()' and (cnauroth: rev c7e03c3a6cf8ccd73a1734a1d19bd8d753b2974c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/CredentialBasedAccessTokenProvider.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/oauth2/AccessTokenProvider.java

            People

            • Assignee:
              snayak Santhosh G Nayak
              Reporter:
              snayak Santhosh G Nayak
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development