Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9174

Fix findbugs warnings in FSOutputSummer.tracer and DirectoryScanner$ReportCompiler.currentThread

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Issue Links

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 19m 57s Pre-patch trunk has 2 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 50s There were no new javac warning messages.
        +1 javadoc 10m 2s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 28s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 31s mvn install still works.
        +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
        +1 findbugs 4m 21s The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 2 pre-existing warnings.
        -1 common tests 6m 38s Tests failed in hadoop-common.
        -1 hdfs tests 87m 22s Tests failed in hadoop-hdfs.
            141m 15s  



        Reason Tests
        Failed unit tests hadoop.net.TestDNS
          hadoop.hdfs.web.TestWebHDFSOAuth2
          hadoop.hdfs.server.namenode.TestFSNamesystem
        Timed out tests org.apache.hadoop.hdfs.TestFileAppend4
          org.apache.hadoop.hdfs.server.namenode.TestINodeAttributeProvider



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12764245/HDFS-9174.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / d6fa34e
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12740/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12740/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12740/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12740/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12740/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12740/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 19m 57s Pre-patch trunk has 2 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 50s There were no new javac warning messages. +1 javadoc 10m 2s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 28s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 4m 21s The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 2 pre-existing warnings. -1 common tests 6m 38s Tests failed in hadoop-common. -1 hdfs tests 87m 22s Tests failed in hadoop-hdfs.     141m 15s   Reason Tests Failed unit tests hadoop.net.TestDNS   hadoop.hdfs.web.TestWebHDFSOAuth2   hadoop.hdfs.server.namenode.TestFSNamesystem Timed out tests org.apache.hadoop.hdfs.TestFileAppend4   org.apache.hadoop.hdfs.server.namenode.TestINodeAttributeProvider Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764245/HDFS-9174.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d6fa34e Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12740/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12740/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/12740/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12740/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12740/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12740/console This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        The changes look good to me. +1 (non-binding)

        Show
        templedf Daniel Templeton added a comment - The changes look good to me. +1 (non-binding)
        Hide
        wheat9 Haohui Mai added a comment -

        Changing it to critical since it breaks findbugs in the current jenkins builds.

        Show
        wheat9 Haohui Mai added a comment - Changing it to critical since it breaks findbugs in the current jenkins builds.
        Hide
        wheat9 Haohui Mai added a comment -

        +1. Will commit shortly.

        Show
        wheat9 Haohui Mai added a comment - +1. Will commit shortly.
        Hide
        wheat9 Haohui Mai added a comment -

        I've committed the patch to trunk and branch-2. Thanks Yi Liu for the contribution.

        Show
        wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Yi Liu for the contribution.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8542 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8542/)
        HDFS-9174. Fix findbugs warnings in FSOutputSummer.tracer and DirectoryScanner$ReportCompiler.currentThread. Contributed by Yi Liu. (wheat9: rev 8703301b466cbc37ef53a96a55bcf6412792d5cf)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSOutputSummer.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8542 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8542/ ) HDFS-9174 . Fix findbugs warnings in FSOutputSummer.tracer and DirectoryScanner$ReportCompiler.currentThread. Contributed by Yi Liu. (wheat9: rev 8703301b466cbc37ef53a96a55bcf6412792d5cf) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSOutputSummer.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #469 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/469/)
        HDFS-9174. Fix findbugs warnings in FSOutputSummer.tracer and DirectoryScanner$ReportCompiler.currentThread. Contributed by Yi Liu. (wheat9: rev 8703301b466cbc37ef53a96a55bcf6412792d5cf)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSOutputSummer.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #469 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/469/ ) HDFS-9174 . Fix findbugs warnings in FSOutputSummer.tracer and DirectoryScanner$ReportCompiler.currentThread. Contributed by Yi Liu. (wheat9: rev 8703301b466cbc37ef53a96a55bcf6412792d5cf) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSOutputSummer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #461 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/461/)
        HDFS-9174. Fix findbugs warnings in FSOutputSummer.tracer and DirectoryScanner$ReportCompiler.currentThread. Contributed by Yi Liu. (wheat9: rev 8703301b466cbc37ef53a96a55bcf6412792d5cf)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSOutputSummer.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #461 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/461/ ) HDFS-9174 . Fix findbugs warnings in FSOutputSummer.tracer and DirectoryScanner$ReportCompiler.currentThread. Contributed by Yi Liu. (wheat9: rev 8703301b466cbc37ef53a96a55bcf6412792d5cf) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSOutputSummer.java
        Hide
        hitliuyi Yi Liu added a comment -

        Thanks Haohui Mai and Daniel Templeton for the review, and thanks Haohui for the committing.

        Show
        hitliuyi Yi Liu added a comment - Thanks Haohui Mai and Daniel Templeton for the review, and thanks Haohui for the committing.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #436 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/436/)
        HDFS-9174. Fix findbugs warnings in FSOutputSummer.tracer and DirectoryScanner$ReportCompiler.currentThread. Contributed by Yi Liu. (wheat9: rev 8703301b466cbc37ef53a96a55bcf6412792d5cf)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSOutputSummer.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #436 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/436/ ) HDFS-9174 . Fix findbugs warnings in FSOutputSummer.tracer and DirectoryScanner$ReportCompiler.currentThread. Contributed by Yi Liu. (wheat9: rev 8703301b466cbc37ef53a96a55bcf6412792d5cf) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSOutputSummer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2376 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2376/)
        HDFS-9174. Fix findbugs warnings in FSOutputSummer.tracer and DirectoryScanner$ReportCompiler.currentThread. Contributed by Yi Liu. (wheat9: rev 8703301b466cbc37ef53a96a55bcf6412792d5cf)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSOutputSummer.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2376 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2376/ ) HDFS-9174 . Fix findbugs warnings in FSOutputSummer.tracer and DirectoryScanner$ReportCompiler.currentThread. Contributed by Yi Liu. (wheat9: rev 8703301b466cbc37ef53a96a55bcf6412792d5cf) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSOutputSummer.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2404 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2404/)
        HDFS-9174. Fix findbugs warnings in FSOutputSummer.tracer and DirectoryScanner$ReportCompiler.currentThread. Contributed by Yi Liu. (wheat9: rev 8703301b466cbc37ef53a96a55bcf6412792d5cf)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSOutputSummer.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2404 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2404/ ) HDFS-9174 . Fix findbugs warnings in FSOutputSummer.tracer and DirectoryScanner$ReportCompiler.currentThread. Contributed by Yi Liu. (wheat9: rev 8703301b466cbc37ef53a96a55bcf6412792d5cf) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSOutputSummer.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1200 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1200/)
        HDFS-9174. Fix findbugs warnings in FSOutputSummer.tracer and DirectoryScanner$ReportCompiler.currentThread. Contributed by Yi Liu. (wheat9: rev 8703301b466cbc37ef53a96a55bcf6412792d5cf)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSOutputSummer.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1200 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1200/ ) HDFS-9174 . Fix findbugs warnings in FSOutputSummer.tracer and DirectoryScanner$ReportCompiler.currentThread. Contributed by Yi Liu. (wheat9: rev 8703301b466cbc37ef53a96a55bcf6412792d5cf) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSOutputSummer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            hitliuyi Yi Liu
            Reporter:
            hitliuyi Yi Liu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development