Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9148

Incorrect assert message in TestWriteToReplica#testWriteToTemporary

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Target Version/s:

      Description

      The following assert text in TestWriteToReplica#testWriteToTemporary is not correct:

            Assert.fail("createRbw() Should have removed the block with the older "
                + "genstamp and replaced it with the newer one: " + blocks[NON_EXISTENT]);
      

      If the assert is triggered, it can only be due to an temporary replica already exists and has newer generation stamp. It should have nothing to do with createRbw().

        Activity

        Hide
        twu Tony Wu added a comment -

        A pretty trivial change to assert text.

        Show
        twu Tony Wu added a comment - A pretty trivial change to assert text.
        Hide
        templedf Daniel Templeton added a comment -

        Looks good. Thanks, Tony Wu. Just add some parentheses after "createTemporary", i.e. createTemporary(), and you have my +1.

        Show
        templedf Daniel Templeton added a comment - Looks good. Thanks, Tony Wu . Just add some parentheses after "createTemporary", i.e. createTemporary(), and you have my +1.
        Hide
        twu Tony Wu added a comment -

        Than you Daniel, for looking at it quickly!

        Show
        twu Tony Wu added a comment - Than you Daniel, for looking at it quickly!
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 7m 45s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 48s There were no new javac warning messages.
        +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 23s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 27s mvn install still works.
        +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
        +1 findbugs 2m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 1m 15s Pre-build of native portion
        -1 hdfs tests 166m 43s Tests failed in hadoop-hdfs.
            189m 44s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.web.TestWebHDFS
          hadoop.hdfs.web.TestWebHDFSOAuth2



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12762484/hdfs-9148.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 892ade6
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12713/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12713/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12713/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12713/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 7m 45s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 48s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 23s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 2m 27s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 15s Pre-build of native portion -1 hdfs tests 166m 43s Tests failed in hadoop-hdfs.     189m 44s   Reason Tests Failed unit tests hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.web.TestWebHDFS   hadoop.hdfs.web.TestWebHDFSOAuth2 Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12762484/hdfs-9148.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 892ade6 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12713/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12713/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12713/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12713/console This message was automatically generated.
        Hide
        twu Tony Wu added a comment -

        I don't think the failed tests (TestDirectoryScanner, TestWebHDFS, TestWebHDFSOAuth2) has anything to do with this patch.

        Show
        twu Tony Wu added a comment - I don't think the failed tests (TestDirectoryScanner, TestWebHDFS, TestWebHDFSOAuth2) has anything to do with this patch.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        +1 for the patch. I've committed this to trunk and branch-2

        Thanks a lot for working on this Tony Wu, and thanks for the reviews from Daniel Templeton!

        Show
        eddyxu Lei (Eddy) Xu added a comment - +1 for the patch. I've committed this to trunk and branch-2 Thanks a lot for working on this Tony Wu , and thanks for the reviews from Daniel Templeton !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8533 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8533/)
        HDFS-9148. Incorrect assert message in TestWriteToReplica#testWriteToTemporary (Tony Wu via Lei (Eddy) Xu) (lei: rev 50741cb568d4da30b92d4954928bc3039e583b22)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8533 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8533/ ) HDFS-9148 . Incorrect assert message in TestWriteToReplica#testWriteToTemporary (Tony Wu via Lei (Eddy) Xu) (lei: rev 50741cb568d4da30b92d4954928bc3039e583b22) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #453 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/453/)
        HDFS-9148. Incorrect assert message in TestWriteToReplica#testWriteToTemporary (Tony Wu via Lei (Eddy) Xu) (lei: rev 50741cb568d4da30b92d4954928bc3039e583b22)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #453 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/453/ ) HDFS-9148 . Incorrect assert message in TestWriteToReplica#testWriteToTemporary (Tony Wu via Lei (Eddy) Xu) (lei: rev 50741cb568d4da30b92d4954928bc3039e583b22) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #460 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/460/)
        HDFS-9148. Incorrect assert message in TestWriteToReplica#testWriteToTemporary (Tony Wu via Lei (Eddy) Xu) (lei: rev 50741cb568d4da30b92d4954928bc3039e583b22)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #460 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/460/ ) HDFS-9148 . Incorrect assert message in TestWriteToReplica#testWriteToTemporary (Tony Wu via Lei (Eddy) Xu) (lei: rev 50741cb568d4da30b92d4954928bc3039e583b22) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1192 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1192/)
        HDFS-9148. Incorrect assert message in TestWriteToReplica#testWriteToTemporary (Tony Wu via Lei (Eddy) Xu) (lei: rev 50741cb568d4da30b92d4954928bc3039e583b22)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1192 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1192/ ) HDFS-9148 . Incorrect assert message in TestWriteToReplica#testWriteToTemporary (Tony Wu via Lei (Eddy) Xu) (lei: rev 50741cb568d4da30b92d4954928bc3039e583b22) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2398 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2398/)
        HDFS-9148. Incorrect assert message in TestWriteToReplica#testWriteToTemporary (Tony Wu via Lei (Eddy) Xu) (lei: rev 50741cb568d4da30b92d4954928bc3039e583b22)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2398 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2398/ ) HDFS-9148 . Incorrect assert message in TestWriteToReplica#testWriteToTemporary (Tony Wu via Lei (Eddy) Xu) (lei: rev 50741cb568d4da30b92d4954928bc3039e583b22) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #430 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/430/)
        HDFS-9148. Incorrect assert message in TestWriteToReplica#testWriteToTemporary (Tony Wu via Lei (Eddy) Xu) (lei: rev 50741cb568d4da30b92d4954928bc3039e583b22)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #430 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/430/ ) HDFS-9148 . Incorrect assert message in TestWriteToReplica#testWriteToTemporary (Tony Wu via Lei (Eddy) Xu) (lei: rev 50741cb568d4da30b92d4954928bc3039e583b22) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2371 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2371/)
        HDFS-9148. Incorrect assert message in TestWriteToReplica#testWriteToTemporary (Tony Wu via Lei (Eddy) Xu) (lei: rev 50741cb568d4da30b92d4954928bc3039e583b22)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2371 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2371/ ) HDFS-9148 . Incorrect assert message in TestWriteToReplica#testWriteToTemporary (Tony Wu via Lei (Eddy) Xu) (lei: rev 50741cb568d4da30b92d4954928bc3039e583b22) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestWriteToReplica.java

          People

          • Assignee:
            twu Tony Wu
            Reporter:
            twu Tony Wu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development