Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9132

Pass genstamp to ReplicaAccessorBuilder

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 2.8.0
        • Fix Version/s: 2.8.0, 3.0.0-alpha1
        • Component/s: hdfs-client
        • Labels:
          None
        • Target Version/s:
        • Hadoop Flags:
          Reviewed

          Description

          We should pass the desired genstamp of the block we want to read to ExternalReplicaBuilder.

          1. Text File
            HDFS-9132.001.patch
            4 kB
            Colin P. McCabe

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -



            +1 overall



            Vote Subsystem Runtime Comment
            0 pre-patch 19m 48s Pre-patch trunk compilation is healthy.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
            +1 javac 7m 50s There were no new javac warning messages.
            +1 javadoc 9m 59s There were no new javadoc warning messages.
            +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
            +1 checkstyle 2m 35s There were no new checkstyle issues.
            +1 whitespace 0m 0s The patch has no lines that end in whitespace.
            +1 install 1m 37s mvn install still works.
            +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
            +1 findbugs 4m 26s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
            +1 native 3m 10s Pre-build of native portion
            +1 hdfs tests 163m 42s Tests passed in hadoop-hdfs.
            +1 hdfs tests 0m 30s Tests passed in hadoop-hdfs-client.
                214m 37s  



            Subsystem Report/Notes
            Patch URL http://issues.apache.org/jira/secure/attachment/12762031/HDFS-9132.001.patch
            Optional Tests javadoc javac unit findbugs checkstyle
            git revision trunk / 1f707ec
            hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12649/artifact/patchprocess/testrun_hadoop-hdfs.txt
            hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12649/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
            Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12649/testReport/
            Java 1.7.0_55
            uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
            Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12649/console

            This message was automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 48s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 50s There were no new javac warning messages. +1 javadoc 9m 59s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 35s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 4m 26s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 10s Pre-build of native portion +1 hdfs tests 163m 42s Tests passed in hadoop-hdfs. +1 hdfs tests 0m 30s Tests passed in hadoop-hdfs-client.     214m 37s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12762031/HDFS-9132.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1f707ec hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12649/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12649/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12649/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12649/console This message was automatically generated.
            Hide
            Permalink
            hitliuyi Yi Liu added a comment -

            Thanks Colin for the work.

            One question, this new added ReplicaAccessor is target for Finalized Replica? If so, why need a genstamp? If genstamp mismatched, then read failed?

            Show
            hitliuyi Yi Liu added a comment - Thanks Colin for the work. One question, this new added ReplicaAccessor is target for Finalized Replica? If so, why need a genstamp? If genstamp mismatched, then read failed?
            Hide
            Permalink
            cmccabe Colin P. McCabe added a comment -

            The ReplicaAccessor may be used to access either finalized or non-finalized replicas. The genstamp may not matter for some implementations, but others may want to check it and fall back to a different access method if it doesn't match the most current genstamp.

            Show
            cmccabe Colin P. McCabe added a comment - The ReplicaAccessor may be used to access either finalized or non-finalized replicas. The genstamp may not matter for some implementations, but others may want to check it and fall back to a different access method if it doesn't match the most current genstamp.
            Hide
            Permalink
            eddyxu Lei (Eddy) Xu added a comment -

            +1. Thanks for the work from Colin P. McCabe and reviews from Yi Liu

            Committed to trunk and branch2

            Show
            eddyxu Lei (Eddy) Xu added a comment - +1. Thanks for the work from Colin P. McCabe and reviews from Yi Liu Committed to trunk and branch2
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-trunk-Commit #8521 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8521/)
            HDFS-9132. Pass genstamp to ReplicaAccessorBuilder. (Colin Patrick McCabe via Lei (Eddy) Xu) (lei: rev 5eb237d544fc8eeea85ac4bd4f7500edd49c8727)

            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestExternalBlockReader.java
            • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReplicaAccessorBuilder.java
            • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
            • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8521 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8521/ ) HDFS-9132 . Pass genstamp to ReplicaAccessorBuilder. (Colin Patrick McCabe via Lei (Eddy) Xu) (lei: rev 5eb237d544fc8eeea85ac4bd4f7500edd49c8727) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestExternalBlockReader.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReplicaAccessorBuilder.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #442 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/442/)
            HDFS-9132. Pass genstamp to ReplicaAccessorBuilder. (Colin Patrick McCabe via Lei (Eddy) Xu) (lei: rev 5eb237d544fc8eeea85ac4bd4f7500edd49c8727)

            • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
            • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestExternalBlockReader.java
            • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReplicaAccessorBuilder.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #442 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/442/ ) HDFS-9132 . Pass genstamp to ReplicaAccessorBuilder. (Colin Patrick McCabe via Lei (Eddy) Xu) (lei: rev 5eb237d544fc8eeea85ac4bd4f7500edd49c8727) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestExternalBlockReader.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReplicaAccessorBuilder.java
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #448 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/448/)
            HDFS-9132. Pass genstamp to ReplicaAccessorBuilder. (Colin Patrick McCabe via Lei (Eddy) Xu) (lei: rev 5eb237d544fc8eeea85ac4bd4f7500edd49c8727)

            • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReplicaAccessorBuilder.java
            • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestExternalBlockReader.java
            • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #448 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/448/ ) HDFS-9132 . Pass genstamp to ReplicaAccessorBuilder. (Colin Patrick McCabe via Lei (Eddy) Xu) (lei: rev 5eb237d544fc8eeea85ac4bd4f7500edd49c8727) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReplicaAccessorBuilder.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestExternalBlockReader.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Hadoop-Yarn-trunk #1181 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1181/)
            HDFS-9132. Pass genstamp to ReplicaAccessorBuilder. (Colin Patrick McCabe via Lei (Eddy) Xu) (lei: rev 5eb237d544fc8eeea85ac4bd4f7500edd49c8727)

            • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReplicaAccessorBuilder.java
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestExternalBlockReader.java
            • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1181 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1181/ ) HDFS-9132 . Pass genstamp to ReplicaAccessorBuilder. (Colin Patrick McCabe via Lei (Eddy) Xu) (lei: rev 5eb237d544fc8eeea85ac4bd4f7500edd49c8727) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReplicaAccessorBuilder.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestExternalBlockReader.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Hdfs-trunk #2359 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2359/)
            HDFS-9132. Pass genstamp to ReplicaAccessorBuilder. (Colin Patrick McCabe via Lei (Eddy) Xu) (lei: rev 5eb237d544fc8eeea85ac4bd4f7500edd49c8727)

            • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
            • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReplicaAccessorBuilder.java
            • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestExternalBlockReader.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2359 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2359/ ) HDFS-9132 . Pass genstamp to ReplicaAccessorBuilder. (Colin Patrick McCabe via Lei (Eddy) Xu) (lei: rev 5eb237d544fc8eeea85ac4bd4f7500edd49c8727) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReplicaAccessorBuilder.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestExternalBlockReader.java
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Mapreduce-trunk #2386 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2386/)
            HDFS-9132. Pass genstamp to ReplicaAccessorBuilder. (Colin Patrick McCabe via Lei (Eddy) Xu) (lei: rev 5eb237d544fc8eeea85ac4bd4f7500edd49c8727)

            • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
            • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestExternalBlockReader.java
            • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReplicaAccessorBuilder.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2386 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2386/ ) HDFS-9132 . Pass genstamp to ReplicaAccessorBuilder. (Colin Patrick McCabe via Lei (Eddy) Xu) (lei: rev 5eb237d544fc8eeea85ac4bd4f7500edd49c8727) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestExternalBlockReader.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReplicaAccessorBuilder.java
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #419 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/419/)
            HDFS-9132. Pass genstamp to ReplicaAccessorBuilder. (Colin Patrick McCabe via Lei (Eddy) Xu) (lei: rev 5eb237d544fc8eeea85ac4bd4f7500edd49c8727)

            • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestExternalBlockReader.java
            • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java
            • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReplicaAccessorBuilder.java
            • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #419 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/419/ ) HDFS-9132 . Pass genstamp to ReplicaAccessorBuilder. (Colin Patrick McCabe via Lei (Eddy) Xu) (lei: rev 5eb237d544fc8eeea85ac4bd4f7500edd49c8727) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestExternalBlockReader.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/BlockReaderFactory.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/ReplicaAccessorBuilder.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

              People

              • Assignee:
                cmccabe Colin P. McCabe
                Reporter:
                cmccabe Colin P. McCabe
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development