Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9085

Show renewer information in DelegationTokenIdentifier#toString

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: security
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      The output of the "hdfs fetchdt --print" command now includes the token renewer appended to the end of the existing token information. This change may be incompatible with tools that parse the output of the command.

      Description

      Show renewer information in DelegationTokenIdentifier#toString. Currently
      org.apache.hadoop.hdfs.security.token.delegation.DelegationTokenIdentifier didn't show the renewer information. It will be very useful to have renewer information to debug security related issue. Because the renewer will be filtered by "hadoop.security.auth_to_local", it will be helpful to show the real renewer info after applying the rules.

      1. HDFS-9085.001.patch
        0.9 kB
        zhihai xu
      2. HDFS-9085.002.patch
        2 kB
        zhihai xu

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #478 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/478/)
          HDFS-9085. Show renewer information in (cnauroth: rev 4f6e842ba936f4a068168b518eea80bb6dd02d85)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #478 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/478/ ) HDFS-9085 . Show renewer information in (cnauroth: rev 4f6e842ba936f4a068168b518eea80bb6dd02d85) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2416 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2416/)
          HDFS-9085. Show renewer information in (cnauroth: rev 4f6e842ba936f4a068168b518eea80bb6dd02d85)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2416 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2416/ ) HDFS-9085 . Show renewer information in (cnauroth: rev 4f6e842ba936f4a068168b518eea80bb6dd02d85) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1244 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1244/)
          HDFS-9085. Show renewer information in (cnauroth: rev 4f6e842ba936f4a068168b518eea80bb6dd02d85)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1244 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1244/ ) HDFS-9085 . Show renewer information in (cnauroth: rev 4f6e842ba936f4a068168b518eea80bb6dd02d85) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2451 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2451/)
          HDFS-9085. Show renewer information in (cnauroth: rev 4f6e842ba936f4a068168b518eea80bb6dd02d85)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2451 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2451/ ) HDFS-9085 . Show renewer information in (cnauroth: rev 4f6e842ba936f4a068168b518eea80bb6dd02d85) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #506 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/506/)
          HDFS-9085. Show renewer information in (cnauroth: rev 4f6e842ba936f4a068168b518eea80bb6dd02d85)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #506 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/506/ ) HDFS-9085 . Show renewer information in (cnauroth: rev 4f6e842ba936f4a068168b518eea80bb6dd02d85) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #517 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/517/)
          HDFS-9085. Show renewer information in (cnauroth: rev 4f6e842ba936f4a068168b518eea80bb6dd02d85)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #517 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/517/ ) HDFS-9085 . Show renewer information in (cnauroth: rev 4f6e842ba936f4a068168b518eea80bb6dd02d85) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8603 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8603/)
          HDFS-9085. Show renewer information in (cnauroth: rev 4f6e842ba936f4a068168b518eea80bb6dd02d85)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8603 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8603/ ) HDFS-9085 . Show renewer information in (cnauroth: rev 4f6e842ba936f4a068168b518eea80bb6dd02d85) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/security/token/delegation/DelegationTokenIdentifier.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/security/TestDelegationToken.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          zxu zhihai xu added a comment -

          Thanks Chris Nauroth for reviewing and committing the patch!

          Show
          zxu zhihai xu added a comment - Thanks Chris Nauroth for reviewing and committing the patch!
          Hide
          cnauroth Chris Nauroth added a comment -

          +1 for patch v002. I reviewed the test failures, and they are unrelated. The tests pass locally on a rerun.

          I have committed this to trunk. I have flagged this as a backwards-incompatible change and entered a release note.

          zhihai xu, thank you for the contribution.

          Show
          cnauroth Chris Nauroth added a comment - +1 for patch v002. I reviewed the test failures, and they are unrelated. The tests pass locally on a rerun. I have committed this to trunk. I have flagged this as a backwards-incompatible change and entered a release note. zhihai xu , thank you for the contribution.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 20m 1s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 56s There were no new javac warning messages.
          +1 javadoc 10m 35s There were no new javadoc warning messages.
          -1 release audit 0m 19s The applied patch generated 1 release audit warnings.
          +1 checkstyle 2m 57s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 4m 56s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 12s Pre-build of native portion
          -1 hdfs tests 67m 45s Tests failed in hadoop-hdfs.
          +1 hdfs tests 0m 29s Tests passed in hadoop-hdfs-client.
              120m 14s  



          Reason Tests
          Failed unit tests hadoop.hdfs.web.TestWebHDFS
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
          Timed out tests org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
            org.apache.hadoop.hdfs.TestDFSMkdirs



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12765733/HDFS-9085.002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / e1bf8b3
          Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12882/artifact/patchprocess/patchReleaseAuditProblems.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12882/artifact/patchprocess/testrun_hadoop-hdfs.txt
          hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12882/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12882/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12882/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 1s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 56s There were no new javac warning messages. +1 javadoc 10m 35s There were no new javadoc warning messages. -1 release audit 0m 19s The applied patch generated 1 release audit warnings. +1 checkstyle 2m 57s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 4m 56s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 12s Pre-build of native portion -1 hdfs tests 67m 45s Tests failed in hadoop-hdfs. +1 hdfs tests 0m 29s Tests passed in hadoop-hdfs-client.     120m 14s   Reason Tests Failed unit tests hadoop.hdfs.web.TestWebHDFS   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010 Timed out tests org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   org.apache.hadoop.hdfs.TestDFSMkdirs Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765733/HDFS-9085.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / e1bf8b3 Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12882/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12882/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12882/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12882/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12882/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 19m 58s Pre-patch trunk has 748 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 0s There were no new javac warning messages.
          +1 javadoc 10m 22s There were no new javadoc warning messages.
          -1 release audit 0m 20s The applied patch generated 1 release audit warnings.
          +1 checkstyle 2m 55s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 29s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 4m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 14s Pre-build of native portion
          -1 hdfs tests 194m 40s Tests failed in hadoop-hdfs.
          -1 hdfs tests 0m 37s Tests failed in hadoop-hdfs-client.
              246m 53s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestDFSStripedOutputStream
            hadoop.hdfs.security.TestDelegationToken
          Failed build hadoop-hdfs-client



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12765685/HDFS-9085.002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 118a35b
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12872/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs-client.html
          Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12872/artifact/patchprocess/patchReleaseAuditProblems.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12872/artifact/patchprocess/testrun_hadoop-hdfs.txt
          hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12872/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12872/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12872/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 19m 58s Pre-patch trunk has 748 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 0s There were no new javac warning messages. +1 javadoc 10m 22s There were no new javadoc warning messages. -1 release audit 0m 20s The applied patch generated 1 release audit warnings. +1 checkstyle 2m 55s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 4m 40s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 14s Pre-build of native portion -1 hdfs tests 194m 40s Tests failed in hadoop-hdfs. -1 hdfs tests 0m 37s Tests failed in hadoop-hdfs-client.     246m 53s   Reason Tests Failed unit tests hadoop.hdfs.TestDFSStripedOutputStream   hadoop.hdfs.security.TestDelegationToken Failed build hadoop-hdfs-client Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12765685/HDFS-9085.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 118a35b Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12872/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs-client.html Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12872/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12872/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12872/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12872/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12872/console This message was automatically generated.
          Hide
          zxu zhihai xu added a comment -

          Thanks for the good suggestion Chris Nauroth! Yes, I uploaded a new patch HDFS-9085.002.patch, which added a unit test to verify toString.

          Show
          zxu zhihai xu added a comment - Thanks for the good suggestion Chris Nauroth ! Yes, I uploaded a new patch HDFS-9085 .002.patch, which added a unit test to verify toString .
          Hide
          cnauroth Chris Nauroth added a comment -

          Hello zhihai xu. Sorry for the delayed response. I am +1 for a commit to trunk only, flagging it as backwards-incompatible, and entering a release note that describes the change in output for hdfs fetchdt --print.

          Before we commit, do you think you can add a unit test to check the new toString output?

          Show
          cnauroth Chris Nauroth added a comment - Hello zhihai xu . Sorry for the delayed response. I am +1 for a commit to trunk only, flagging it as backwards-incompatible, and entering a release note that describes the change in output for hdfs fetchdt --print . Before we commit, do you think you can add a unit test to check the new toString output?
          Hide
          zxu zhihai xu added a comment -

          Thanks for the review Chris Nauroth! That is great information. Yes, it makes sense to commit the patch to trunk only.

          Show
          zxu zhihai xu added a comment - Thanks for the review Chris Nauroth ! That is great information. Yes, it makes sense to commit the patch to trunk only.
          Hide
          cnauroth Chris Nauroth added a comment -

          Hello zhihai xu. Thank you for the patch. This looks helpful.

          Unfortunately, there is a small backwards-compatibility concern. The return value of DelegationTokenIdentifier#toString is output to the console by the hdfs fetchdt --print command. If an administrator had written any scripting that relies on parsing that output, then this change could break it. I think that prevents us from committing to branch-2, though a commit to trunk would still be possible.

          Show
          cnauroth Chris Nauroth added a comment - Hello zhihai xu . Thank you for the patch. This looks helpful. Unfortunately, there is a small backwards-compatibility concern. The return value of DelegationTokenIdentifier#toString is output to the console by the hdfs fetchdt --print command. If an administrator had written any scripting that relies on parsing that output, then this change could break it. I think that prevents us from committing to branch-2, though a commit to trunk would still be possible.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 33s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 58s There were no new javac warning messages.
          +1 javadoc 10m 18s There were no new javadoc warning messages.
          +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 36s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 31s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          +1 findbugs 2m 0s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 15s Pre-build of native portion
          +1 hdfs tests 0m 29s Tests passed in hadoop-hdfs-client.
              45m 45s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12756118/HDFS-9085.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 559c09d
          hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12462/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12462/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12462/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 33s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 58s There were no new javac warning messages. +1 javadoc 10m 18s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 36s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 2m 0s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 15s Pre-build of native portion +1 hdfs tests 0m 29s Tests passed in hadoop-hdfs-client.     45m 45s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12756118/HDFS-9085.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 559c09d hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/12462/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12462/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12462/console This message was automatically generated.

            People

            • Assignee:
              zxu zhihai xu
              Reporter:
              zxu zhihai xu
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development