Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9070

Allow fsck display pending replica location information for being-written blocks

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Hide
      The output of fsck command for being written hdfs files had been changed. When using fsck against being written hdfs files with {{-openforwrite}} and {{-files -blocks -locations}}, the fsck output will include the being written block for replication files or being written block group for erasure code files.
      Show
      The output of fsck command for being written hdfs files had been changed. When using fsck against being written hdfs files with {{-openforwrite}} and {{-files -blocks -locations}}, the fsck output will include the being written block for replication files or being written block group for erasure code files.

      Description

      When a EC file is being written, it can be helpful to allow fsck display datanode information of the being-written EC file block group.

      1. HDFS-9070--HDFS-7285.00.patch
        169 kB
        Rui Gao
      2. HDFS-9070-HDFS-7285.00.patch
        169 kB
        Rui Gao
      3. HDFS-9070-HDFS-7285.01.patch
        5 kB
        Rui Gao
      4. HDFS-9070-HDFS-7285.02.patch
        5 kB
        Rui Gao
      5. HDFS-9070-trunk.03.patch
        6 kB
        Rui Gao
      6. HDFS-9070-trunk.04.patch
        6 kB
        Rui Gao
      7. HDFS-9070-trunk.05.patch
        14 kB
        Rui Gao
      8. HDFS-9070-trunk.06.patch
        15 kB
        Rui Gao
      9. HDFS-9070-trunk.07.patch
        15 kB
        Rui Gao

        Activity

        Hide
        demongaorui Rui Gao added a comment -

        Thanks Allen Wittenauer. I have written the Release Note. Please let me know if it make sense to you.

        Show
        demongaorui Rui Gao added a comment - Thanks Allen Wittenauer . I have written the Release Note. Please let me know if it make sense to you.
        Hide
        aw Allen Wittenauer added a comment -

        Should I make this change compatible, so that this function could be used in 2.x? Currently we run system tests on hdfs with scripts which need being-written blocks infos from fsck.

        You can't. If you change the (pre-existing) output of a command line utility, it's automatically incompatible:

        http://hadoop.apache.org/docs/r2.7.1/hadoop-project-dist/hadoop-common/Compatibility.html#Command_Line_Interface_CLI

        By the way, how should we write the release note? I haven't wrote release note before.

        Go up to edit in the JIRA and fill in the Release Note box. Say what changed and how it may impact end users.

        Show
        aw Allen Wittenauer added a comment - Should I make this change compatible, so that this function could be used in 2.x? Currently we run system tests on hdfs with scripts which need being-written blocks infos from fsck. You can't. If you change the (pre-existing) output of a command line utility, it's automatically incompatible: http://hadoop.apache.org/docs/r2.7.1/hadoop-project-dist/hadoop-common/Compatibility.html#Command_Line_Interface_CLI By the way, how should we write the release note? I haven't wrote release note before. Go up to edit in the JIRA and fill in the Release Note box. Say what changed and how it may impact end users.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2513 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2513/)
        HDFS-9070. Allow fsck display pending replica location information for (jing9: rev d806a5bf079bf136114520c5a3a9d1f16ecf2eda)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          Move HDFS-9070 to trunk section in CHANGES.txt (jing9: rev 2f19602bba1a9f5fe9b80f2f7840ad1920553cbc)
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2513 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2513/ ) HDFS-9070 . Allow fsck display pending replica location information for (jing9: rev d806a5bf079bf136114520c5a3a9d1f16ecf2eda) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java Move HDFS-9070 to trunk section in CHANGES.txt (jing9: rev 2f19602bba1a9f5fe9b80f2f7840ad1920553cbc) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2460 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2460/)
        HDFS-9070. Allow fsck display pending replica location information for (jing9: rev d806a5bf079bf136114520c5a3a9d1f16ecf2eda)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          Move HDFS-9070 to trunk section in CHANGES.txt (jing9: rev 2f19602bba1a9f5fe9b80f2f7840ad1920553cbc)
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2460 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2460/ ) HDFS-9070 . Allow fsck display pending replica location information for (jing9: rev d806a5bf079bf136114520c5a3a9d1f16ecf2eda) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java Move HDFS-9070 to trunk section in CHANGES.txt (jing9: rev 2f19602bba1a9f5fe9b80f2f7840ad1920553cbc) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        demongaorui Rui Gao added a comment -

        Should I make this change compatible, so that this function could be used in 2.x? Currently we run system tests on hdfs with scripts which need being-written blocks infos from fsck.

        By the way, how should we write the release note? I haven't wrote release note before.

        Show
        demongaorui Rui Gao added a comment - Should I make this change compatible, so that this function could be used in 2.x? Currently we run system tests on hdfs with scripts which need being-written blocks infos from fsck. By the way, how should we write the release note? I haven't wrote release note before.
        Hide
        aw Allen Wittenauer added a comment -

        Marking this as an incompatible change so that folks moving from 2.x to 3.x can expect the extra output in fsck. Someone please write the release note. Thanks.

        Show
        aw Allen Wittenauer added a comment - Marking this as an incompatible change so that folks moving from 2.x to 3.x can expect the extra output in fsck. Someone please write the release note. Thanks.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #523 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/523/)
        HDFS-9070. Allow fsck display pending replica location information for (jing9: rev d806a5bf079bf136114520c5a3a9d1f16ecf2eda)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          Move HDFS-9070 to trunk section in CHANGES.txt (jing9: rev 2f19602bba1a9f5fe9b80f2f7840ad1920553cbc)
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #523 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/523/ ) HDFS-9070 . Allow fsck display pending replica location information for (jing9: rev d806a5bf079bf136114520c5a3a9d1f16ecf2eda) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java Move HDFS-9070 to trunk section in CHANGES.txt (jing9: rev 2f19602bba1a9f5fe9b80f2f7840ad1920553cbc) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        demongaorui Rui Gao added a comment -

        Thanks for your review and help, Jing Zhao,J.Andreina!

        Show
        demongaorui Rui Gao added a comment - Thanks for your review and help, Jing Zhao , J.Andreina !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #565 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/565/)
        HDFS-9070. Allow fsck display pending replica location information for (jing9: rev d806a5bf079bf136114520c5a3a9d1f16ecf2eda)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          Move HDFS-9070 to trunk section in CHANGES.txt (jing9: rev 2f19602bba1a9f5fe9b80f2f7840ad1920553cbc)
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #565 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/565/ ) HDFS-9070 . Allow fsck display pending replica location information for (jing9: rev d806a5bf079bf136114520c5a3a9d1f16ecf2eda) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java Move HDFS-9070 to trunk section in CHANGES.txt (jing9: rev 2f19602bba1a9f5fe9b80f2f7840ad1920553cbc) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1301 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1301/)
        HDFS-9070. Allow fsck display pending replica location information for (jing9: rev d806a5bf079bf136114520c5a3a9d1f16ecf2eda)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Move HDFS-9070 to trunk section in CHANGES.txt (jing9: rev 2f19602bba1a9f5fe9b80f2f7840ad1920553cbc)
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1301 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1301/ ) HDFS-9070 . Allow fsck display pending replica location information for (jing9: rev d806a5bf079bf136114520c5a3a9d1f16ecf2eda) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Move HDFS-9070 to trunk section in CHANGES.txt (jing9: rev 2f19602bba1a9f5fe9b80f2f7840ad1920553cbc) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #579 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/579/)
        HDFS-9070. Allow fsck display pending replica location information for (jing9: rev d806a5bf079bf136114520c5a3a9d1f16ecf2eda)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Move HDFS-9070 to trunk section in CHANGES.txt (jing9: rev 2f19602bba1a9f5fe9b80f2f7840ad1920553cbc)
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #579 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/579/ ) HDFS-9070 . Allow fsck display pending replica location information for (jing9: rev d806a5bf079bf136114520c5a3a9d1f16ecf2eda) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Move HDFS-9070 to trunk section in CHANGES.txt (jing9: rev 2f19602bba1a9f5fe9b80f2f7840ad1920553cbc) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8682 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8682/)
        HDFS-9070. Allow fsck display pending replica location information for (jing9: rev d806a5bf079bf136114520c5a3a9d1f16ecf2eda)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Move HDFS-9070 to trunk section in CHANGES.txt (jing9: rev 2f19602bba1a9f5fe9b80f2f7840ad1920553cbc)
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8682 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8682/ ) HDFS-9070 . Allow fsck display pending replica location information for (jing9: rev d806a5bf079bf136114520c5a3a9d1f16ecf2eda) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Move HDFS-9070 to trunk section in CHANGES.txt (jing9: rev 2f19602bba1a9f5fe9b80f2f7840ad1920553cbc) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        jingzhao Jing Zhao added a comment -

        Currently the changes and the test do not apply to branch-2, so I only commit the patch into trunk. Thanks for the contribution, Rui Gao! Thanks for the review J.Andreina!

        Show
        jingzhao Jing Zhao added a comment - Currently the changes and the test do not apply to branch-2, so I only commit the patch into trunk. Thanks for the contribution, Rui Gao ! Thanks for the review J.Andreina !
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 18m 25s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 4s There were no new javac warning messages.
        +1 javadoc 10m 38s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 27s The applied patch generated 1 new checkstyle issues (total was 118, now 111).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 16s Pre-build of native portion
        -1 hdfs tests 51m 30s Tests failed in hadoop-hdfs.
            98m 25s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12767321/HDFS-9070-trunk.07.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / d759b4b
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13111/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13111/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13111/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13111/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13111/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 25s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 4s There were no new javac warning messages. +1 javadoc 10m 38s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 27s The applied patch generated 1 new checkstyle issues (total was 118, now 111). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 16s Pre-build of native portion -1 hdfs tests 51m 30s Tests failed in hadoop-hdfs.     98m 25s   Reason Tests Failed unit tests hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12767321/HDFS-9070-trunk.07.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d759b4b Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/13111/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/13111/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/13111/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13111/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13111/console This message was automatically generated.
        Hide
        jingzhao Jing Zhao added a comment -

        Thanks for updating the patch Rui Gao. Also thanks for the review, J.Andreina.
        The latest patch also looks good to me. +1 pending Jenkins.

        Show
        jingzhao Jing Zhao added a comment - Thanks for updating the patch Rui Gao . Also thanks for the review, J.Andreina . The latest patch also looks good to me. +1 pending Jenkins.
        Hide
        andreina J.Andreina added a comment -

        Thanks Rui Gao.
        Updated patch looks good to me.

        Show
        andreina J.Andreina added a comment - Thanks Rui Gao . Updated patch looks good to me.
        Hide
        demongaorui Rui Gao added a comment -

        Hi, J.Andreina. I have uploaded a new patch, please let me know if it makes sense to you. Thanks

        Show
        demongaorui Rui Gao added a comment - Hi, J.Andreina . I have uploaded a new patch, please let me know if it makes sense to you. Thanks
        Hide
        demongaorui Rui Gao added a comment -

        Thanks J.Andreina. For nits 1, I think explicit check for isComplete could be removed, cause under construction block shouldn't be included in corruptReplicas or blocksExcess. I will revise the code. Nits 2, I will add EC related assert in testFsckOpenECFiles. I think it's better to test against open EC files as well as normal files. Cause, both EC and non-EC file are necessary test scenarios. I'll upload a new patch soon. Thank you very much for your comment.

        Show
        demongaorui Rui Gao added a comment - Thanks J.Andreina . For nits 1, I think explicit check for isComplete could be removed, cause under construction block shouldn't be included in corruptReplicas or blocksExcess. I will revise the code. Nits 2, I will add EC related assert in testFsckOpenECFiles . I think it's better to test against open EC files as well as normal files. Cause, both EC and non-EC file are necessary test scenarios. I'll upload a new patch soon. Thank you very much for your comment.
        Hide
        andreina J.Andreina added a comment -

        Thanks Rui Gao ,recent changes Looks good.

        Some nits:
        1.

        +        } else if (isComplete && corruptReplicas != null
        +            && corruptReplicas.contains(dnDesc)) {
        +          sb.append("CORRUPT)");
        +        } else if (isComplete && blocksExcess != null
        +            && blocksExcess.contains(storedBlock)) {
        +          sb.append("EXCESS)");
        

        I don't think isComplete() check is required in above code .
        Block can be CORRUPT or EXCESS, logically possible only if it is complete. So explicit check might not be required.

        2. Test testFsckOpenECFiles is written for EC files, but changes are not specific to EC file, and there is nothing asserted against EC related. Hence when the test is run, it takes lot of time, since it involves 10 DNs.
        IMO, its okay to test samething with normal non-EC file.

        Show
        andreina J.Andreina added a comment - Thanks Rui Gao ,recent changes Looks good. Some nits: 1. + } else if (isComplete && corruptReplicas != null + && corruptReplicas.contains(dnDesc)) { + sb.append( "CORRUPT)" ); + } else if (isComplete && blocksExcess != null + && blocksExcess.contains(storedBlock)) { + sb.append( "EXCESS)" ); I don't think isComplete() check is required in above code . Block can be CORRUPT or EXCESS, logically possible only if it is complete. So explicit check might not be required. 2. Test testFsckOpenECFiles is written for EC files, but changes are not specific to EC file, and there is nothing asserted against EC related. Hence when the test is run, it takes lot of time, since it involves 10 DNs. IMO, its okay to test samething with normal non-EC file.
        Hide
        demongaorui Rui Gao added a comment -

        Hi Jing Zhao, J.Andreina. I have attached a new patch HDFS-9070-trunk.06.patch, thank Jing Zhao very much for the guidances in the Email.

        Please let me know if this patch make sense to you.

        Show
        demongaorui Rui Gao added a comment - Hi Jing Zhao , J.Andreina . I have attached a new patch HDFS-9070-trunk.06.patch , thank Jing Zhao very much for the guidances in the Email. Please let me know if this patch make sense to you.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 18m 21s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 58s There were no new javac warning messages.
        +1 javadoc 11m 29s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 33s The applied patch generated 3 new checkstyle issues (total was 118, now 116).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        +1 findbugs 2m 35s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 31s Pre-build of native portion
        -1 hdfs tests 50m 46s Tests failed in hadoop-hdfs.
            99m 51s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.ha.TestHAAppend
        Timed out tests org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
          org.apache.hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks
          org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean
          org.apache.hadoop.hdfs.server.blockmanagement.TestPendingReplication



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12766435/HDFS-9070-trunk.05.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 40cac59
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12967/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12967/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12967/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12967/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12967/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 21s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 58s There were no new javac warning messages. +1 javadoc 11m 29s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 33s The applied patch generated 3 new checkstyle issues (total was 118, now 116). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 2m 35s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 31s Pre-build of native portion -1 hdfs tests 50m 46s Tests failed in hadoop-hdfs.     99m 51s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestHAAppend Timed out tests org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager   org.apache.hadoop.hdfs.server.blockmanagement.TestOverReplicatedBlocks   org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean   org.apache.hadoop.hdfs.server.blockmanagement.TestPendingReplication Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766435/HDFS-9070-trunk.05.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 40cac59 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12967/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12967/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12967/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12967/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12967/console This message was automatically generated.
        Hide
        demongaorui Rui Gao added a comment -

        Hi, J.Andreina,Jing Zhao! I have refactored related code, and attached the patch: HDFS-9070-trunk.05.patch. There are some overlap codes outside and inside the new created method collectBlocksDetails. These overlap codes seems to be needed to get BlockManager,ExtendedBlock,BlockInfo for displaying block related infos. If you got ideas which could make the code more pretty, please let me know, thanks a lot!

        Show
        demongaorui Rui Gao added a comment - Hi, J.Andreina , Jing Zhao ! I have refactored related code, and attached the patch: HDFS-9070-trunk.05.patch . There are some overlap codes outside and inside the new created method collectBlocksDetails . These overlap codes seems to be needed to get BlockManager , ExtendedBlock , BlockInfo for displaying block related infos. If you got ideas which could make the code more pretty, please let me know, thanks a lot!
        Hide
        jingzhao Jing Zhao added a comment -

        We can extract the existing finalized-block's code for the check on (showLocations || showRacks || showReplicaDetails ) to a method and can reuse the code for under-construction block also.

        big +1 for this.

        Show
        jingzhao Jing Zhao added a comment - We can extract the existing finalized-block's code for the check on (showLocations || showRacks || showReplicaDetails ) to a method and can reuse the code for under-construction block also. big +1 for this.
        Hide
        andreina J.Andreina added a comment -

        Hi Rui Gao ,thanks for the patch. It looks good overall . I have few comments.

        1.
        In last patch , we are printing the under construction block information only if the user sets "showLocations" to true.
        We can remove the check for showLocations in below code, to be consistent with the behavior in finalized blocks.

        	   
               if (!blocks.isLastBlockComplete() && lastBlock != null && showLocations) {
        	      report.append('\n');
        	      report.append("Under Construction Block:\n");
        

        2.
        There are possibilities that while the last block is under-construction , the node is getting into decommissioning state.
        So the possible replica state , when the block is under-construction could be :
        Decommissioning
        STALE_NODE
        STALE_BLOCK_CONTENT
        LIVE

        So i feel it would be good , if we can show the rackinfo and replica informations as well.

        We can extract the existing finalized-block's code for the check on (showLocations || showRacks || showReplicaDetails ) to a method and can reuse the code for under-construction block also.

        Show
        andreina J.Andreina added a comment - Hi Rui Gao ,thanks for the patch. It looks good overall . I have few comments. 1. In last patch , we are printing the under construction block information only if the user sets "showLocations" to true. We can remove the check for showLocations in below code, to be consistent with the behavior in finalized blocks. if (!blocks.isLastBlockComplete() && lastBlock != null && showLocations) { report.append('\n'); report.append( "Under Construction Block:\n" ); 2. There are possibilities that while the last block is under-construction , the node is getting into decommissioning state. So the possible replica state , when the block is under-construction could be : Decommissioning STALE_NODE STALE_BLOCK_CONTENT LIVE So i feel it would be good , if we can show the rackinfo and replica informations as well. We can extract the existing finalized-block's code for the check on (showLocations || showRacks || showReplicaDetails ) to a method and can reuse the code for under-construction block also.
        Hide
        demongaorui Rui Gao added a comment -

        Hi, Jing Zhao. I have uploaded a new patch to address the showRacks and showReplicaDetail problem. Thanks for your advice!

        Show
        demongaorui Rui Gao added a comment - Hi, Jing Zhao . I have uploaded a new patch to address the showRacks and showReplicaDetail problem. Thanks for your advice!
        Hide
        jingzhao Jing Zhao added a comment -

        Thanks for updating the patch, Rui Gao. The new patch looks good to me. But I think currently we do not need to support showRacks or showReplicaDetails for a UC block. +1 after addressing the comments.

        Show
        jingzhao Jing Zhao added a comment - Thanks for updating the patch, Rui Gao . The new patch looks good to me. But I think currently we do not need to support showRacks or showReplicaDetails for a UC block. +1 after addressing the comments.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 21s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 8s There were no new javac warning messages.
        +1 javadoc 10m 17s There were no new javadoc warning messages.
        -1 release audit 0m 15s The applied patch generated 1 release audit warnings.
        -1 checkstyle 1m 27s The applied patch generated 3 new checkstyle issues (total was 118, now 120).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 28s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 2m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 13s Pre-build of native portion
        -1 hdfs tests 199m 13s Tests failed in hadoop-hdfs.
            245m 28s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestAppendSnapshotTruncate
          hadoop.hdfs.web.TestWebHdfsContentLength
          hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
          hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.security.TestDelegationTokenForProxyUser



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12764979/HDFS-9070-trunk.03.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 0faa4ef
        Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12791/artifact/patchprocess/patchReleaseAuditProblems.txt
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12791/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12791/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12791/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12791/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 21s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 8s There were no new javac warning messages. +1 javadoc 10m 17s There were no new javadoc warning messages. -1 release audit 0m 15s The applied patch generated 1 release audit warnings. -1 checkstyle 1m 27s The applied patch generated 3 new checkstyle issues (total was 118, now 120). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 13s Pre-build of native portion -1 hdfs tests 199m 13s Tests failed in hadoop-hdfs.     245m 28s   Reason Tests Failed unit tests hadoop.hdfs.TestAppendSnapshotTruncate   hadoop.hdfs.web.TestWebHdfsContentLength   hadoop.hdfs.server.namenode.ha.TestBootstrapStandby   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.security.TestDelegationTokenForProxyUser Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764979/HDFS-9070-trunk.03.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0faa4ef Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12791/artifact/patchprocess/patchReleaseAuditProblems.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12791/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12791/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12791/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12791/console This message was automatically generated.
        Hide
        demongaorui Rui Gao added a comment -

        Jing Zhao Thanks for your advise, I have uploaded a new patch. Sorry for the delay, I just come back from NYC

        Show
        demongaorui Rui Gao added a comment - Jing Zhao Thanks for your advise, I have uploaded a new patch. Sorry for the delay, I just come back from NYC
        Hide
        jingzhao Jing Zhao added a comment -

        Thanks for updating the patch, Rui Gao! The new patch looks pretty good to me. Only one minor: it may be better to call append(DatanodeInfoWithStorage) for the last uc block in order to be consistent with the complete block case. Also let's also add a simple check lastBlock != null.

        sb.append(new DatanodeInfoWithStorage(dnDesc, storage.getStorageID(), storage
            .getStorageType()));
        
        Show
        jingzhao Jing Zhao added a comment - Thanks for updating the patch, Rui Gao ! The new patch looks pretty good to me. Only one minor: it may be better to call append(DatanodeInfoWithStorage) for the last uc block in order to be consistent with the complete block case. Also let's also add a simple check lastBlock != null . sb.append( new DatanodeInfoWithStorage(dnDesc, storage.getStorageID(), storage .getStorageType()));
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 16m 14s Findbugs (version ) appears to be broken on HDFS-7285.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 1s There were no new javac warning messages.
        +1 javadoc 10m 19s There were no new javadoc warning messages.
        -1 release audit 0m 16s The applied patch generated 1 release audit warnings.
        +1 checkstyle 0m 41s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 44s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        +1 findbugs 2m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 32s Pre-build of native portion
        -1 hdfs tests 223m 1s Tests failed in hadoop-hdfs.
            267m 1s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestReplaceDatanodeOnFailure



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12762781/HDFS-9070-HDFS-7285.02.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision HDFS-7285 / c09dc25
        Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12706/artifact/patchprocess/patchReleaseAuditProblems.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12706/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12706/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12706/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 14s Findbugs (version ) appears to be broken on HDFS-7285 . +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 1s There were no new javac warning messages. +1 javadoc 10m 19s There were no new javadoc warning messages. -1 release audit 0m 16s The applied patch generated 1 release audit warnings. +1 checkstyle 0m 41s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 44s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 2m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 32s Pre-build of native portion -1 hdfs tests 223m 1s Tests failed in hadoop-hdfs.     267m 1s   Reason Tests Failed unit tests hadoop.hdfs.TestReplaceDatanodeOnFailure Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12762781/HDFS-9070-HDFS-7285.02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision HDFS-7285 / c09dc25 Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12706/artifact/patchprocess/patchReleaseAuditProblems.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12706/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12706/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12706/console This message was automatically generated.
        Hide
        demongaorui Rui Gao added a comment -

        Jing Zhao Thank you very much for your advise. I have attached a new patch, hope it works.

        Show
        demongaorui Rui Gao added a comment - Jing Zhao Thank you very much for your advise. I have attached a new patch, hope it works.
        Hide
        jingzhao Jing Zhao added a comment -

        For #1, I've moved the issue out of the HDFS-8031 and also updated the jira title.

        Show
        jingzhao Jing Zhao added a comment - For #1, I've moved the issue out of the HDFS-8031 and also updated the jira title.
        Hide
        jingzhao Jing Zhao added a comment -

        Thanks for working on this, Rui! The patch looks good to me in general. Some comments:

        1. The change is not specific for EC files. We should do it in trunk directly.
        2. Looks like we should show expected locations of a under-construction block only when "showLocations" is enabled?
        3. It's better to append the information to the report instead of directly using out.println.
        Show
        jingzhao Jing Zhao added a comment - Thanks for working on this, Rui! The patch looks good to me in general. Some comments: The change is not specific for EC files. We should do it in trunk directly. Looks like we should show expected locations of a under-construction block only when "showLocations" is enabled? It's better to append the information to the report instead of directly using out.println .
        Hide
        demongaorui Rui Gao added a comment -

        Sorry Jing Zhao, I made a mistake about git diff patch. I have uploaded the right patch. I'm really sorry for causing this confusion to you.

        Show
        demongaorui Rui Gao added a comment - Sorry Jing Zhao , I made a mistake about git diff patch. I have uploaded the right patch. I'm really sorry for causing this confusion to you.
        Hide
        jingzhao Jing Zhao added a comment -

        Rui Gao, looks like your patch contains a lot of unrelated changes. Maybe you need to pull the most recent changes to your code base first?

        Show
        jingzhao Jing Zhao added a comment - Rui Gao , looks like your patch contains a lot of unrelated changes. Maybe you need to pull the most recent changes to your code base first?
        Hide
        demongaorui Rui Gao added a comment -

        Sorry for the patch name problem. I have changed patch file name, and uploaded the patch again.

        Show
        demongaorui Rui Gao added a comment - Sorry for the patch name problem. I have changed patch file name, and uploaded the patch again.
        Hide
        zhz Zhe Zhang added a comment -

        Patch name has 2 dashes. Not sure if that broke Jenkins.

        Show
        zhz Zhe Zhang added a comment - Patch name has 2 dashes. Not sure if that broke Jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12756228/HDFS-9070--HDFS-7285.00.patch
        Optional Tests javadoc javac unit findbugs checkstyle site
        git revision trunk / bf2f2b4
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12477/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12756228/HDFS-9070--HDFS-7285.00.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / bf2f2b4 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12477/console This message was automatically generated.
        Hide
        demongaorui Rui Gao added a comment -

        I have uploaded a patch for this Jira. Hope it can fix this problem.

        Show
        demongaorui Rui Gao added a comment - I have uploaded a patch for this Jira. Hope it can fix this problem.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks for reporting the issue Rui. I think it is a nice follow-on task, moving it to HDFS-8031.

        Show
        zhz Zhe Zhang added a comment - Thanks for reporting the issue Rui. I think it is a nice follow-on task, moving it to HDFS-8031 .

          People

          • Assignee:
            demongaorui Rui Gao
            Reporter:
            demongaorui Rui Gao
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development