Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1, 2.8.2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      New fsck option "-upgradedomains" has been added to display upgrade domains of any block.

      Description

      This will make it easy for people to use fsck to check block placement when upgrade domain is enabled.

      1. HDFS-9016.branch-2.8.001.patch
        12 kB
        Ming Ma
      2. HDFS-9016-4.patch
        12 kB
        Ming Ma
      3. HDFS-9016-branch-2-2.patch
        12 kB
        Ming Ma
      4. HDFS-9016-branch-2.patch
        12 kB
        Ming Ma
      5. HDFS-9016-4.patch
        12 kB
        Ming Ma
      6. HDFS-9016-3.patch
        12 kB
        Ming Ma
      7. HDFS-9016-2.patch
        11 kB
        Ming Ma
      8. HDFS-9016.patch
        6 kB
        Ming Ma

        Activity

        Hide
        mingma Ming Ma added a comment -

        Here is the draft patch. Given there is no backward compatibility issue, it seems unnecessary to introduce another upgrade domain flag to fsck. fsck will return the upgrade domain when it is set and one or more of

        {"-locations", "-racks", "-replicadetails"}

        are specified.

        Show
        mingma Ming Ma added a comment - Here is the draft patch. Given there is no backward compatibility issue, it seems unnecessary to introduce another upgrade domain flag to fsck. fsck will return the upgrade domain when it is set and one or more of {"-locations", "-racks", "-replicadetails"} are specified.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 10m 31s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 25s trunk passed
        +1 compile 0m 38s trunk passed with JDK v1.8.0_77
        +1 compile 0m 39s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 19s trunk passed
        +1 mvnsite 0m 47s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 53s trunk passed
        +1 javadoc 1m 6s trunk passed with JDK v1.8.0_77
        +1 javadoc 1m 39s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 35s the patch passed with JDK v1.8.0_77
        +1 javac 0m 35s the patch passed
        +1 compile 0m 37s the patch passed with JDK v1.7.0_95
        +1 javac 0m 37s the patch passed
        +1 checkstyle 0m 18s the patch passed
        +1 mvnsite 0m 45s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 1s the patch passed
        +1 javadoc 0m 59s the patch passed with JDK v1.8.0_77
        +1 javadoc 1m 41s the patch passed with JDK v1.7.0_95
        -1 unit 66m 29s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
        -1 unit 63m 51s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 25s Patch does not generate ASF License warnings.
        164m 52s



        Reason Tests
        JDK v1.8.0_77 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
          hadoop.security.TestPermissionSymlinks
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
          hadoop.fs.TestSymlinkHdfsFileSystem
          hadoop.hdfs.tools.TestDFSAdmin
          hadoop.hdfs.TestReadStripedFileWithMissingBlocks
          hadoop.fs.TestFcHdfsSetUMask
          hadoop.fs.contract.hdfs.TestHDFSContractRename
          hadoop.hdfs.TestHDFSTrash
          hadoop.hdfs.TestCrcCorruption
          hadoop.hdfs.TestErasureCodeBenchmarkThroughput
          hadoop.hdfs.TestDFSUpgradeFromImage
        JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile
          org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
          hadoop.hdfs.TestHFlush
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
          hadoop.hdfs.tools.TestDFSAdmin
          hadoop.hdfs.TestQuota
          hadoop.hdfs.TestReadStripedFileWithMissingBlocks
          hadoop.hdfs.TestDFSInputStream
          hadoop.hdfs.TestCrcCorruption
          hadoop.hdfs.TestErasureCodeBenchmarkThroughput
        JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile
          org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12798616/HDFS-9016.patch
        JIRA Issue HDFS-9016
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 4912792d99b6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0d9194d
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15155/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15155/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15155/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15155/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15155/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15155/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 10m 31s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 25s trunk passed +1 compile 0m 38s trunk passed with JDK v1.8.0_77 +1 compile 0m 39s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 47s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 53s trunk passed +1 javadoc 1m 6s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 39s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 45s the patch passed +1 compile 0m 35s the patch passed with JDK v1.8.0_77 +1 javac 0m 35s the patch passed +1 compile 0m 37s the patch passed with JDK v1.7.0_95 +1 javac 0m 37s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 45s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 1s the patch passed +1 javadoc 0m 59s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 41s the patch passed with JDK v1.7.0_95 -1 unit 66m 29s hadoop-hdfs in the patch failed with JDK v1.8.0_77. -1 unit 63m 51s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 164m 52s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.security.TestPermissionSymlinks   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure   hadoop.fs.TestSymlinkHdfsFileSystem   hadoop.hdfs.tools.TestDFSAdmin   hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.fs.TestFcHdfsSetUMask   hadoop.fs.contract.hdfs.TestHDFSContractRename   hadoop.hdfs.TestHDFSTrash   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.TestErasureCodeBenchmarkThroughput   hadoop.hdfs.TestDFSUpgradeFromImage JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile   org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding JDK v1.7.0_95 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.TestHFlush   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure   hadoop.hdfs.tools.TestDFSAdmin   hadoop.hdfs.TestQuota   hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.hdfs.TestDFSInputStream   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.TestErasureCodeBenchmarkThroughput JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile   org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12798616/HDFS-9016.patch JIRA Issue HDFS-9016 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4912792d99b6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0d9194d Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15155/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15155/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15155/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15155/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15155/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15155/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        mingma Ming Ma added a comment -

        TestReadStripedFileWithDecoding and TestWriteReadStripedFile aren't related. All other tests passed locally.

        Show
        mingma Ming Ma added a comment - TestReadStripedFileWithDecoding and TestWriteReadStripedFile aren't related. All other tests passed locally.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Hi, Ming Ma

        Thanks for the work.
        I +1 for the code. But it'd be better for Allen Wittenauer or Andrew Wang to comment the compatibility.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Hi, Ming Ma Thanks for the work. I +1 for the code. But it'd be better for Allen Wittenauer or Andrew Wang to comment the compatibility.
        Hide
        aw Allen Wittenauer added a comment -

        If it changes the output in any way/shape/form, it's not backward compatible. See http://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/Compatibility.html#Command_Line_Interface_CLI .

        Show
        aw Allen Wittenauer added a comment - If it changes the output in any way/shape/form, it's not backward compatible. See http://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/Compatibility.html#Command_Line_Interface_CLI .
        Hide
        mingma Ming Ma added a comment -

        Thanks, Lei (Eddy) Xu! It shouldn't change fsck's output format given upgrade domain isn't defined by default and it can't be defined until HDFS-9005 was available. Given 2.8 hasn't been released yet, it seems ok as long as this jira is added to 2.8. Allen Wittenauer, Andrew Wang, thoughts?

        Show
        mingma Ming Ma added a comment - Thanks, Lei (Eddy) Xu ! It shouldn't change fsck's output format given upgrade domain isn't defined by default and it can't be defined until HDFS-9005 was available. Given 2.8 hasn't been released yet, it seems ok as long as this jira is added to 2.8. Allen Wittenauer , Andrew Wang , thoughts?
        Hide
        aw Allen Wittenauer added a comment -

        fsck has already shipped in a previous release of Hadoop. Changing it's output is not a compatible change in the entirety of branch-2.

        Show
        aw Allen Wittenauer added a comment - fsck has already shipped in a previous release of Hadoop. Changing it's output is not a compatible change in the entirety of branch-2.
        Hide
        mingma Ming Ma added a comment -

        By default there is no format change.

        Scenarios Prior to 2.8 2.8 with the patch
        upgrade domain not enabled by default current format current format
        config change to enable upgrade domain undefined given upgrade domain feature wasn't available additional upgrade domain string

        Here is another scenario. To enable upgrade domain upgrade, admins need to switch block placement policy. The switch might cause the fsck output to change, because the block placement policy defines part of fsck's error message from BlockPlacementPolicyDefault's Block should be additionally replicated on 1 more rack(s) ... to BlockPlacementPolicyWithUpgradeDomain's Block has 3 replicas. But only has 2 upgrade domains...

        I can add another fsck flag for upgrade domain so that fsck won't return upgrade domain unless the flag is set, even when upgrade domain policy is used. But how do we handle the above scenario? It will break tools with the assumption about fsck's string content regardless of the configured block placement policy.

        Show
        mingma Ming Ma added a comment - By default there is no format change. Scenarios Prior to 2.8 2.8 with the patch upgrade domain not enabled by default current format current format config change to enable upgrade domain undefined given upgrade domain feature wasn't available additional upgrade domain string Here is another scenario. To enable upgrade domain upgrade, admins need to switch block placement policy. The switch might cause the fsck output to change, because the block placement policy defines part of fsck's error message from BlockPlacementPolicyDefault 's Block should be additionally replicated on 1 more rack(s) ... to BlockPlacementPolicyWithUpgradeDomain 's Block has 3 replicas. But only has 2 upgrade domains... I can add another fsck flag for upgrade domain so that fsck won't return upgrade domain unless the flag is set, even when upgrade domain policy is used. But how do we handle the above scenario? It will break tools with the assumption about fsck's string content regardless of the configured block placement policy.
        Hide
        andrew.wang Andrew Wang added a comment -

        I'm okay with the config flag, since it only affects users who are explicitly opting in to this information.

        Show
        andrew.wang Andrew Wang added a comment - I'm okay with the config flag, since it only affects users who are explicitly opting in to this information.
        Hide
        mingma Ming Ma added a comment -

        I can add a new config property or maybe a new fsck CLI option "-upgradedomains" (similar to "-replicadetails") is better. That was my initial plan too. But I still wondered if that is necessary.

        The users has already explicitly opted in for this information to some degree, given users has to set dfs.namenode.hosts.provider.classname to CombinedHostFileManager with proper json file in order to config upgrade domains. In addition users have to specify fsck CLI option like "-replicadetails" to display it.

        If down the road we need to add more properties to DN, does it mean we need to add new fsck CLI option for each one of those, or can we use something more general like "-replicadetails"?

        Also as mentioned above, I am not sure how fsck output can maintain strict compatibility when the block placement policy is changed via dfs.block.replicator.classname.

        Show
        mingma Ming Ma added a comment - I can add a new config property or maybe a new fsck CLI option "-upgradedomains" (similar to "-replicadetails") is better. That was my initial plan too. But I still wondered if that is necessary. The users has already explicitly opted in for this information to some degree, given users has to set dfs.namenode.hosts.provider.classname to CombinedHostFileManager with proper json file in order to config upgrade domains. In addition users have to specify fsck CLI option like "-replicadetails" to display it. If down the road we need to add more properties to DN, does it mean we need to add new fsck CLI option for each one of those, or can we use something more general like "-replicadetails"? Also as mentioned above, I am not sure how fsck output can maintain strict compatibility when the block placement policy is changed via dfs.block.replicator.classname.
        Hide
        aw Allen Wittenauer added a comment - - edited

        This is basically Hadoop's operability problems coming to the forefront:

        • The compatibility guidelines don't offer any real out for CLI output that actually needs to change based upon the implementation. So no, technically, a special flag like '-replicadetails' would not be magically immune. Once the output is in a released version, it's fixed. If the output changes based upon how the system is configured, there is no hints anywhere visible that this is going to occur. The compatibility guidelines are the ONLY thread by which operation teams are holding on and every time we ignore them, all hell breaks loose. (Of course, a lot of the people who work on the code don't realize this because they have no direct lines of communication or really pay attention that much when an ops person does point out that the world broke. "Feature expediency" takes over for common sense just way too much. HDFS rolling upgrade is a great example--it actually caused data loss in certain instances because someone thought it was a great idea to turn a heavily depended upon NN flag to be a no-op with a success exit code.)
        • We don't build that many interfaces that can actually be used by the scripting languages (perl, python, ruby, etc) leaving stdout as the only way the vast majority of ops people are going to be able to process information. While the JMX-\>REST hook was a great help, it's read only and still doesn't expose vital information (fsck being the worst offender, because frankly, it's doing way too much. Why does it have to be literally the only source for block level information?).

        To me, things like the storagepolicy code should have taken on the PMC and tried to revamp the compatibility guidelines to specifically spell out that command line arguments that generate output need to also specify stability in their accompanying documentation. Buried in a javadoc is useless. Unless people are writing code, users don't see that information. See: metrics, rack awareness, and a host of other bits that have had real documentation written over the past 2 years. All of that information was previously done through word of mouth.

        That said, I know what the outcome of this JIRA will be. Another cranny where the rules don't apply to come back and bite someone hard in the future.

        Show
        aw Allen Wittenauer added a comment - - edited This is basically Hadoop's operability problems coming to the forefront: The compatibility guidelines don't offer any real out for CLI output that actually needs to change based upon the implementation. So no, technically, a special flag like '-replicadetails' would not be magically immune. Once the output is in a released version, it's fixed. If the output changes based upon how the system is configured, there is no hints anywhere visible that this is going to occur. The compatibility guidelines are the ONLY thread by which operation teams are holding on and every time we ignore them, all hell breaks loose. (Of course, a lot of the people who work on the code don't realize this because they have no direct lines of communication or really pay attention that much when an ops person does point out that the world broke. "Feature expediency" takes over for common sense just way too much. HDFS rolling upgrade is a great example--it actually caused data loss in certain instances because someone thought it was a great idea to turn a heavily depended upon NN flag to be a no-op with a success exit code.) We don't build that many interfaces that can actually be used by the scripting languages (perl, python, ruby, etc) leaving stdout as the only way the vast majority of ops people are going to be able to process information. While the JMX-\>REST hook was a great help, it's read only and still doesn't expose vital information (fsck being the worst offender, because frankly, it's doing way too much. Why does it have to be literally the only source for block level information?). To me, things like the storagepolicy code should have taken on the PMC and tried to revamp the compatibility guidelines to specifically spell out that command line arguments that generate output need to also specify stability in their accompanying documentation. Buried in a javadoc is useless. Unless people are writing code, users don't see that information. See: metrics, rack awareness, and a host of other bits that have had real documentation written over the past 2 years. All of that information was previously done through word of mouth. That said, I know what the outcome of this JIRA will be. Another cranny where the rules don't apply to come back and bite someone hard in the future.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        IMO, when the user does not use new/additional flags, the output is the exactly same as previous result, then the patch is backward-compatible. Otherwise, it would be difficult to add any feature to branch-2.

        My 2 cents. Thanks.

        Show
        eddyxu Lei (Eddy) Xu added a comment - IMO, when the user does not use new/additional flags, the output is the exactly same as previous result, then the patch is backward-compatible. Otherwise, it would be difficult to add any feature to branch-2. My 2 cents. Thanks.
        Hide
        mingma Ming Ma added a comment - - edited

        Thanks all for the input. I will add "-upgradedomain" flag to fsck.

        I am still not convinced this is necessary for the reasons explained earlier, especially the fact that fsck output could be incompatible when default block placement policy changes to any other policy. And that is more likely to happen than changing to upgrade domain policy.

        Another example is the output of "dfsadmin -report". As we add new attributes to DatanodeInfo, the new attributes will be displayed. "dfsadmin -report" doesn't use flags to control what attributes get displayed. My main point here is we have much bigger surface of backward incompatibility and should take care of those scenarios at higher priority.

        Show
        mingma Ming Ma added a comment - - edited Thanks all for the input. I will add "-upgradedomain" flag to fsck. I am still not convinced this is necessary for the reasons explained earlier, especially the fact that fsck output could be incompatible when default block placement policy changes to any other policy. And that is more likely to happen than changing to upgrade domain policy. Another example is the output of "dfsadmin -report". As we add new attributes to DatanodeInfo, the new attributes will be displayed. "dfsadmin -report" doesn't use flags to control what attributes get displayed. My main point here is we have much bigger surface of backward incompatibility and should take care of those scenarios at higher priority.
        Hide
        mingma Ming Ma added a comment -

        The new patch adds "-upgradedomains" fsck command option.

        Show
        mingma Ming Ma added a comment - The new patch adds "-upgradedomains" fsck command option.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 9s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 16s trunk passed
        +1 compile 0m 44s trunk passed
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 42s trunk passed
        +1 javadoc 0m 53s trunk passed
        +1 mvninstall 0m 47s the patch passed
        +1 compile 0m 41s the patch passed
        +1 javac 0m 41s the patch passed
        -1 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 6 new + 430 unchanged - 2 fixed = 436 total (was 432)
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        -1 whitespace 0m 0s The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 1m 46s the patch passed
        +1 javadoc 0m 51s the patch passed
        -1 unit 57m 49s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        76m 6s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache
          hadoop.hdfs.server.datanode.TestDataNodeLifeline
          hadoop.hdfs.TestDecommissionWithStriped



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809882/HDFS-9016-2.patch
        JIRA Issue HDFS-9016
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 88a8116c2cc2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 28b66ae
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15754/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15754/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15754/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15754/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15754/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15754/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 16s trunk passed +1 compile 0m 44s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 42s trunk passed +1 javadoc 0m 53s trunk passed +1 mvninstall 0m 47s the patch passed +1 compile 0m 41s the patch passed +1 javac 0m 41s the patch passed -1 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 6 new + 430 unchanged - 2 fixed = 436 total (was 432) +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 10s the patch passed -1 whitespace 0m 0s The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 1m 46s the patch passed +1 javadoc 0m 51s the patch passed -1 unit 57m 49s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 76m 6s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.server.datanode.TestDataNodeLifeline   hadoop.hdfs.TestDecommissionWithStriped Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809882/HDFS-9016-2.patch JIRA Issue HDFS-9016 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 88a8116c2cc2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 28b66ae Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15754/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15754/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15754/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15754/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15754/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15754/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        mingma Ming Ma added a comment -

        Updated patch to address checkstyle issues. The failed uni tests aren't related.

        Show
        mingma Ming Ma added a comment - Updated patch to address checkstyle issues. The failed uni tests aren't related.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 10s trunk passed
        +1 compile 0m 44s trunk passed
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 40s trunk passed
        +1 javadoc 0m 55s trunk passed
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 41s the patch passed
        +1 javac 0m 41s the patch passed
        +1 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 410 unchanged - 22 fixed = 410 total (was 432)
        +1 mvnsite 0m 48s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        -1 whitespace 0m 0s The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 1m 45s the patch passed
        +1 javadoc 0m 52s the patch passed
        -1 unit 63m 58s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        82m 11s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache
          hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs
          hadoop.hdfs.TestRenameWhileOpen



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809974/HDFS-9016-3.patch
        JIRA Issue HDFS-9016
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 11fd2de9b729 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 709a814
        Default Java 1.8.0_91
        findbugs v3.0.0
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15758/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15758/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15758/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15758/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15758/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 10s trunk passed +1 compile 0m 44s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 40s trunk passed +1 javadoc 0m 55s trunk passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 41s the patch passed +1 javac 0m 41s the patch passed +1 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 410 unchanged - 22 fixed = 410 total (was 432) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 9s the patch passed -1 whitespace 0m 0s The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 1m 45s the patch passed +1 javadoc 0m 52s the patch passed -1 unit 63m 58s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 82m 11s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.metrics2.sink.TestRollingFileSystemSinkWithHdfs   hadoop.hdfs.TestRenameWhileOpen Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809974/HDFS-9016-3.patch JIRA Issue HDFS-9016 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 11fd2de9b729 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 709a814 Default Java 1.8.0_91 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15758/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15758/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15758/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15758/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15758/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        mingma Ming Ma added a comment -

        Fix a minor format issue. Also includes the patch for branch-2 which requires manual merge.

        Show
        mingma Ming Ma added a comment - Fix a minor format issue. Also includes the patch for branch-2 which requires manual merge.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 10m 40s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 36s branch-2 passed
        +1 compile 0m 39s branch-2 passed with JDK v1.8.0_91
        +1 compile 0m 42s branch-2 passed with JDK v1.7.0_101
        +1 checkstyle 0m 33s branch-2 passed
        +1 mvnsite 0m 53s branch-2 passed
        +1 mvneclipse 0m 17s branch-2 passed
        +1 findbugs 2m 1s branch-2 passed
        +1 javadoc 0m 57s branch-2 passed with JDK v1.8.0_91
        +1 javadoc 1m 37s branch-2 passed with JDK v1.7.0_101
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 38s the patch passed with JDK v1.8.0_91
        +1 javac 0m 38s the patch passed
        +1 compile 0m 39s the patch passed with JDK v1.7.0_101
        +1 javac 0m 39s the patch passed
        -1 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 393 unchanged - 16 fixed = 395 total (was 409)
        +1 mvnsite 0m 50s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 7s the patch passed
        +1 javadoc 0m 54s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 35s the patch passed with JDK v1.7.0_101
        -1 unit 57m 34s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 unit 49m 58s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        145m 0s



        Reason Tests
        JDK v1.8.0_91 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.server.namenode.TestEditLog
          hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
        JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2
        JDK v1.7.0_101 Failed junit tests hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:babe025
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12810170/HDFS-9016-branch-2.patch
        JIRA Issue HDFS-9016
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b32668cd0fc6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / ff4466f
        Default Java 1.7.0_101
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15761/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15761/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15761/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15761/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15761/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15761/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15761/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 10m 40s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 36s branch-2 passed +1 compile 0m 39s branch-2 passed with JDK v1.8.0_91 +1 compile 0m 42s branch-2 passed with JDK v1.7.0_101 +1 checkstyle 0m 33s branch-2 passed +1 mvnsite 0m 53s branch-2 passed +1 mvneclipse 0m 17s branch-2 passed +1 findbugs 2m 1s branch-2 passed +1 javadoc 0m 57s branch-2 passed with JDK v1.8.0_91 +1 javadoc 1m 37s branch-2 passed with JDK v1.7.0_101 +1 mvninstall 0m 46s the patch passed +1 compile 0m 38s the patch passed with JDK v1.8.0_91 +1 javac 0m 38s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_101 +1 javac 0m 39s the patch passed -1 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 393 unchanged - 16 fixed = 395 total (was 409) +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 7s the patch passed +1 javadoc 0m 54s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 35s the patch passed with JDK v1.7.0_101 -1 unit 57m 34s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 unit 49m 58s hadoop-hdfs in the patch failed with JDK v1.7.0_101. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 145m 0s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 JDK v1.7.0_101 Failed junit tests hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits Subsystem Report/Notes Docker Image:yetus/hadoop:babe025 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12810170/HDFS-9016-branch-2.patch JIRA Issue HDFS-9016 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b32668cd0fc6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / ff4466f Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15761/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15761/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15761/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15761/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15761/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15761/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15761/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        mingma Ming Ma added a comment -

        New branch-2 patch to fix checkstyle issues.

        Show
        mingma Ming Ma added a comment - New branch-2 patch to fix checkstyle issues.
        Hide
        aw Allen Wittenauer added a comment -

        You'll need to re-upload the trunk patch. You can't submit two patches at once to precommit; it only uses the last one attached.

        Show
        aw Allen Wittenauer added a comment - You'll need to re-upload the trunk patch. You can't submit two patches at once to precommit; it only uses the last one attached.
        Hide
        mingma Ming Ma added a comment -

        Thanks Allen. Reload trunk patch.

        Show
        mingma Ming Ma added a comment - Thanks Allen. Reload trunk patch.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        +1, pending jenkins.

        Thanks Ming!

        Show
        eddyxu Lei (Eddy) Xu added a comment - +1, pending jenkins. Thanks Ming!
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 12s trunk passed
        +1 compile 0m 48s trunk passed
        +1 checkstyle 0m 36s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 2m 3s trunk passed
        +1 javadoc 0m 56s trunk passed
        +1 mvninstall 0m 49s the patch passed
        +1 compile 0m 47s the patch passed
        +1 javac 0m 47s the patch passed
        +1 checkstyle 0m 30s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 410 unchanged - 22 fixed = 410 total (was 432)
        +1 mvnsite 0m 53s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 8s the patch passed
        +1 javadoc 1m 0s the patch passed
        +1 unit 59m 15s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        80m 13s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12810597/HDFS-9016-4.patch
        JIRA Issue HDFS-9016
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 9366672afb68 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 8e8cb4c
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15769/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15769/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 12s trunk passed +1 compile 0m 48s trunk passed +1 checkstyle 0m 36s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 2m 3s trunk passed +1 javadoc 0m 56s trunk passed +1 mvninstall 0m 49s the patch passed +1 compile 0m 47s the patch passed +1 javac 0m 47s the patch passed +1 checkstyle 0m 30s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 410 unchanged - 22 fixed = 410 total (was 432) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 8s the patch passed +1 javadoc 1m 0s the patch passed +1 unit 59m 15s hadoop-hdfs in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 80m 13s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12810597/HDFS-9016-4.patch JIRA Issue HDFS-9016 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9366672afb68 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8e8cb4c Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15769/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15769/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        mingma Ming Ma added a comment -

        I have committed it to trunk and branch-2. Thanks Lei (Eddy) Xu, Allen Wittenauer and Andrew Wang for the review.

        Show
        mingma Ming Ma added a comment - I have committed it to trunk and branch-2. Thanks Lei (Eddy) Xu , Allen Wittenauer and Andrew Wang for the review.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 13m 51s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 9m 14s branch-2.8 passed
        +1 compile 0m 38s branch-2.8 passed with JDK v1.8.0_131
        +1 compile 0m 43s branch-2.8 passed with JDK v1.7.0_121
        +1 checkstyle 0m 23s branch-2.8 passed
        +1 mvnsite 0m 53s branch-2.8 passed
        +1 mvneclipse 0m 17s branch-2.8 passed
        +1 findbugs 1m 57s branch-2.8 passed
        +1 javadoc 0m 37s branch-2.8 passed with JDK v1.8.0_131
        +1 javadoc 0m 59s branch-2.8 passed with JDK v1.7.0_121
        +1 mvninstall 0m 43s the patch passed
        +1 compile 0m 36s the patch passed with JDK v1.8.0_131
        +1 javac 0m 36s the patch passed
        +1 compile 0m 41s the patch passed with JDK v1.7.0_121
        +1 javac 0m 41s the patch passed
        -0 checkstyle 0m 21s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 134 unchanged - 15 fixed = 135 total (was 149)
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 8s the patch passed
        +1 javadoc 0m 37s the patch passed with JDK v1.8.0_131
        +1 javadoc 0m 57s the patch passed with JDK v1.7.0_121
        +1 unit 47m 29s hadoop-hdfs in the patch passed with JDK v1.7.0_121.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        138m 20s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:5970e82
        JIRA Issue HDFS-9016
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865989/HDFS-9016.branch-2.8.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux bc08ef0046b5 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.8 / 42fa35d
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19269/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19269/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19269/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 13m 51s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 14s branch-2.8 passed +1 compile 0m 38s branch-2.8 passed with JDK v1.8.0_131 +1 compile 0m 43s branch-2.8 passed with JDK v1.7.0_121 +1 checkstyle 0m 23s branch-2.8 passed +1 mvnsite 0m 53s branch-2.8 passed +1 mvneclipse 0m 17s branch-2.8 passed +1 findbugs 1m 57s branch-2.8 passed +1 javadoc 0m 37s branch-2.8 passed with JDK v1.8.0_131 +1 javadoc 0m 59s branch-2.8 passed with JDK v1.7.0_121 +1 mvninstall 0m 43s the patch passed +1 compile 0m 36s the patch passed with JDK v1.8.0_131 +1 javac 0m 36s the patch passed +1 compile 0m 41s the patch passed with JDK v1.7.0_121 +1 javac 0m 41s the patch passed -0 checkstyle 0m 21s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 134 unchanged - 15 fixed = 135 total (was 149) +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 8s the patch passed +1 javadoc 0m 37s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 57s the patch passed with JDK v1.7.0_121 +1 unit 47m 29s hadoop-hdfs in the patch passed with JDK v1.7.0_121. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 138m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:5970e82 JIRA Issue HDFS-9016 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865989/HDFS-9016.branch-2.8.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bc08ef0046b5 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 42fa35d Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/19269/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/19269/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/19269/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        mingma Ming Ma added a comment -

        Backported to branch-2.8 per the discussion in the umbrella jira.

        Show
        mingma Ming Ma added a comment - Backported to branch-2.8 per the discussion in the umbrella jira.

          People

          • Assignee:
            mingma Ming Ma
            Reporter:
            mingma Ming Ma
          • Votes:
            0 Vote for this issue
            Watchers:
            12 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development