Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8981

Adding revision to data node jmx getVersion() method

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      Hide
      getSoftwareVersion method would replace original getVersion method, which returns the version string.

      The new getVersion method would return both version string and revision string.
      Show
      getSoftwareVersion method would replace original getVersion method, which returns the version string. The new getVersion method would return both version string and revision string.

      Description

      to be consistent with namenode jmx, datanode jmx should also output revision number

      1. HDFS-8981.v1.patch
        0.8 kB
        Siqi Li
      2. HDFS-8981.v2.patch
        3 kB
        Siqi Li
      3. HDFS-8981.v3.patch
        3 kB
        Siqi Li
      4. HDFS-8981.v4.patch
        3 kB
        Siqi Li

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2297 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2297/)
        HDFS-8981. Adding revision to data node jmx getVersion() method. (Siqi Li via mingma) (mingma: rev 30db1adac31b07b34ce8e8d426cc139fb8cfad02)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2297 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2297/ ) HDFS-8981 . Adding revision to data node jmx getVersion() method. (Siqi Li via mingma) (mingma: rev 30db1adac31b07b34ce8e8d426cc139fb8cfad02) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #336 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/336/)
        HDFS-8981. Adding revision to data node jmx getVersion() method. (Siqi Li via mingma) (mingma: rev 30db1adac31b07b34ce8e8d426cc139fb8cfad02)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #336 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/336/ ) HDFS-8981 . Adding revision to data node jmx getVersion() method. (Siqi Li via mingma) (mingma: rev 30db1adac31b07b34ce8e8d426cc139fb8cfad02) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #348 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/348/)
        HDFS-8981. Adding revision to data node jmx getVersion() method. (Siqi Li via mingma) (mingma: rev 30db1adac31b07b34ce8e8d426cc139fb8cfad02)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #348 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/348/ ) HDFS-8981 . Adding revision to data node jmx getVersion() method. (Siqi Li via mingma) (mingma: rev 30db1adac31b07b34ce8e8d426cc139fb8cfad02) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1085 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1085/)
        HDFS-8981. Adding revision to data node jmx getVersion() method. (Siqi Li via mingma) (mingma: rev 30db1adac31b07b34ce8e8d426cc139fb8cfad02)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1085 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1085/ ) HDFS-8981 . Adding revision to data node jmx getVersion() method. (Siqi Li via mingma) (mingma: rev 30db1adac31b07b34ce8e8d426cc139fb8cfad02) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2274 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2274/)
        HDFS-8981. Adding revision to data node jmx getVersion() method. (Siqi Li via mingma) (mingma: rev 30db1adac31b07b34ce8e8d426cc139fb8cfad02)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2274 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2274/ ) HDFS-8981 . Adding revision to data node jmx getVersion() method. (Siqi Li via mingma) (mingma: rev 30db1adac31b07b34ce8e8d426cc139fb8cfad02) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8405 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8405/)
        HDFS-8981. Adding revision to data node jmx getVersion() method. (Siqi Li via mingma) (mingma: rev 30db1adac31b07b34ce8e8d426cc139fb8cfad02)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8405 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8405/ ) HDFS-8981 . Adding revision to data node jmx getVersion() method. (Siqi Li via mingma) (mingma: rev 30db1adac31b07b34ce8e8d426cc139fb8cfad02) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #353 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/353/)
        HDFS-8981. Adding revision to data node jmx getVersion() method. (Siqi Li via mingma) (mingma: rev 30db1adac31b07b34ce8e8d426cc139fb8cfad02)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #353 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/353/ ) HDFS-8981 . Adding revision to data node jmx getVersion() method. (Siqi Li via mingma) (mingma: rev 30db1adac31b07b34ce8e8d426cc139fb8cfad02) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNodeMXBean.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        Hide
        mingma Ming Ma added a comment -

        I have committed it to trunk. Thanks Siqi Li for the contribution and Sangjin Lee and Haohui Mai for the review.

        Show
        mingma Ming Ma added a comment - I have committed it to trunk. Thanks Siqi Li for the contribution and Sangjin Lee and Haohui Mai for the review.
        Hide
        wheat9 Haohui Mai added a comment -

        Thanks for the explanation. That way the JMX is consistent across NN and DN. Changing the target version to trunk.

        Show
        wheat9 Haohui Mai added a comment - Thanks for the explanation. That way the JMX is consistent across NN and DN. Changing the target version to trunk.
        Hide
        mingma Ming Ma added a comment -

        Thanks Haohui Mai. This patch changes the output format of an existing attribute "Version" and add a new attribute "SoftwareVersion". Which method is to deprecate? The current plan is to commit this only to trunk.

        Show
        mingma Ming Ma added a comment - Thanks Haohui Mai . This patch changes the output format of an existing attribute "Version" and add a new attribute "SoftwareVersion". Which method is to deprecate? The current plan is to commit this only to trunk.
        Hide
        wheat9 Haohui Mai added a comment -

        It might make sense to file a new jira to deprecate the old method in branch-2 and clean things up in trunk?

        Show
        wheat9 Haohui Mai added a comment - It might make sense to file a new jira to deprecate the old method in branch-2 and clean things up in trunk?
        Hide
        mingma Ming Ma added a comment -

        +1 on the latest patch. The failed unit tests aren't related. I will wait until tomorrow to commit in case folks have questions about the incompatible change.

        Show
        mingma Ming Ma added a comment - +1 on the latest patch. The failed unit tests aren't related. I will wait until tomorrow to commit in case folks have questions about the incompatible change.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 21m 18s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 54s There were no new javac warning messages.
        +1 javadoc 10m 17s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 24s The applied patch generated 3 new checkstyle issues (total was 150, now 152).
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 29s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 25s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 9s Pre-build of native portion
        -1 hdfs tests 166m 5s Tests failed in hadoop-hdfs.
            215m 4s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
          hadoop.hdfs.server.datanode.web.dtp.TestDtpHttp2
          hadoop.hdfs.server.namenode.snapshot.TestSnapshot



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12754047/HDFS-8981.v4.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 524ba87
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12288/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12288/artifact/patchprocess/whitespace.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12288/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12288/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12288/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 21m 18s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 54s There were no new javac warning messages. +1 javadoc 10m 17s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 24s The applied patch generated 3 new checkstyle issues (total was 150, now 152). -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 29s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 25s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 9s Pre-build of native portion -1 hdfs tests 166m 5s Tests failed in hadoop-hdfs.     215m 4s   Reason Tests Failed unit tests hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade   hadoop.hdfs.server.datanode.web.dtp.TestDtpHttp2   hadoop.hdfs.server.namenode.snapshot.TestSnapshot Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12754047/HDFS-8981.v4.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 524ba87 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12288/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12288/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12288/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12288/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12288/console This message was automatically generated.
        Hide
        l201514 Siqi Li added a comment -

        thanks Ming Ma for the review, I have uploaded patch v4.

        Show
        l201514 Siqi Li added a comment - thanks Ming Ma for the review, I have uploaded patch v4.
        Hide
        mingma Ming Ma added a comment -

        Thanks Siqi Li. It looks good. For the unit test that verifies the format of Version property, I meant you can do something like below:

              String version = (String)mbs.getAttribute(mxbeanName, "Version");
              assertTrue(version.equals(VersionInfo.getVersion()
                  + ", r" + VersionInfo.getRevision()));
        
        Show
        mingma Ming Ma added a comment - Thanks Siqi Li . It looks good. For the unit test that verifies the format of Version property, I meant you can do something like below: String version = (String)mbs.getAttribute(mxbeanName, "Version"); assertTrue(version.equals(VersionInfo.getVersion() + ", r" + VersionInfo.getRevision()));
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 16m 6s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 0s There were no new javac warning messages.
        +1 javadoc 10m 4s There were no new javadoc warning messages.
        +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 37s There were no new checkstyle issues.
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 14s Pre-build of native portion
        -1 hdfs tests 70m 15s Tests failed in hadoop-hdfs.
            113m 26s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestEncryptionZonesWithKMS
          hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes
          hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs
        Timed out tests org.apache.hadoop.hdfs.TestConnCache



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12753848/HDFS-8981.v3.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / afc88b3
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12259/artifact/patchprocess/whitespace.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12259/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12259/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12259/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 6s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 0s There were no new javac warning messages. +1 javadoc 10m 4s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 37s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 14s Pre-build of native portion -1 hdfs tests 70m 15s Tests failed in hadoop-hdfs.     113m 26s   Reason Tests Failed unit tests hadoop.hdfs.TestEncryptionZonesWithKMS   hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes   hadoop.hdfs.TestDatanodeStartupFixesLegacyStorageIDs Timed out tests org.apache.hadoop.hdfs.TestConnCache Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753848/HDFS-8981.v3.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / afc88b3 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12259/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12259/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12259/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12259/console This message was automatically generated.
        Hide
        l201514 Siqi Li added a comment -

        checkstyle and test failures seems to be not related to this patch

        Show
        l201514 Siqi Li added a comment - checkstyle and test failures seems to be not related to this patch
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 50s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 50s There were no new javac warning messages.
        +1 javadoc 10m 11s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 21s The applied patch generated 3 new checkstyle issues (total was 150, now 152).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 27s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 8s Pre-build of native portion
        -1 hdfs tests 168m 29s Tests failed in hadoop-hdfs.
            214m 42s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.blockmanagement.TestBlockManager
          hadoop.hdfs.TestLeaseRecovery2
          hadoop.hdfs.web.TestWebHDFSOAuth2
        Timed out tests org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery
          org.apache.hadoop.hdfs.TestMultiThreadedHflush



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12753562/HDFS-8981.v2.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 0eb9b19
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12230/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12230/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12230/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12230/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 50s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 50s There were no new javac warning messages. +1 javadoc 10m 11s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 21s The applied patch generated 3 new checkstyle issues (total was 150, now 152). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 28s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 8s Pre-build of native portion -1 hdfs tests 168m 29s Tests failed in hadoop-hdfs.     214m 42s   Reason Tests Failed unit tests hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.TestLeaseRecovery2   hadoop.hdfs.web.TestWebHDFSOAuth2 Timed out tests org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery   org.apache.hadoop.hdfs.TestMultiThreadedHflush Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753562/HDFS-8981.v2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0eb9b19 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12230/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12230/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12230/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12230/console This message was automatically generated.
        Hide
        mingma Ming Ma added a comment -

        Thanks Siqi Li. It makes sense to include revision just like namenode JMX. The one issue here is backward compatibility. AFAIK, change of JMX output format is considered incompatible. If so, we can commit the change only to trunk.

        • To be consistent with NameNodeMXBean, perhaps we can add getSoftwareVersion to DataNodeMXBean.
        • It might be good to have unit test for it. For example, you can compare the output of getVersion with VersionInfo like TestNameNodeMXBean.
        Show
        mingma Ming Ma added a comment - Thanks Siqi Li . It makes sense to include revision just like namenode JMX. The one issue here is backward compatibility. AFAIK, change of JMX output format is considered incompatible. If so, we can commit the change only to trunk. To be consistent with NameNodeMXBean , perhaps we can add getSoftwareVersion to DataNodeMXBean . It might be good to have unit test for it. For example, you can compare the output of getVersion with VersionInfo like TestNameNodeMXBean .
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 17m 33s Pre-patch trunk has 2 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 48s There were no new javac warning messages.
        +1 javadoc 9m 54s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 20s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 27s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        +1 findbugs 2m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 7s Pre-build of native portion
        +1 hdfs tests 167m 24s Tests passed in hadoop-hdfs.
            212m 7s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12752854/HDFS-8981.v1.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / a9c8ea7
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12175/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12175/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12175/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12175/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 33s Pre-patch trunk has 2 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 48s There were no new javac warning messages. +1 javadoc 9m 54s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 20s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 2m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 7s Pre-build of native portion +1 hdfs tests 167m 24s Tests passed in hadoop-hdfs.     212m 7s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12752854/HDFS-8981.v1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a9c8ea7 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12175/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12175/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12175/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12175/console This message was automatically generated.

          People

          • Assignee:
            l201514 Siqi Li
            Reporter:
            l201514 Siqi Li
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development