Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8969

Clean up findbugs warnings for HDFS-8823 and HDFS-8932

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Fix Findbug warnings

        Issue Links

          Activity

          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Anu Engineer thanks for reporting this jira..

          can you please handle following one also and change the issue summary..?

          Redundant nullcheck of blockInfo, which is known to be non-null in org.apache.hadoop.hdfs.server.namenode.NamenodeFsck.blockIdCK(String)
          Bug type RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE (click for details) 
          In class org.apache.hadoop.hdfs.server.namenode.NamenodeFsck
          In method org.apache.hadoop.hdfs.server.namenode.NamenodeFsck.blockIdCK(String)
          Value loaded from blockInfo
          Return value of org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.getStoredBlock(Block)
          Redundant null check at NamenodeFsck.java:[line 257]
          
          Show
          brahmareddy Brahma Reddy Battula added a comment - Anu Engineer thanks for reporting this jira.. can you please handle following one also and change the issue summary..? Redundant nullcheck of blockInfo, which is known to be non-null in org.apache.hadoop.hdfs.server.namenode.NamenodeFsck.blockIdCK(String) Bug type RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE (click for details) In class org.apache.hadoop.hdfs.server.namenode.NamenodeFsck In method org.apache.hadoop.hdfs.server.namenode.NamenodeFsck.blockIdCK(String) Value loaded from blockInfo Return value of org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.getStoredBlock(Block) Redundant null check at NamenodeFsck.java:[line 257]
          Hide
          anu Anu Engineer added a comment -

          Brahma Reddy Battula I have fixed both issues in the patch

          Show
          anu Anu Engineer added a comment - Brahma Reddy Battula I have fixed both issues in the patch
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Anu Engineer thanks a lot for your patch..Patch looks good to me..+1 ( non binding)..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Anu Engineer thanks a lot for your patch..Patch looks good to me..+1 ( non binding)..
          Hide
          wheat9 Haohui Mai added a comment -

          +1 pending jenkins.

          Show
          wheat9 Haohui Mai added a comment - +1 pending jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 17m 22s Pre-patch trunk has 4 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 41s There were no new javac warning messages.
          +1 javadoc 9m 50s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 45s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 28s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 2 pre-existing warnings.
          +1 native 3m 9s Pre-build of native portion
          +1 hdfs tests 161m 10s Tests passed in hadoop-hdfs.
              204m 57s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12752779/HDFS-8969.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 0bf2854
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12165/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12165/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12165/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12165/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 22s Pre-patch trunk has 4 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 41s There were no new javac warning messages. +1 javadoc 9m 50s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 45s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 2 pre-existing warnings. +1 native 3m 9s Pre-build of native portion +1 hdfs tests 161m 10s Tests passed in hadoop-hdfs.     204m 57s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12752779/HDFS-8969.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0bf2854 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12165/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12165/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12165/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12165/console This message was automatically generated.
          Hide
          anu Anu Engineer added a comment -

          working as expected. "The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 2 pre-existing warnings" and this patch did not modify any tests, hadoop QA tests are as expected.

          Show
          anu Anu Engineer added a comment - working as expected. "The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 2 pre-existing warnings" and this patch did not modify any tests, hadoop QA tests are as expected.
          Hide
          wheat9 Haohui Mai added a comment -

          I've committed the patch to trunk and branch-2. Thanks Anu Engineer for the contribution.

          Show
          wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Anu Engineer for the contribution.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8358 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8358/)
          HDFS-8969. Clean up findbugs warnings for HDFS-8823 and HDFS-8932. Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8358 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8358/ ) HDFS-8969 . Clean up findbugs warnings for HDFS-8823 and HDFS-8932 . Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #313 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/313/)
          HDFS-8969. Clean up findbugs warnings for HDFS-8823 and HDFS-8932. Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #313 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/313/ ) HDFS-8969 . Clean up findbugs warnings for HDFS-8823 and HDFS-8932 . Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1046 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1046/)
          HDFS-8969. Clean up findbugs warnings for HDFS-8823 and HDFS-8932. Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1046 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1046/ ) HDFS-8969 . Clean up findbugs warnings for HDFS-8823 and HDFS-8932 . Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #318 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/318/)
          HDFS-8969. Clean up findbugs warnings for HDFS-8823 and HDFS-8932. Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #318 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/318/ ) HDFS-8969 . Clean up findbugs warnings for HDFS-8823 and HDFS-8932 . Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #305 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/305/)
          HDFS-8969. Clean up findbugs warnings for HDFS-8823 and HDFS-8932. Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #305 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/305/ ) HDFS-8969 . Clean up findbugs warnings for HDFS-8823 and HDFS-8932 . Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2262 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2262/)
          HDFS-8969. Clean up findbugs warnings for HDFS-8823 and HDFS-8932. Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2262 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2262/ ) HDFS-8969 . Clean up findbugs warnings for HDFS-8823 and HDFS-8932 . Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2243 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2243/)
          HDFS-8969. Clean up findbugs warnings for HDFS-8823 and HDFS-8932. Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2243 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2243/ ) HDFS-8969 . Clean up findbugs warnings for HDFS-8823 and HDFS-8932 . Contributed by Anu Engineer. (wheat9: rev f97a0f8c2cdad0668a3892319f6969fafc2f04cd) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLog.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java

            People

            • Assignee:
              anu Anu Engineer
              Reporter:
              anu Anu Engineer
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development