[HDFS-8946] Improve choosing datanode storage for block placement

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: namenode
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Yi Liu
• Reporter: Yi Liu
• Created: 24/Aug/15 16:00
• Updated: 03/Mar/17 13:22
• Resolved: 01/Sep/15 01:06

Description

This JIRA is to:
Improve chooseing datanode storage for block placement:
In BlockPlacementPolicyDefault (chooseLocalStorage, chooseRandom), we have following logic to choose datanode storage to place block.
For given storage type, we iterate storages of the datanode. But for datanode, it only cares about the storage type. In the loop, we check according to Storage type and return the first storage if the storages of the type on the datanode fit in requirement. So we can remove the iteration of storages, and just need to do once to find a good storage of given type, it's efficient if the storages of the type on the datanode don't fit in requirement since we don't need to loop all storages and do the same check.
Besides, no need to shuffle the storages, since we only need to check according to the storage type on the datanode once.
This also improves the logic and make it more clear.

      if (excludedNodes.add(localMachine) // was not in the excluded list
          && isGoodDatanode(localDatanode, maxNodesPerRack, false,
              results, avoidStaleNodes)) {
        for (Iterator<Map.Entry<StorageType, Integer>> iter = storageTypes
            .entrySet().iterator(); iter.hasNext(); ) {
          Map.Entry<StorageType, Integer> entry = iter.next();
          for (DatanodeStorageInfo localStorage : DFSUtil.shuffle(
              localDatanode.getStorageInfos())) {
            StorageType type = entry.getKey();
            if (addIfIsGoodTarget(localStorage, excludedNodes, blocksize,
                results, type) >= 0) {
              int num = entry.getValue();
              ...

(current logic above)

Issue Links

• is related to: HDFS-11464 Improve the selection in choosing storage for blocks
• is related to: HDFS-11494 Log message when DN is not selected for block replication
• relates to: HDFS-8863 The remaining space check in BlockPlacementPolicyDefault is flawed
• relates to: HDFS-8884 Fail-fast check in BlockPlacementPolicyDefault#chooseTarget