Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-891

DataNode no longer needs to check for dfs.network.script

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Looking at the code for DataNode.instantiateDataNode())} , I see that it calls {{system.exit(-1) if it is not happy with the configuration

          if (conf.get("dfs.network.script") != null) {
            LOG.error("This configuration for rack identification is not supported" +
                " anymore. RackID resolution is handled by the NameNode.");
            System.exit(-1);
          }
      

      This is excessive. It should throw an exception and let whoever called the method decide how to handle it. The DataNode.main() method will log the exception and exit with a -1 value, but other callers (such as anything using MiniDFSCluster will now see a meaningful message rather than some Junit "tests exited without completing" warning.

      Easy to write a test for the correct behaviour: start a MiniDFSCluster with this configuration set, see what happens.

      1. hdfs-891.txt
        1 kB
        Eli Collins
      2. HDFS-891.patch
        0.9 kB
        Harsh J

        Issue Links

          Activity

          steve_l created issue -
          steve_l made changes -
          Field Original Value New Value
          Link This issue relates to HADOOP-1985 [ HADOOP-1985 ]
          steve_l made changes -
          Priority Major [ 3 ] Minor [ 4 ]
          Gavin made changes -
          Reporter Steve Loughran [ steve_l ] Steve Loughran [ stevel@apache.org ]
          Harsh J made changes -
          Attachment HDFS-891.patch [ 12509791 ]
          Harsh J made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Target Version/s 0.24.0, 0.23.1 [ 12317653, 12318885 ]
          Robert Joseph Evans made changes -
          Target Version/s 0.23.1, 0.24.0 [ 12318885, 12317653 ] 2.0.0, 3.0.0 [ 12320353, 12320356 ]
          Eli Collins made changes -
          Summary DataNode.instantiateDataNode calls system.exit(-1) if conf.get("dfs.network.script") != null DataNode no longer needs to check for dfs.network.script
          Assignee Harsh J [ qwertymaniac ]
          Affects Version/s 0.23.0 [ 12315571 ]
          Affects Version/s 0.22.0 [ 12314241 ]
          Target Version/s 3.0.0, 2.0.0 [ 12320356, 12320353 ] 2.0.0 [ 12320353 ]
          Eli Collins made changes -
          Attachment hdfs-891.txt [ 12523249 ]
          Eli Collins made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Target Version/s 2.0.0 [ 12320353 ]
          Fix Version/s 2.0.0 [ 12320353 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              Harsh J
              Reporter:
              Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development