Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-891

DataNode no longer needs to check for dfs.network.script

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.23.0
    • 2.0.0-alpha
    • datanode
    • None
    • Reviewed

    Description

      Looking at the code for DataNode.instantiateDataNode())} , I see that it calls {{system.exit(-1) if it is not happy with the configuration

          if (conf.get("dfs.network.script") != null) {
            LOG.error("This configuration for rack identification is not supported" +
                " anymore. RackID resolution is handled by the NameNode.");
            System.exit(-1);
          }
      

      This is excessive. It should throw an exception and let whoever called the method decide how to handle it. The DataNode.main() method will log the exception and exit with a -1 value, but other callers (such as anything using MiniDFSCluster will now see a meaningful message rather than some Junit "tests exited without completing" warning.

      Easy to write a test for the correct behaviour: start a MiniDFSCluster with this configuration set, see what happens.

      Attachments

        1. HDFS-891.patch
          0.9 kB
          Harsh J
        2. hdfs-891.txt
          1 kB
          Eli Collins

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            qwertymaniac Harsh J
            stevel@apache.org Steve Loughran
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment