Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 2.7.2, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      FSDirConcatOp.verifySrcFiles may change src files order, but it should their order as input.

      1. HDFS-8891.001.patch
        4 kB
        Yong Zhang
      2. HDFS-8891.002.patch
        4 kB
        Yong Zhang
      3. HDFS-8891-test-only-branch-2.6.patch
        2 kB
        Akira Ajisaka

        Issue Links

          Activity

          Hide
          zhangyongxyz Yong Zhang added a comment -

          First patch, please review

          Show
          zhangyongxyz Yong Zhang added a comment - First patch, please review
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 16s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 39s There were no new javac warning messages.
          +1 javadoc 9m 42s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 21s There were no new checkstyle issues.
          -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 22s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 3s Pre-build of native portion
          -1 hdfs tests 175m 19s Tests failed in hadoop-hdfs.
              219m 12s  



          Reason Tests
          Timed out tests org.apache.hadoop.cli.TestHDFSCLI



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12750259/HDFS-8891.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 53bef9c
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11988/artifact/patchprocess/whitespace.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11988/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11988/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11988/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 16s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 39s There were no new javac warning messages. +1 javadoc 9m 42s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 21s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 22s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 30s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 3s Pre-build of native portion -1 hdfs tests 175m 19s Tests failed in hadoop-hdfs.     219m 12s   Reason Tests Timed out tests org.apache.hadoop.cli.TestHDFSCLI Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750259/HDFS-8891.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 53bef9c whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11988/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11988/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11988/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11988/console This message was automatically generated.
          Hide
          jingzhao Jing Zhao added a comment -

          Thanks for working on this, Yong! Agree we should keep the srcs order. For the fix, maybe we only need to replace "HashSet" to "LinkedHashSet"?

          Show
          jingzhao Jing Zhao added a comment - Thanks for working on this, Yong! Agree we should keep the srcs order. For the fix, maybe we only need to replace "HashSet" to "LinkedHashSet"?
          Hide
          zhangyongxyz Yong Zhang added a comment -

          Thanks Jing Zhao for review.
          Upload 2th path base on Jing Zhao's comment. But also need to change UT code.

          Show
          zhangyongxyz Yong Zhang added a comment - Thanks Jing Zhao for review. Upload 2th path base on Jing Zhao 's comment. But also need to change UT code.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 15m 42s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 55s There were no new javac warning messages.
          +1 javadoc 10m 1s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 33s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 35s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 2m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 3s Pre-build of native portion
          -1 hdfs tests 177m 6s Tests failed in hadoop-hdfs.
              219m 23s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
            hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation
          Timed out tests org.apache.hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
            org.apache.hadoop.cli.TestHDFSCLI



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12750423/HDFS-8891.002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 0a03054
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11994/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11994/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11994/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 42s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 55s There were no new javac warning messages. +1 javadoc 10m 1s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 33s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 2m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 3s Pre-build of native portion -1 hdfs tests 177m 6s Tests failed in hadoop-hdfs.     219m 23s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation Timed out tests org.apache.hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer   org.apache.hadoop.cli.TestHDFSCLI Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750423/HDFS-8891.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0a03054 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11994/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11994/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11994/console This message was automatically generated.
          Hide
          zhangyongxyz Yong Zhang added a comment -

          Failed test cases are not related to this patch.

          Show
          zhangyongxyz Yong Zhang added a comment - Failed test cases are not related to this patch.
          Hide
          jingzhao Jing Zhao added a comment -

          +1. I will commit the patch shortly.

          Show
          jingzhao Jing Zhao added a comment - +1. I will commit the patch shortly.
          Hide
          jingzhao Jing Zhao added a comment -

          I've committed this to trunk and branch-2. Thanks Yong for the contribution!

          Show
          jingzhao Jing Zhao added a comment - I've committed this to trunk and branch-2. Thanks Yong for the contribution!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8309 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8309/)
          HDFS-8891. HDFS concat should keep srcs order. Contributed by Yong Zhang. (jing9: rev dc7a061668a3f4d86fe1b07a40d46774b5386938)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8309 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8309/ ) HDFS-8891 . HDFS concat should keep srcs order. Contributed by Yong Zhang. (jing9: rev dc7a061668a3f4d86fe1b07a40d46774b5386938) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #288 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/288/)
          HDFS-8891. HDFS concat should keep srcs order. Contributed by Yong Zhang. (jing9: rev dc7a061668a3f4d86fe1b07a40d46774b5386938)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #288 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/288/ ) HDFS-8891 . HDFS concat should keep srcs order. Contributed by Yong Zhang. (jing9: rev dc7a061668a3f4d86fe1b07a40d46774b5386938) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1018 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1018/)
          HDFS-8891. HDFS concat should keep srcs order. Contributed by Yong Zhang. (jing9: rev dc7a061668a3f4d86fe1b07a40d46774b5386938)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1018 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1018/ ) HDFS-8891 . HDFS concat should keep srcs order. Contributed by Yong Zhang. (jing9: rev dc7a061668a3f4d86fe1b07a40d46774b5386938) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2234 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2234/)
          HDFS-8891. HDFS concat should keep srcs order. Contributed by Yong Zhang. (jing9: rev dc7a061668a3f4d86fe1b07a40d46774b5386938)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2234 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2234/ ) HDFS-8891 . HDFS concat should keep srcs order. Contributed by Yong Zhang. (jing9: rev dc7a061668a3f4d86fe1b07a40d46774b5386938) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #285 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/285/)
          HDFS-8891. HDFS concat should keep srcs order. Contributed by Yong Zhang. (jing9: rev dc7a061668a3f4d86fe1b07a40d46774b5386938)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #285 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/285/ ) HDFS-8891 . HDFS concat should keep srcs order. Contributed by Yong Zhang. (jing9: rev dc7a061668a3f4d86fe1b07a40d46774b5386938) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2215 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2215/)
          HDFS-8891. HDFS concat should keep srcs order. Contributed by Yong Zhang. (jing9: rev dc7a061668a3f4d86fe1b07a40d46774b5386938)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2215 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2215/ ) HDFS-8891 . HDFS concat should keep srcs order. Contributed by Yong Zhang. (jing9: rev dc7a061668a3f4d86fe1b07a40d46774b5386938) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #277 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/277/)
          HDFS-8891. HDFS concat should keep srcs order. Contributed by Yong Zhang. (jing9: rev dc7a061668a3f4d86fe1b07a40d46774b5386938)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #277 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/277/ ) HDFS-8891 . HDFS concat should keep srcs order. Contributed by Yong Zhang. (jing9: rev dc7a061668a3f4d86fe1b07a40d46774b5386938) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirConcatOp.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestHDFSConcat.java
          Hide
          chris.douglas Chris Douglas added a comment -

          Any objection to including this in 2.7.2?

          Show
          chris.douglas Chris Douglas added a comment - Any objection to including this in 2.7.2?
          Hide
          ajisakaa Akira Ajisaka added a comment -

          I'm +1 for including this in 2.7.2.

          Show
          ajisakaa Akira Ajisaka added a comment - I'm +1 for including this in 2.7.2.
          Hide
          chris.douglas Chris Douglas added a comment -

          Committed to branch-2.7

          Show
          chris.douglas Chris Douglas added a comment - Committed to branch-2.7
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8334 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8334/)
          HDFS-8891. HDFS concat should keep srcs order. Contributed by Yong Zhang. (cdouglas: rev b0564c9f3c501bf7806f07649929038624dea10f)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8334 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8334/ ) HDFS-8891 . HDFS concat should keep srcs order. Contributed by Yong Zhang. (cdouglas: rev b0564c9f3c501bf7806f07649929038624dea10f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #291 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/291/)
          HDFS-8891. HDFS concat should keep srcs order. Contributed by Yong Zhang. (cdouglas: rev b0564c9f3c501bf7806f07649929038624dea10f)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #291 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/291/ ) HDFS-8891 . HDFS concat should keep srcs order. Contributed by Yong Zhang. (cdouglas: rev b0564c9f3c501bf7806f07649929038624dea10f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1024 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1024/)
          HDFS-8891. HDFS concat should keep srcs order. Contributed by Yong Zhang. (cdouglas: rev b0564c9f3c501bf7806f07649929038624dea10f)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1024 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1024/ ) HDFS-8891 . HDFS concat should keep srcs order. Contributed by Yong Zhang. (cdouglas: rev b0564c9f3c501bf7806f07649929038624dea10f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #294 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/294/)
          HDFS-8891. HDFS concat should keep srcs order. Contributed by Yong Zhang. (cdouglas: rev b0564c9f3c501bf7806f07649929038624dea10f)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #294 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/294/ ) HDFS-8891 . HDFS concat should keep srcs order. Contributed by Yong Zhang. (cdouglas: rev b0564c9f3c501bf7806f07649929038624dea10f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2240 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2240/)
          HDFS-8891. HDFS concat should keep srcs order. Contributed by Yong Zhang. (cdouglas: rev b0564c9f3c501bf7806f07649929038624dea10f)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2240 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2240/ ) HDFS-8891 . HDFS concat should keep srcs order. Contributed by Yong Zhang. (cdouglas: rev b0564c9f3c501bf7806f07649929038624dea10f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #283 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/283/)
          HDFS-8891. HDFS concat should keep srcs order. Contributed by Yong Zhang. (cdouglas: rev b0564c9f3c501bf7806f07649929038624dea10f)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #283 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/283/ ) HDFS-8891 . HDFS concat should keep srcs order. Contributed by Yong Zhang. (cdouglas: rev b0564c9f3c501bf7806f07649929038624dea10f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2221 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2221/)
          HDFS-8891. HDFS concat should keep srcs order. Contributed by Yong Zhang. (cdouglas: rev b0564c9f3c501bf7806f07649929038624dea10f)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2221 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2221/ ) HDFS-8891 . HDFS concat should keep srcs order. Contributed by Yong Zhang. (cdouglas: rev b0564c9f3c501bf7806f07649929038624dea10f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          sjlee0 Sangjin Lee added a comment -

          Does this issue exist in 2.6.x? Should this be backported to branch-2.6?

          Show
          sjlee0 Sangjin Lee added a comment - Does this issue exist in 2.6.x? Should this be backported to branch-2.6?
          Hide
          djp Junping Du added a comment -

          Hi Chris Douglas and Jing Zhao, shall we cherry-pick this fix to 2.6.4 as well? Thanks!

          Show
          djp Junping Du added a comment - Hi Chris Douglas and Jing Zhao , shall we cherry-pick this fix to 2.6.4 as well? Thanks!
          Hide
          chris.douglas Chris Douglas added a comment -

          shall we cherry-pick this fix to 2.6.4 as well?

          Yes, it looks like this is also in branch-2.6.

          Show
          chris.douglas Chris Douglas added a comment - shall we cherry-pick this fix to 2.6.4 as well? Yes, it looks like this is also in branch-2.6.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          shall we cherry-pick this fix to 2.6.4 as well?

          No. I don't think this fix should be cherry-picked to 2.6.4 because this bug is not in branch-2.6.

          Show
          ajisakaa Akira Ajisaka added a comment - shall we cherry-pick this fix to 2.6.4 as well? No. I don't think this fix should be cherry-picked to 2.6.4 because this bug is not in branch-2.6.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          The regression test passes in branch-2.6. Attaching a regression-test-only-patch for branch-2.6.

          I looked into the source code and I don't see the srcs are into HashMap and then converted to an array in branch-2.6. In branch-2.6, the order or the srcs is kept.

          Show
          ajisakaa Akira Ajisaka added a comment - The regression test passes in branch-2.6. Attaching a regression-test-only-patch for branch-2.6. I looked into the source code and I don't see the srcs are into HashMap and then converted to an array in branch-2.6. In branch-2.6, the order or the srcs is kept.
          Hide
          chris.douglas Chris Douglas added a comment -

          Akira is right; this isn't in 2.6

          Show
          chris.douglas Chris Douglas added a comment - Akira is right; this isn't in 2.6
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Chris. Removing target version 2.6.4.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Chris. Removing target version 2.6.4.
          Hide
          djp Junping Du added a comment -

          Thanks Akira Ajisaka and Chris Douglas for confirmation.

          Show
          djp Junping Du added a comment - Thanks Akira Ajisaka and Chris Douglas for confirmation.

            People

            • Assignee:
              zhangyongxyz Yong Zhang
              Reporter:
              zhangyongxyz Yong Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development