Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-885

Datanode toString() NPEs on null dnRegistration

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: datanode
    • Labels:
      None

      Description

      Datanode toString() }} assumes the {{dnRegistration value is never null. This is not always true, and when it is not the case, the toString() operator NPEs.

        Activity

        steve_l created issue -
        Hide
        steve_l added a comment -

        Patch to toString(). No test. You'd need to create a datanode without a namenode, while it is spinning to start up, call toString() in a different thread.

        Show
        steve_l added a comment - Patch to toString() . No test. You'd need to create a datanode without a namenode, while it is spinning to start up, call toString() in a different thread.
        steve_l made changes -
        Field Original Value New Value
        Attachment HDFS-885.patch [ 12429772 ]
        steve_l made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Konstantin Boudnik added a comment -

        +1 looks good

        Show
        Konstantin Boudnik added a comment - +1 looks good
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12429772/HDFS-885.patch
        against trunk revision 897068.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/91/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/91/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/91/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/91/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12429772/HDFS-885.patch against trunk revision 897068. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/91/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/91/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/91/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/91/console This message is automatically generated.
        steve_l made changes -
        Issue Type Improvement [ 4 ] Bug [ 1 ]
        Hide
        steve_l added a comment -

        committed, with changes.txt

        Show
        steve_l added a comment - committed, with changes.txt
        steve_l made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #164 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/164/)
        . Datanode toString() NPEs on null dnRegistration.

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #164 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/164/ ) . Datanode toString() NPEs on null dnRegistration.
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #94 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/94/)
        . Datanode toString() NPEs on null dnRegistration.

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #94 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/94/ ) . Datanode toString() NPEs on null dnRegistration.
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #183 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/183/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #183 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/183/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #198 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/198/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #198 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/198/ )
        Gavin made changes -
        Reporter Steve Loughran [ steve_l ] Steve Loughran [ stevel@apache.org ]
        Gavin made changes -
        Assignee Steve Loughran [ steve_l ] Steve Loughran [ stevel@apache.org ]
        Tom White made changes -
        Fix Version/s 0.21.0 [ 12314046 ]
        Fix Version/s 0.22.0 [ 12314241 ]
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Steve Loughran
            Reporter:
            Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development