Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-882

Datanode could log what hostname and ports its listening on on startup

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The Datanode logs the port it is listening too, but if you have having problems with multi-NIC systems or IPv6 grief, knowing the hostname is handy too. Also, it doesn't log the SSL port info.

      Proposed: provide more details at the debug level

        Activity

        steve_l created issue -
        steve_l made changes -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        steve_l added a comment -

        Two extra logs at debug level, no tests

        Show
        steve_l added a comment - Two extra logs at debug level, no tests
        steve_l made changes -
        Attachment HDFS-882.patch [ 12429762 ]
        steve_l made changes -
        Status In Progress [ 3 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12429762/HDFS-882.patch
        against trunk revision 897068.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/89/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/89/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/89/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/89/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12429762/HDFS-882.patch against trunk revision 897068. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/89/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/89/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/89/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/89/console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        +1 You can drop the LOG.isDebugEnabled() checks as you're not evaluating anything complex in the Log.debug arguments.

        Show
        Eli Collins added a comment - +1 You can drop the LOG.isDebugEnabled() checks as you're not evaluating anything complex in the Log.debug arguments.
        Hide
        steve_l added a comment -

        OK. I'd fenced it off as they were calling toString and string concat operations. The logging will only happen on node startup and there are other delays in there, so its cost is low.

        Show
        steve_l added a comment - OK. I'd fenced it off as they were calling toString and string concat operations. The logging will only happen on node startup and there are other delays in there, so its cost is low.
        Gavin made changes -
        Reporter Steve Loughran [ steve_l ] Steve Loughran [ stevel@apache.org ]
        Gavin made changes -
        Assignee Steve Loughran [ steve_l ] Steve Loughran [ stevel@apache.org ]
        Hide
        dhruba borthakur added a comment -

        I incorporated Eli's code-review feedback and committed this. Thanks Steve!

        Show
        dhruba borthakur added a comment - I incorporated Eli's code-review feedback and committed this. Thanks Steve!
        dhruba borthakur made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #330 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/330/)
        HDFS-882. Datanode logs the hostname and port its listening on.
        (Steve Loughran via dhruba)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #330 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/330/ ) HDFS-882 . Datanode logs the hostname and port its listening on. (Steve Loughran via dhruba)

          People

          • Assignee:
            Steve Loughran
            Reporter:
            Steve Loughran
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development