Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8749

Fix findbugs warning in BlockManager.java

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      BlockManager#checkBlocksProperlyReplicated
              final BlockInfoUnderConstruction uc =
                  (BlockInfoUnderConstruction)b;
      

      uc is not needed and this causes findbugs warning.

      1. findbugs.png
        132 kB
        Akira Ajisaka
      2. HDFS-8749.patch
        1.0 kB
        Brahma Reddy Battula

        Activity

        Hide
        ajisakaa Akira Ajisaka added a comment -

        It was fixed as a part of HDFS-8652 but it was reverted.

        Show
        ajisakaa Akira Ajisaka added a comment - It was fixed as a part of HDFS-8652 but it was reverted.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Attaching the screenshot of mvn findbugs:gui.

        Show
        ajisakaa Akira Ajisaka added a comment - Attaching the screenshot of mvn findbugs:gui .
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Akira Ajisaka attached the patch kindly review..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Akira Ajisaka attached the patch kindly review..
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1 pending Jenkins. Thanks Brahma.

        Show
        ajisakaa Akira Ajisaka added a comment - +1 pending Jenkins. Thanks Brahma.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 17m 32s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 49s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 20s The applied patch generated 1 new checkstyle issues (total was 171, now 171).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 19s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 1 pre-existing warnings.
        +1 native 3m 1s Pre-build of native portion
        -1 hdfs tests 166m 10s Tests failed in hadoop-hdfs.
            210m 18s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.ha.TestStandbyIsHot



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12744621/HDFS-8749.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 1a0752d
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11650/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11650/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11650/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11650/testReport/
        Java 1.7.0_55
        uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11650/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 32s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 49s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 20s The applied patch generated 1 new checkstyle issues (total was 171, now 171). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 19s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 29s The patch does not introduce any new Findbugs (version 3.0.0) warnings, and fixes 1 pre-existing warnings. +1 native 3m 1s Pre-build of native portion -1 hdfs tests 166m 10s Tests failed in hadoop-hdfs.     210m 18s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestStandbyIsHot Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744621/HDFS-8749.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1a0752d Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11650/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11650/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11650/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11650/testReport/ Java 1.7.0_55 uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11650/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, the test failure is not related to the patch.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, the test failure is not related to the patch.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk and branch-2. Thanks Brahma Reddy Battula for the contribution.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Brahma Reddy Battula for the contribution.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8146 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8146/)
        HDFS-8749. Fix findbugs warnings in BlockManager.java. Contributed by Brahma Reddy Battula. (aajisaka: rev d66302ed9b2c25b560d8319d6d755aee7cfa4d67)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8146 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8146/ ) HDFS-8749 . Fix findbugs warnings in BlockManager.java. Contributed by Brahma Reddy Battula. (aajisaka: rev d66302ed9b2c25b560d8319d6d755aee7cfa4d67) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #252 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/252/)
        HDFS-8749. Fix findbugs warnings in BlockManager.java. Contributed by Brahma Reddy Battula. (aajisaka: rev d66302ed9b2c25b560d8319d6d755aee7cfa4d67)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #252 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/252/ ) HDFS-8749 . Fix findbugs warnings in BlockManager.java. Contributed by Brahma Reddy Battula. (aajisaka: rev d66302ed9b2c25b560d8319d6d755aee7cfa4d67) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #982 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/982/)
        HDFS-8749. Fix findbugs warnings in BlockManager.java. Contributed by Brahma Reddy Battula. (aajisaka: rev d66302ed9b2c25b560d8319d6d755aee7cfa4d67)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #982 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/982/ ) HDFS-8749 . Fix findbugs warnings in BlockManager.java. Contributed by Brahma Reddy Battula. (aajisaka: rev d66302ed9b2c25b560d8319d6d755aee7cfa4d67) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2179 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2179/)
        HDFS-8749. Fix findbugs warnings in BlockManager.java. Contributed by Brahma Reddy Battula. (aajisaka: rev d66302ed9b2c25b560d8319d6d755aee7cfa4d67)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2179 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2179/ ) HDFS-8749 . Fix findbugs warnings in BlockManager.java. Contributed by Brahma Reddy Battula. (aajisaka: rev d66302ed9b2c25b560d8319d6d755aee7cfa4d67) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2198 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2198/)
        HDFS-8749. Fix findbugs warnings in BlockManager.java. Contributed by Brahma Reddy Battula. (aajisaka: rev d66302ed9b2c25b560d8319d6d755aee7cfa4d67)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2198 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2198/ ) HDFS-8749 . Fix findbugs warnings in BlockManager.java. Contributed by Brahma Reddy Battula. (aajisaka: rev d66302ed9b2c25b560d8319d6d755aee7cfa4d67) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #240 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/240/)
        HDFS-8749. Fix findbugs warnings in BlockManager.java. Contributed by Brahma Reddy Battula. (aajisaka: rev d66302ed9b2c25b560d8319d6d755aee7cfa4d67)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #240 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/240/ ) HDFS-8749 . Fix findbugs warnings in BlockManager.java. Contributed by Brahma Reddy Battula. (aajisaka: rev d66302ed9b2c25b560d8319d6d755aee7cfa4d67) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #250 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/250/)
        HDFS-8749. Fix findbugs warnings in BlockManager.java. Contributed by Brahma Reddy Battula. (aajisaka: rev d66302ed9b2c25b560d8319d6d755aee7cfa4d67)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #250 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/250/ ) HDFS-8749 . Fix findbugs warnings in BlockManager.java. Contributed by Brahma Reddy Battula. (aajisaka: rev d66302ed9b2c25b560d8319d6d755aee7cfa4d67) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            ajisakaa Akira Ajisaka
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development