Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are some checkstyle warnings generated by HDFS-8620 in ClientProtocol. They were about the import statements.

      1. HDFS-8730.0.patch
        31 kB
        Takanobu Asanuma

        Issue Links

          Activity

          Hide
          tasanuma0829 Takanobu Asanuma added a comment -

          The warnings in ClientProtocol are "Unused import". The classes are

          java.io.FileNotFoundException.
          org.apache.hadoop.fs.FileAlreadyExistsException.
          org.apache.hadoop.fs.ParentNotDirectoryException.
          org.apache.hadoop.fs.UnresolvedLinkException.
          org.apache.hadoop.hdfs.server.namenode.NotReplicatedYetException.
          org.apache.hadoop.hdfs.server.namenode.SafeModeException.
          org.apache.hadoop.security.AccessControlException.
          

          They are only used in javadoc comments.

          Hi, Haohui Mai. Please check my plan when you have free.
          First removing the import statements, then comverting relative paths to absolute paths in the javadoc comments. How does look that?

          Show
          tasanuma0829 Takanobu Asanuma added a comment - The warnings in ClientProtocol are "Unused import". The classes are java.io.FileNotFoundException. org.apache.hadoop.fs.FileAlreadyExistsException. org.apache.hadoop.fs.ParentNotDirectoryException. org.apache.hadoop.fs.UnresolvedLinkException. org.apache.hadoop.hdfs.server.namenode.NotReplicatedYetException. org.apache.hadoop.hdfs.server.namenode.SafeModeException. org.apache.hadoop.security.AccessControlException. They are only used in javadoc comments. Hi, Haohui Mai . Please check my plan when you have free. First removing the import statements, then comverting relative paths to absolute paths in the javadoc comments. How does look that?
          Hide
          wheat9 Haohui Mai added a comment -

          Sounds good to me. Please go ahead and submit a patch. Thanks!

          Show
          wheat9 Haohui Mai added a comment - Sounds good to me. Please go ahead and submit a patch. Thanks!
          Hide
          tasanuma0829 Takanobu Asanuma added a comment -

          Thank you for your confirmation, Haohui Mai. I uploaded an initial patch.

          Show
          tasanuma0829 Takanobu Asanuma added a comment - Thank you for your confirmation, Haohui Mai . I uploaded an initial patch.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 20m 45s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 48s There were no new javac warning messages.
          +1 javadoc 10m 10s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 33s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 21s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 59s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 8s Pre-build of native portion
          +1 hdfs tests 0m 26s Tests passed in hadoop-hdfs-client.
              48m 9s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12746751/HDFS-8730.0.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / ee98d63
          hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11804/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11804/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11804/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 45s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 48s There were no new javac warning messages. +1 javadoc 10m 10s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 33s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 59s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 8s Pre-build of native portion +1 hdfs tests 0m 26s Tests passed in hadoop-hdfs-client.     48m 9s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746751/HDFS-8730.0.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ee98d63 hadoop-hdfs-client test log https://builds.apache.org/job/PreCommit-HDFS-Build/11804/artifact/patchprocess/testrun_hadoop-hdfs-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11804/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11804/console This message was automatically generated.
          Hide
          wheat9 Haohui Mai added a comment -

          +1

          Show
          wheat9 Haohui Mai added a comment - +1
          Hide
          wheat9 Haohui Mai added a comment -

          I've committed the patch to trunk and branch-2. Thanks Takanobu Asanuma for the contribution.

          Show
          wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Takanobu Asanuma for the contribution.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8207 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8207/)
          HDFS-8730. Clean up the import statements in ClientProtocol. Contributed by Takanobu Asanuma. (wheat9: rev 813cf89bb56ad1a48b35fd44644d63540e8fa7d1)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8207 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8207/ ) HDFS-8730 . Clean up the import statements in ClientProtocol. Contributed by Takanobu Asanuma. (wheat9: rev 813cf89bb56ad1a48b35fd44644d63540e8fa7d1) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          Hide
          tasanuma0829 Takanobu Asanuma added a comment -

          Thank you for the review and the commitment, Haohui Mai!

          Show
          tasanuma0829 Takanobu Asanuma added a comment - Thank you for the review and the commitment, Haohui Mai !
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #996 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/996/)
          HDFS-8730. Clean up the import statements in ClientProtocol. Contributed by Takanobu Asanuma. (wheat9: rev 813cf89bb56ad1a48b35fd44644d63540e8fa7d1)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #996 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/996/ ) HDFS-8730 . Clean up the import statements in ClientProtocol. Contributed by Takanobu Asanuma. (wheat9: rev 813cf89bb56ad1a48b35fd44644d63540e8fa7d1) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #266 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/266/)
          HDFS-8730. Clean up the import statements in ClientProtocol. Contributed by Takanobu Asanuma. (wheat9: rev 813cf89bb56ad1a48b35fd44644d63540e8fa7d1)

          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #266 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/266/ ) HDFS-8730 . Clean up the import statements in ClientProtocol. Contributed by Takanobu Asanuma. (wheat9: rev 813cf89bb56ad1a48b35fd44644d63540e8fa7d1) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2193 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2193/)
          HDFS-8730. Clean up the import statements in ClientProtocol. Contributed by Takanobu Asanuma. (wheat9: rev 813cf89bb56ad1a48b35fd44644d63540e8fa7d1)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2193 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2193/ ) HDFS-8730 . Clean up the import statements in ClientProtocol. Contributed by Takanobu Asanuma. (wheat9: rev 813cf89bb56ad1a48b35fd44644d63540e8fa7d1) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #255 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/255/)
          HDFS-8730. Clean up the import statements in ClientProtocol. Contributed by Takanobu Asanuma. (wheat9: rev 813cf89bb56ad1a48b35fd44644d63540e8fa7d1)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #255 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/255/ ) HDFS-8730 . Clean up the import statements in ClientProtocol. Contributed by Takanobu Asanuma. (wheat9: rev 813cf89bb56ad1a48b35fd44644d63540e8fa7d1) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2212 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2212/)
          HDFS-8730. Clean up the import statements in ClientProtocol. Contributed by Takanobu Asanuma. (wheat9: rev 813cf89bb56ad1a48b35fd44644d63540e8fa7d1)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2212 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2212/ ) HDFS-8730 . Clean up the import statements in ClientProtocol. Contributed by Takanobu Asanuma. (wheat9: rev 813cf89bb56ad1a48b35fd44644d63540e8fa7d1) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #263 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/263/)
          HDFS-8730. Clean up the import statements in ClientProtocol. Contributed by Takanobu Asanuma. (wheat9: rev 813cf89bb56ad1a48b35fd44644d63540e8fa7d1)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #263 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/263/ ) HDFS-8730 . Clean up the import statements in ClientProtocol. Contributed by Takanobu Asanuma. (wheat9: rev 813cf89bb56ad1a48b35fd44644d63540e8fa7d1) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java

            People

            • Assignee:
              tasanuma0829 Takanobu Asanuma
              Reporter:
              tasanuma0829 Takanobu Asanuma
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development