Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8713

Convert DatanodeDescriptor to use SLF4J logging

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.6-alpha
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      Let's convert this class to use SLF4J

        Activity

        Hide
        andrew.wang Andrew Wang added a comment -

        Patch attached, I also added an if guard to an INFO print I saw spamming the NN log ("Number of failed storages changes from 0 to 0") I think due to a NN restart.

        Show
        andrew.wang Andrew Wang added a comment - Patch attached, I also added an if guard to an INFO print I saw spamming the NN log ("Number of failed storages changes from 0 to 0") I think due to a NN restart.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        LGTM.

        +1, pending Jenkings. Thanks Andrew Wang

        Show
        eddyxu Lei (Eddy) Xu added a comment - LGTM. +1, pending Jenkings. Thanks Andrew Wang
        Hide
        hitliuyi Yi Liu added a comment -

        Kick off a new Jenkins.

        Show
        hitliuyi Yi Liu added a comment - Kick off a new Jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 15m 32s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 41s There were no new javac warning messages.
        +1 javadoc 9m 42s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 34s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 31s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 5s Pre-build of native portion
        -1 hdfs tests 172m 48s Tests failed in hadoop-hdfs.
            214m 24s  



        Reason Tests
        Timed out tests org.apache.hadoop.cli.TestHDFSCLI



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12743378/hdfs-8713.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 13604bd
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12007/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12007/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12007/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 32s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 41s There were no new javac warning messages. +1 javadoc 9m 42s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 34s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 5s Pre-build of native portion -1 hdfs tests 172m 48s Tests failed in hadoop-hdfs.     214m 24s   Reason Tests Timed out tests org.apache.hadoop.cli.TestHDFSCLI Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12743378/hdfs-8713.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 13604bd hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12007/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12007/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12007/console This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks for reminding me about this one Yi, I ran the timed out test locally successfully. Will commit to trunk and branch-2 based on Eddy's earlier +1.

        Show
        andrew.wang Andrew Wang added a comment - Thanks for reminding me about this one Yi, I ran the timed out test locally successfully. Will commit to trunk and branch-2 based on Eddy's earlier +1.
        Hide
        andrew.wang Andrew Wang added a comment -

        Committed to trunk and branch-2, thanks again Eddy + Yi.

        Show
        andrew.wang Andrew Wang added a comment - Committed to trunk and branch-2, thanks again Eddy + Yi.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #8313 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8313/)
        HDFS-8713. Convert DatanodeDescriptor to use SLF4J logging. (wang: rev 2e7b7e2cda67eba4c03e0a2c7892d868d235b0cf)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #8313 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8313/ ) HDFS-8713 . Convert DatanodeDescriptor to use SLF4J logging. (wang: rev 2e7b7e2cda67eba4c03e0a2c7892d868d235b0cf) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1021 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1021/)
        HDFS-8713. Convert DatanodeDescriptor to use SLF4J logging. (wang: rev 2e7b7e2cda67eba4c03e0a2c7892d868d235b0cf)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1021 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1021/ ) HDFS-8713 . Convert DatanodeDescriptor to use SLF4J logging. (wang: rev 2e7b7e2cda67eba4c03e0a2c7892d868d235b0cf) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #291 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/291/)
        HDFS-8713. Convert DatanodeDescriptor to use SLF4J logging. (wang: rev 2e7b7e2cda67eba4c03e0a2c7892d868d235b0cf)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #291 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/291/ ) HDFS-8713 . Convert DatanodeDescriptor to use SLF4J logging. (wang: rev 2e7b7e2cda67eba4c03e0a2c7892d868d235b0cf) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #288 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/288/)
        HDFS-8713. Convert DatanodeDescriptor to use SLF4J logging. (wang: rev 2e7b7e2cda67eba4c03e0a2c7892d868d235b0cf)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #288 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/288/ ) HDFS-8713 . Convert DatanodeDescriptor to use SLF4J logging. (wang: rev 2e7b7e2cda67eba4c03e0a2c7892d868d235b0cf) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2237 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2237/)
        HDFS-8713. Convert DatanodeDescriptor to use SLF4J logging. (wang: rev 2e7b7e2cda67eba4c03e0a2c7892d868d235b0cf)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2237 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2237/ ) HDFS-8713 . Convert DatanodeDescriptor to use SLF4J logging. (wang: rev 2e7b7e2cda67eba4c03e0a2c7892d868d235b0cf) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2218 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2218/)
        HDFS-8713. Convert DatanodeDescriptor to use SLF4J logging. (wang: rev 2e7b7e2cda67eba4c03e0a2c7892d868d235b0cf)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2218 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2218/ ) HDFS-8713 . Convert DatanodeDescriptor to use SLF4J logging. (wang: rev 2e7b7e2cda67eba4c03e0a2c7892d868d235b0cf) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #280 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/280/)
        HDFS-8713. Convert DatanodeDescriptor to use SLF4J logging. (wang: rev 2e7b7e2cda67eba4c03e0a2c7892d868d235b0cf)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #280 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/280/ ) HDFS-8713 . Convert DatanodeDescriptor to use SLF4J logging. (wang: rev 2e7b7e2cda67eba4c03e0a2c7892d868d235b0cf) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeDescriptor.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            andrew.wang Andrew Wang
            Reporter:
            andrew.wang Andrew Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development